Re: Proxied client IP logging

2005-12-16 Thread Filip Hanik - Mailing Lists
if you have two proxy servers, very common, the X-Forwarded-For becomes a comma separated list of IP addresses Shankar Unni wrote: Tim Funk wrote: 2) X-Forwarded-For (IIRC) can be multi-valued (comma seperated via multiple proxies) Plus, other load balancers seem to stick in other headers

Re: svn commit: r1207852 - in /tomcat/trunk/modules/jdbc-pool: ./ doc/changelog.xml

2011-11-29 Thread Filip Hanik Mailing Lists
I can't for the life of me seem to get this right, do you have the right command? Filip - Original Message - From: fha...@apache.org To: dev@tomcat.apache.org Sent: Tuesday, November 29, 2011 5:56:03 AM Subject: svn commit: r1207852 - in /tomcat/trunk/modules/jdbc-pool: ./ doc/changelog

Re: svn commit: r1207856 - /tomcat/tc7.0.x/trunk/modules/

2011-11-29 Thread Filip Hanik Mailing Lists
svn propset svn:externals '^/tomcat/trunk/modules/jdbc-pool@1207712 jdbc-pool' modules does that seem right? - Original Message - From: fha...@apache.org To: dev@tomcat.apache.org Sent: Tuesday, November 29, 2011 6:00:19 AM Subject: svn commit: r1207856 - /tomcat/tc7.0.x/trunk/modules/

Re: [VOTE] Release build 6.0.35

2011-11-29 Thread Filip Hanik Mailing Lists
[X] Stable Filip - Original Message - From: "jean-frederic clere" To: dev@tomcat.apache.org Sent: Monday, November 28, 2011 4:30:37 AM Subject: [VOTE] Release build 6.0.35 The candidates binaries are available here: http://people.apache.org/~jfclere/tomcat-6/v6.0.35/ According to the r

WebSockets in Tomcat 6

2012-03-14 Thread Filip Hanik Mailing Lists
http://people.apache.org/~fhanik/reports/servers/ Attached is a patch that leverages the Tomcat WebSocket API with minimalistic changes and uses that to implement WebSockets in Tomcat 6.0.x http://people.apache.org/~fhanik/websockets-for-tomcat-6.patch This implementation doesn't touch the endp

Re: WebSockets in Tomcat 6

2012-03-16 Thread Filip Hanik Mailing Lists
- Original Message - > From: "Costin Manolache" > > I haven't looked at the tomcat6/tomcat7 interfaces, but I think the > current > hook mechanism used by spdy could be ported with minimal risk and > could be > used by websockets. Tomcat 7 may be a candidate. Tomcat 6, If I was an adm

RE: svn commit: r1302948 - in /tomcat/trunk/modules/jdbc-pool/src: main/java/org/apache/tomcat/jdbc/pool/ main/java/org/apache/tomcat/jdbc/pool/jmx/ test/java/org/apache/tomcat/jdbc/test/

2012-03-20 Thread Filip Hanik (mailing lists)
> -Original Message- > > There is no need in the above clone() method. > It has the same access level (protected) as super one. > > I see that PoolProperties is written as "implements Cloneable". In > such case the clone method is usually redeclared as public one. [Filip Hanik] No, im

RE: svn commit: r1303082 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolExhaustedException.java

2012-03-20 Thread Filip Hanik (mailing lists)
I need to investigate this, and why my config file is not being picked up by subversion Best Filip > -Original Message- > From: kkoli...@apache.org [mailto:kkoli...@apache.org] > Sent: Tuesday, March 20, 2012 12:39 PM > To: dev@tomcat.apache.org > Subject: svn commit: r1303082 - /tomcat/

RE: svn commit: r1303096 - in /tomcat/trunk/modules/jdbc-pool: doc/jdbc-pool.xml src/test/java/org/apache/tomcat/jdbc/test/MultipleCloseTest.java

2012-03-20 Thread Filip Hanik (mailing lists)
Have we published a check style configuration file? > -Original Message- > From: kkoli...@apache.org [mailto:kkoli...@apache.org] > Sent: Tuesday, March 20, 2012 12:56 PM > To: dev@tomcat.apache.org > Subject: svn commit: r1303096 - in /tomcat/trunk/modules/jdbc-pool: > doc/jdbc-pool.xml >

Re: [VOTE] Release Apache Tomcat Connectors 1.2.34

2012-03-21 Thread Filip Hanik Mailing Lists
> [X] Stable, go ahead and release - Original Message - > From: "Henri Gomez" > To: "Tomcat Developers List" > Sent: Wednesday, March 21, 2012 2:33:58 AM > Subject: Re: [VOTE] Release Apache Tomcat Connectors 1.2.34 > > > The Apache Tomcat Connectors 1.2.34 is > >  [X] Stable, go ahead

RE: svn commit: r1303082 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolExhaustedException.java

2012-03-21 Thread Filip Hanik (mailing lists)
ject: Re: svn commit: r1303082 - /tomcat/trunk/modules/jdbc- > pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolExhaustedException. > java > > 2012/3/20 Filip Hanik (mailing lists) : > > I need to investigate this, and why my config file is not being picked up by > subversion &g

RE: [VOTE] Release Apache Tomcat Connectors 1.2.35

2012-03-22 Thread Filip Hanik (mailing lists)
[X] Stable, go ahead and release > -Original Message- > From: Mladen Turk [mailto:mt...@apache.org] > Sent: Thursday, March 22, 2012 10:50 AM > To: Tomcat Developers List > Subject: Re: [VOTE] Release Apache Tomcat Connectors 1.2.35 > > On 03/22/2012 02:46 PM, Mladen Turk wrote: > > > > T

RE: svn commit: r1303082 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolExhaustedException.java

2012-03-22 Thread Filip Hanik (mailing lists)
On windows, it wasn't picking up ~/.subversion/config but ~/AppData/Roaming/Subversion/config Filip > -Original Message- > From: Filip Hanik (mailing lists) [mailto:devli...@hanik.com] > Sent: Wednesday, March 21, 2012 6:17 PM > To: 'Tomcat Developers List'

Re: SPDY support

2012-03-25 Thread Filip Hanik Mailing Lists
Tomcat 7 is a Servlet 3.0 implementation with requirements to support Java 6, wouldn't this break that contract if we do it for NIO/BIO? Could this be done as a extras package for the Java connectors? Why not add this into trunk first, and work with it there, as opposed to an external repository?

RE: svn commit: r1305931 - in /tomcat/trunk/modules/jdbc-pool: doc/ src/main/java/org/apache/tomcat/jdbc/pool/ src/main/java/org/apache/tomcat/jdbc/pool/jmx/

2012-03-28 Thread Filip Hanik (mailing lists)
> If InterruptedException was thrown by JRE it alone means that > interrupted flag has been cleared. So Thread.interrupted() call is a > NOOP. > > (Effectively the interruption state means "to interrupt the next > wait() etc. call immediately when they are called". When the actual > interruption

RE: [VOTE] Release Apache Taglibs Parent POM 3

2012-03-28 Thread Filip Hanik (mailing lists)
[+1] Released > -Original Message- > From: Jeremy Boynes [mailto:jer...@boynes.com] On Behalf Of Jeremy > Boynes > Sent: Sunday, March 25, 2012 11:02 PM > To: Tomcat Developers List > Subject: [VOTE] Release Apache Taglibs Parent POM 3 > > The proposed 3 release of Apache Taglibs Parent P

RE: [VOTE] Release Apache Taglibs Parent POM 3

2012-03-28 Thread Filip Hanik (mailing lists)
> -Original Message- > From: Jeremy Boynes [mailto:jer...@boynes.com] On Behalf Of Jeremy > Boynes > Sent: Wednesday, March 28, 2012 8:38 AM > To: Tomcat Developers List > Subject: Re: [VOTE] Release Apache Taglibs Parent POM 3 > > Request for more votes please, we only have one binding

RE: svn commit: r1306130 - in /tomcat/trunk/java/org/apache/catalina/startup: LocalStrings.properties UserConfig.java

2012-03-28 Thread Filip Hanik (mailing lists)
> -Original Message- > From: kfuj...@apache.org [mailto:kfuj...@apache.org] > Sent: Tuesday, March 27, 2012 8:51 PM > To: dev@tomcat.apache.org > Subject: svn commit: r1306130 - in > /tomcat/trunk/java/org/apache/catalina/startup: LocalStrings.properties > UserConfig.java > > +fo

RE: buildbot failure in ASF Buildbot on tomcat-trunk

2012-03-28 Thread Filip Hanik (mailing lists)
Is it my email client, or are some of these emails empty? > -Original Message- > From: build...@apache.org [mailto:build...@apache.org] > Sent: Wednesday, March 28, 2012 10:00 AM > To: dev@tomcat.apache.org > Subject: buildbot failure in ASF Buildbot on tomcat-trunk > -

RE: svn commit: r1306130 - in /tomcat/trunk/java/org/apache/catalina/startup: LocalStrings.properties UserConfig.java

2012-03-29 Thread Filip Hanik (mailing lists)
> >> -Original Message- > >> From: kfuj...@apache.org [mailto:kfuj...@apache.org] > >> Sent: Tuesday, March 27, 2012 8:51 PM > >> To: dev@tomcat.apache.org > >> Subject: svn commit: r1306130 - in > >> /tomcat/trunk/java/org/apache/catalina/startup: LocalStrings.properties > >> UserConfig.ja

Re: [VOTE] Release Apache Tomcat 7.0.27

2012-04-04 Thread Filip Hanik Mailing Lists
[X] Stable - go ahead and release as 7.0.27 Stable - Original Message - > From: "Mark Thomas" > To: "Tomcat Developers List" > Sent: Saturday, March 31, 2012 11:07:30 AM > Subject: [VOTE] Release Apache Tomcat 7.0.27 > > The proposed Apache Tomcat 7.0.27 release is now available for > v

Re: svn commit: r1307093 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java

2012-04-04 Thread Filip Hanik Mailing Lists
- Original Message - > From: ma...@apache.org > To: dev@tomcat.apache.org > Sent: Thursday, March 29, 2012 2:19:18 PM > Subject: svn commit: r1307093 - > /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java > > Author: markt > Date: Th

Re: svn commit: r1307093 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java

2012-04-04 Thread Filip Hanik Mailing Lists
onFacade.java > > On 04/04/2012 17:12, Filip Hanik Mailing Lists wrote: > > > > > > - Original Message - > >> From: ma...@apache.org To: dev@tomcat.apache.org Sent: Thursday, > >> March 29, 2012 2:19:18 PM Subject: svn commit: r1307093 - &

Re: svn commit: r1307093 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java

2012-04-04 Thread Filip Hanik Mailing Lists
eConnectionFacade.java > > 2012/4/4 Filip Hanik Mailing Lists : > > > > > > - Original Message - > >> From: "Mark Thomas" > >> To: "Tomcat Developers List" > >> Sent: Wednesday, April 4, 2012 11:18:42 AM > >>

RE: svn commit: r1307093 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java

2012-04-05 Thread Filip Hanik (mailing lists)
e/tomcat/jdbc/pool/DisposableConnectionFacad > e.java > > 2012/4/4 Filip Hanik Mailing Lists : > >> > >> I know of two places where long lines cause problems: > >> > >> 1. Commit e-mails. > >> > >> Long lines are wrapped and it impacts readability

Re: have Re: MaxQueueSize for Executor and Tomcat 6

2012-04-23 Thread Filip Hanik Mailing Lists
- Original Message - > From: "Rüdiger Plüm, Vodafone Group" > > Ok. As far as I can see the new method > > execute(Runnable command, long timeout, TimeUnit unit); > > of the Executor interface is implemented but not used. > Would it still be an acceptable backport if > > 1. The changes

RE: svn commit: r1333218 - in /tomcat/trunk: java/org/apache/tomcat/util/net/NioEndpoint.java webapps/docs/changelog.xml webapps/docs/config/http.xml

2012-05-02 Thread Filip Hanik (mailing lists)
Math.min is the intention here. On a 64 core box, it should still only have 2 pollers, not 64 The comment should read ('from' instead of 'of') > > Very hard for applications to see a performance benefit *from* more than 2 > pollers > -Original Message- > From: Christopher Schultz [mailt

RE: [VOTE] Release Apache Tomcat Connectors 1.2.36

2012-05-11 Thread Filip Hanik (mailing lists)
The Apache Tomcat Connectors 1.2.36 is [X] Stable, go ahead and release [ ] Broken because of ... Filip > -Original Message- > From: Mladen Turk [mailto:mt...@apache.org] > Sent: Friday, May 11, 2012 3:27 AM > To: dev@tomcat.apache.org > Subject: Re: [VOTE] Release Apache Tomcat Conne

RE: svn commit: r1335546 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/ConnectionState.java

2012-05-15 Thread Filip Hanik (mailing lists)
Yes we should. I can do it today, unless you beat me to it > -Original Message- > From: Konstantin Kolinko [mailto:knst.koli...@gmail.com] > Sent: Monday, May 14, 2012 5:55 AM > To: Tomcat Developers List > Subject: Re: svn commit: r1335546 - /tomcat/trunk/modules/jdbc- > pool/src/main/jav

Re: svn commit: r1340215 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2012-05-21 Thread Filip Hanik Mailing Lists
- Mensaje original - > De: "Rainer Jung" } > > Was that intentional? I'd say the timestamp should be provided by the > log framework and not by java.sql.Date. But maybe the whole message > is > just a leftover from debugging the issue. > > The same for the TC 7 backport. >

RE: [VOTE] Release Apache Tomcat Connectors 1.2.37

2012-05-30 Thread Filip Hanik (mailing lists)
[X] Stable, go ahead and release > -Original Message- > From: Mladen Turk [mailto:mt...@apache.org] > Sent: Tuesday, May 29, 2012 3:24 AM > To: Tomcat Developers List > Subject: [VOTE] Release Apache Tomcat Connectors 1.2.37 > > Hi, > > Apache Tomcat Connectors 1.2.37 release candidate i

RE: svn commit: r1342473 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/Http11NioProcessor.java java/org/apache/tomcat/util/net/NioEndpoint.java

2012-05-30 Thread Filip Hanik (mailing lists)
Changing a public API method is something I would do for trunk. I'm not sure about a .28 release that is considered stable. Filip > -Original Message- > From: kkoli...@apache.org [mailto:kkoli...@apache.org] > Sent: Thursday, May 24, 2012 5:02 PM > To: dev@tomcat.apache.org > Subject: sv

RE: svn commit: r1342473 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/Http11NioProcessor.java java/org/apache/tomcat/util/net/NioEndpoint.java

2012-05-30 Thread Filip Hanik (mailing lists)
omcat/util/net/NioEndpoint.java > > 2012/5/30 Filip Hanik (mailing lists) : > > Changing a public API method is something I would do for trunk. I'm > not sure about a .28 release that is considered stable. > > "API Stability" section of RELEASE-NOTES.txt says tho

RE: svn commit: r1345848 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/deploy/NamingResources.java java/org/apache/tomcat/util/net/AbstractEndpoint.java

2012-06-04 Thread Filip Hanik (mailing lists)
Ok, this is back to code discipline. At some point, we'd have to expect that more users will adopt v7 in production (I'm still seeing 80%+ being on v6), at that point, commits like this do nothing except pollute the diffs. Servlet 3.1 has released a draft, where I'd expect that trunk is headed.

RE: svn commit: r1345848 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/deploy/NamingResources.java java/org/apache/tomcat/util/net/AbstractEndpoint.java

2012-06-04 Thread Filip Hanik (mailing lists)
rg/apache/tomcat/util/net/AbstractEndpoint.java > > On 04/06/2012 17:05, Filip Hanik (mailing lists) wrote: > > > > Ok, this is back to code discipline. At some point, we'd have to > > expect that more users will adopt v7 in production (I'm still seeing > > 8

RE: Tomcat 7 code policy (was: Re: svn commit: r1345848)

2012-06-05 Thread Filip Hanik (mailing lists)
> -Original Message- > From: Konstantin Kolinko [mailto:knst.koli...@gmail.com] > Sent: Monday, June 04, 2012 3:50 PM > To: Tomcat Developers List > Subject: Re: Tomcat 7 code policy (was: Re: svn commit: r1345848) > > 2012/6/5 Konstantin Kolinko : > >> > >> For that reason, I'd like us

Time for 7.0.28?

2012-06-12 Thread Filip Hanik (mailing lists)
Over 2 months since last release Got some critical fixes that I would like to see released - max connections broken - send file in nio broken - jdbc pool can hang during DB failure Filip - To unsubscribe, e-mail: dev-unsubsc

RE: [VOTE] Release Apache Tomcat Native 1.1.24

2012-06-12 Thread Filip Hanik (mailing lists)
[X] Stable, go ahead and release - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

RE: "WARNING: Incorrect connection count" when running testsuite for APR/native 1.1.24

2012-06-13 Thread Filip Hanik (mailing lists)
This is one example of counting down twice. There are a lot of places calling destroySocket, the best would have been to pass a SocketWrapper instead of long and keep a AtomicBoolean to track if destroy has been called on it. if (running && !paused) { // Hand this socket off to an appropri

RE: svn commit: r1349984 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2012-06-13 Thread Filip Hanik (mailing lists)
> } else { > -countDownConnection(); > // Close socket and pool right away > destroySocket(socket); > } > [Filip Hanik] 'running' variable could be false here, at which point, so

RE: svn commit: r1349984 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2012-06-13 Thread Filip Hanik (mailing lists)
My suggestion for a 7.0.28 is to have -1 for the default value of maxConnections for APR. This disables maxConnections until we have a better grip on it. Changing it to track closures is quite a surgery, something I would do for trunk, but leave out of 7.0.x. This leaves existing code flow inta

RE: svn commit: r1354112 - in /tomcat/trunk/java/javax/servlet: ./ http/

2012-06-26 Thread Filip Hanik (mailing lists)
> -Original Message- > From: Konstantin Kolinko [mailto:knst.koli...@gmail.com] > Sent: Tuesday, June 26, 2012 11:38 AM > To: Tomcat Developers List > Subject: Re: svn commit: r1354112 - in /tomcat/trunk/java/javax/servlet: > ./ http/ > > 2012/6/26 : > > Author: fhanik > > Date: Tue Jun

RE: Timing for 7.0.29

2012-06-26 Thread Filip Hanik (mailing lists)
+1 > -Original Message- > From: Mark Thomas [mailto:ma...@apache.org] > Sent: Tuesday, June 26, 2012 2:12 PM > To: Tomcat Developers List > Subject: Timing for 7.0.29 > > I'm sure circumstances will conspire against me but I am currently > planning to start the 7.0.29 release process earl

Starting on 3.1 implementation

2012-06-27 Thread Filip Hanik (mailing lists)
As some of you noticed, I added in the stubs for Servlet 3.1 yesterday. I'm planning on starting on 3.1 features, mainly the non blocking read/writes. In Tomcat, we already have an implementation of this in the sandbox http://svn.apache.org/viewvc/tomcat/sandbox/gdev6x/ That works fully, and I'll

RE: Starting on 3.1 implementation

2012-06-27 Thread Filip Hanik (mailing lists)
> > 3.1 seems to be a fairly minor update so far, so we should be able to > start > > pushing Tomcat 8 right around the time as the spec is finalized. > > Just a word of caution. The EG is far from agreed on the best way to do > the non-blocking API at the moment. As with happened with the 3.0 asy

RE: Starting on 3.1 implementation

2012-06-27 Thread Filip Hanik (mailing lists)
> > > 3.1 seems to be a fairly minor update so far, so we should be able to > start > > pushing Tomcat 8 right around the time as the spec is finalized. > > Just a word of caution. The EG is far from agreed on the best way to do > the non-blocking API at the moment. As with happened with the 3.0

non blocking API

2012-06-28 Thread Filip Hanik (mailing lists)
I posted some feedback to the expert group: http://java.net/projects/servlet-spec/lists/users/archive/2012-06/message/15 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tom

jdbc-pool build in 7.0.28

2012-06-29 Thread Filip Hanik (mailing lists)
Haven't had time to confirm this yet myself. I helped a user troubleshoot an issue, something that looked like a bug that was already fixed https://issues.apache.org/bugzilla/show_bug.cgi?id=53367 The conversation is at http://tomcat.markmail.org/thread/betq2iim6todqlde and when I gave the user

RE: svn commit: r1355615 - in /tomcat/trunk: java/org/apache/catalina/realm/JNDIRealm.java webapps/docs/config/realm.xml

2012-07-01 Thread Filip Hanik (mailing lists)
Thanks for the review and fix > -Original Message- > From: Konstantin Kolinko [mailto:knst.koli...@gmail.com] > Sent: Sunday, July 01, 2012 6:06 AM > To: Tomcat Developers List > Subject: Re: svn commit: r1355615 - in /tomcat/trunk: > java/org/apache/catalina/realm/JNDIRealm.java > webapps

RE: svn commit: r1356849 - /tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java

2012-07-03 Thread Filip Hanik (mailing lists)
> -Original Message- > From: Mark Thomas [mailto:ma...@apache.org] > Sent: Tuesday, July 03, 2012 12:37 PM > To: Tomcat Developers List > Subject: Re: svn commit: r1356849 - > /tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java > > On 03/07/2012 18:54, fha...@apache.org wrote: > >

RE: buildbot failure in ASF Buildbot on tomcat-trunk

2012-07-03 Thread Filip Hanik (mailing lists)
Will fix! > -Original Message- > From: Konstantin Kolinko [mailto:knst.koli...@gmail.com] > Sent: Tuesday, July 03, 2012 12:51 PM > To: Tomcat Developers List > Subject: Re: buildbot failure in ASF Buildbot on tomcat-trunk > > 2012/7/3 : > > The Buildbot has detected a new failure on bui

RE: Unit tests and trunk

2012-07-09 Thread Filip Hanik (mailing lists)
I'm on Windows 7 and see TestOutputBuffer fail inconsistently with Java 7 Most runs are failures. I'll be looking into this this week > -Original Message- > From: Mark Thomas [mailto:ma...@apache.org] > Sent: Monday, July 09, 2012 4:33 AM > To: Tomcat Developers List > Subject: Unit test

RE: Unit tests and trunk

2012-07-09 Thread Filip Hanik (mailing lists)
This failure happens when the write blocks, and we enter the Selector for a write operation. filip > -Original Message- > From: Filip Hanik (mailing lists) [mailto:devli...@hanik.com] > Sent: Monday, July 09, 2012 2:23 PM > To: 'Tomcat Developers List' > Subject:

RE: Unit tests and trunk

2012-07-10 Thread Filip Hanik (mailing lists)
t; > filip > > > -Original Message- > > From: Filip Hanik (mailing lists) [mailto:devli...@hanik.com] > > Sent: Monday, July 09, 2012 2:23 PM > > To: 'Tomcat Developers List' > > Subject: RE: Unit tests and trunk > > > > I'm on Windows 7

RE: Unit tests and trunk

2012-07-10 Thread Filip Hanik (mailing lists)
data > -Original Message----- > From: Filip Hanik (mailing lists) [mailto:devli...@hanik.com] > Sent: Tuesday, July 10, 2012 10:43 AM > To: 'Tomcat Developers List' > Subject: RE: Unit tests and trunk > > Ok, definitely a bug in Java 7/Windows 7. > If I turn on

RE: Unit tests and trunk

2012-07-11 Thread Filip Hanik (mailing lists)
> -Original Message- > From: Mark Thomas [mailto:ma...@apache.org] > Sent: Wednesday, July 11, 2012 2:45 AM > To: Tomcat Developers List > Subject: Re: Unit tests and trunk > > On 11/07/2012 02:27, Filip Hanik (mailing lists) wrote: > > Here's what I

RE: Unit tests and trunk

2012-07-11 Thread Filip Hanik (mailing lists)
> -Original Message- > From: Filip Hanik (mailing lists) [mailto:devli...@hanik.com] > Sent: Wednesday, July 11, 2012 10:13 AM > To: 'Tomcat Developers List' > Subject: RE: Unit tests and trunk > > > > > -Original Message- > &

RE: Unit tests and trunk

2012-07-11 Thread Filip Hanik (mailing lists)
> Sent: Wednesday, July 11, 2012 1:32 PM > To: Tomcat Developers List > Subject: Re: Unit tests and trunk > > On 11/07/2012 20:13, Filip Hanik (mailing lists) wrote: > > > > > >> -----Original Message- > >> From: Filip Hanik (mailing lists) [mailto:devli...@h

RE: Unit tests and trunk

2012-07-11 Thread Filip Hanik (mailing lists)
bit-server-hangs-on-socket.html > -Original Message- > From: Filip Hanik (mailing lists) [mailto:devli...@hanik.com] > Sent: Wednesday, July 11, 2012 2:54 PM > To: 'Tomcat Developers List' > Subject: RE: Unit tests and trunk > > The idea of creating a VM th

RE: svn commit: r1360372 - /tomcat/trunk/webapps/docs/aio.xml

2012-07-11 Thread Filip Hanik (mailing lists)
Will fix > -Original Message- > From: Mark Thomas [mailto:ma...@apache.org] > Sent: Wednesday, July 11, 2012 4:03 PM > To: Tomcat Developers List > Subject: Re: svn commit: r1360372 - /tomcat/trunk/webapps/docs/aio.xml > > On 11/07/2012 20:51, fha...@apache.org wrote: > > Author: fhanik

RE: Unit tests and trunk

2012-07-11 Thread Filip Hanik (mailing lists)
> -Original Message- > From: Mark Thomas [mailto:ma...@apache.org] > Sent: Wednesday, July 11, 2012 4:28 PM > To: Tomcat Developers List > Subject: Re: Unit tests and trunk > > On 11/07/2012 22:39, Filip Hanik (mailing lists) wrote: > > Ok, I have a reso

RE: Unit tests and trunk

2012-07-11 Thread Filip Hanik (mailing lists)
I opened a new issue pointing back to the old issue http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7183450. It may take a day or two before your bug shows up in this external database. > -Original Message- > From: Filip Hanik (mailing lists) [mailto:devli...@hanik.com]

access to build environment

2012-07-11 Thread Filip Hanik (mailing lists)
How do I get access to the build environment? So we can change the build to default to Java 7 Filip - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

RE: access to build environment

2012-07-12 Thread Filip Hanik (mailing lists)
unk even for jdbc-pool. > > Mark > > > > > Sent from my iPhone > > > > On Jul 11, 2012, at 16:42, Mark Thomas wrote: > > > >> On 11/07/2012 23:40, Filip Hanik (mailing lists) wrote: > >>> How do I get access to the build environment? > >&

RE: svn commit: r1360905 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioSelectorPool.java

2012-07-12 Thread Filip Hanik (mailing lists)
You are correct, I was chasing down the following: Testsuite: org.apache.catalina.websocket.TestWebSocket Tests run: 6, Failures: 1, Errors: 0, Time elapsed: 2.048 sec INFO: Starting ProtocolHandler ["http-nio-127.0.0.1-auto-2-9027"] Jul 12, 2012 11:56:27 AM org.apache.coyote.AbstractProtoco

RE: Current unit test behaviour for trunk using Java 7 on Solaris

2012-07-12 Thread Filip Hanik (mailing lists)
Fixed in http://svn.apache.org/viewvc?view=revision&revision=1360917 DBCP should compile as well as JDBC-POOL with 1.7 now too > -Original Message- > From: Rainer Jung [mailto:rainer.j...@kippdata.de] > Sent: Thursday, July 12, 2012 6:33 AM > To: Tomcat Developers List > Subject: Current

Re: Current unit test behaviour for trunk using Java 7 on Solaris

2012-07-12 Thread Filip Hanik Mailing Lists
and properly fixed in http://svn.apache.org/viewvc?view=revision&revision=1360929 - Original Message - > From: "Filip Hanik (mailing lists)" > To: "Tomcat Developers List" > Sent: Thursday, July 12, 2012 2:43:55 PM > Subject: RE: Current unit test

Re: svn commit: r1360729 - in /tomcat/trunk: ./ modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/driver/ res/dbcp/

2012-07-14 Thread Filip Hanik Mailing Lists
I know, it's the same patch for DBCP as for DBCP2. we can fix it, not urgent though - Original Message - > From: "Rainer Jung" > To: dev@tomcat.apache.org > Sent: Friday, July 13, 2012 3:47:27 AM > Subject: Re: svn commit: r1360729 - in /tomcat/trunk: ./ > modules/jdbc-pool/src/test/java/

Re: svn commit: r1360729 - in /tomcat/trunk: ./ modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/driver/ res/dbcp/

2012-07-15 Thread Filip Hanik Mailing Lists
st/java/org/apache/tomcat/jdbc/test/driver/ res/dbcp/ > > Do these patches need to be fed back to Commons DBCP? > > Or do they only apply to the version embedded by Tomcat? > > On 14 July 2012 21:47, Rainer Jung wrote: > > On 14.07.2012 22:25, Filip Hanik Mailing Lists w

RE: Unit tests and trunk

2012-07-18 Thread Filip Hanik (mailing lists)
adn't tested it to confirm what the OS was claiming was > indeed true. > > > I'm sure there will be more bug reports as more people turn to java 7 > on windows/hardware > > Yep. > > Mark > > > > > Sent from my iPhone > > > > On Jul 11,

Re: tomat-jdbc & hashCode

2012-07-30 Thread Filip Hanik Mailing Lists
nope, I will fix that Filip - Original Message - > From: "Romain Manni-Bucau" > To: "Tomcat Developers List" > Sent: Tuesday, July 24, 2012 5:18:32 PM > Subject: tomat-jdbc & hashCode > > Hi, > > just noticed tomcat jdbc doesn't manage hashCode if the connection is > already close (it

RE: tomat-jdbc & hashCode

2012-08-06 Thread Filip Hanik (mailing lists)
Fixed in r1370074 and r1370075 http://svn.apache.org/viewvc?rev=1370075&view=rev http://svn.apache.org/viewvc?rev=1370074&view=rev > -Original Message----- > From: Filip Hanik Mailing Lists [mailto:devli...@hanik.com] > Sent: Monday, July 30, 2012 5:58 AM > To: To

RE: pooledconnection & tccl?

2012-08-22 Thread Filip Hanik (mailing lists)
I've thought about this, you see if it is using TCCL it will cause a memory leak on app reload as the app wont be unloaded due to the pool holding it. But I think we should make it an option Best Filip > -Original Message- > From: Romain Manni-Bucau [mailto:rmannibu...@gmail.com] > Sent:

RE: svn commit: r1377689 - /tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java

2012-08-27 Thread Filip Hanik (mailing lists)
> -Original Message- > From: Konstantin Kolinko [mailto:knst.koli...@gmail.com] > Sent: Monday, August 27, 2012 2:09 PM > To: Tomcat Developers List > Subject: Re: svn commit: r1377689 - > /tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListe > ner.java > > 2012/8/27 M

RE: svn commit: r1377689 - /tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java

2012-08-27 Thread Filip Hanik (mailing lists)
r.java > > 2012/8/28 Filip Hanik (mailing lists) : > >> > >> There are documentation glitches yet to be fixed: > >> a. systemprops.xml change in trunk was not reverted by this commit. > >> It was reverted in 7.0.x only. > > [Filip Hanik] > >

RE: svn commit: r1377689 - /tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java

2012-08-27 Thread Filip Hanik (mailing lists)
; > On 27/08/2012 22:37, Filip Hanik (mailing lists) wrote: > >> -Original Message- > >> From: Konstantin Kolinko [mailto:knst.koli...@gmail.com] > >> Sent: Monday, August 27, 2012 2:09 PM > >> To: Tomcat Developers List > >> Subject: Re: s

RE: svn commit: r1377689 - /tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java

2012-08-27 Thread Filip Hanik (mailing lists)
; > On 27/08/2012 22:48, Filip Hanik (mailing lists) wrote: > > > > > >> -Original Message- > >> From: Mark Thomas [mailto:ma...@apache.org] > >> Sent: Monday, August 27, 2012 3:44 PM > >> To: Tomcat Developers List > >> Su

RE: org.apache.tomcat.util.net.AbstractEndpoint#shutdownExecutor lasts 5s?

2013-11-06 Thread Filip Hanik (mailing lists)
Romain, what you could do for a work around right now, is to set an executor yourself. This way, Tomcat won't attempt to stop it, and there wont be a delay. http://tomcat.apache.org/tomcat-7.0-doc/config/executor.html the only time tomcat attempts to stop the executor, is if it created it, but if

I'm back

2013-11-06 Thread Filip Hanik (mailing lists)
Ladies and Gentlemen, I'm back, it will take a little while to get up to speed on all changes but I intend to get involved again, so go easy on me while I learn the new tools of the trade ;) Filip - To unsubscribe, e-mail: dev-u

RE: org.apache.tomcat.util.net.AbstractEndpoint#shutdownExecutor lasts 5s?

2013-11-06 Thread Filip Hanik (mailing lists)
"http-bio-1234-exec-19" daemon prio=10 tid=0x7fc30c014000 nid=0x5bb2 runnable [0x7fc31250f000] java.lang.Thread.State: RUNNABLE at java.net.SocketInputStream.socketRead0(Native Method) at java.net.SocketInputStream.read(SocketInputStream.java:152) at java.net.SocketInputStream.read(SocketIn

RE: [VOTE] Apache Tomcat Maven plugin 2.2

2013-11-06 Thread Filip Hanik (mailing lists)
+1 > -Original Message- > From: Olivier Lamy [mailto:ol...@apache.org] > Sent: Wednesday, November 06, 2013 6:05 PM > To: Tomcat Developers List > Subject: [VOTE] Apache Tomcat Maven plugin 2.2 > > Hi, > I'd like to release Apache Tomcat Maven plugin 2.2. > > We fixed 22 issues. See > ht