Re: svn commit: r830589 - /tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java

2009-10-28 Thread Filip Hanik - Dev Lists
On 10/28/2009 09:34 AM, Mark Thomas wrote: ma...@apache.org wrote: Author: markt Date: Wed Oct 28 15:30:49 2009 New Revision: 830589 URL: http://svn.apache.org/viewvc?rev=830589&view=rev Log: Ensure thread ratio calc is valid This will need to go into 6.0.x to address Konstantin's re

Re: svn commit: r830589 - /tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java

2009-10-29 Thread Filip Hanik - Dev Lists
On 10/28/2009 10:54 PM, Konstantin Kolinko wrote: 2009/10/28: Author: markt Date: Wed Oct 28 15:30:49 2009 New Revision: 830589 +if (endpoint.getCurrentThreadsBusy()>0&& +endpoint.getMaxThreads()>0) { +threadRatio = (endpoint.getCurrentThreadsBusy() * 10

Re: svn commit: r832039 - in /tomcat/trunk/java/org/apache/naming: HandlerRef.java ResourceRef.java ServiceRef.java StringManager.java resources/DirContextURLStreamHandler.java

2009-11-03 Thread Filip Hanik - Dev Lists
On 11/02/2009 02:30 PM, Remy Maucherat wrote: On Mon, 2009-11-02 at 18:46 +, ma...@apache.org wrote: Author: markt Date: Mon Nov 2 18:46:21 2009 New Revision: 832039 URL: http://svn.apache.org/viewvc?rev=832039&view=rev Log: StringBuffer -> StringBuilder for o.a.naming So I did

Re: SSL & Tomcat

2009-11-10 Thread Filip Hanik - Dev Lists
I don't think NIO allows a renegotiation as it is today. I will have to look deeper in the code. But I think the negotiation is a one time deal per connection. I will look closer. Filip On 11/07/2009 09:59 AM, Mark Thomas wrote: All, I was thinking about this on my way back from ApacheCon an

Re: SSL & Tomcat

2009-11-11 Thread Filip Hanik - Dev Lists
On 11/11/2009 12:11 AM, Costin Manolache wrote: openssl s_client ... Type "R" ( to renegotiate ). Unfortunately renegotiation is handled transparently and did work quite well... bummer, I will see what needs to be done today. Costin On Tue, Nov 10, 2009 at 10:53 PM, Filip H

Re: SSL & Tomcat

2009-11-11 Thread Filip Hanik - Dev Lists
g, and probably eventually timeout and close the connection. Why, cause I can't remember coding it to allow renegotiation. But I will verify today. Filip We can tell people to switch to it while waiting for the other fixes... Costin On Wed, Nov 11, 2009 at 8:25 AM, Filip Hanik -

Re: Cookie issues

2009-11-11 Thread Filip Hanik - Dev Lists
On 11/11/2009 02:45 PM, Mark Thomas wrote: Remy Maucherat wrote: Hi, I think cookies are still broken, and this is getting more and more complex. The apparent issue is that the parser applies v1 parsing rules when parsing v0 cookies (which are generated using a much more lenient character e

Re: APR Connector renegotiation fix

2009-11-12 Thread Filip Hanik - Dev Lists
On 11/12/2009 04:34 AM, Mladen Turk wrote: Hi, Just made the fix by modifying the mod_ssl patch so that connection gets closed on R. Problem with OpenSSL 0.9.8l that it has renegotiation disabled and that it gets blocked in 'R' thus making it a potential DoS (much worse then actual R) so I'd su

Re: [SECURITY] CVE-2009-3555 SSL Man-In-The-Middle attack

2009-11-13 Thread Filip Hanik - Dev Lists
On 11/09/2009 09:43 AM, Mark Thomas wrote: BIO& NIO connectors using JSSE These connectors are vulnerable when renegotiation is triggered by the client or the server. This is incorrect. NIO doesn't do renegotiation. Instead it sees invalid data and times out. -

Re: svn commit: r835886 - in /tomcat/trunk/java/org/apache: catalina/startup/ContextConfig.java jasper/compiler/TldLocationsCache.java

2009-11-13 Thread Filip Hanik - Dev Lists
this would be better if it was read from a file that one can simply add on stuff. ie, better to be configurable, not hardcoded Filip On 11/13/2009 08:48 AM, ma...@apache.org wrote: Author: markt Date: Fri Nov 13 15:48:41 2009 New Revision: 835886 URL: http://svn.apache.org/viewvc?rev=835886&

Re: [VOTE] Releasing Apache Tomcat Native 1.1.18

2009-11-18 Thread Filip Hanik - Dev Lists
On 11/18/2009 08:18 AM, jean-frederic clere wrote: [X] Stable - no major issues, no regressions - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: SSL MITM status update

2009-11-20 Thread Filip Hanik - Dev Lists
On 11/19/2009 04:20 PM, Mark Thomas wrote: and 5.5.28 does not don't think there is a HTTP NIO in 5.5.x Filip - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apa

Re: DBCP 1.3/1.4

2009-12-08 Thread Filip Hanik - Dev Lists
On 12/08/2009 11:04 AM, Mark Thomas wrote: Tim Funk wrote: [I know I'm missing something .. but] Would it be worth dropping dbcp from 7 and just use jdbc-pool? I think dropping dbcp would be bad - it is something that is familiar to lots of users. familiar in what sense? how would

Re: tomcat-jdbc pool interceptor

2009-12-08 Thread Filip Hanik - Dev Lists
hi Kevin, hi Kevin, what you seem to be missing in your config is testOnBorrow="true" Filip On 12/02/2009 05:11 AM, Kevin Jackson wrote: Hi, We have a situation with a clustered SQL Server database and tomcat-jdbc. When the cluster fails over and the active node switches to the passive node,

Tomcat 7 - META-INF/context.xml

2009-12-08 Thread Filip Hanik - Dev Lists
I would like to suggest that context.xml files that are contained within directories or WAR files do not get copied to a sub directory under "conf" where it remains if the war file or directory is removed while the server is shutdown. Copying the file META-INF/context.xml has never made much s

Re: Tomcat 7 - META-INF/context.xml

2009-12-09 Thread Filip Hanik - Dev Lists
On 12/09/2009 02:57 AM, Mark Thomas wrote: Filip Hanik - Dev Lists wrote: I would like to suggest that context.xml files that are contained within directories or WAR files do not get copied to a sub directory under "conf" where it remains if the war file or directory is removed

Re: Tomcat 7 - META-INF/context.xml

2009-12-09 Thread Filip Hanik - Dev Lists
On 12/09/2009 07:06 AM, Mark Thomas wrote: Filip Hanik - Dev Lists wrote: On 12/09/2009 02:57 AM, Mark Thomas wrote: Filip Hanik - Dev Lists wrote: I would like to suggest that context.xml files that are contained within directories or WAR files do not get copied to a sub

Re: svn commit: r1094069 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/manager/ java/org/apache/catalina/session/ webapps/docs/

2011-04-19 Thread Filip Hanik - Dev Lists
On 4/18/2011 4:39 AM, Mark Thomas wrote: On 18/04/2011 10:13, Remy Maucherat wrote: On Sat, 2011-04-16 at 22:25 +, ma...@apache.org wrote: Author: markt Date: Sat Apr 16 22:25:28 2011 New Revision: 1094069 URL: http://svn.apache.org/viewvc?rev=1094069&view=rev Log: Fix https://issues.apa

Re: svn commit: r1095367 - in /tomcat/trunk: java/org/apache/catalina/startup/ java/org/apache/jasper/compiler/ java/org/apache/tomcat/util/scan/ webapps/docs/

2011-04-20 Thread Filip Hanik - Dev Lists
On 4/20/2011 10:07 AM, Mark Thomas wrote: The new code is better than the old. You are welcome to try and improve it further although I don't think there is much more scope for improvement given the performance figures I am seeing. My suggestion here would be to: 1. When a JAR file has been sca

SpnegoAuthenticator feedback

2011-04-20 Thread Filip Hanik - Dev Lists
Here are some thoughts on the implementation 1. |com.sun.security.jgss.initiate is not needed This definition is not needed in jaas.conf. Tomcat is not a client in this case, it's a server accepting tickets. the .initiate is only for clients that request a Kerberos ticket from the KDC. The examp

Re: SpnegoAuthenticator feedback

2011-04-21 Thread Filip Hanik - Dev Lists
On 4/21/2011 3:09 AM, Mark Thomas wrote: On 20/04/2011 21:00, Filip Hanik - Dev Lists wrote: Here are some thoughts on the implementation Thanks for the feedback. 1. |com.sun.security.jgss.initiate is not needed This definition is not needed in jaas.conf. Tomcat is not a client in this case

Re: svn commit: r1095794 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11Processor.java webapps/docs/changelog.xml

2011-04-21 Thread Filip Hanik - Dev Lists
On 4/21/2011 1:02 PM, ma...@apache.org wrote: +int firstReadTimeout; +if (queueTime>= standardTimeout) { +// Queued for longer than timeout but there might be +// data so use shortest possible timeout +

Re: svn commit: r1094069 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/ha/session/ java/org/apache/catalina/manager/ java/org/apache/catalina/session/ webapps/docs/

2011-04-26 Thread Filip Hanik - Dev Lists
On 4/21/2011 8:00 AM, Mark Thomas wrote: On 19/04/2011 16:27, Filip Hanik - Dev Lists wrote: On 4/18/2011 4:39 AM, Mark Thomas wrote: On 18/04/2011 10:13, Remy Maucherat wrote: On Sat, 2011-04-16 at 22:25 +, ma...@apache.org wrote: Author: markt Date: Sat Apr 16 22:25:28 2011 New

Re: bindOnInit and maxConnections for AJP connectors

2011-05-03 Thread Filip Hanik - Dev Lists
On 5/3/2011 10:50 AM, Mark Thomas wrote: On 21/04/2011 20:21, Mark Thomas wrote: On 06/04/2011 22:51, Tim Whittington wrote: On Wed, Apr 6, 2011 at 11:16 PM, Mark Thomas wrote: On 05/04/2011 10:50, Tim Whittington wrote: Is what's actually going on more like: APR: use maxConnections == poll

Re: BIO performance issues

2011-05-04 Thread Filip Hanik - Dev Lists
On 5/3/2011 2:02 PM, Mark Thomas wrote: All, Summary --- While trying to align the documentation for maxConnections with the actual implementation a couple of performance issue have been identified with the BIO connector. All bar one of these have been fixed. A fix needs to be agreed for the

Re: BIO performance issues

2011-05-04 Thread Filip Hanik - Dev Lists
On 5/4/2011 9:54 AM, Mark Thomas wrote: On 04/05/2011 16:17, Filip Hanik - Dev Lists wrote: On 5/3/2011 2:02 PM, Mark Thomas wrote: In a similar fashion, we can also craft a test run that will yield a substantial improvement over the old implementation in throughput. So there is a test case to

Re: BIO performance issues

2011-05-05 Thread Filip Hanik - Dev Lists
fan-tastic! Thank you! On 5/5/2011 9:56 AM, Mark Thomas wrote: On 04/05/2011 16:17, Filip Hanik - Dev Lists wrote: Here is what I propose, and you'll see that it's pretty much inline with what you suggest. a) add in a flag that lets keep alive be turned off during c

Re: Time for 7.0.13

2011-05-05 Thread Filip Hanik - Dev Lists
+1 Filip On 5/5/2011 10:00 AM, Mark Thomas wrote: All open bugs (apart from 49683 which should probably be re-classed as an enhancement) have been fixed in trunk, the BIO changes have been applied and recent enhancement requests (with patches) have been applied. I am about to start the testing

Re: [VOTE] Release Apache Tomcat 7.0.14

2011-05-10 Thread Filip Hanik - Dev Lists
On 5/9/2011 5:31 PM, Mark Thomas wrote: [X] Stable - go ahead and release as 7.0.14 Stable - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: DO NOT REPLY [Bug 51189] New: Acceptor threads are blocked

2011-05-12 Thread Filip Hanik - Dev Lists
on most OS:es there is a single lock for accepting new connections, so a better default is 1 for acceptor thread count. there is no performance gain in multiple threads, none that I was ever able to detect. Filip On 5/12/2011 2:32 AM, bugzi...@apache.org wrote: https://issues.apache.org/bugzil

Re: svn commit: r1103633 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java

2011-05-16 Thread Filip Hanik - Dev Lists
-1 for this change. 0 means infinite (no timeout) http://download.oracle.com/javase/6/docs/api/java/net/Socket.html#setSoTimeout%28int%29 Filip On 5/16/2011 1:31 AM, ma...@apache.org wrote: Author: markt Date: Mon May 16 07:31:23 2011 New Revision: 1103633 URL: http://svn.apache.org/viewvc?re

Re: svn commit: r1103633 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioBlockingSelector.java

2011-05-16 Thread Filip Hanik - Dev Lists
tch(readTimeout,TimeUnit.MILLISECONDS); +} Filip On 5/16/2011 3:38 PM, Mark Thomas wrote: On 16/05/2011 16:24, Filip Hanik - Dev Lists wrote: -1 for this change. 0 means infinite (no timeout) http://download.oracle.com/javase/6/docs/api/java/net/Socket.html#setSoTimeout%28int%29 The problem

Re: [PROPOSAL] Move to svnpubsub for /dist/tomcat

2011-05-18 Thread Filip Hanik - Dev Lists
+1 sounds good Filip On 5/18/2011 7:38 AM, Mark Thomas wrote: All, We have the option to move to svnpubsub for managing our releases. Rather than copying artefacts to people.a.o and then waiting for rsync (every around 2 hours) we would commit the artefacts to svn and a commit hook would updat

Re: LocalXA patch proposition

2011-05-24 Thread Filip Hanik - Dev Lists
hi Philippe, open a bugzilla item https://issues.apache.org/bugzilla/enter_bug.cgi?product=Tomcat%20Modules Add your patch there, and I will happily take a look thanks for contributing Filip On 5/24/2011 8:31 AM, Philippe Mouawad wrote: Hello, I have implemented for Ofbiz a port of DBCP Local

Re: Plan for 7.0.15

2011-06-03 Thread Filip Hanik - Dev Lists
I'd like to suggest that we include tomcat-jdbc.jar in the 7.0.15 release. DBCP will still be the default, but allows users to configure an alternative fairly easily without downloading separate libraries. It's easy to include in the build process, the jar is very small, so it doesn't bloat the

Re: Plan for 7.0.15

2011-06-03 Thread Filip Hanik - Dev Lists
On 6/3/2011 10:13 AM, Mark Thomas wrote: On 03/06/2011 17:07, Filip Hanik - Dev Lists wrote: I'd like to suggest that we include tomcat-jdbc.jar in the 7.0.15 release. DBCP will still be the default, but allows users to configure an alternative fairly easily without downloading sep

Re: svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

2011-06-20 Thread Filip Hanik - Dev Lists
On 6/20/2011 8:06 AM, Mladen Turk wrote: On 06/20/2011 03:53 PM, Rainer Jung wrote: On 20.06.2011 15:41, Mladen Turk wrote: In general all commands except those that start a Tomcat (and thus deploy webapps etc.) should not use that type of params. They should go into CATALINA_OPTS. Everything t

Re: svn commit: r1144061 - in /tomcat/trunk: build.xml modules/jdbc-pool/build.xml res/maven/mvn-pub.xml res/maven/tomcat-jdbc.pom webapps/docs/project.xml

2011-07-08 Thread Filip Hanik - Dev Lists
On 7/7/2011 5:55 PM, Konstantin Kolinko wrote: 2011/7/8: Author: fhanik Date: Thu Jul 7 21:40:05 2011 New Revision: 1144061 URL: http://svn.apache.org/viewvc?rev=1144061&view=rev Log: Include jdbc-pool into tomcat release. Added: tomcat/trunk/res/maven/tomcat-jdbc.pom 1) svn:eol-style fo

Re: svn commit: r1144061 - in /tomcat/trunk: build.xml modules/jdbc-pool/build.xml res/maven/mvn-pub.xml res/maven/tomcat-jdbc.pom webapps/docs/project.xml

2011-07-10 Thread Filip Hanik - Dev Lists
On 7/10/2011 6:59 AM, Rainer Jung wrote: Hi Filip, On 07.07.2011 23:40, fha...@apache.org wrote: Author: fhanik Date: Thu Jul 7 21:40:05 2011 New Revision: 1144061 URL: http://svn.apache.org/viewvc?rev=1144061&view=rev Log: Include jdbc-pool into tomcat release. Added: tomcat/trunk/res/

Re: [jdbc-pool] AT sign in manifest (filtered version strings)

2011-07-10 Thread Filip Hanik - Dev Lists
feel free to commit the fix On 7/10/2011 2:38 PM, Rainer Jung wrote: I tested the jdbc-pool building, which is part of the release right now. The manifest contains patterns of the form @@VERSION@@, e.g. org.apache.tomcat.jdbc.pool;version="@@VERSION@@"; org.apache.tomcat.jdbc.pool.interceptor;v

Re: Distributable contexts and non-serializable session attributes

2011-07-10 Thread Filip Hanik - Dev Lists
go ahead add it in, if you add in a flag to toggle the behavior, and the flag is defaulted to today's behavior. you're safe, and you give users an option Filip On 7/10/2011 1:38 PM, Rainer Jung wrote: I implemented an addition to DeltaManager which allows to filter which session attributes act

Re: [VOTE] Release Apache Tomcat 7.0.19

2011-07-18 Thread Filip Hanik - Dev Lists
[X] Stable - go ahead and release as 7.0.19 Stable On 7/14/2011 3:21 AM, Mark Thomas wrote: The proposed Apache Tomcat 7.0.19 release is now available for voting. It can be obtained from: http://people.apache.org/~markt/dev/tomcat-7/v7.0.19/ The svn tag is: http://svn.apache.org/repos/asf/tom

Re: is this acceptor threadsafe?

2011-08-15 Thread Filip Hanik - Dev Lists
On 8/15/2011 6:34 AM, Ҷï wrote: /** * Server socket acceptor thread. */ protected class Acceptor implements Runnable { /** * The background thread that listens for incoming TCP/IP connections and * hands them off to an appropriate processor.

Re: [VOTE] Grant Olivier Lamy commit karma to the Tomcat repo (for the Maven plugin)

2011-08-25 Thread Filip Hanik - Dev Lists
+1 On 8/25/2011 8:44 AM, Mark Thomas wrote: Subject says it all. Here is my +1 to start this off. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1157874 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java

2011-08-26 Thread Filip Hanik - Dev Lists
Thank you! On 8/26/2011 7:31 AM, Konstantin Kolinko wrote: 2011/8/25 Konstantin Kolinko: URL: http://svn.apache.org/viewvc?rev=1157874&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51583 1) I think that because of this change the " while (con != null) {" loop may run infi

Re: Tomcat 6.0.34

2011-09-08 Thread Filip Hanik - Dev Lists
On 9/7/2011 11:48 AM, Anand, Amit (Contractor) wrote: All, Kinda new to tomcat but have a couple quick questions which came up regarding CVE-2011-3109 (Bug 51698). Questions: Any timeline to when stable release of 6.0.34 is supposed to be released? Just follow this list. That's the best way

Re: new year, new version? 6.0.16

2008-01-08 Thread Filip Hanik - Dev Lists
ok, I'll take a look at this before we move on Filip Remy Maucherat wrote: On Fri, 2008-01-04 at 11:20 -0700, Filip Hanik - Dev Lists wrote: we have a lot of updates added in, I think it may be good to set a date for our next release and work towards that r297710 is a hack

Re: new year, new version? 6.0.16

2008-01-08 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Fri, 2008-01-04 at 11:20 -0700, Filip Hanik - Dev Lists wrote: we have a lot of updates added in, I think it may be good to set a date for our next release and work towards that r297710 is a hack, and reintroduces a data corruption bug that was fixed a long

Re: backlog measurement

2008-01-10 Thread Filip Hanik - Dev Lists
I'm a bit confused on how you can measure backlog in Java. Backlog is a TCP stack implementation setting. Also, between TCP implementations, there is no firm definition of what backlog actually means. does it mean SYN_RCVD or ESTABLISHED but not yet accepted? If I read the implementation corre

Re: backlog measurement

2008-01-10 Thread Filip Hanik - Dev Lists
this problem, can you please advice me a more appropriate way. Thank you Andrew. On 1/10/08, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote: I'm a bit confused on how you can measure backlog in Java. Backlog is a TCP stack implementation setting. Also, between TCP implementations,

Re: svn commit: r610946 - in /tomcat/trunk: conf/tomcat-users.xml webapps/examples/jsp/tagplugin/if.jsp

2008-01-10 Thread Filip Hanik - Dev Lists
I don't think we wanna ship a file that has a default user for admin and manager roles. most folks leave this realm in their server.xml, and the manager app enabled, so this would create future complaints -1 on the tomcat-users.xml change Filip [EMAIL PROTECTED] wrote: Author: markt Date:

Re: Native 1.1.12 release

2008-01-14 Thread Filip Hanik - Dev Lists
you're other option is to just vote on tcnative separately, and that way utilize all the ASF mirrors and release sites Filip Mladen Turk wrote: Mark Thomas wrote: Mladen Turk wrote: Henri Gomez wrote: No, like said, Tomcat Native is voted *together* with Tomcat version that contains it. M

Re: Native 1.1.12 release

2008-01-14 Thread Filip Hanik - Dev Lists
Mladen Turk wrote: Filip Hanik - Dev Lists wrote: you're other option is to just vote on tcnative separately, and that way utilize all the ASF mirrors and release sites But that is exactly what we should *not* do. Tomcat comes with it's native, so if you upgrade the Tomcat, u

Re: [VOTE] Release Tomcat native 1.1.12

2008-01-14 Thread Filip Hanik - Dev Lists
Mladen Turk wrote: Yoav Shapira wrote: Sorry, I typed this before reading the other thread. +1 for releasing this specific file. If this vote doesn't pass, the file has to be removed. I'll remove the file (1.1.12) Like said they are already inside http://tomcat.apache.org/dev/dist/tomcat-co

Re: svn commit: r612319 - /tomcat/current/tc5.5.x/STATUS.txt

2008-01-15 Thread Filip Hanik - Dev Lists
I get a 404 on the URL Filip [EMAIL PROTECTED] wrote: Author: markt Date: Tue Jan 15 16:03:57 2008 New Revision: 612319 URL: http://svn.apache.org/viewvc?rev=612319&view=rev Log: Propose a library update for TC5 Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x

Re: Tagging 5.5.26

2008-01-16 Thread Filip Hanik - Dev Lists
just a reminder Filip Filip Hanik - Dev Lists wrote: Hey all, I'm planning on tagging 5.5.26 on Monday Jan 21st, roughly around noon MST. This should give us plenty of time to clear out status and test everything before doing the release. I'll assume lazy consensus unless anyone

Re: new year, new version? 6.0.16

2008-01-16 Thread Filip Hanik - Dev Lists
could we get a target date for this? I believe there is enough community interest to push out a new release Filip Filip Hanik - Dev Lists wrote: we have a lot of updates added in, I think it may be good to set a date for our next release and work towards that Filip

Re: svn commit: r612192 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java

2008-01-16 Thread Filip Hanik - Dev Lists
cause I'm likely to discover elsewhere in the tribes module where reverse DNS lookups are taking place, and at that point can take advantage of the global flag rather than creating duplicate configs or creating component dependencies that are not supposed to be there. does that make sense? Fil

Re: new year, new version? 6.0.16

2008-01-17 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Wed, 2008-01-16 at 15:26 -0700, Filip Hanik - Dev Lists wrote: could we get a target date for this? I believe there is enough community interest to push out a new release There are still a lot of pending patches. that's alright, shouldn't preve

Re: new year, new version? 6.0.16

2008-01-17 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Thu, 2008-01-17 at 07:56 -0700, Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: On Wed, 2008-01-16 at 15:26 -0700, Filip Hanik - Dev Lists wrote: could we get a target date for this? I believe there is enough community interest to push out a new

Re: new year, new version? 6.0.16

2008-01-17 Thread Filip Hanik - Dev Lists
date set on trunk yet, there wont be until trunk moves to a 6.x branch, and then we do releases from there. I don't see this one in a while, 6.0 is still gaining momentum and is getting bugfixes done. Filip thanks david jencks On Jan 4, 2008, at 10:20 AM, Filip Hanik - Dev Lists wrote: we

Re: svn commit: r613796 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/startup/HostConfig.java webapps/docs/changelog.xml

2008-01-21 Thread Filip Hanik - Dev Lists
lets try to avoid further delays, 6.0.16 is much anticipated Filip Peter Rossbach wrote: Hi Remy, +1 to release next week! Am 21.01.2008 um 10:53 schrieb Remy Maucherat: On Mon, 2008-01-21 at 08:41 +, [EMAIL PROTECTED] wrote: Author: pero Date: Mon Jan 21 00:41:31 2008 New Revision: 6

Re: svn commit: r613796 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/startup/HostConfig.java webapps/docs/changelog.xml

2008-01-21 Thread Filip Hanik - Dev Lists
btw, I'll delay 5.5 as well, that way all patches that were entered until now, can be tested. so there is no need to wait for the tag to test, during this week Filip Remy Maucherat wrote: On Mon, 2008-01-21 at 08:41 +, [EMAIL PROTECTED] wrote: Author: pero Date: Mon Jan 21 00:41:31 20

Re: svn commit: r614974 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/coyote/http11/Http11NioProcessor.java

2008-01-25 Thread Filip Hanik - Dev Lists
you got it Filip Peter Rossbach wrote: Hi Filip, can you remove the STATUS.txt entry, please? Thanks Peter Am 24.01.2008 um 21:23 schrieb [EMAIL PROTECTED]: Author: fhanik Date: Thu Jan 24 12:22:59 2008 New Revision: 614974 URL: http://svn.apache.org/viewvc?rev=614974&view=rev Log: vote an

Re: DOS-Lineends in many files contained in distribution tar.gz

2008-01-25 Thread Filip Hanik - Dev Lists
what effect do the line endings actually have, from a functionality point? only if it affects the distro in a negative way would I actually go through all this trouble. but I haven't had any problems so far, and we are on all kinds of platforms Filip Rainer Jung wrote: Hello, no unfortunat

Re: DOS-Lineends in many files contained in distribution tar.gz

2008-01-26 Thread Filip Hanik - Dev Lists
Rainer Jung wrote: Hi Filip, Filip Hanik - Dev Lists schrieb: what effect do the line endings actually have, from a functionality point? It's more the human factor. I expect none of the mentioned files to fail fatally with DOS style on Unix. On the other hand some of those are

reminder 5.5.26

2008-01-27 Thread Filip Hanik - Dev Lists
reminder, I will be tagging 5.5.26 around noon tomorrow (MST). I will be running a smoke test with the TCK's prior to the tag. Filip - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: Where's the fix of CVE-2005-2090?

2008-01-28 Thread Filip Hanik - Dev Lists
Mark Thomas wrote: Michal Vyskocil wrote: I'm unable to locate a patch to fix the CVE-2005-2090. I cannot found any hint from svn commit log or bugzilla. Maybe is this commit r513079 | markt | 2007-03-01 01:26:12 +0100 (Č

Re: reminder 5.5.26

2008-01-28 Thread Filip Hanik - Dev Lists
Candidate binaries for 5.5.26 http://people.apache.org/~fhanik/tomcat/tomcat-5.5/v5.5.26/ I'll post a vote up on Wednesday. Filip Filip Hanik - Dev Lists wrote: reminder, I will be tagging 5.5.26 around noon tomorrow (MST). I will be running a smoke test with the TCK's prior

Re: svn commit: r616522 - in /tomcat/trunk/java/org/apache/tomcat/util/net/puretls: PureTLSImplementation.java PureTLSSocket.java PureTLSSocketFactory.java PureTLSSupport.java

2008-01-29 Thread Filip Hanik - Dev Lists
Bill Barker wrote: "Mark Thomas" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Author: markt Date: Tue Jan 29 13:18:25 2008 New Revision: 616522 URL: http://svn.apache.org/viewvc?rev=616522&view=rev Log: Tab police. No function change Modified:

Re: svn commit: r616522 - in /tomcat/trunk/java/org/apache/tomcat/util/net/puretls: PureTLSImplementation.java PureTLSSocket.java PureTLSSocketFactory.java PureTLSSupport.java

2008-01-30 Thread Filip Hanik - Dev Lists
Bill Barker wrote: "Filip Hanik - Dev Lists" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] Bill Barker wrote: "Mark Thomas" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Author:

Re: svn commit: r616522 - in /tomcat/trunk/java/org/apache/tomcat/util/net/puretls: PureTLSImplementation.java PureTLSSocket.java PureTLSSocketFactory.java PureTLSSupport.java

2008-01-30 Thread Filip Hanik - Dev Lists
Mark Thomas wrote: Filip Hanik - Dev Lists wrote: Bill Barker wrote: I'm for removing support for PureTLS, since it is largely unmaintained at the moment. But the abstraction is usefull to be able to support SSL providers (e.g. Mozilla meantioned above) that don't implement

[VOTE] Release build 5.5.26

2008-01-31 Thread Filip Hanik - Dev Lists
The candidates binaries are available here: http://people.apache.org/~fhanik/tomcat/tomcat-5.5/v5.5.26/ According to the release process, the 5.5.26 tag is: [ ] Broken [ ] Alpha [ ] Beta [ ] Stable - To unsubscribe, e-mail:

Re: [VOTE] Release build 5.5.26

2008-01-31 Thread Filip Hanik - Dev Lists
fixed, Filip Konstantin Kolinko wrote: The md5 files have an extra CR-LF in them. E.g. c8248787ee28cd0a80196f7cc6f57db8 *apache-tomcat-5.5.26.zip For 6.0.16 they are OK. 2008/1/31, Filip Hanik - Dev Lists <[EMAIL PROTECTED]>: The candidates binaries are available here

Re: Wrong path to servlet - 404 Not Found

2008-01-31 Thread Filip Hanik - Dev Lists
did you try: myapp swallowOutput="true" /> docBase="/usr/local/apache-tomcat-5.5.25/server/webapps/manager" debug="0" privileged="true"/> Emmanuel Milou wrote: here is the part of my server.xml you wanted to check: myapp swallowOutput="true" /> do

Re: slight gotcha with tomcat 6.0 cluster startup with already running tomcat 5 cluster on the network

2008-01-31 Thread Filip Hanik - Dev Lists
thanks for the feedback, we can add in a message, that notifies the user that we are receiving invalid multicast packets and that there is probably some other piece of software broadcasting on our channel Filip Haroon Rafique wrote: Hi there, I ran into something today which might help someo

Re: [VOTE] Release build 6.0.16

2008-01-31 Thread Filip Hanik - Dev Lists
Mark Thomas wrote: Mark Thomas wrote: Remy Maucherat wrote: The candidates binaries are available here: http://people.apache.org/~remm/tomcat-6/v6.0.16/ According to the release process, the 6.0.16 tag is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable I currently see a small number TCK failures.

Re: [VOTE] Release build 6.0.16

2008-01-31 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: The candidates binaries are available here: http://people.apache.org/~remm/tomcat-6/v6.0.16/ According to the release process, the 6.0.16 tag is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable Rémy - To unsub

Re: svn commit: r618150 - /tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java

2008-02-03 Thread Filip Hanik - Dev Lists
are we still using the debug attribute, or should it be if log.isDebugEnabled log.debug... Filip [EMAIL PROTECTED] wrote: Author: funkman Date: Sun Feb 3 18:10:39 2008 New Revision: 618150 URL: http://svn.apache.org/viewvc?rev=618150&view=rev Log: http://issues.apache.org/bugzilla/show_bug.cg

Heads up: Bayeux contribution

2008-02-04 Thread Filip Hanik - Dev Lists
Guy Molinari and myself have completed a Bayuex implementation. You can find it at: http://svn.hanik.com/viewvc/tomcat-bayeux/ user: tomcat password: tomcat We are now waiting for Guy's CLA to be registered and then we are ready to contribute it to the Tomcat code base. We did rework the dojox.c

Re: Heads up: Bayeux contribution

2008-02-05 Thread Filip Hanik - Dev Lists
, Greate job, nice to see you cometd implementation. Can you please active a dir tarball download at your viewvc or place a complete download release, otherwise? Regards Peter Am 05.02.2008 um 04:16 schrieb Filip Hanik - Dev Lists: Guy Molinari and myself have completed a Bayuex implementation

Re: Heads up: Bayeux contribution

2008-02-05 Thread Filip Hanik - Dev Lists
sorry, the link is svn co --username tomcat http://svn.hanik.com/svn/repos/tomcat-bayeux Filip Peter Rossbach wrote: Many thanks for info! Peter Am 05.02.2008 um 15:02 schrieb Filip Hanik - Dev Lists: hi Peter, http://svn.hanik.com/viewvc/tomcat-bayeux/build/ user: tomcat pwd: tomcat

[ANN] Apache Tomcat 5.5.26 released

2008-02-05 Thread Filip Hanik - Dev Lists
The Apache Tomcat team announces the immediate availability of Apache Tomcat 5.5.26 stable. Apache Tomcat 5.5.26 incorporates numerous security updates and bug fixes. Please refer to the change log for the list of changes: http://tomcat.apache.org/tomcat-5.5-doc/changelog.html Downloads: http://

Re: Heads up: Bayeux contribution

2008-02-05 Thread Filip Hanik - Dev Lists
Niall Pemberton wrote: On Feb 5, 2008 2:06 PM, jean-frederic clere <[EMAIL PROTECTED]> wrote: Yoav Shapira wrote: On Feb 5, 2008 3:26 AM, jean-frederic clere <[EMAIL PROTECTED]> wrote: The normal way is to go through the incubator process. Why? This is not a new proje

Re: [VOTE] Release build 6.0.16

2008-02-05 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: Rainer Jung wrote: Remy Maucherat schrieb: The candidates binaries are available here: http://people.apache.org/~remm/tomcat-6/v6.0.16/ According to the release process, the 6.0.16 tag is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable Rémy One small note: there is a new Thu

Re: [VOTE] Release build 6.0.16

2008-02-05 Thread Filip Hanik - Dev Lists
Niall Pemberton wrote: On Feb 5, 2008 6:56 PM, Mark Thomas <[EMAIL PROTECTED]> wrote: Rainer Jung wrote: Remy Maucherat wrote: Rainer Jung wrote: Remy Maucherat schrieb: The candidates binaries are available here: http://people.apache.org/~remm/tomcat-6/v6.

Re: [VOTE] Release tc-native 1.1.13

2008-02-09 Thread Filip Hanik - Dev Lists
According to the release process, the 1.1.13 tag is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable Filip - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: Cookies are broken in 6.0.16?

2008-02-09 Thread Filip Hanik - Dev Lists
no regression, if you do this c = new javax.servlet.http.Cookie("abcv1","123=="); c.setVersion(1); response.addCookie(c); then it works just fine. however, if you do c = new javax.servlet.http.Cookie("abcv0","123=="); response.addCookie(c); then it doesn't. if we encode it, (which we did

Re: Cookies are broken in 6.0.16?

2008-02-09 Thread Filip Hanik - Dev Lists
actually not, in previous version, we double quoted v0 cookies, and so browsers treated them as v1 in terms of value any sort of encoding attempt we made was miserable between different browsers. filip Jim Manico wrote: Filip, Would you consider auto-encoding only = and ; in the cookie value,

Re: Cookies are broken in 6.0.16?

2008-02-09 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Sat, 2008-02-09 at 16:14 -0700, Filip Hanik - Dev Lists wrote: no regression, if you do this c = new javax.servlet.http.Cookie("abcv1","123=="); c.setVersion(1); response.addCookie(c); then it works just fine. however,

Re: Cookies are broken in 6.0.16?

2008-02-09 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Sat, 2008-02-09 at 16:14 -0700, Filip Hanik - Dev Lists wrote: no regression, if you do this c = new javax.servlet.http.Cookie("abcv1","123=="); c.setVersion(1); response.addCookie(c); then it works just fine. however,

Re: Cookies are broken in 6.0.16?

2008-02-09 Thread Filip Hanik - Dev Lists
ns roll back to the old/non-standard cookie handling methodology? no, we wont do that. we fixed the cookie behavior in this release due to security issues filed against the old parsing. Filip - Jim Remy Maucherat wrote: On Sat, 2008-02-09 at 16:14 -0700, Filip Hanik - Dev Lists wrote: no re

Re: Cookies are broken in 6.0.16?

2008-02-10 Thread Filip Hanik - Dev Lists
Mark Thomas wrote: Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: Jim Manico wrote: > I guess we could throw a run time exception if the value contained any of those. other than that, I'm not sure how to behave I think this is the best case scenario for v0 cookies. Perhaps,

Re: Cookies are broken in 6.0.16?

2008-02-10 Thread Filip Hanik - Dev Lists
Mark Thomas wrote: Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: Jim Manico wrote: > I guess we could throw a run time exception if the value contained any of those. other than that, I'm not sure how to behave I think this is the best case scenario for v0 cookies. Perhaps,

Re: Cookies are broken in 6.0.16?

2008-02-10 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Sun, 2008-02-10 at 11:44 -0500, Jim Manico wrote: Filip - you are 100% correct on this thread. Are you basically the traffic cop guarding the core of Tomcat? I understand, you are not impacted by the behavior change, and as a result this allows you to be "fair"

Re: Cookies are broken in 6.0.16?

2008-02-10 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: On Sun, 2008-02-10 at 11:17 -0700, Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: On Sun, 2008-02-10 at 11:44 -0500, Jim Manico wrote: Filip - you are 100% correct on this thread. Are you basically the traffic cop guarding the core of Tomcat

Re: Cookies are broken in 6.0.16?

2008-02-10 Thread Filip Hanik - Dev Lists
Bill Barker wrote: "Remy Maucherat" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] On Sun, 2008-02-10 at 23:29 +, Mark Thomas wrote: Filip Hanik - Dev Lists wrote: Would this be ok, given its a spec class? or do we have to leave this class unto

Re: Cookies are broken in 6.0.16?

2008-02-10 Thread Filip Hanik - Dev Lists
Mark Thomas wrote: Filip Hanik - Dev Lists wrote: Would this be ok, given its a spec class? or do we have to leave this class untouched and modify it elsewhere, in which case it'd be more of a hack. I think, as long as we leave the public interface unchanged, changing the spec class

Re: Cookies are broken in 6.0.16?

2008-02-12 Thread Filip Hanik - Dev Lists
Sven Köhler wrote: The difficulty here is that although '=' is the delimiter between NAME and VALUE there is no need to encode it if it appears in the name or the value. This causes some ambiguities when parsing a header of the form: Set-Cookie: foo=bar=bartoo Is the name 'foo' or 'foo=bar'? Is

Re: Heads up: Bayeux contribution

2008-02-12 Thread Filip Hanik - Dev Lists
status update, we're just waiting for the API update to have a shared/common server side API before we make the proposals Filip Filip Hanik - Dev Lists wrote: Niall Pemberton wrote: On Feb 5, 2008 2:06 PM, jean-frederic clere <[EMAIL PROTECTED]> wrote: Yoav Shapira wrote:

<    6   7   8   9   10   11   12   13   14   15   >