error-page mapping for 200?

2007-01-08 Thread Arvind Srinivasan
Hi, StandardContext.findErrorPage(int) (http://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardContext.java) has the following public ErrorPage findErrorPage(int errorCode) { if (errorCode == 200) { return (okErrorPage); } el

[PATCH] - Remove redundant code in Mapper.java

2007-03-26 Thread Arvind Srinivasan
Attached is a simple patch (for TC 6.0's trunk) that removes a couple of lines of redundant code in org.apache.tomcat.util.http.mapper.Mapper Arvind Index: java/org/apache/tomcat/util/http/mapper/Mapper.java === --- java/org/apache/

Re: [PATCH] - Remove redundant code in Mapper.java

2007-03-27 Thread Arvind Srinivasan
Remy Maucherat wrote: > I am not certain they're that redundant. I would leave them in just to I'm not quite sure I understand why, so please could you elaborate. * Since setString() is invoked after setChars(), a toString() on (which is pretty much the only method invoked on mappingData.reques

TC4.x vs TC5/6.x - JSESSIONID Set-Cookie differences

2007-03-30 Thread Arvind Srinivasan
Hi, In Tomcat 5.x and 6.x, the JSESSIONID Set-Cookie header is added to the response during session creation (in Request.doGetSession), whereas in Tomcat 4.x this used to be done during Response.sendHeaders(). Not that it causes any problems, but TC 5.x/6.x responses can contain JSESSIONID Se

Re: TC4.x vs TC5/6.x - JSESSIONID Set-Cookie differences

2007-04-01 Thread Arvind Srinivasan
Filip Hanik - Dev Lists wrote: what would seem appropriate would be to do this: 1. Prevent multiple cookies, ie, swap out the old cookie. Only one session id should be sent down There doesn't seem to be an easy way to get hold of the response object from inside of session.expire(). 2. throw

Re: TC4.x vs TC5/6.x - JSESSIONID Set-Cookie differences

2007-04-01 Thread Arvind Srinivasan
Remy Maucherat wrote: This is not that easy to do. I realized this when trying to come up with a patch for moving the logic to the response :) Arvind - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-