https://bz.apache.org/bugzilla/show_bug.cgi?id=69710
Mark Thomas changed:
What|Removed |Added
Resolution|--- |WONTFIX
Status|NEW
ChristopherSchultz commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2962314501
@morning-gu Please don't ping specific members of this team to ask for a
review. Everyone is aware that this PR is here, and it will be reviewed when
these volunteers have time to
https://bz.apache.org/bugzilla/show_bug.cgi?id=69710
--- Comment #5 from Remy Maucherat ---
Ok, so what would be a reasonable default value in your opinion ?
--
You are receiving this mail because:
You are the assignee for the bug.
---
morning-gu commented on code in PR #867:
URL: https://github.com/apache/tomcat/pull/867#discussion_r2139963921
##
java/org/apache/coyote/Request.java:
##
@@ -389,14 +389,18 @@ public void setLocalPort(int port) {
// encoding/type
https://bz.apache.org/bugzilla/show_bug.cgi?id=69710
--- Comment #6 from Aleksandr Beliakov ---
I did some tests, it seems like Tomcat mixes a number of fields and number of
files uploaded. On some of the forms, I have a limit of 5-10 files per form, on
others I cannot submit even a single file..
ChristopherSchultz commented on code in PR #867:
URL: https://github.com/apache/tomcat/pull/867#discussion_r2139938437
##
java/org/apache/coyote/Request.java:
##
@@ -389,14 +389,18 @@ public void setLocalPort(int port) {
// encoding/type ---
ChristopherSchultz commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2962441562
This analysis looks correct to me, and the solution is staightforward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
ChristopherSchultz commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2962444324
What does your flame graph look like after this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
https://bz.apache.org/bugzilla/show_bug.cgi?id=69710
--- Comment #7 from Christopher Schultz ---
There is no difference between "files" and "non-files" when it comes to
multipart requests. There are only names and values. The fact that your
application treats the differently comes down to applica
https://bz.apache.org/bugzilla/show_bug.cgi?id=69710
--- Comment #8 from Aleksandr Beliakov ---
Thank you for the clarification.
Considering the parameters include both file and non-file fields, I am even
more concerned about the choice that have been made to set the total number of
parameters t
morning-gu commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2962535411
> What does your flame graph look like after this change?
Sorry, I don't have a flame graph right now. I can capture one tomorrow.
--
This is an automated message from the Apache
rmaucher commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2962991943
I think it is likely ok. I did not like it since it is backwards from the
original intent of the refactoring.
--
This is an automated message from the Apache Git Service.
To respond to th
markt-asf commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2963154081
Looks reasonable to me. Needs a change log entry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
https://bz.apache.org/bugzilla/show_bug.cgi?id=69710
--- Comment #9 from Remy Maucherat ---
The problem seems that you are not using multipart very efficiently. If you
have trivial flag parameters to pass, then URL params work, for starters.
Although multipart happened to work in all cases, this
morning-gu commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2962026185
@rmaucher Please review and approve the workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
morning-gu commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2961546330
> Why would the charset name be null ?
Because it is not included in the request headers, as shown below:
‌Content-Type=application/x-www-form-urlencoded
--
This is an automate
morning-gu commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2961553998
reopen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
https://bz.apache.org/bugzilla/show_bug.cgi?id=69710
Bug ID: 69710
Summary: FileCountLimitExceededException is thrown in version
11.0.8
Product: Tomcat 11
Version: unspecified
Hardware: PC
Status: NEW
https://bz.apache.org/bugzilla/show_bug.cgi?id=69710
Aleksandr Beliakov changed:
What|Removed |Added
OS||All
--- Comment #1 from Aleksandr
https://bz.apache.org/bugzilla/show_bug.cgi?id=69710
--- Comment #3 from Aleksandr Beliakov ---
The problem for us is that the code fails even when I submit a single file. But
because I have some other input fields, it throws an exception
FileCountLimitExceededException. Which is very confusing.
https://bz.apache.org/bugzilla/show_bug.cgi?id=69710
--- Comment #4 from Aleksandr Beliakov ---
The problem for us is that the code fails even when I submit a single file. But
because I have some other input fields, it throws an exception
FileCountLimitExceededException. Which is very confusing.
morning-gu commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2964740795
> Looks reasonable to me. Needs a change log entry.
Thank you for the feedback. I have added a changelog entry to
webapps/docs/changelog.xml for this change.
--
This is an automa
qingdaoheze opened a new pull request, #868:
URL: https://github.com/apache/tomcat/pull/868
The request statistics will be wrong when Request object is reused in the
object pool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
morning-gu commented on PR #867:
URL: https://github.com/apache/tomcat/pull/867#issuecomment-2964764619
> What does your flame graph look like after this change?
After optimization, the consumption of `Request#getCharsetHolder` is only
present during the first parsing. Subsequently, d
24 matches
Mail list logo
