markt-asf commented on PR #857:
URL: https://github.com/apache/tomcat/pull/857#issuecomment-2889918221
This appears to be addressing a symptom (various error messages) rather than
the cause (no local address available to unlock the `Acceptor`). We should be
looking at the root cause. What c
reiern70 commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2890201043
@ChristopherSchultz any chances to get this PR merged into Tomcat 11?
- Any other work to be done from my side?
- Add tests?
- Back-port this to previous tomcat versions?
rmaucher commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2890245052
Personally I am not a fan at all right now:
- About the way it is hooked in Request and esp ApplicationContext.
- It changes fileupload, which is a separate component (fileupload would
markt-asf commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2890250497
See https://github.com/jakartaee/servlet/issues/66
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
rmaucher commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2890282071
Let's see how the feature proposal progresses first then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
reiern70 commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2890315507
> Personally I am not a fan at all right now:
>
Ok.
> * About the way it is hooked in Request and esp ApplicationContext.
I'm totally new to Tomcat code-base. I tried to
reiern70 commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2890416198
> See [jakartaee/servlet#66](https://github.com/jakartaee/servlet/issues/66)
Thanks for the link. See
https://github.com/jakartaee/servlet/issues/66#issuecomment-2890413278
markt-asf commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2890457132
> IMHO what is described there is not what we need... because it has the
same problem we have now.
Which is what, exactly?
--
This is an automated message from the Apache Git Serv
https://bz.apache.org/bugzilla/show_bug.cgi?id=69694
Bug ID: 69694
Summary: Manager Deploy does not check return value of war copy
Product: Tomcat 9
Version: 9.0.102
Hardware: PC
Status: NEW
Severity: normal
Pri
https://bz.apache.org/bugzilla/show_bug.cgi?id=69695
Bug ID: 69695
Summary: Pte certificate without exam
Product: Tomcat Native
Version: 2.0.7
Hardware: PC
Status: NEW
Severity: normal
Priority: P2
Comp
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new ea0cdb0449 Improve error reporting of file copy errors
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 296f8ccd5d Improve error reporting of file copy er
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 11.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/11.0.x by this push:
new 1f74a6c416 Improve error reporting of file copy er
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new acfa5cc919 Improve error reporting of file copy erro
https://bz.apache.org/bugzilla/show_bug.cgi?id=69694
Remy Maucherat changed:
What|Removed |Added
Resolution|--- |FIXED
OS|
reiern70 commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2890882787
> > IMHO what is described there is not what we need... because it has the
same problem we have now.
>
> Which is what, exactly?
The problem now is: 1) "someone" calls getParam
rmannibucau commented on PR #857:
URL: https://github.com/apache/tomcat/pull/857#issuecomment-2890899779
@markt-asf http11nio protocol handler, the root cause is what i mentionned
in my mail to the list, the acceptor thread doesn't handle the fact stop is
being called properly so when serve
reiern70 commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2890957828
> > IMHO what is described there is not what we need... because it has the
same problem we have now.
>
> Which is what, exactly?
You suggested to avoid using multipart... but a
markt-asf commented on PR #857:
URL: https://github.com/apache/tomcat/pull/857#issuecomment-2891015548
This issue does not occur on a clean install with `bindOnInit` set to
`false`.
For the first change, `localAddress` should not be null. The correct fix is
to address why `localAddr
rmannibucau commented on PR #857:
URL: https://github.com/apache/tomcat/pull/857#issuecomment-2891074271
@markt-asf agree it fails similarly with `bindOnInit` or not set:
here is a reproducer:
```
package com.github.rmannibucau;
import org.apache.catalina.LifecycleExce
markt-asf commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2891145754
It looks like Tomcat parsing parts for `multipart/form-data' with no
`` as a result of calling getParemeter() and friends is a bug
although I need to check the TCK. Fix that and the Wicket
reiern70 commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2891175364
> It looks like Tomcat parsing parts for `multipart/form-data` with no
`` as a result of calling `getParameter()` and friends is a
bug although I need to check the TCK. Fix that and the Wic
markt-asf commented on PR #857:
URL: https://github.com/apache/tomcat/pull/857#issuecomment-2891191012
That test case doesn't log any exceptions or warnings for me with Tomcat
12.0.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Build status: BUILD FAILED: failed Snapshot deployed to ASF Maven snapshot
repository (failure)
Worker used: bb_worker2_ubuntu
URL: https://ci2.apache.org/#builders/37/builds/1408
Blamelist: remm
Build Text: failed Snapshot deployed to ASF Maven snapshot repository (failure)
Status Detected: new
markt-asf commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2891358727
> This is how all started ...
Not quite. The provided reproducer uses the `@MultipartConfig` annotation.
Therefore, for that configuration, it is working as designed.
--
This is a
rmannibucau commented on PR #857:
URL: https://github.com/apache/tomcat/pull/857#issuecomment-2891401991
@markt-asf tested with main (ea0cdb044941f1ced5baf236aba395c170030768):
```
mai 19, 2025 5:13:12 PM org.apache.catalina.core.StandardService
startInternal
INFOS: Starting ser
reiern70 commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2891405212
> > This is how all started ...
>
> Not quite. The provided reproducer uses the `@MultipartConfig` annotation.
Therefore, for that configuration, it is working as designed.
Not
markt-asf commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2891416271
> * If you do not set the casualMultipartConfig or the @MultipartConfig
tomcat will complain when getParameters is called
That looks like a Tomcat bug but I need to confirm that. Ass
reiern70 commented on PR #856:
URL: https://github.com/apache/tomcat/pull/856#issuecomment-2891431758
> > * If you do not set the casualMultipartConfig or the @MultipartConfig
tomcat will complain when getParameters is called
>
> That looks like a Tomcat bug but I need to confirm that
markt-asf commented on PR #857:
URL: https://github.com/apache/tomcat/pull/857#issuecomment-2891481233
That error message suggests that the Acceptor either isn't unlocking at all
or isn't unlocking quickly enough. Can you run that test again with log level
set to `ALL`? That should point us
rmannibucau commented on PR #857:
URL: https://github.com/apache/tomcat/pull/857#issuecomment-2891506680
@markt-asf did it using "one line formatter" and only copied from the http
request reception to the stop state to not flood with useless data:
https://gist.githubusercontent.com/rmannibu
31 matches
Mail list logo
