Re: [PR] Add unit tests for AsyncStateMachine's asyncPostProcess method [tomcat]

2025-02-24 Thread via GitHub
markt-asf commented on PR #828: URL: https://github.com/apache/tomcat/pull/828#issuecomment-2677681461 The code coverage of `AsyncStateMachine` is already fairly good. I'd prefer to see some tests using real requests that exercised the few code paths (excluding trace level logging and `Ille

Re: [PR] Add unit tests for AsyncStateMachine's asyncPostProcess method [tomcat]

2025-02-24 Thread via GitHub
rmaucher commented on PR #828: URL: https://github.com/apache/tomcat/pull/828#issuecomment-2677710733 BTW, the code coverage report is here: https://nightlies.apache.org/tomcat/tomcat-12.0.x/coverage/index.html#dn-a It can be generated using test.coverage=true property in build.properties

Re: [PR] BZ69504 move force recycle from log access method [tomcat]

2025-02-24 Thread via GitHub
markt-asf closed pull request #821: BZ69504 move force recycle from log access method URL: https://github.com/apache/tomcat/pull/821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] BZ69504 move force recycle from log access method [tomcat]

2025-02-24 Thread via GitHub
markt-asf commented on PR #821: URL: https://github.com/apache/tomcat/pull/821#issuecomment-2677711179 I share Rémy's concerns. I see multiple concerns being addressed in this PR. Correct recycling is critical to the correct operation of Tomcat and log still recycles the request/response

(tomcat) 01/02: Add connection ID to the ExtendedAccessLogValve

2025-02-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 987f737afe4f08da939d870b5b1ec4b96010d926 Author: Mark Thomas AuthorDate: Mon Feb 24 12:25:31 2025 + Add connection

(tomcat) 02/02: Add ConnectionID to AccessLogValve

2025-02-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 3cfc9bc048109c5a566fc24539e5bb9759c114b6 Author: Mark Thomas AuthorDate: Mon Feb 24 12:55:08 2025 + Add Connection

(tomcat) branch main updated (e3d05323c5 -> 3cfc9bc048)

2025-02-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git from e3d05323c5 Add specific test for TE parsing new 987f737afe Add connection ID to the ExtendedAccessLogValve new

(tomcat) branch 11.0.x updated: Add ConnectionID to AccessLogValve

2025-02-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new 22b99bac65 Add ConnectionID to AccessLogValve 22b

(tomcat) branch 10.1.x updated: Add ConnectionID to AccessLogValve

2025-02-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 65551ce98f Add ConnectionID to AccessLogValve 655

(tomcat) branch 11.0.x updated: Add connection ID to the ExtendedAccessLogValve

2025-02-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new 3b0ba0fce3 Add connection ID to the ExtendedAcces

(tomcat) branch 10.1.x updated: Add connection ID to the ExtendedAccessLogValve

2025-02-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new fe3409fd2f Add connection ID to the ExtendedAcces

Re: [PR] log connectionId [tomcat]

2025-02-24 Thread via GitHub
markt-asf closed pull request #814: log connectionId URL: https://github.com/apache/tomcat/pull/814 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-

Re: [PR] log connectionId [tomcat]

2025-02-24 Thread via GitHub
markt-asf commented on PR #814: URL: https://github.com/apache/tomcat/pull/814#issuecomment-2678517529 Manually applied as there were a few things I needed to add/change - %{xxx}L is for ID attributes not connection attributes - new settings needed to be added to the docs - change lo

Re: [PR] log connectionId [tomcat]

2025-02-24 Thread via GitHub
Dmole commented on PR #814: URL: https://github.com/apache/tomcat/pull/814#issuecomment-2678622306 https://github.com/apache/tomcat/commit/3cfc9bc048109c5a566fc24539e5bb9759c114b6 https://github.com/apache/tomcat/commit/987f737afe4f08da939d870b5b1ec4b96010d926 -- This is an automa

[PR] Fix info-then-debug logging in Http2UpgradeHandler [tomcat]

2025-02-24 Thread via GitHub
bergander opened a new pull request, #830: URL: https://github.com/apache/tomcat/pull/830 Fix info-then-debug logging in `Http2UpgradeHandler` by making the `UserDataHelper` static. Otherwise the _lastInfoTime_ in `UserDataHelper` will be per HTTP2-connection, but it should be a global scop

[Bug 69479] The HTTP2 header data is confused in H2C, resulting in parsing failure

2025-02-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69479 --- Comment #10 from Thomas --- Please see the repo for the test case to reproduce the problem. https://github.com/qingdaoheze/tomcat-header-mix One solution to resolve the problem: https://github.com/qingdaoheze/tomcat/pull/1 -- You are rec

[Bug 69479] The HTTP2 header data is confused in H2C, resulting in parsing failure

2025-02-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69479 --- Comment #11 from Remy Maucherat --- (In reply to Thomas from comment #10) > Please see the repo for the test case to reproduce the problem. > https://github.com/qingdaoheze/tomcat-header-mix > > One solution to resolve the problem: > https

[Bug 69479] The HTTP2 header data is confused in H2C, resulting in parsing failure

2025-02-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69479 --- Comment #12 from Thomas --- OK, so you will give the better solution, right? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e

Re: [PR] Fix info-then-debug logging in Http2UpgradeHandler [tomcat]

2025-02-24 Thread via GitHub
markt-asf commented on PR #830: URL: https://github.com/apache/tomcat/pull/830#issuecomment-2679115250 Tx. Well-spotted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

(tomcat) branch 11.0.x updated: Fix info-then-debug logging in Http2UpgradeHandler by making the UserDataHelper static (#830)

2025-02-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new 3b1019df74 Fix info-then-debug logging in Http2Up

Re: [PR] Fix info-then-debug logging in Http2UpgradeHandler [tomcat]

2025-02-24 Thread via GitHub
markt-asf merged PR #830: URL: https://github.com/apache/tomcat/pull/830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o

(tomcat) branch 10.1.x updated: Fix info-then-debug logging in Http2UpgradeHandler by making the UserDataHelper static (#830)

2025-02-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 8f59b0b3c2 Fix info-then-debug logging in Http2Up

(tomcat) branch 9.0.x updated: Fix info-then-debug logging in Http2UpgradeHandler by making the UserDataHelper static (#830)

2025-02-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 5c00c0be74 Fix info-then-debug logging in Http2Upgr

(tomcat) branch main updated: Fix info-then-debug logging in Http2UpgradeHandler by making the UserDataHelper static (#830)

2025-02-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 688e6cc286 Fix info-then-debug logging in Http2Upgrad

[Bug 69479] The HTTP2 header data is confused in H2C, resulting in parsing failure

2025-02-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69479 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #13 from Mark Thomas --

[Bug 69479] The HTTP2 header data is confused in H2C, resulting in parsing failure

2025-02-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69479 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---