[Bug 64570] Transaction not rollbacked if autocommit is false

2023-11-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64570 Mark Thomas changed: What|Removed |Added Resolution|--- |INVALID Status|NEW

Re: [PR] Before closing the database connection, roll back the transaction [tomcat]

2023-11-08 Thread via GitHub
markt-asf closed pull request #667: Before closing the database connection, roll back the transaction URL: https://github.com/apache/tomcat/pull/667 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Before closing the database connection, roll back the transaction [tomcat]

2023-11-08 Thread via GitHub
markt-asf commented on PR #667: URL: https://github.com/apache/tomcat/pull/667#issuecomment-1801356054 Closing since behaviour is intentionally configurable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

(tomcat) branch main updated: Improve formatting prior to running auto-format tools

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 58fb49bd64 Improve formatting prior to running auto-f

(tomcat) branch 10.1.x updated: Improve formatting prior to running auto-format tools

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 8f0e6af20e Improve formatting prior to running au

(tomcat) branch 9.0.x updated: Improve formatting prior to running auto-format tools

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 6add0699b4 Improve formatting prior to running auto

(tomcat) branch 8.5.x updated: Improve formatting prior to running auto-format tools

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 44c8735e47 Improve formatting prior to running auto

[Bug 68105] New: Required fix for hsts on tomcat 7.0.57

2023-11-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68105 Bug ID: 68105 Summary: Required fix for hsts on tomcat 7.0.57 Product: Tomcat Modules Version: unspecified Hardware: Other Status: NEW Severity: critical Prio

[Bug 68105] Required fix for hsts on tomcat 7.0.57

2023-11-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68105 Mark Thomas changed: What|Removed |Added Resolution|--- |INVALID OS|

(tomcat) branch main updated: Handle errors consistently

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new cbe52ede4a Handle errors consistently cbe52ede4a is d

(tomcat) branch 10.1.x updated: Handle errors consistently

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 665e06e9e7 Handle errors consistently 665e06e9e7

(tomcat) branch 9.0.x updated: Handle errors consistently

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new a01d212960 Handle errors consistently a01d212960 is

(tomcat) branch 8.5.x updated: Handle errors consistently

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new e32d154ebd Handle errors consistently e32d154ebd is

[Bug 2651] the mailer - tags reply no error

2023-11-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=2651 Charli D Amelio changed: What|Removed |Added CC||katewins...@gmail.com -- You are rec

(tomcat) 03/03: Ensure IOException on request read always triggers error handling

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit cca12473573cb37d38d95fab48d2fae07fb6d1a4 Author: Mark Thomas AuthorDate: Wed Nov 8 15:25:17 2023 + Ensure IOExcept

(tomcat) branch main updated (cbe52ede4a -> cca1247357)

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git from cbe52ede4a Handle errors consistently new c2b60ded7b Differentiate request cancellation from a bad request new

(tomcat) 01/03: Differentiate request cancellation from a bad request

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit c2b60ded7b961aa30201c32a11a9e7c4ee632302 Author: Mark Thomas AuthorDate: Wed Nov 8 14:59:41 2023 + Differentiate r

(tomcat) 02/03: Use a 400 response for bad requests rather than a 500 response

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 84afcbf511de37a063784443e0dc5d752d7e62fe Author: Mark Thomas AuthorDate: Wed Nov 8 15:09:44 2023 + Use a 400 respo

(tomcat) branch 10.1.x updated: Differentiate request cancellation from a bad request

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new b3c95e9667 Differentiate request cancellation fro

(tomcat) branch 9.0.x updated: Differentiate request cancellation from a bad request

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 030e7bb77b Differentiate request cancellation from

(tomcat) branch 8.5.x updated: Differentiate request cancellation from a bad request

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new abdf1d8e8a Differentiate request cancellation from

(tomcat) branch 8.5.x updated: Use a 400 response for bad requests rather than a 500 response

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 2f65f1f967 Use a 400 response for bad requests rath

(tomcat) branch 10.1.x updated: Ensure IOException on request read always triggers error handling

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new b5776d769b Ensure IOException on request read alw

(tomcat) branch 10.1.x updated: Use a 400 response for bad requests rather than a 500 response

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new dc38c17394 Use a 400 response for bad requests ra

(tomcat) branch 9.0.x updated: Use a 400 response for bad requests rather than a 500 response

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new e664b6d6d3 Use a 400 response for bad requests rath

(tomcat) branch 9.0.x updated: Ensure IOException on request read always triggers error handling

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 7a2d8818fc Ensure IOException on request read alway

(tomcat) branch 8.5.x updated: Ensure IOException on request read always triggers error handling

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new aa92971e87 Ensure IOException on request read alway

(tomcat) branch 10.1.x updated: Fix back-port

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new f752e64c6b Fix back-port f752e64c6b is described

(tomcat) branch 9.0.x updated: Fix back-port

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new d1fc93aeb5 Fix back-port d1fc93aeb5 is described be

(tomcat) branch 8.5.x updated: Fix back-port

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 79a953129c Fix back-port 79a953129c is described be

(tomcat) 02/02: Better message if size limit is reached reading trailer header name

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit b73cd85b5c55f7c31ab0495f97785f95ca2d9c17 Author: Mark Thomas AuthorDate: Wed Nov 8 16:43:48 2023 + Better message

(tomcat) 01/02: Use sendError() rather than working directly with Coyote response

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit afd3e121eb05674188e5307f7d7f0b94b9f0efbe Author: Mark Thomas AuthorDate: Wed Nov 8 16:36:41 2023 + Use sendError(

(tomcat) branch 9.0.x updated (d1fc93aeb5 -> b73cd85b5c)

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from d1fc93aeb5 Fix back-port new afd3e121eb Use sendError() rather than working directly with Coyote response new

(tomcat) branch 8.5.x updated (79a953129c -> 10a45a5b5c)

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from 79a953129c Fix back-port new 10e75e4e1c Use sendError() rather than working directly with Coyote response new

(tomcat) 02/02: Better message if size limit is reached reading trailer header name

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 10a45a5b5c7a30f9546f1fd5dc75848004fd9709 Author: Mark Thomas AuthorDate: Wed Nov 8 16:43:48 2023 + Better message

(tomcat) 01/02: Use sendError() rather than working directly with Coyote response

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 10e75e4e1c9fe6add2fc17ac6301d7b65560bf8d Author: Mark Thomas AuthorDate: Wed Nov 8 16:36:41 2023 + Use sendError(

(tomcat) 01/02: Use sendError() rather than working directly with Coyote response

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 700d582b508d899aa6dd2d1cc1e42c12e9f47ba0 Author: Mark Thomas AuthorDate: Wed Nov 8 16:36:41 2023 + Use sendError

(tomcat) 02/02: Better message if size limit is reached reading trailer header name

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 92c3efdebd89f281369ffe99f392b1300782cdfc Author: Mark Thomas AuthorDate: Wed Nov 8 16:43:48 2023 + Better messag

(tomcat) branch 10.1.x updated (f752e64c6b -> 92c3efdebd)

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from f752e64c6b Fix back-port new 700d582b50 Use sendError() rather than working directly with Coyote response ne

(tomcat) 02/02: Better message if size limit is reached reading trailer header name

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 656d36c178365a0762731ecb192e9a72587569c5 Author: Mark Thomas AuthorDate: Wed Nov 8 16:43:48 2023 + Better message

(tomcat) branch main updated (cca1247357 -> 656d36c178)

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git from cca1247357 Ensure IOException on request read always triggers error handling new 72b972c699 Use sendError() rather

(tomcat) 01/02: Use sendError() rather than working directly with Coyote response

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 72b972c699c2dc0a5a7cc9731326282f7da779b6 Author: Mark Thomas AuthorDate: Wed Nov 8 16:36:41 2023 + Use sendError()

Tagging and code signing

2023-11-08 Thread Mark Thomas
Hi all, I have a few things I still want to look at with the recent error handling changes. I'm seeing differences in behaviour between versions I at least want to understand. Depending on what I find, I might try and align behaviours a little more. Once that is done, I plan to run my usual

(tomcat) branch main updated: Update to use new signing certificate

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new a1d72d09c7 Update to use new signing certificate a1d7

(tomcat) branch 10.1.x updated: Update to use new signing certificate

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 1f7d7c6893 Update to use new signing certificate

(tomcat) branch 9.0.x updated: Update to use new signing certificate

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 6b5091fc42 Update to use new signing certificate 6b

(tomcat) branch 8.5.x updated: Update to use new signing certificate

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 21c3742fe8 Update to use new signing certificate 21

(tomcat) branch main updated: Missed files in previous commit

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new d918b679c0 Missed files in previous commit d918b679c0

Buildbot failure in on tomcat-9.0.x

2023-11-08 Thread buildbot
Build status: BUILD FAILED: failed compile (failure) Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/37/builds/762 Blamelist: Mark Thomas Build Text: failed compile (failure) Status Detected: new failure Build Source Stamp: [branch 9.0.x] 6b5091fc425e41414fd803ddef4da2e2d06c24

(tomcat) 01/02: Only close the connection for client disconnects not bad requests

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 24441f289a03582967ee344b222eedba1520dc80 Author: Mark Thomas AuthorDate: Wed Nov 8 20:29:32 2023 + Only close the

(tomcat) 02/02: Look for wrapped InvalidParameterException and use 400 response if found

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 66df5fd7548aac7ea3e80a75cb1b2cd2a3bda708 Author: Mark Thomas AuthorDate: Wed Nov 8 20:29:59 2023 + Look for wrappe

(tomcat) branch main updated (69475ccdb4 -> 66df5fd754)

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git from 69475ccdb4 Use more appropriate exception so a bad request triggers a 400 response new 24441f289a Only close the co

(tomcat) branch 8.5.x updated: Move BadRequestException so it is visible to coyote package

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 79d2aca437 Move BadRequestException so it is visibl

(tomcat) branch 9.0.x updated: Move BadRequestException so it is visible to coyote package

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new c5475fae20 Move BadRequestException so it is visibl

(tomcat) branch 10.1.x updated: Missed files in previous commit

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 105436b9f0 Missed files in previous commit 105436

(tomcat) branch 9.0.x updated: Missed files in previous commit

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new aedb964ba7 Missed files in previous commit aedb964b

Re: Tagging and code signing

2023-11-08 Thread Christopher Schultz
Mark, On 11/8/23 12:58, Mark Thomas wrote: Hi all, I have a few things I still want to look at with the recent error handling changes. I'm seeing differences in behaviour between versions I at least want to understand. Depending on what I find, I might try and align behaviours a little more.

(tomcat) branch 8.5.x updated: Fix back-port

2023-11-08 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new cac14df9db Fix back-port cac14df9db is described be

Buildbot success in on tomcat-9.0.x

2023-11-08 Thread buildbot
Build status: Build succeeded! Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/37/builds/763 Blamelist: Mark Thomas Build Text: build successful Status Detected: restored build Build Source Stamp: [branch 9.0.x] aedb964ba7d94cefafe80134304cd57c68df538f Steps: worker_prepa

[Bug 68105] Required fix for hsts on tomcat 7.0.57

2023-11-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68105 Jonnalagadda Raghuram changed: What|Removed |Added Resolution|INVALID |--- Status|RESOLVE

[Bug 68105] Required fix for hsts on tomcat 7.0.57

2023-11-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68105 Remy Maucherat changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---