chenggwang commented on PR #671:
URL: https://github.com/apache/tomcat/pull/671#issuecomment-1762749332
> The benefit seems null IMO, in the debugger it will print out that this is
null instead of a NPE, which should mean the same for a developer. Also,
Nio2Channel.toString is the same.
chenggwang commented on PR #671:
URL: https://github.com/apache/tomcat/pull/671#issuecomment-1762757733
@rmaucher @markt-asf @michael-o Such a change in tomcat functionality does
not help, but after the initialization of the NioChannel object should provide
a reliable, stable function, can
The following votes were cast:
Binding:
+1: remm, lihan, fschumacher, markt, isapir, schultz
No other votes were cast.
The vote therefore passes.
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional
Author: markt
Date: Sat Oct 14 12:57:49 2023
New Revision: 64524
Log:
Release Tomcat 11.0.0-M13
Added:
release/tomcat/tomcat-11/v11.0.0-M13/
- copied from r64523, dev/tomcat/tomcat-11/v11.0.0-M13/
Removed:
dev/tomcat/tomcat-11/v11.0.0-M13/
-
Author: markt
Date: Sat Oct 14 12:58:49 2023
New Revision: 64525
Log:
Drop old releases from CDN
Removed:
release/tomcat/tomcat-11/v11.0.0-M11/
release/tomcat/tomcat-9/v9.0.80/
release/tomcat/tomcat-9/v9.0.81/
-
To
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 35e7caf8c6 Add release date for 11.0.0-M13
35e7caf8c6
Author: markt
Date: Sat Oct 14 13:27:19 2023
New Revision: 1912958
URL: http://svn.apache.org/viewvc?rev=1912958&view=rev
Log:
Update site with 11.0.0-M13 docs
[This commit notification would consist of 58 parts,
which exceeds the limit of 50 ones, so it was shortened to the summary.]
Author: markt
Date: Sat Oct 14 13:28:21 2023
New Revision: 1912959
URL: http://svn.apache.org/viewvc?rev=1912959&view=rev
Log:
Update site for 11.0.0-M13 release
Modified:
tomcat/site/trunk/docs/download-11.html
tomcat/site/trunk/docs/index.html
tomcat/site/trunk/docs/migration-11.0.h
kkolinko commented on PR #671:
URL: https://github.com/apache/tomcat/pull/671#issuecomment-1763032642
I do not like the use of "?:" operator here.
Just simple `... + ":" + sc;` is enough, or if you want to be explicit `+
":" + String.valueOf(sc);`
--
This is an automated message from
https://bz.apache.org/bugzilla/show_bug.cgi?id=64570
--- Comment #2 from Konstantin Kolinko ---
https://tomcat.apache.org/tomcat-11.0-doc/jdbc-pool.html
See "rollbackOnReturn" attribute. It is false by default.
--
You are receiving this mail because:
You are the assignee for the bug.
-
kkolinko commented on PR #667:
URL: https://github.com/apache/tomcat/pull/667#issuecomment-1763097366
From code review point of view: -1
1. No error handling.
2. No configuration.
The `rollbackOnReturn` option should take care of the original BZ issue. And
if there is a bug,
chenggwang commented on PR #671:
URL: https://github.com/apache/tomcat/pull/671#issuecomment-1763120686
> I do not like the use of "?:" operator here. Just simple `... + ":" + sc;`
is enough, or if you want to be explicit `+ ":" + String.valueOf(sc);`
If we don't consider the constant
chenggwang commented on PR #671:
URL: https://github.com/apache/tomcat/pull/671#issuecomment-1763157260
This is a bug that tomcat itself just doesn't realize. Because it doesn't
need to call toString immediately after the `NioChannel` object is
created.However, for third-party software that
markt-asf commented on PR #671:
URL: https://github.com/apache/tomcat/pull/671#issuecomment-1763192873
If we are going to do anything for this
> Just simple `... + ":" + sc;` is enough
works for me if applied to both NIO and NIO2 rather than just NIO.
--
This is an automated
https://bz.apache.org/bugzilla/show_bug.cgi?id=67675
--- Comment #3 from Mark Thomas ---
It seems that very few (no?) users are creating keys with pass-phrases this way
as this isn't an issue that has been reported previously and we went through a
phase of getting reports of unsupported formats w
chenggwang commented on PR #671:
URL: https://github.com/apache/tomcat/pull/671#issuecomment-1763278643
> If we are going to do anything for this
>
> > Just simple `... + ":" + sc;` is enough
>
> works for me if applied to both NIO and NIO2 rather than just NIO
Ok!Mark，I'
16 matches
Mail list logo
