This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 6aff396 Extend default timeout as buildbot tests are
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.0.x by this push:
new a268e91 Extend default timeout as buildbot tests
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 9f8c539 Extend default timeout as buildbot tests a
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new f754ff3 Extend default timeout as buildbot tests a
Hi all,
Sorry about this but while testing some updates to the Servlet TCK I
discovered my fix for [1] has broken HTTP server push for at least some,
possibly all, use cases.
I'm currently investigating and should have an update later today.
Mark
[1] https://bz.apache.org/bugzilla/show_bug
https://bz.apache.org/bugzilla/show_bug.cgi?id=65802
Bug ID: 65802
Summary: Invalid header name should be rejected in the HTTP
server response
Product: Tomcat 9
Version: 9.0.x
Hardware: Macintosh
OS: Mac OS
https://bz.apache.org/bugzilla/show_bug.cgi?id=65802
--- Comment #1 from Remy Maucherat ---
Instead of fixing this "issue", how about we revert 65785 instead ?
--
You are receiving this mail because:
You are the assignee for the bug.
-
https://bz.apache.org/bugzilla/show_bug.cgi?id=65802
Remy Maucherat changed:
What|Removed |Added
Severity|normal |enhancement
--
You are receiving thi
https://bz.apache.org/bugzilla/show_bug.cgi?id=65802
--- Comment #2 from Nils R ---
Well, https://bz.apache.org/bugzilla/show_bug.cgi?id=65785 was about having the
same behaviour between HTTP/1.1 and HTTP/2.0 : to return an HTTP 400 on
requests with an invalid header name.
With HTTP/1.1, tomcat
https://bz.apache.org/bugzilla/show_bug.cgi?id=65802
--- Comment #3 from Mark Thomas ---
The Javadoc for HttpServletResponse addHeader and setHeader don't define the
behaviour for invalid inputs. You could argue the Javadoc implies that the
inputs are expected to be HTTP specification compliant.
Mark,
On 1/14/22 07:29, Mark Thomas wrote:
Sorry about this but while testing some updates to the Servlet TCK I
discovered my fix for [1] has broken HTTP server push for at least some,
possibly all, use cases.
I'm currently investigating and should have an update later today.
No problem. I
https://bz.apache.org/bugzilla/show_bug.cgi?id=65802
--- Comment #4 from Remy Maucherat ---
I think the other one should be reverted since this is only a strict HTTP/1.1
compatibility thing, since HTTP/2 is a binary protocol. Is there a really real
reason to limit it ? Other than spec lawyering o
This is an automated email from the ASF dual-hosted git repository.
markt pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git.
from 6aff396 Extend default timeout as buildbot tests are occasionally
timeing out
new a5e931d Don't include a cookie
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit f0797a8f7ccad15e939889167bd45f097b8ab4ca
Author: Mark Thomas
AuthorDate: Fri Jan 14 19:25:35 2022 +
Fix server pus
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 19403f341af9c82dac613f3f31ff26294d5c68fd
Author: Mark Thomas
AuthorDate: Fri Jan 14 19:24:42 2022 +
Add support to
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit b2426b4dc9ad586184543c79e91ebc6fc71bb5c4
Author: Mark Thomas
AuthorDate: Fri Jan 14 19:22:59 2022 +
Remove unneces
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 1ea67f5b70cc75a6523bc6eb2cad0a1067523dc9
Author: Mark Thomas
AuthorDate: Fri Jan 14 19:24:58 2022 +
Add a simple t
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit a5e931d429f05457d7163f3fd535b6020fbabce2
Author: Mark Thomas
AuthorDate: Fri Jan 14 19:20:04 2022 +
Don't include
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit ed4f3c7a28419863f947e75b831acb6693f6ad5f
Author: Mark Thomas
AuthorDate: Fri Jan 14 19:22:41 2022 +
Refactor the h
https://bz.apache.org/bugzilla/show_bug.cgi?id=65776
--- Comment #6 from Mark Thomas ---
That should only be an issue if:
- there are no other connections to the server between liveness checks
- the liveness checks are >= time_wait seconds apart
Increasing the frequency of the liveness checks sh
This is an automated email from the ASF dual-hosted git repository.
markt pushed a change to branch 10.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git.
from a268e91 Extend default timeout as buildbot tests are occasionally
timing out
new 08ff1b4 Don't include a cooki
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit daca6fd05076ee9bc8a59985f5c77c3bcd09fcdc
Author: Mark Thomas
AuthorDate: Fri Jan 14 19:22:41 2022 +
Refactor the
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 9a9d542baf7121649deecee28de809ceabaed244
Author: Mark Thomas
AuthorDate: Fri Jan 14 19:24:42 2022 +
Add support
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 08ff1b4dc1e63d2abff348d7725251d741733afb
Author: Mark Thomas
AuthorDate: Fri Jan 14 19:20:04 2022 +
Don't includ
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 640ffb89631ac99fa9b1445adc0d54defdd8fb27
Author: Mark Thomas
AuthorDate: Fri Jan 14 19:47:17 2022 +
Back-port cr
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 9e417fad44ff903e47f3b2c27350f0d9bca76af7
Author: Mark Thomas
AuthorDate: Fri Jan 14 19:25:35 2022 +
Fix server p
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit bbd67b090b55ad569314ce20acadb43e96db44c2
Author: Mark Thomas
AuthorDate: Fri Jan 14 19:24:58 2022 +
Add a simple
This is an automated email from the ASF dual-hosted git repository.
markt pushed a change to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git.
from 9f8c539 Extend default timeout as buildbot tests are occasionally
timing out
new 3122653 Don't include a cookie
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 3122653120857b9ea225474f7cbd8e4a508a7cdd
Author: Mark Thomas
AuthorDate: Fri Jan 14 19:20:04 2022 +
Don't include
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit ec6c25cbab42408a927260601e4536852b1996f9
Author: Mark Thomas
AuthorDate: Fri Jan 14 19:47:17 2022 +
Back-port cre
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit b2a6641183fe3f3bc5692b2b4b0108c8d8021832
Author: Mark Thomas
AuthorDate: Fri Jan 14 19:24:58 2022 +
Add a simple
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 77ed41ce7491d778c9f3b1ff14722aa3bf2d3d55
Author: Mark Thomas
AuthorDate: Fri Jan 14 19:24:42 2022 +
Add support t
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit dd4f5dcc87d1b6b8bc517c8df825bf0d5172035f
Author: Mark Thomas
AuthorDate: Fri Jan 14 19:22:41 2022 +
Refactor the
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 37ef4a8202664a7d36efb62bd8f1be0f48f314e2
Author: Mark Thomas
AuthorDate: Fri Jan 14 19:25:35 2022 +
Fix server pu
https://bz.apache.org/bugzilla/show_bug.cgi?id=65802
--- Comment #5 from Christopher Schultz ---
If I'm reading this right, then returning a 400 response is entirely
inappropriate.
400 means "client sent an invalid request"
That's not the case, here. The application (server) is sending an inval
This is an automated email from the ASF dual-hosted git repository.
markt pushed a change to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git.
from f754ff3 Extend default timeout as buildbot tests are occasionally
timing out
new 70a9a31 Don't include a cookie
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 368399e6048ff6af79d00c910cd4ce4a351bdd15
Author: Mark Thomas
AuthorDate: Fri Jan 14 19:24:58 2022 +
Add a simple
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit dc4bb27f91cfd582696c8f521b0ea4741921eefd
Author: Mark Thomas
AuthorDate: Fri Jan 14 19:24:42 2022 +
Add support t
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit f5459e6bd0f8d991193d85589ef9c2b72992772a
Author: Mark Thomas
AuthorDate: Fri Jan 14 19:22:41 2022 +
Refactor the
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 6c71b4f206730c20d3e81459d7d5e4a9d8234bae
Author: Mark Thomas
AuthorDate: Fri Jan 14 19:25:35 2022 +
Fix server pu
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 70a9a31060d0e71c10c41f11053a343e4d63bd43
Author: Mark Thomas
AuthorDate: Fri Jan 14 19:20:04 2022 +
Don't include
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 6bfd0f7e73975d4eec87805e3a780ee0ede67f8c
Author: Mark Thomas
AuthorDate: Fri Jan 14 19:47:17 2022 +
Back-port cre
https://bz.apache.org/bugzilla/show_bug.cgi?id=65776
--- Comment #7 from Mark Thomas ---
Checking the time since the last accept adds a significant overhead. With a
simply JMeter test with keep-alive disabled, throughput dropped by 75% once I
added the timing check. That level of overhead isn't a
On 13/01/2022 08:21, Mark Thomas wrote:
On 12/01/2022 17:38, Mark Thomas wrote:
The proposed 10.1.0-M9 release is:
[X] Broken - do not release
[ ] Alpha - go ahead and release as 10.1.0-M9 (alpha)
Changing my vote to broken as I have discovered HTTP/2 server push was
broken.
I'm cancelling
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new c7ffd2c 10.1.0-M9 release vote was cancelled
c7ffd2c
On 13/01/2022 08:25, Mark Thomas wrote:
On 12/01/2022 19:37, Mark Thomas wrote:
The proposed 10.0.15 release is:
[x] Broken - do not release
[ ] Stable - go ahead and release as 10.0.15 (stable)
Changing my vote to broken as I have discovered HTTP/2 server push was
broken.
I'm cancelling t
On 13/01/2022 08:26, Mark Thomas wrote:
On 12/01/2022 21:13, Rémy Maucherat wrote:
The proposed 9.0.57 release is:
[X] Broken - do not release
[ ] Stable - go ahead and release as 9.0.57 (stable)
Changing my vote to broken as I have discovered HTTP/2 server push was
broken.
Mark
---
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.0.x by this push:
new ba55aea 10.0.15 release vote was cancelled
ba55a
Mark,
Should I go ahead and cancel the 8.5 vote, then, as well?
-chris
On 1/14/22 17:27, Mark Thomas wrote:
On 13/01/2022 08:25, Mark Thomas wrote:
On 12/01/2022 19:37, Mark Thomas wrote:
The proposed 10.0.15 release is:
[x] Broken - do not release
[ ] Stable - go ahead and release as 10.0.
On 13/01/2022 13:44, Christopher Schultz wrote:
The proposed 8.5.74 release is:
[X] Broken - do not release
[ ] Stable - go ahead and release as 8.5.73 (stable)
I have discovered HTTP/2 server push was broken.
This is minor for 8.5.x since server push isn't available via the
Servlet API. You
On 14/01/2022 22:29, Christopher Schultz wrote:
Mark,
Should I go ahead and cancel the 8.5 vote, then, as well?
See my comment on that thread.
Mark
-chris
On 1/14/22 17:27, Mark Thomas wrote:
On 13/01/2022 08:25, Mark Thomas wrote:
On 12/01/2022 19:37, Mark Thomas wrote:
The proposed
Author: remm
Date: Fri Jan 14 22:38:07 2022
New Revision: 52087
Log:
Drop 9.0.57
Removed:
dev/tomcat/tomcat-9/v9.0.57/
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@to
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 128207f Cancel 9.0.57
128207f is described below
c
Author: markt
Date: Fri Jan 14 22:45:07 2022
New Revision: 52088
Log:
Drop cancelled releases
Removed:
dev/tomcat/tomcat-10/v10.0.15/
dev/tomcat/tomcat-10/v10.1.0-M9/
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apa
On Fri, Jan 14, 2022 at 11:32 PM Mark Thomas wrote:
>
> On 13/01/2022 13:44, Christopher Schultz wrote:
>
> > The proposed 8.5.74 release is:
> > [X] Broken - do not release
> > [ ] Stable - go ahead and release as 8.5.73 (stable)
>
> I have discovered HTTP/2 server push was broken.
>
> This is mi
55 matches
Mail list logo