martin-g commented on a change in pull request #379:
URL: https://github.com/apache/tomcat/pull/379#discussion_r530317113
##
File path: java/org/apache/tomcat/util/net/AbstractEndpoint.java
##
@@ -1302,6 +1320,16 @@ protected long countDownConnection() {
*/
public fi
markt-asf commented on a change in pull request #379:
URL: https://github.com/apache/tomcat/pull/379#discussion_r530331336
##
File path: java/org/apache/tomcat/util/net/AbstractEndpoint.java
##
@@ -1302,6 +1320,16 @@ protected long countDownConnection() {
*/
public f
markt-asf commented on a change in pull request #379:
URL: https://github.com/apache/tomcat/pull/379#discussion_r530331565
##
File path: java/org/apache/tomcat/util/net/AbstractEndpoint.java
##
@@ -1312,6 +1340,30 @@ public final void closeServerSocketGraceful() {
}
+
https://bz.apache.org/bugzilla/show_bug.cgi?id=64872
--- Comment #22 from Mark Thomas ---
Updated branch:
https://github.com/markt-asf/tomcat/tree/bz-64872
The tests for the optimised ELInterpreter show about 10% improvement. The tests
for the custom StringInterpreter (that handles attr="EnumCon
rmaucher commented on pull request #379:
URL: https://github.com/apache/tomcat/pull/379#issuecomment-733693070
Looks ok, at least I can't see right now why it would be bad.
This is an automated message from the Apache Git Ser
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new 2883d5c Remove reused reference to NioChannel
288
https://bz.apache.org/bugzilla/show_bug.cgi?id=64872
--- Comment #23 from John Engebretson ---
My constant reaction is "I'm glad you're doing this and not me." Your
expertise is creating a far better implementation than I did! Thank you for
your hard work.
The code looks solid; the only thing
https://bz.apache.org/bugzilla/show_bug.cgi?id=47750
Locate Review changed:
What|Removed |Added
URL||https://www.locatereview.co
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new b1133ad Fix BZ 64080 - graceful close
b1133ad is d
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new a1cbdab Fix BZ 64080 - graceful close
a1cbdab is
https://bz.apache.org/bugzilla/show_bug.cgi?id=64080
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bz.apache.org/bugzilla/show_bug.cgi?id=64872
--- Comment #24 from Mark Thomas ---
There can be issues around loggers and class loading with Jasper. Tomcat has a
custom LogManager that ID's logger by a combination of name and
ThreadContextClassLoader (rather than just name).
Depending on
The Buildbot has detected a restored build on builder tomcat-9-trunk while
building tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-9-trunk/builds/555
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: asf946_ubuntu
Build Reason: The AnyBranchSchedu
https://bz.apache.org/bugzilla/show_bug.cgi?id=64858
--- Comment #8 from Gael Lalire ---
(In reply to Mark Thomas from comment #7)
> Which code are you referring to here? The StandardJarScanner obtains URLs
> for the JARs via the WebResources implementation.
StandardJarScanner.process is expecti
https://bz.apache.org/bugzilla/show_bug.cgi?id=64872
--- Comment #25 from Christopher Schultz ---
I noticed that some of the boxed/primitive handling (e.g. boolean, char) are
handled in separate branches and others (e.g. long, int, short) are handled
together in a single branch (with sub-branches
15 matches
Mail list logo