https://bz.apache.org/bugzilla/show_bug.cgi?id=64858
--- Comment #8 from Gael Lalire <gael.lal...@gaellalire.fr> --- (In reply to Mark Thomas from comment #7) > Which code are you referring to here? The StandardJarScanner obtains URLs > for the JARs via the WebResources implementation. StandardJarScanner.process is expecting either "jar:" or "file:" URL, so even if WebResource is allowing any URL we are forced to use one of these. The good think is that JarScannerCallback is now using a org.apache.tomcat.Jar so if I can overload StandardJarScanner.process it will be good but : - UrlJar is opening a connection and cast in JarURLConnection - FragmentJarScannerCallback.extractJarFileName is expecting a jar URL. - TagLibraryInfoImpl.<init> is opening a connection instead of using an inexistent Jar.getLastModified(<no-arg>) which could call WebResource.getLastModified - StandardRoot.BaseLocation.<init> is expecting either jar or file. With jar it is expected a file inside. Should also use JarFactory.newInstance instead. - maybe other ... However it is not an issue for the moment I can use file and jar URL and still load from Maven repository. (In reply to Mark Thomas from comment #7) > My preference continues to be doing this via WebResources and making changes > > there as necessary to permit extensions like this. OK, I updated my PR putting only what I need. I changed only 5 tomcat files with minor changes (https://github.com/apache/tomcat/pull/375/files). I understand that the TomcatController I proposed is too invasive. Can you guide me on how to transform it so it becomes acceptable ? -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
