https://bz.apache.org/bugzilla/show_bug.cgi?id=64632
Michael Osipov changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
stokito edited a comment on pull request #325:
URL: https://github.com/apache/tomcat/pull/325#issuecomment-661298600
At least triple fast because creates less memory garbage. For two comma
separated ETags may work 10 times faster.
Here is a benchmark with results
https://gist.github.com
https://bz.apache.org/bugzilla/show_bug.cgi?id=64265
--- Comment #7 from Sergey Ponomarev ---
We also should implement weak match for If-None-Match
I created PR with the fix
https://github.com/apache/tomcat/pull/325
--
You are receiving this mail because:
You are the assignee for the bug.
-
stokito commented on pull request #325:
URL: https://github.com/apache/tomcat/pull/325#issuecomment-666382555
Ok, so Tomcat should make a weak matching.
I changed the description of PR and added commits. Now this is a bug fix and
simplification is only in last commit.
You can merge ev
stokito commented on pull request #325:
URL: https://github.com/apache/tomcat/pull/325#issuecomment-666445794
I added another two commits with performance optimization. Given the nature
of ETags that Tomcat generates itself I made some priority to check ETag:
1. Full match (what we norma
stokito edited a comment on pull request #325:
URL: https://github.com/apache/tomcat/pull/325#issuecomment-666445794
I added another two commits with performance optimization. Given the nature
of ETags that Tomcat generates itself I made some priority to check ETag:
1. Strict comparision
https://bz.apache.org/bugzilla/show_bug.cgi?id=64634
--- Comment #1 from cst...@ephibian.com ---
Documentation on Azure application gateway headers:
https://docs.microsoft.com/en-us/azure/application-gateway/how-application-gateway-works#modifications-to-the-request
--
You are receiving this ma
https://bz.apache.org/bugzilla/show_bug.cgi?id=64634
Bug ID: 64634
Summary: RemoteIpValve support x-forwarded-for header with port
(Azure)
Product: Tomcat 9
Version: 9.0.x
Hardware: PC
OS: Linux
stokito commented on pull request #325:
URL: https://github.com/apache/tomcat/pull/325#issuecomment-45463
OMG you right, they differ:
An origin server MUST use the strong comparison function when
comparing entity-tags for If-Match (Section 2.3.2), since the client
stokito edited a comment on pull request #325:
URL: https://github.com/apache/tomcat/pull/325#issuecomment-45463
OMG you right, they differ:
An origin server MUST use the strong comparison function when
comparing entity-tags for If-Match (Section 2.3.2), since the
stokito edited a comment on pull request #325:
URL: https://github.com/apache/tomcat/pull/325#issuecomment-45463
OMG you right, they differ:
An origin server MUST use the strong comparison function when
comparing entity-tags for If-Match (Section 2.3.2), since the cli
isapir commented on a change in pull request #327:
URL: https://github.com/apache/tomcat/pull/327#discussion_r463257146
##
File path: java/org/apache/catalina/manager/Constants.java
##
@@ -39,38 +39,65 @@
"\n" +
"
https://bz.apache.org/bugzilla/show_bug.cgi?id=64634
--- Comment #2 from Christopher Schultz ---
Is it supplying X-Forwarded-For or X-Forwarded-Host?
X-Forwarded-For should contain the IP address of the client, and having their
port number (some random high-numbered port, likely) is pretty usele
https://bz.apache.org/bugzilla/show_bug.cgi?id=64634
--- Comment #3 from Christopher Schultz ---
(In reply to cstuhr from comment #0)
> The RemoteIpValve can't parse this, so it fails to work.
Do you get an error, or just a failure to operate as expected?
If an error, please post that.
In eith
This is an automated email from the ASF dual-hosted git repository.
schultz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new eed9426 Add test including port numbers in var
https://bz.apache.org/bugzilla/show_bug.cgi?id=64634
Christopher Schultz changed:
What|Removed |Added
Status|NEW |NEEDINFO
--- Comment #4 from Chr
This is an automated email from the ASF dual-hosted git repository.
schultz pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 6632954 Add test including port numbers in vario
This is an automated email from the ASF dual-hosted git repository.
schultz pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 74298d4 Add test including port numbers in vario
stokito commented on pull request #325:
URL: https://github.com/apache/tomcat/pull/325#issuecomment-666732691
@michael-o now I fixed, please review
This is an automated message from the Apache Git Service.
To respond to the m
stokito commented on pull request #324:
URL: https://github.com/apache/tomcat/pull/324#issuecomment-666735779
Well, as far I can tell it's quite safe to change the ETag generation
schema. After update some servers may receive a spike because all files will be
re-downloaded. Also may fail s
michael-o commented on pull request #325:
URL: https://github.com/apache/tomcat/pull/325#issuecomment-666737304
Will do tomorrow.
This is an automated message from the Apache Git Service.
To respond to the message, please log
https://bz.apache.org/bugzilla/show_bug.cgi?id=64634
--- Comment #5 from cst...@ephibian.com ---
Yeah sorry for the mixup. I had initially tried to get this to work a year ago
and recalled seeing an error then, but I can't seem to replicate it again now.
I had just done a quick test of it again to
22 matches
Mail list logo
