[GitHub] [tomcat-native] martin-g commented on issue #7: BZ 64260: Clean up install target

2020-03-30 Thread GitBox
martin-g commented on issue #7: BZ 64260: Clean up install target URL: https://github.com/apache/tomcat-native/pull/7#issuecomment-605859387 Everything works fine on my Ubuntu 18.04.4 ARM64! The changes also look good to me but I am not an expert in this area. ---

[GitHub] [tomcat-native] michael-o commented on issue #7: BZ 64260: Clean up install target

2020-03-30 Thread GitBox
michael-o commented on issue #7: BZ 64260: Clean up install target URL: https://github.com/apache/tomcat-native/pull/7#issuecomment-605878034 @martin-g Thanks. I will wait a couple of days for the other to look over eventually and will merge in April. --

[Bug 64290] New: Regression: The commit from December 06 2019 on FileUploadBase introduced an incompatible API change

2020-03-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64290 Bug ID: 64290 Summary: Regression: The commit from December 06 2019 on FileUploadBase introduced an incompatible API change Product: Tomcat 8 Version: 8.5.x-trunk Hardwar

[Bug 64265] ETag comparison does not properly implement RFC 7232, section 2.3.2

2020-03-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64265 --- Comment #1 from mgrigorov --- Hi Michael, I see no difference between your > Tomcat returns a weak etag, so try the weak function: >> $ curl "https://.../test/test.txt"; -H 'If-None-Match: W/"6-1585143822000"' -I and > If I try strong

[tomcat] branch master updated (1b41fc7 -> fe41e7d)

2020-03-30 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 1b41fc7 Add Java 14 and 15 support to JSP compilation when supported by the ECJ new 415a738 Fix order new

[tomcat] 02/02: Update / expand French translations

2020-03-30 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit fe41e7db715591c0b6bdbace8cf8bade59e7d07f Author: Mark Thomas AuthorDate: Mon Mar 30 12:48:07 2020 +0100 Update / exp

[tomcat] 01/02: Fix order

2020-03-30 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 415a7380b448d6d0f1f16d542a243ed7b28501ba Author: Mark Thomas AuthorDate: Mon Mar 30 12:47:26 2020 +0100 Fix order --

[Bug 64290] Regression: The commit from December 06 2019 on FileUploadBase introduced an incompatible API change

2020-03-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64290 Michael Osipov changed: What|Removed |Added OS||All --- Comment #1 from Michael Osipo

[tomcat] branch master updated (fe41e7d -> 589664c)

2020-03-30 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from fe41e7d Update / expand French translations new 73bd7b3 Add space before ? ! and ; as required by French gramma

[tomcat] 01/02: Add space before ? ! and ; as required by French grammar

2020-03-30 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 73bd7b3b0f1684560af671f962984919ae1cc46c Author: Mark Thomas AuthorDate: Mon Mar 30 13:15:49 2020 +0100 Add space be

Re: [tomcat] 02/02: Add space before and after ':' as required by French grammar

2020-03-30 Thread Rémy Maucherat
On Mon, Mar 30, 2020 at 2:47 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > markt pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > commit 589664c1cfc978a445710455e380507a160f75ff > Author: Mark Thomas > Autho

[tomcat] branch master updated: Fix an incorrect search/replace

2020-03-30 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 9b3467a Fix an incorrect search/replace 9b3467a

[tomcat] branch 9.0.x updated: Fix an incorrect search/replace

2020-03-30 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 49c3d94 Fix an incorrect search/replace 49c3d94 is

[tomcat] 02/02: Fix an incorrect search/replace

2020-03-30 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit e7538fcf13f2d03e992cb50cfb30937b2eb8adf1 Author: Mark Thomas AuthorDate: Mon Mar 30 14:12:47 2020 +0100 Fix an incorr

[tomcat] branch 8.5.x updated (86f8d8c -> e7538fc)

2020-03-30 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 86f8d8c Update comment for Target JRE as well new 624b488 Update French translations. Add spaces required by Fre

[tomcat] branch 7.0.x updated: Update French translations. Add spaces required by French grammar.

2020-03-30 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new 3b7f03f Update French translations. Add spaces req

Re: [tomcat] 02/02: Add space before and after ':' as required by French grammar

2020-03-30 Thread Mark Thomas
On 30/03/2020 14:13, Rémy Maucherat wrote: > On Mon, Mar 30, 2020 at 2:47 PM > wrote: > > This is an automated email from the ASF dual-hosted git repository. > > markt pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat

[Bug 64265] ETag comparison does not properly implement RFC 7232, section 2.3.2

2020-03-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64265 --- Comment #2 from Michael Osipov --- (In reply to mgrigorov from comment #1) > Hi Michael, > > I see no difference between your > > > Tomcat returns a weak etag, so try the weak function: > >> $ curl "https://.../test/test.txt"; -H 'If-Non

[Bug 64290] Regression: The commit from December 06 2019 on FileUploadBase introduced an incompatible API change

2020-03-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64290 --- Comment #2 from Remy Maucherat --- Fileupload as it is included is considered the same as if it was internal Tomcat code, so releases or snapshots are not relevant. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 64272] Broken links on the WebSocket How-To page

2020-03-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64272 --- Comment #2 from Jerry Lampi --- Mark, thank you. This is still failing for me. I did hard page reloads, cleared browser cache and so on. Even tried it from a browser I never use, knowing that caching would not be a factor. Do you know w

[Bug 64265] ETag comparison does not properly implement RFC 7232, section 2.3.2

2020-03-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64265 --- Comment #3 from mgrigorov --- > Please read my comments also the defined comparison functions: strong and > weak in the RFC. I just wanted to point out that the arguments of the two 'curl` commands are exactly the same. So receiving the s

[Bug 64272] Broken links on the WebSocket How-To page

2020-03-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64272 --- Comment #3 from Mark Thomas --- The tomcat-X.Y-doc pages always reflect the most recent Tomcat release so those pages will be updated with the next round of releases - typically around the 2nd week of the month. The latest version is alway

[Bug 64290] Regression: The commit from December 06 2019 on FileUploadBase introduced an incompatible API change

2020-03-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64290 --- Comment #3 from Markus Schlegel --- "Do you org.apache.tomcat.util.http.fileupload.FileUploadBase.FileSizeLimitExceededException from #getCause()?" We are using Tomcat Embedded and we have built a Jax-Rs resource for the Fileupload, which

[tomcat] branch master updated: Another javax -> jakarta update. Clarify position on stability.

2020-03-30 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 15b4a1a Another javax -> jakarta update. Clarify

[Bug 64265] ETag comparison does not properly implement RFC 7232, section 2.3.2

2020-03-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64265 --- Comment #4 from Michael Osipov --- (In reply to mgrigorov from comment #3) > > Please read my comments also the defined comparison functions: strong and > > weak in the RFC. > > I just wanted to point out that the arguments of the two 'cu

[Bug 64290] Regression: The commit from December 06 2019 on FileUploadBase introduced an incompatible API change

2020-03-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64290 --- Comment #4 from Michael Osipov --- (In reply to Remy Maucherat from comment #2) > Fileupload as it is included is considered the same as if it was internal > Tomcat code, so releases or snapshots are not relevant. If so, we should not add

[Bug 64290] Regression: The commit from December 06 2019 on FileUploadBase introduced an incompatible API change

2020-03-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64290 --- Comment #5 from Mark Thomas --- Tomcat is going to continue to track HEAD for the various Apache Commons projects for which a local fork is maintained. Generally, a class being public doesn't make it part of Tomcat's public API. Tomcat's p

[Bug 64290] Regression: The commit from December 06 2019 on FileUploadBase introduced an incompatible API change

2020-03-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64290 --- Comment #6 from Michael Osipov --- (In reply to Markus Schlegel from comment #3) > "Do you > org.apache.tomcat.util.http.fileupload.FileUploadBase. > FileSizeLimitExceededException from #getCause()?" > > We are using Tomcat Embedded and we

[Bug 64290] Regression: The commit from December 06 2019 on FileUploadBase introduced an incompatible API change

2020-03-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64290 --- Comment #7 from Markus Schlegel --- (In reply to Mark Thomas from comment #5) > Tomcat is going to continue to track HEAD for the various Apache Commons > projects for which a local fork is maintained. > > Generally, a class being public d

[tomcat] branch master updated: BZ 64270. Use documented default umask of 0027 with jsvc and daemon.sh.

2020-03-30 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new ab83a2e BZ 64270. Use documented default umask o

[tomcat] branch 9.0.x updated: BZ 64270. Use documented default umask of 0027 with jsvc and daemon.sh.

2020-03-30 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 6b15b94 BZ 64270. Use documented default umask of

[tomcat] branch 8.5.x updated: BZ 64270. Use documented default umask of 0027 with jsvc and daemon.sh.

2020-03-30 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new d15991a BZ 64270. Use documented default umask of

[Bug 64270] daemon.sh doesn't pass the default umask to JSVC

2020-03-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64270 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[tomcat] branch 7.0.x updated: BZ 64270. Use documented default umask of 0027 with jsvc and daemon.sh.

2020-03-30 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new 785fb71 BZ 64270. Use documented default umask of

buildbot failure in on tomcat-9-trunk

2020-03-30 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-9-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-9-trunk/builds/132 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler

[Bug 64290] Regression: The commit from December 06 2019 on FileUploadBase introduced an incompatible API change

2020-03-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64290 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 64237] Mime-mapping for *.Z files is missing in default configuration of Tomcat 7.0.103

2020-03-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64237 --- Comment #2 from Mark Thomas --- I can neither recall nor find regressions associated with the switch to case insensitive mapping so I plan to back-port that change to 7.0.x shortly. -- You are receiving this mail because: You are the assi

[Bug 64237] Mime-mapping for *.Z files is missing in default configuration of Tomcat 7.0.103

2020-03-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64237 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[tomcat] branch 7.0.x updated: BZ 45995 / BZ 64237. Make MIME mappings case insensitive

2020-03-30 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new a711248 BZ 45995 / BZ 64237. Make MIME mappings ca

[Bug 64290] Regression: The commit from December 06 2019 on FileUploadBase introduced an incompatible API change

2020-03-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64290 --- Comment #9 from Markus Schlegel --- I will change our code. Thank you guys for digging into this! I'll also check if we used some other inofficial classes. When I got you right, we should not use the tomcat classes at all but rather the apa

[Bug 64225] An exception occurred while parse the given input as an HTTP Host header value

2020-03-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64225 Mark Thomas changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEW

[tomcat] branch master updated: Replace reference to "SPNEGO" with "SPNEGO AD"

2020-03-30 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 8d66375 Replace reference to "SPNEGO" with "SPNE

[tomcat] branch 8.5.x updated: Replace reference to "SPNEGO" with "SPNEGO AD"

2020-03-30 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 4f5d8e3 Replace reference to "SPNEGO" with "SPNEGO

[tomcat] branch 9.0.x updated: Replace reference to "SPNEGO" with "SPNEGO AD"

2020-03-30 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 9a21b74 Replace reference to "SPNEGO" with "SPNEGO

[tomcat] branch 7.0.x updated: Replace reference to "SPNEGO" with "SPNEGO AD"

2020-03-30 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new d3d0be6 Replace reference to "SPNEGO" with "SPNEGO

buildbot success in on tomcat-9-trunk

2020-03-30 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-9-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-9-trunk/builds/133 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchSchedu

buildbot success in on tomcat-7-trunk

2020-03-30 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-7-trunk/builds/1650 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchSched

[Bug 64290] Regression: The commit from December 06 2019 on FileUploadBase introduced an incompatible API change

2020-03-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64290 --- Comment #10 from Mark Thomas --- There isn't a clear dividing line between what is and is not part of the public API. The only absolute guarantees are what is in the release notes. Those are deliberately minimal. Everything else we try not

[Bug 64222] Getting User from SSO using SPNEGO returns Tomcat Linux user instead of Windows user above Tomcat9.0.8 - Update documentation

2020-03-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64222 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED

[Bug 64265] ETag comparison does not properly implement RFC 7232, section 2.3.2

2020-03-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64265 --- Comment #5 from Mark Thomas --- The DefaultServlet defers to the WebResources implementation to generate ETags. The WebResource implementation provided by Tomcat is hard-coded to only provide weak ETags. It would be a fair amount of work f

Re: Remaining Tomcat 10 items

2020-03-30 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 3/27/20 13:12, Mark Thomas wrote: > Spec - STRICT_SERVLET_COMPLIANCE Is a useful short-cut - Move the > remaining ones to the Context or related object where possible (I > haven't checked how easy that would be) Would it be possible to hav

Re: Remaining Tomcat 10 items

2020-03-30 Thread Mark Thomas
On 30/03/2020 20:27, Christopher Schultz wrote: > Mark, > > On 3/27/20 13:12, Mark Thomas wrote: >> Spec - STRICT_SERVLET_COMPLIANCE Is a useful short-cut - Move the >> remaining ones to the Context or related object where possible (I >> haven't checked how easy that would be) > > Would it be pos

[tomcat] branch master updated: BZ 64265. Fix ETag comparison. Always use weak comparison.

2020-03-30 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new b26ad77 BZ 64265. Fix ETag comparison. Always us

[tomcat] branch 9.0.x updated: BZ 64265. Fix ETag comparison. Always use weak comparison.

2020-03-30 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new e7774ab BZ 64265. Fix ETag comparison. Always use

[tomcat] branch 8.5.x updated: BZ 64265. Fix ETag comparison. Always use weak comparison.

2020-03-30 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new b2da849 BZ 64265. Fix ETag comparison. Always use

[tomcat] branch master updated: Remove unnecessary trim()

2020-03-30 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 13b12ee Remove unnecessary trim() 13b12ee is des

[tomcat] branch 9.0.x updated: Remove unnecessary trim()

2020-03-30 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 0d8e2d1 Remove unnecessary trim() 0d8e2d1 is descr

[tomcat] branch 8.5.x updated: Remove unnecessary trim()

2020-03-30 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 9a567f2 Remove unnecessary trim() 9a567f2 is descr

[tomcat] branch 7.0.x updated: BZ 64265. Fix ETag comparison. Always use weak comparison.

2020-03-30 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new da6cd88 BZ 64265. Fix ETag comparison. Always use

[Bug 64265] ETag comparison does not properly implement RFC 7232, section 2.3.2

2020-03-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64265 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[tomcat] branch master updated: Update docs as STRICT_SERVLET_COMPLIANCE no longer impacts URIEncoding

2020-03-30 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new c240e49 Update docs as STRICT_SERVLET_COMPLIANCE

buildbot failure in on tomcat-7-trunk

2020-03-30 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-7-trunk/builds/1652 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchSchedule