https://bz.apache.org/bugzilla/show_bug.cgi?id=64290
--- Comment #7 from Markus Schlegel <sch...@gmail.com> --- (In reply to Mark Thomas from comment #5) > Tomcat is going to continue to track HEAD for the various Apache Commons > projects for which a local fork is maintained. > > Generally, a class being public doesn't make it part of Tomcat's public API. > Tomcat's public API is defined in the RELEASE-NOTES file at the root of both > the source and binary distributions. That said, we try to provide a lot more > stability than the guarantees in that file. Ok, thanks for the hint about the RELEASE-NOTES. I did not wirte the respective code myself. It was a collegue, which I am sure of will never have read the RELEASE-NOTES. At times when we all were visiting the project's download page to get the libraries source or binaries, such a RELEASE-NOTES might made sense. Today, I guess 99% of the projects use some dependency-mgmt like maven or in our case ivy, where a release-notes might not be read anymore. When a developer decides to use some class, he will rely on the Javadoc of it. In contrast to the releasenotes (which almost never change), the changelog is THE SOURCE to find out if a new release fits into the project. Unfortunately, that API change was not mentioned there. > I can see why applications might be interested in the specific exception > thrown. There are (ugly) ways to write code to handle both variations of > class structure but in this instance I think it would be reasonable if we > added back inner classes (deprecated and marked for removal in Tomcat 10) on > an "as required" basis and have then simply extend the new classes. > > Markus, I'm assuming that the only class you need is > FileUploadBase.FileSizeLimitExceededException Yes, that's true. But as I stated in my previous comment, if this problem is isolated to our specific usage only and if you think that this kind of class use is "unique", then it makes no sense to just re-add that specific innerclass, since we are now able to fix it in our maintenance code. But if others might have used the inner classes in a similar way, then you should consider re-adding all of them (extending the new ones of course). -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
