[GitHub] [tomcat] markt-asf commented on issue #242: get a hands on ...

2020-02-16 Thread GitBox
markt-asf commented on issue #242: get a hands on ... URL: https://github.com/apache/tomcat/pull/242#issuecomment-586686517 The issue with refactoring for clean code is that the benefits are subjective and people are going to have different views. Performance numbers are objective and wh

[GitHub] [tomcat] oopexpert closed pull request #242: get a hands on ...

2020-02-16 Thread GitBox
oopexpert closed pull request #242: get a hands on ... URL: https://github.com/apache/tomcat/pull/242 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [tomcat] oopexpert commented on issue #242: get a hands on ...

2020-02-16 Thread GitBox
oopexpert commented on issue #242: get a hands on ... URL: https://github.com/apache/tomcat/pull/242#issuecomment-586698111 > Performance numbers are objective and while a refactoring that makes a small piece of code ~3x slower is going to have a negligible impact on performance, the idea

[GUMP@gump-vm]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

2020-02-16 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio has an issue affecting its community integration. Th

[GUMP@gump-vm]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2020-02-16 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio2 has an issue affecting its community integration. T

Re: [tomcat] branch master updated: 64141: Allow overriding JVM trust store

2020-02-16 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy, On 2/15/20 07:22, r...@apache.org wrote: > This is an automated email from the ASF dual-hosted git > repository. > > remm pushed a commit to branch master in repository > https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commi

Re: [tomcat] branch master updated: 64141: Allow overriding JVM trust store

2020-02-16 Thread Rémy Maucherat
On Sun, Feb 16, 2020 at 3:46 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > > +truststoreFile = null; +} +} > > this.caCertificateFile = caCertificateFile; } > > Also, is this the best way to do this? Instead of defaulting to > javax.ssl.trustSt

[GitHub] [tomcat] bohmber opened a new pull request #243: Improved CloudMembershipService documentation and configuration

2020-02-16 Thread GitBox
bohmber opened a new pull request #243: Improved CloudMembershipService documentation and configuration URL: https://github.com/apache/tomcat/pull/243 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [tomcat] bohmber opened a new pull request #244: The '$' in the class name of Digester$EnvironmentPropertySource is no…

2020-02-16 Thread GitBox
bohmber opened a new pull request #244: The '$' in the class name of Digester$EnvironmentPropertySource is no… URL: https://github.com/apache/tomcat/pull/244 …t really shell frendly for unix environments. The class should not a inner class.