oopexpert commented on issue #242: get a hands on ... URL: https://github.com/apache/tomcat/pull/242#issuecomment-586698111 > Performance numbers are objective and while a refactoring that makes a small piece of code ~3x slower is going to have a negligible impact on performance, the idea of repeating that sort of refactoring - with that sort of impact - across the code base is not something that is likely to be considered acceptable. I see that you are not able to get my point. Maybe my english isn't that precise. Sorry about that. > The issue isn't that you have depended on Java 9+ functionality (as far as I could see from a quick look), but that you have added a compile time dependency on org.apache.catalina.*. That is not permitted for the Servlet API classes which cannot have any compile time dependencies other than the JRE. Here you got a point according to the "hack". > The issue with refactoring for clean code is that the benefits are subjective and people are going to have different views. Clean Code isn't a matter of "views". It's a matter of understanding. Nevertheless: I heard enough. Thank you for your time.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
