[Bug 63879] Unessesary log noise under DEBUG

2019-10-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63879 --- Comment #5 from Christopher Schultz --- I think switching the log message to TRACE is the best solution. -- You are receiving this mail because: You are the assignee for the bug. ---

Re: [PROPOSAL] Tomcat 10: Remove Server-Side Includes (SSI)

2019-10-28 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, Note: this was not a vote. The consensus seems to be that SSIs should be moved into a separate JAR file. I've done a *very* short investigation, and I have discovered the following: 1. Tomcat builds fine after removing the entire org.apache.

Re: [PROPOSAL] Tomcat 10: Remove Server-Side Includes (SSI)

2019-10-28 Thread Rémy Maucherat
On Mon, Oct 28, 2019 at 2:34 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > All, > > Note: this was not a vote. > > The consensus seems to be that SSIs should be moved into a separate > JAR file. > > I've done a *very* short in

[Bug 63879] Unessesary log noise under DEBUG

2019-10-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63879 --- Comment #6 from Michael Bazos --- I agree switching to TRACE is the best option. Also it might be helpful to not throw new Exception(); as this produces this message "java.lang.Exception: null" If you are going to have this it might be best

[Bug 63879] Unessesary log noise under DEBUG

2019-10-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63879 --- Comment #6 from Michael Bazos --- I agree switching to TRACE is the best option. Also it might be helpful to not throw new Exception(); as this produces this message "java.lang.Exception: null" If you are going to have this it might be best

Re: [PROPOSAL] Tomcat 10: Remove CGI Servlet

2019-10-28 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, Note: this was not a vote. There was very little feedback, and responses were mixed. We got exactly one response on the users@ list about real-world usage of CGI, so we cannot draw any conclusions about real-world uses. Otherwise, the consens

[Bug 63879] Unessesary log noise under DEBUG

2019-10-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63879 --- Comment #8 from Christopher Schultz --- (In reply to Michael Bazos from comment #6) > I agree switching to TRACE is the best option. Also it might be helpful to > not throw new Exception() Note that the exception is not thrown, only constr

Re: [PROPOSAL] Tomcat 10: Remove Server-Side Includes (SSI)

2019-10-28 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rémy, On 10/28/19 09:51, Rémy Maucherat wrote: > On Mon, Oct 28, 2019 at 2:34 PM Christopher Schultz > > wrote: > > All, > > Note: this was not a vote. > > The consensus seems to be that SSIs should be moved

Re: [PROPOSAL] Tomcat 10: Remove Server-Side Includes (SSI)

2019-10-28 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, On 10/28/19 09:34, Christopher Schultz wrote: > 2. Separating the packaging should be easy. Note that I haven't > actually done this: > > i. Modify files.catalina in build.xml to the > org.apache.catalina.ssi package ii. Modify the "packag

[tomcat] branch 7.0.x updated: Better fix for bug 63836

2019-10-28 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new cdfe4c7 Better fix for bug 63836 cdfe4c7 is descri

[tomcat] branch 7.0.x updated: Update guidance for Eclipse 4.13

2019-10-28 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new c2cd611 Update guidance for Eclipse 4.13 c2cd611 i

[tomcat] branch 8.5.x updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63836

2019-10-28 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 05664f3 Fix https://bz.apache.org/bugzilla/show_bu

[tomcat] branch master updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63836

2019-10-28 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 7fb643d Fix https://bz.apache.org/bugzilla/show_

[tomcat] branch master updated: Update guidance for Eclipse 4.13

2019-10-28 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 8cb570d Update guidance for Eclipse 4.13 8cb570d

[tomcat] branch 8.5.x updated: Update guidance for Eclipse 4.13

2019-10-28 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 6fac0e0 Update guidance for Eclipse 4.13 6fac0e0 i

[tomcat] branch master updated: Fix imports

2019-10-28 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new a54fff8 Fix imports a54fff8 is described below

Re: [PROPOSAL] Tomcat 10: Remove Server-Side Includes (SSI)

2019-10-28 Thread Mark Thomas
On 28/10/2019 15:23, Christopher Schultz wrote: >> i. Modify files.catalina in build.xml to the >> org.apache.catalina.ssi package ii. Modify the "package" target in >> build.xml to with the >> appropriate classes >> >> I think this is super simple to do and we should go ahead and do >> this

[GitHub] [tomcat] markt-asf commented on a change in pull request #218: WIP: BZ 63835: Add support for Keep-Alive header

2019-10-28 Thread GitBox
markt-asf commented on a change in pull request #218: WIP: BZ 63835: Add support for Keep-Alive header URL: https://github.com/apache/tomcat/pull/218#discussion_r339780088 ## File path: java/org/apache/coyote/http11/Http11Processor.java ## @@ -915,8 +915,26 @@ protected fi

Re: RewriteMap parsing

2019-10-28 Thread Mark Thomas
On 27/10/2019 11:27, Felix Schumacher wrote: > Hi all, > > while looking at the RewriteMap configuration, I noticed, that parsing > of the RewriteMap directive is a bit minimal. Parameters are split at > whitespace (no quotes will be recognized) and only the first of the > optional parameters w

Re: [PROPOSAL] Tomcat 10: Remove Server-Side Includes (SSI)

2019-10-28 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 10/28/19 16:30, Mark Thomas wrote: > On 28/10/2019 15:23, Christopher Schultz wrote: > > > >>> i. Modify files.catalina in build.xml to the >>> org.apache.catalina.ssi package ii. Modify the "package" target >>> in build.xml to with

[GitHub] [tomcat] michael-o commented on a change in pull request #218: WIP: BZ 63835: Add support for Keep-Alive header

2019-10-28 Thread GitBox
michael-o commented on a change in pull request #218: WIP: BZ 63835: Add support for Keep-Alive header URL: https://github.com/apache/tomcat/pull/218#discussion_r339792589 ## File path: java/org/apache/coyote/http11/Http11Processor.java ## @@ -915,8 +915,26 @@ protected fi

[GitHub] [tomcat] michael-o commented on a change in pull request #218: WIP: BZ 63835: Add support for Keep-Alive header

2019-10-28 Thread GitBox
michael-o commented on a change in pull request #218: WIP: BZ 63835: Add support for Keep-Alive header URL: https://github.com/apache/tomcat/pull/218#discussion_r339792589 ## File path: java/org/apache/coyote/http11/Http11Processor.java ## @@ -915,8 +915,26 @@ protected fi

[tomcat] branch BZ-63835/9.0.x updated (38fdae1 -> d7f8616)

2019-10-28 Thread michaelo
This is an automated email from the ASF dual-hosted git repository. michaelo pushed a change to branch BZ-63835/9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. omit 38fdae1 BZ 63835: Add support for Keep-Alive header add 8096561 Polish. Align with 8.5.x. add e

[tomcat] 01/01: BZ 63835: Add support for Keep-Alive header

2019-10-28 Thread michaelo
This is an automated email from the ASF dual-hosted git repository. michaelo pushed a commit to branch BZ-63835/9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit d7f8616144ee0f3eaba94bfee73cfd2ca3de8667 Author: Michael Osipov AuthorDate: Wed Oct 23 15:37:42 2019 +0200

[GitHub] [tomcat] michael-o commented on issue #218: WIP: BZ 63835: Add support for Keep-Alive header

2019-10-28 Thread GitBox
michael-o commented on issue #218: WIP: BZ 63835: Add support for Keep-Alive header URL: https://github.com/apache/tomcat/pull/218#issuecomment-547156714 Critics have been resolved, please re-evaluate. This is an automated me

[tomcat] branch master updated (a54fff8 -> 1638e4f)

2019-10-28 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from a54fff8 Fix imports add 1638e4f Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63838 No new revisions were

[tomcat] branch 8.5.x updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63838

2019-10-28 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 08018d3 Fix https://bz.apache.org/bugzilla/show_bu

[Bug 63838] Illegal reflective access by WebappClassLoaderBase$1 in Java 13

2019-10-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63838 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[tomcat] branch 7.0.x updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63838

2019-10-28 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new a891580 Fix https://bz.apache.org/bugzilla/show_bu

[Bug 63852] ServerInfo.java discloses server-version ignoring settings from server.xml

2019-10-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63852 --- Comment #14 from Mark Thomas --- I'm leaning towards resolving this as WONTFIX. The server attribute defaults to null whereas ServerInfo (as used in the ErrorReportValve and other places) defaults to "Apache Tomcat/". I don't see any easy

[GitHub] [tomcat] rmaucher commented on a change in pull request #218: WIP: BZ 63835: Add support for Keep-Alive header

2019-10-28 Thread GitBox
rmaucher commented on a change in pull request #218: WIP: BZ 63835: Add support for Keep-Alive header URL: https://github.com/apache/tomcat/pull/218#discussion_r339814604 ## File path: java/org/apache/coyote/http11/Http11Processor.java ## @@ -915,8 +915,26 @@ protected fin

Re: RewriteMap parsing

2019-10-28 Thread Romain Manni-Bucau
+1 for quotes Can the "function" support be pluggable either with an explicit registry or a SPI? Would be awesome to enrich it in "super tomcat" instances (thinking to meecrowave, tomee and maybe spring boot). Le lun. 28 oct. 2019 à 21:43, Mark Thomas a écrit : > > > On 27/10/2019 11:27, Felix

[Bug 63859] AJP cping/cpong mode failing on Tomcat 9.x

2019-10-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63859 Mark Thomas changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #7 from Mark Thomas

[Bug 63879] Unessesary log noise under DEBUG

2019-10-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63879 --- Comment #9 from Steve Sanders --- (In reply to Christopher Schultz from comment #8) > (In reply to Michael Bazos from comment #6) > > I agree switching to TRACE is the best option. Also it might be helpful to > > not throw new Exception() >

[Bug 63890] New: JDNI & JDBC Connection when using IPV4 going back to IPV6

2019-10-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63890 Bug ID: 63890 Summary: JDNI & JDBC Connection when using IPV4 going back to IPV6 Product: Tomcat 9 Version: unspecified Hardware: PC Status: NEW Sev

[Bug 63890] JDNI & JDBC Connection when using IPV4 going back to IPV6

2019-10-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63890 Paul Harding changed: What|Removed |Added OS||All --- Comment #1 from Paul Harding -