Author: fschumacher
Date: Fri Aug 10 10:00:18 2018
New Revision: 1837786
URL: http://svn.apache.org/viewvc?rev=1837786&view=rev
Log:
Use short circuit logic to prevent potential NPE in CorsFilter.
The same logic is used a few lines below, so it was most probably
intended that way anyways.
Modif
Author: fschumacher
Date: Fri Aug 10 10:08:54 2018
New Revision: 1837787
URL: http://svn.apache.org/viewvc?rev=1837787&view=rev
Log:
Simplify construction of appName from container name in JAASRealm.
There is no need to add a slash in front of the container name as
the method makeLegalForJAAS wil
Author: fschumacher
Date: Fri Aug 10 10:10:18 2018
New Revision: 1837788
URL: http://svn.apache.org/viewvc?rev=1837788&view=rev
Log:
Spacepolice
Modified:
tomcat/trunk/java/org/apache/catalina/realm/JAASRealm.java
Modified: tomcat/trunk/java/org/apache/catalina/realm/JAASRealm.java
URL:
htt
https://bz.apache.org/bugzilla/show_bug.cgi?id=62603
--- Comment #6 from Jordi ---
I've reviewed the changes and everything looks good(I will test/debug it also
next week)
Thanks
--
You are receiving this mail because:
You are the assignee for the bug.
-
GitHub user seratch opened a pull request:
https://github.com/apache/tomcat/pull/118
Fix typos detected by github.com/client9/misspell
Fixing typos is sometimes very hard. It's not so easy to visually review
them. Recently, I discovered a very useful tool for it,
[misspell](https:/
https://bz.apache.org/bugzilla/show_bug.cgi?id=62614
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bz.apache.org/bugzilla/show_bug.cgi?id=62615
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Github user markt-asf commented on the issue:
https://github.com/apache/tomcat/pull/118
Thanks for this. Working through a review of the patch now.
Note that there are some files that we can't change such as the Oracle
provided XSDs.
---
-
Github user seratch commented on a diff in the pull request:
https://github.com/apache/tomcat/pull/118#discussion_r209289041
--- Diff: java/org/apache/tomcat/dbcp/dbcp2/managed/ManagedConnection.java
---
@@ -1,4 +1,4 @@
-/**
+vi /**
--- End diff --
I will remov
Github user seratch commented on a diff in the pull request:
https://github.com/apache/tomcat/pull/118#discussion_r209289321
--- Diff: java/org/apache/catalina/ha/session/SessionMessageImpl.java ---
@@ -144,7 +144,7 @@ public String getEventTypeString()
case EVT_GET
Github user markt-asf commented on a diff in the pull request:
https://github.com/apache/tomcat/pull/118#discussion_r209290720
--- Diff: java/org/apache/tomcat/dbcp/dbcp2/managed/ManagedConnection.java
---
@@ -1,4 +1,4 @@
-/**
+vi /**
--- End diff --
No worries
Github user markt-asf commented on a diff in the pull request:
https://github.com/apache/tomcat/pull/118#discussion_r209292288
--- Diff: java/org/apache/catalina/ha/session/SessionMessageImpl.java ---
@@ -144,7 +144,7 @@ public String getEventTypeString()
case EVT_G
Github user asfgit closed the pull request at:
https://github.com/apache/tomcat/pull/118
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Author: markt
Date: Fri Aug 10 15:16:11 2018
New Revision: 1837809
URL: http://svn.apache.org/viewvc?rev=1837809&view=rev
Log:
Correct various spelling errors throughout the source code and documentation.
Patch provided by Kazuhiro Sera.
This closes #118
Modified:
tomcat/trunk/java/javax/serv
Author: markt
Date: Fri Aug 10 15:18:16 2018
New Revision: 1837810
URL: http://svn.apache.org/viewvc?rev=1837810&view=rev
Log:
Another typo reported by Kazuhiro Sera.
Modified:
tomcat/trunk/webapps/examples/WEB-INF/classes/jsp2/examples/simpletag/FindBookSimpleTag.java
Modified:
tomcat/tru
Github user seratch commented on the issue:
https://github.com/apache/tomcat/pull/118
Thank you for merging the changes. ð
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands,
Author: markt
Date: Fri Aug 10 15:26:16 2018
New Revision: 1837812
URL: http://svn.apache.org/viewvc?rev=1837812&view=rev
Log:
More typos reported by Kazuhiro Sera.
Modified:
tomcat/trunk/java/org/apache/coyote/http11/filters/SavedRequestInputFilter.java
tomcat/trunk/java/org/apache/tomc
Author: markt
Date: Fri Aug 10 15:29:21 2018
New Revision: 1837813
URL: http://svn.apache.org/viewvc?rev=1837813&view=rev
Log: (empty)
Modified:
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
Modified: tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat
Author: markt
Date: Fri Aug 10 15:30:30 2018
New Revision: 1837814
URL: http://svn.apache.org/viewvc?rev=1837814&view=rev
Log:
Correct various spelling errors throughout the source code and documentation.
Patch provided by Kazuhiro Sera.
Modified:
tomcat/tc8.5.x/trunk/ (props changed)
t
Author: markt
Date: Fri Aug 10 15:40:03 2018
New Revision: 1837815
URL: http://svn.apache.org/viewvc?rev=1837815&view=rev
Log:
Typo
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaManager.java
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaMa
Author: markt
Date: Fri Aug 10 15:41:59 2018
New Revision: 1837816
URL: http://svn.apache.org/viewvc?rev=1837816&view=rev
Log:
Correct various spelling errors throughout the source code and documentation.
Patch provided by Kazuhiro Sera.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
t
Propchange: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/http/fileupload/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Aug 10 15:41:59 2018
@@ -1,4 +1,4 @@
/commons/proper/fileupload/trunk/src/main/java/org/a
Author: markt
Date: Fri Aug 10 15:42:55 2018
New Revision: 1837817
URL: http://svn.apache.org/viewvc?rev=1837817&view=rev
Log:
Typo
Modified:
tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java
Modified: tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java
URL:
https://bz.apache.org/bugzilla/show_bug.cgi?id=62614
--- Comment #2 from Dapeng Zhang ---
My fault again, sorry about that.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev
Github user asfgit closed the pull request at:
https://github.com/apache/tomcat/pull/114
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Author: markt
Date: Fri Aug 10 15:46:39 2018
New Revision: 1837818
URL: http://svn.apache.org/viewvc?rev=1837818&view=rev
Log:
Remove ServletException from declaration of Tomcat.addWebapp(String,String)
since it is never thrown.
Patch provided by Tzafrir.
This closes #114
Modified:
tomcat/tr
Author: markt
Date: Fri Aug 10 15:47:29 2018
New Revision: 1837819
URL: http://svn.apache.org/viewvc?rev=1837819&view=rev
Log:
Remove ServletException from declaration of Tomcat.addWebapp(String,String)
since it is never thrown.
Patch provided by Tzafrir.
Modified:
tomcat/tc8.5.x/trunk/ (p
Author: markt
Date: Fri Aug 10 15:49:08 2018
New Revision: 1837820
URL: http://svn.apache.org/viewvc?rev=1837820&view=rev
Log:
Remove ServletException from declaration of Tomcat.addWebapp(String,String)
since it is never thrown.
Patch provided by Tzafrir.
Modified:
tomcat/tc7.0.x/trunk/ (p
Github user markt-asf commented on a diff in the pull request:
https://github.com/apache/tomcat/pull/117#discussion_r209306777
--- Diff: webapps/docs/introduction.xml ---
@@ -89,6 +80,122 @@ same as $CATALINA_HOME.
+
+ Throughout the documentation, there a
Github user markt-asf commented on a diff in the pull request:
https://github.com/apache/tomcat/pull/117#discussion_r209308073
--- Diff: webapps/docs/introduction.xml ---
@@ -89,6 +80,122 @@ same as $CATALINA_HOME.
+
+ Throughout the documentation, there a
https://bz.apache.org/bugzilla/show_bug.cgi?id=62614
Dapeng Zhang changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|INVALID
The Buildbot has detected a new failure on builder tomcat-trunk while building
. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/3511
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchScheduler schedu
https://bz.apache.org/bugzilla/show_bug.cgi?id=62614
Dapeng Zhang changed:
What|Removed |Added
Summary|Async servlet over HTTP/2 |Async servlet over HTTP/2
https://bz.apache.org/bugzilla/show_bug.cgi?id=62611
--- Comment #1 from Christopher Schultz ---
Be careful; sometimes log files can be large and compressing them can take a
while.
I would recommend against adding more code to Tomcat that solves a problem
already solved by better logging framewo
The Buildbot has detected a restored build on builder tomcat-trunk while
building . Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/3512
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchScheduler sch
35 matches
Mail list logo
