svn commit: r1834932 - /tomcat/trunk/java/org/apache/catalina/mapper/Mapper.java

2018-07-03 Thread markt
Author: markt Date: Tue Jul 3 08:59:53 2018 New Revision: 1834932 URL: http://svn.apache.org/viewvc?rev=1834932&view=rev Log: Fix Findbugs warning Avoid problems if there is a concurrent update of the defaultHostName Modified: tomcat/trunk/java/org/apache/catalina/mapper/Mapper.java Modifie

[Bug 62273] Add support for alternate URL specification

2018-07-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62273 --- Comment #26 from Markus Schlegel --- The Patch provided in the attachments has a USE_URL_LIVING_STANDARD switch implemented. However, when I look at the source code of my downloaded Tomcat 8.5.32, I can not see this change (and my webapp us

[jira] [Created] (MTOMCAT-315) Failed to execute goal org.codehaus.mojo:tomcat-maven-plugin:1.1:run (default-cli) on project

2018-07-03 Thread keshav chourasiya (JIRA)
keshav chourasiya created MTOMCAT-315: - Summary: Failed to execute goal org.codehaus.mojo:tomcat-maven-plugin:1.1:run (default-cli) on project Key: MTOMCAT-315 URL: https://issues.apache.org/jira/browse/MTOMCA

[Bug 62273] Add support for alternate URL specification

2018-07-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62273 --- Comment #27 from Mark Thomas --- (In reply to Markus Schlegel from comment #26) > The Patch provided in the attachments has a USE_URL_LIVING_STANDARD switch > implemented. > However, when I look at the source code of my downloaded Tomcat 8.

svn commit: r1834949 - in /tomcat/trunk/bin: makebase.bat makebase.sh

2018-07-03 Thread markt
Author: markt Date: Tue Jul 3 11:55:14 2018 New Revision: 1834949 URL: http://svn.apache.org/viewvc?rev=1834949&view=rev Log: Mark as executable Modified: tomcat/trunk/bin/makebase.bat (props changed) tomcat/trunk/bin/makebase.sh (props changed) Propchange: tomcat/trunk/bin/makebase

Re: File Permissions in SVN/Git

2018-07-03 Thread Mark Thomas
On 03/07/18 07:14, Violeta Georgieva wrote: > Hi, > > 2018-07-03 7:24 GMT+03:00 Igal Sapir : >> >> The new files bin/makebase.bat and makebase.sh do not have the same >> permissions as the other files in bin, possibly because I committed them >> from a Windows machine. >> >> Specifically, the file

buildbot success in on tomcat-trunk

2018-07-03 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3421 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler sch

svn commit: r1834989 - in /tomcat/trunk/bin: makebase.bat makebase.sh

2018-07-03 Thread markt
Author: markt Date: Tue Jul 3 15:31:37 2018 New Revision: 1834989 URL: http://svn.apache.org/viewvc?rev=1834989&view=rev Log: Fix line-endings Modified: tomcat/trunk/bin/makebase.bat (props changed) tomcat/trunk/bin/makebase.sh (props changed) Propchange: tomcat/trunk/bin/makebase.b

svn commit: r1834990 - /tomcat/trunk/bin/makebase.bat

2018-07-03 Thread markt
Author: markt Date: Tue Jul 3 15:33:51 2018 New Revision: 1834990 URL: http://svn.apache.org/viewvc?rev=1834990&view=rev Log: This is Windows, not Linux and friends Modified: tomcat/trunk/bin/makebase.bat Modified: tomcat/trunk/bin/makebase.bat URL: http://svn.apache.org/viewvc/tomcat/trun

svn commit: r1834991 - /tomcat/trunk/bin/makebase.sh

2018-07-03 Thread markt
Author: markt Date: Tue Jul 3 15:39:14 2018 New Revision: 1834991 URL: http://svn.apache.org/viewvc?rev=1834991&view=rev Log: Fix problem finding conf directory when $0 is './makebase.sh' by copying standard code from other .sh scripts. Replace 'HOME_DIR' with 'CATALINA_HOME'. Non-standard name

svn commit: r1834992 - /tomcat/trunk/bin/makebase.bat

2018-07-03 Thread markt
Author: markt Date: Tue Jul 3 15:41:00 2018 New Revision: 1834992 URL: http://svn.apache.org/viewvc?rev=1834992&view=rev Log: Don't echo comments (follow-up to r1834853) Modified: tomcat/trunk/bin/makebase.bat Modified: tomcat/trunk/bin/makebase.bat URL: http://svn.apache.org/viewvc/tomcat

svn commit: r1834993 - /tomcat/trunk/bin/makebase.bat

2018-07-03 Thread markt
Author: markt Date: Tue Jul 3 15:41:35 2018 New Revision: 1834993 URL: http://svn.apache.org/viewvc?rev=1834993&view=rev Log: Doh! It just needed to be moved. Modified: tomcat/trunk/bin/makebase.bat Modified: tomcat/trunk/bin/makebase.bat URL: http://svn.apache.org/viewvc/tomcat/trunk/bin/

svn commit: r1834994 - /tomcat/trunk/bin/makebase.bat

2018-07-03 Thread markt
Author: markt Date: Tue Jul 3 15:46:16 2018 New Revision: 1834994 URL: http://svn.apache.org/viewvc?rev=1834994&view=rev Log: echo does not need quotes on Windows. They are echoed as well which just looks odd. Modified: tomcat/trunk/bin/makebase.bat Modified: tomcat/trunk/bin/makebase.bat

svn commit: r1834995 - /tomcat/trunk/bin/makebase.bat

2018-07-03 Thread markt
Author: markt Date: Tue Jul 3 15:53:17 2018 New Revision: 1834995 URL: http://svn.apache.org/viewvc?rev=1834995&view=rev Log: Escape '<' and '>' Modified: tomcat/trunk/bin/makebase.bat Modified: tomcat/trunk/bin/makebase.bat URL: http://svn.apache.org/viewvc/tomcat/trunk/bin/makebase.bat?r

svn commit: r1834996 - /tomcat/trunk/bin/makebase.bat

2018-07-03 Thread markt
Author: markt Date: Tue Jul 3 15:53:39 2018 New Revision: 1834996 URL: http://svn.apache.org/viewvc?rev=1834996&view=rev Log: Use windows file separator Modified: tomcat/trunk/bin/makebase.bat Modified: tomcat/trunk/bin/makebase.bat URL: http://svn.apache.org/viewvc/tomcat/trunk/bin/makeba

svn commit: r1834998 - /tomcat/trunk/bin/makebase.bat

2018-07-03 Thread markt
Author: markt Date: Tue Jul 3 16:10:02 2018 New Revision: 1834998 URL: http://svn.apache.org/viewvc?rev=1834998&view=rev Log: Copy standard code to determine CATALINA_HOME from other scripts. Use setlocal so changes env variables don't persist outside the script. Use standard name, CATALINA_HOME

svn commit: r1835001 - in /tomcat/trunk/bin: makebase.bat makebase.sh

2018-07-03 Thread markt
Author: markt Date: Tue Jul 3 16:14:58 2018 New Revision: 1835001 URL: http://svn.apache.org/viewvc?rev=1835001&view=rev Log: Align / correct comments Modified: tomcat/trunk/bin/makebase.bat tomcat/trunk/bin/makebase.sh Modified: tomcat/trunk/bin/makebase.bat URL: http://svn.apache.org

makebase script and webapps

2018-07-03 Thread Mark Thomas
Hi, I've been looking at the makebase script and thinking about potential use cases. Currently, we copy conf recursively but create an empty webapps. This is inconsistent as any directories under conf will (nearly always) be web application specific config. I think we should either copy web appl

Re: svn commit: r1834989 - in /tomcat/trunk/bin: makebase.bat makebase.sh

2018-07-03 Thread Michael Osipov
Am 2018-07-03 um 17:31 schrieb ma...@apache.org: Author: markt Date: Tue Jul 3 15:31:37 2018 New Revision: 1834989 URL: http://svn.apache.org/viewvc?rev=1834989&view=rev Log: Fix line-endings Modified: tomcat/trunk/bin/makebase.bat (props changed) tomcat/trunk/bin/makebase.sh (pr

Inconsistencies makebase.sh

2018-07-03 Thread Michael Osipov
Friends, I still see some inconsistencies and portability issues: 1. Some expressions, some are not. It should be consistently quoted to avoid whitespace issues or similar. 2. "cp -a" is not portable. Some platforms don't have it, e.g., HP-UX which I use for approx 10 years with Tomcat. 3. Ev

Re: makebase script and webapps

2018-07-03 Thread Igal Sapir
On 7/3/2018 9:27 AM, Mark Thomas wrote: Currently, we copy conf recursively but create an empty webapps. This is inconsistent as any directories under conf will (nearly always) be web application specific config. I think we should either copy web applications and config or not copy both. My s

Re: Inconsistencies makebase.sh

2018-07-03 Thread William L. Thomson Jr.
On Tue, 3 Jul 2018 20:09:44 +0200 Michael Osipov wrote: > Friends, > > I still see some inconsistencies and portability issues: > > 1. Some expressions, some are not. It should be consistently quoted > to avoid whitespace issues or similar. > 2. "cp -a" is not portable. Some platforms don't hav

Re: svn commit: r1834989 - in /tomcat/trunk/bin: makebase.bat makebase.sh

2018-07-03 Thread Violeta Georgieva
На вт, 3.07.2018 г. в 21:02 ч. Michael Osipov написа: > > Am 2018-07-03 um 17:31 schrieb ma...@apache.org: > > Author: markt > > Date: Tue Jul 3 15:31:37 2018 > > New Revision: 1834989 > > > > URL: http://svn.apache.org/viewvc?rev=1834989&view=rev > > Log: > > Fix line-endings > > > > Modified: >

Re: svn commit: r1834989 - in /tomcat/trunk/bin: makebase.bat makebase.sh

2018-07-03 Thread Mark Thomas
On 03/07/18 20:33, Violeta Georgieva wrote: > На вт, 3.07.2018 г. в 21:02 ч. Michael Osipov написа: >> >> Am 2018-07-03 um 17:31 schrieb ma...@apache.org: >>> Author: markt >>> Date: Tue Jul 3 15:31:37 2018 >>> New Revision: 1834989 >>> >>> URL: http://svn.apache.org/viewvc?rev=1834989&view=rev >

Re: makebase script and webapps

2018-07-03 Thread Michael Osipov
Am 2018-07-03 um 18:27 schrieb Mark Thomas: Hi, I've been looking at the makebase script and thinking about potential use cases. Currently, we copy conf recursively but create an empty webapps. This is inconsistent as any directories under conf will (nearly always) be web application specific c

Re: makebase script and webapps

2018-07-03 Thread Mark Thomas
On 03/07/18 21:02, Michael Osipov wrote: > Am 2018-07-03 um 18:27 schrieb Mark Thomas: >> Hi, >> >> I've been looking at the makebase script and thinking about potential >> use cases. >> >> Currently, we copy conf recursively but create an empty webapps. This is >> inconsistent as any directories u

Re: makebase script and webapps

2018-07-03 Thread Michael Osipov
Am 2018-07-03 um 22:07 schrieb Mark Thomas: On 03/07/18 21:02, Michael Osipov wrote: Am 2018-07-03 um 18:27 schrieb Mark Thomas: Hi, I've been looking at the makebase script and thinking about potential use cases. Currently, we copy conf recursively but create an empty webapps. This is incons

Re: makebase script and webapps

2018-07-03 Thread Mark Thomas
On 03/07/18 21:10, Michael Osipov wrote: > Am 2018-07-03 um 22:07 schrieb Mark Thomas: >> On 03/07/18 21:02, Michael Osipov wrote: >>> Am 2018-07-03 um 18:27 schrieb Mark Thomas: Hi, I've been looking at the makebase script and thinking about potential use cases. Curre

Re: makebase script and webapps

2018-07-03 Thread Michael Osipov
Am 2018-07-03 um 22:12 schrieb Mark Thomas: On 03/07/18 21:10, Michael Osipov wrote: Am 2018-07-03 um 22:07 schrieb Mark Thomas: On 03/07/18 21:02, Michael Osipov wrote: Am 2018-07-03 um 18:27 schrieb Mark Thomas: Hi, I've been looking at the makebase script and thinking about potential use

Re: makebase script and webapps

2018-07-03 Thread Igal Sapir
On 7/3/2018 1:15 PM, Michael Osipov wrote: Am 2018-07-03 um 22:12 schrieb Mark Thomas: On 03/07/18 21:10, Michael Osipov wrote: Am 2018-07-03 um 22:07 schrieb Mark Thomas: On 03/07/18 21:02, Michael Osipov wrote: Am 2018-07-03 um 18:27 schrieb Mark Thomas: Hi, I've been looking at the makeb

Re: makebase script and webapps

2018-07-03 Thread Michael Osipov
Am 2018-07-03 um 22:37 schrieb Igal Sapir: On 7/3/2018 1:15 PM, Michael Osipov wrote: Am 2018-07-03 um 22:12 schrieb Mark Thomas: On 03/07/18 21:10, Michael Osipov wrote: Am 2018-07-03 um 22:07 schrieb Mark Thomas: On 03/07/18 21:02, Michael Osipov wrote: Am 2018-07-03 um 18:27 schrieb Mark

Re: makebase script and webapps

2018-07-03 Thread Igal Sapir
On 7/3/2018 1:48 PM, Michael Osipov wrote: Am 2018-07-03 um 22:37 schrieb Igal Sapir: On 7/3/2018 1:15 PM, Michael Osipov wrote: Am 2018-07-03 um 22:12 schrieb Mark Thomas: On 03/07/18 21:10, Michael Osipov wrote: Am 2018-07-03 um 22:07 schrieb Mark Thomas: On 03/07/18 21:02, Michael Osipov