On 03/07/18 21:10, Michael Osipov wrote: > Am 2018-07-03 um 22:07 schrieb Mark Thomas: >> On 03/07/18 21:02, Michael Osipov wrote: >>> Am 2018-07-03 um 18:27 schrieb Mark Thomas: >>>> Hi, >>>> >>>> I've been looking at the makebase script and thinking about potential >>>> use cases. >>>> >>>> Currently, we copy conf recursively but create an empty webapps. >>>> This is >>>> inconsistent as any directories under conf will (nearly always) be web >>>> application specific config. >>>> >>>> I think we should either copy web applications and config or not copy >>>> both. >>>> >>>> My suggestion is not to copy web applications and config (i.e. sub dirs >>>> of /conf) by default and to add a -webapps option (or similar) to the >>>> makebase script and only copy them when the option is present. >>>> >>>> Thoughts? >>> >>> First of all, I don't like the '-a' approach because you make >>> assumptions about the target you don't know while other operations don't >>> do it. I'd simply do "-r". >>> >>> I do agree with your that it is somewhat inconsistent, but we need to >>> consider a very important point which must be true for our script to >>> work properly: CATALINA_HOME has to remain unmodified, i.e., contents of >>> conf, webapps. >>> Though, the new CATALINA_BASE needs to be complete to start a Tomcat >>> instance, and it is complete with an empty webapps/ dir. conf/ is >>> mandatory. >> >> The start will be unnecessarily messy if there are context.xml files in >> sub-directories of conf but not corresponding application in webapps. > > Then why not copy only the necessary files which Tomcat needs to start?
That is the point of -webapps. Only copy the context.xml files if you are going to copy the contents of webapps. >>> Given that you want to add "--webapps", which will you copy? Manager? >>> Host Manager? All of them? >> >> All of them. I think it has to be all or nothing. Anything else will get >> very complicated very quickly for a script. I think most cases won't >> want to copy (hence the default) but I can think of a few scenarios >> where it could be useful. > > So even if it contains some user deployed apps? Yes. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
