On 09/14/2015 04:44 PM, r...@apache.org wrote:
Author: remm
Date: Mon Sep 14 14:44:06 2015
New Revision: 1702962
URL: http://svn.apache.org/r1702962
Log:
Similar to NIO2, async NIO sendfile needs to deallocate and recycle the buffer.
That fixed the java.lang.OutOfMemoryError: Direct buffer mem
Author: markt
Date: Tue Sep 15 08:02:56 2015
New Revision: 1703115
URL: http://svn.apache.org/r1703115
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58378
Clarify comment on thread-safety.
Ensure the latest pathInfo value is visible to the main test thread.
Modified:
tomcat/tc8.0.x
Author: markt
Date: Tue Sep 15 08:04:43 2015
New Revision: 1703116
URL: http://svn.apache.org/r1703116
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58378
Clarify comment on thread-safety.
Ensure the latest pathInfo value is visible to the main test thread.
Modified:
tomcat/trunk/te
https://bz.apache.org/bugzilla/show_bug.cgi?id=58378
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
The Buildbot has detected a build exception on builder tomcat-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/275
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSch
c/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-6.11-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20
Author: markt
Date: Tue Sep 15 10:26:58 2015
New Revision: 1703140
URL: http://svn.apache.org/r1703140
Log:
Add missing license header
Modified:
tomcat/tc8.0.x/trunk/test/org/apache/tomcat/util/http/TesterHttpMessagesPerformance.java
Modified:
tomcat/tc8.0.x/trunk/test/org/apache/tomcat/ut
Author: markt
Date: Tue Sep 15 10:38:05 2015
New Revision: 1703143
URL: http://svn.apache.org/r1703143
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58379
Updates to the socketWrapper need to be visible to async threads.
Modified:
tomcat/trunk/java/org/apache/coyote/AbstractProcesso
Author: markt
Date: Tue Sep 15 10:40:44 2015
New Revision: 1703144
URL: http://svn.apache.org/r1703144
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58379
Updates to the socketWrapper need to be visible to async threads.
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tomcat/t
https://bz.apache.org/bugzilla/show_bug.cgi?id=58379
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
The Buildbot has detected a new failure on builder tomcat-trunk while building
ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/276
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSchedul
Author: markt
Date: Tue Sep 15 10:52:42 2015
New Revision: 1703146
URL: http://svn.apache.org/r1703146
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58380
Both maxInactiveInterval and isNew can be accessed concurrently so they need to
be volatile
Modified:
tomcat/trunk/java/org/apa
Author: markt
Date: Tue Sep 15 10:56:36 2015
New Revision: 1703147
URL: http://svn.apache.org/r1703147
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58380
Both maxInactiveInterval and isNew can be accessed concurrently so they need to
be volatile
Modified:
tomcat/tc8.0.x/trunk/ (
https://bz.apache.org/bugzilla/show_bug.cgi?id=58380
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
The Buildbot has detected a build exception on builder tomcat-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/277
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSch
Author: markt
Date: Tue Sep 15 11:11:51 2015
New Revision: 1703151
URL: http://svn.apache.org/r1703151
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58381
The list of events is accessed by multiple threads so use a thread safe Deque
implementation.
Fix a Javadoc comment
Simplify the cod
Author: markt
Date: Tue Sep 15 11:14:35 2015
New Revision: 1703153
URL: http://svn.apache.org/r1703153
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58381
The list of events is accessed by multiple threads so use a thread safe Deque
implementation.
Fix a Javadoc comment
Simplify the cod
https://bz.apache.org/bugzilla/show_bug.cgi?id=58381
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
The Buildbot has detected a new failure on builder tomcat-trunk while building
ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/278
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSchedul
Author: markt
Date: Tue Sep 15 11:55:10 2015
New Revision: 1703160
URL: http://svn.apache.org/r1703160
Log:
Deprecate unused code
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/membership/Membership.java
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/membership/Membership.ja
Author: markt
Date: Tue Sep 15 11:55:49 2015
New Revision: 1703161
URL: http://svn.apache.org/r1703161
Log:
Deprecate unused code
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/membership/Membership.java
Propchange: tomcat/tc8.0.x/
Author: markt
Date: Tue Sep 15 11:56:18 2015
New Revision: 1703162
URL: http://svn.apache.org/r1703162
Log:
Remove deprecated, unused code
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/membership/Membership.java
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/membership/Memb
The Buildbot has detected a build exception on builder tomcat-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/279
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSch
Author: markt
Date: Tue Sep 15 12:03:50 2015
New Revision: 1703164
URL: http://svn.apache.org/r1703164
Log:
Fix Javadoc
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/membership/Membership.java
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/membership/Membership.java
URL:
h
Author: markt
Date: Tue Sep 15 12:16:41 2015
New Revision: 1703167
URL: http://svn.apache.org/r1703167
Log:
Code clean-up.
Should be no functional change.
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/membership/Membership.java
Modified:
tomcat/trunk/java/org/apache/catalina/tribes
Author: markt
Date: Tue Sep 15 12:41:35 2015
New Revision: 1703174
URL: http://svn.apache.org/r1703174
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58382
Use single object (membersLock) for all locking
Make members volatile so single reads are safe
Reduce scope of locks where possible
E
Author: markt
Date: Tue Sep 15 12:44:55 2015
New Revision: 1703175
URL: http://svn.apache.org/r1703175
Log:
Fix Javadoc
Modified:
tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/membership/Membership.java
Modified:
tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/membership/Member
Author: markt
Date: Tue Sep 15 12:45:24 2015
New Revision: 1703176
URL: http://svn.apache.org/r1703176
Log:
Code clean-up.
Should be no functional change.
Modified:
tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/membership/Membership.java
Modified:
tomcat/tc8.0.x/trunk/java/org/apach
Author: markt
Date: Tue Sep 15 12:45:48 2015
New Revision: 1703177
URL: http://svn.apache.org/r1703177
Log:
Use single object (membersLock) for all locking
Make members volatile so single reads are safe
Reduce scope of locks where possible
Expand scope of locks where necessary
Modified:
tomca
https://bz.apache.org/bugzilla/show_bug.cgi?id=58382
Mark Thomas changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
https://bz.apache.org/bugzilla/show_bug.cgi?id=58284
--- Comment #8 from Mark Thomas ---
Ping? I'm likely to be in a position to start the next 8.0.x release soon and
this needs to be fixed before the tag. If no patch is forthcoming, I'll likely
end up writing the patch myself.
--
You are recei
The Buildbot has detected a new failure on builder tomcat-trunk while building
ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/282
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSchedul
Author: markt
Date: Tue Sep 15 13:26:32 2015
New Revision: 1703192
URL: http://svn.apache.org/r1703192
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58383
Fix data race on getSenderState
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/transport/SenderState.java
Modified:
to
Author: markt
Date: Tue Sep 15 13:28:22 2015
New Revision: 1703193
URL: http://svn.apache.org/r1703193
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58383
Fix data race on getSenderState
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/cata
https://bz.apache.org/bugzilla/show_bug.cgi?id=58383
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
The Buildbot has detected a build exception on builder tomcat-8-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-8-trunk/builds/123
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranc
Author: markt
Date: Tue Sep 15 13:43:55 2015
New Revision: 1703194
URL: http://svn.apache.org/r1703194
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58384
Calls to backgroundProcess() may come from different threads
Modified:
tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocket
Author: markt
Date: Tue Sep 15 13:46:58 2015
New Revision: 1703195
URL: http://svn.apache.org/r1703195
Log:
Fix backport
Modified:
tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/transport/SenderState.java
Modified:
tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/transport/Sender
Author: markt
Date: Tue Sep 15 13:47:59 2015
New Revision: 1703196
URL: http://svn.apache.org/r1703196
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58384
Calls to backgroundProcess() may come from different threads
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tomcat/tc8.0
https://bz.apache.org/bugzilla/show_bug.cgi?id=58384
Mark Thomas changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
Author: markt
Date: Tue Sep 15 13:55:27 2015
New Revision: 1703198
URL: http://svn.apache.org/r1703198
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58385
Fix a rare data race in the internal flag Tomcat uses to keep track of whether
or not a request is being used for Comet processing.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58385
Mark Thomas changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
On 13/09/2015 21:59, Yilong Li wrote:
> Sorry about the vague explanation. But the actual reasons are not the point
> here.
No, that is exactly the point. When you claim that something that
appears to be working without issue for many, many users then you need
to provide a justification for why th
https://bz.apache.org/bugzilla/show_bug.cgi?id=57920
--- Comment #4 from izanm...@gmail.com ---
I'm fang the exact same issue, and can't find the culprit for this deadlock.
How did you find it?
--
You are receiving this mail because:
You are the assignee for the bug.
---
The Buildbot has detected a restored build on builder tomcat-8-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-8-trunk/builds/124
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranch
The Buildbot has detected a build exception on builder tomcat-8-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-8-trunk/builds/125
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranc
I am not sure declaring this field as volatile is the right way to fix it
because the increment is still not atomic. If this counter doesn't have to
be precise, I think it's OK to allow data races on this field. Otherwise,
it should be declared as atomic.
Yilong
On Tue, Sep 15, 2015 at 6:43 AM,
> From: Yilong Li [mailto:yilong...@runtimeverification.com]
> Subject: Re: svn commit: r1703194 -
> /tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java
> I am not sure declaring this field as volatile is the right way to fix it
> because the increment is still not atomic. I
On 15/09/2015 17:30, Caldarale, Charles R wrote:
>> From: Yilong Li [mailto:yilong...@runtimeverification.com]
>> Subject: Re: svn commit: r1703194 -
>> /tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java
>
>> I am not sure declaring this field as volatile is the right way t
On Tue, Sep 15, 2015 at 7:19 AM, Mark Thomas wrote:
> On 13/09/2015 21:59, Yilong Li wrote:
> > Sorry about the vague explanation. But the actual reasons are not the
> point
> > here.
>
> No, that is exactly the point. When you claim that something that
> appears to be working without issue for m
Hi Mark,
Am 15.09.2015 um 14:45 schrieb ma...@apache.org:
Author: markt
Date: Tue Sep 15 12:45:48 2015
New Revision: 1703177
URL: http://svn.apache.org/r1703177
Log:
Use single object (membersLock) for all locking
Make members volatile so single reads are safe
I am not sure, if it is enough to
> From: Mark Thomas [mailto:ma...@apache.org]
> Subject: Re: svn commit: r1703194 -
> /tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java
> The odds of a data race here are slim (to non-existent)
That's definitely true; the questions arising here are more theoretical than
Hi Mark,
why didn't you remove the synchronization when you converted the code to
ConcurrentLinkedDeque?
The old code had a concurrency problem, since events.size() was checked
outside of the synchronize block. I think this is not a problem anymore,
but I don't understand the call to events.
> From: Yilong Li [mailto:yilong...@runtimeverification.com]
> Subject: Re: RV-Predict bugs
> The following is a valid execution trace consists of 5 events:
> T1 T2
> 1 READ null
> 2 WRITE s
> 3 READ s
> 4
https://bz.apache.org/bugzilla/show_bug.cgi?id=58081
--- Comment #2 from Christopher Schultz ---
I think the Java source in there is now primarily there for historical reasons.
Does anyone actually build the Java code from the tcnative project?
--
You are receiving this mail because:
You are th
https://bz.apache.org/bugzilla/show_bug.cgi?id=58404
Christopher Schultz changed:
What|Removed |Added
Status|NEW |NEEDINFO
--- Comment #1 from Chr
Mark,
On 9/14/15 4:00 AM, Mark Thomas wrote:
> On 13/09/2015 23:11, Caldarale, Charles R wrote:
>>> From: ma...@apache.org [mailto:ma...@apache.org]
>>> Subject: svn commit: r1702821 - in /tomcat/tc8.0.x/trunk:
>>> java/org/apache/tomcat/util/http/HttpMessages.java
>>> webapps/docs/changelog.xm
On Tue, Sep 15, 2015 at 10:58 AM, Caldarale, Charles R <
chuck.caldar...@unisys.com> wrote:
> > From: Yilong Li [mailto:yilong...@runtimeverification.com]
> > Subject: Re: RV-Predict bugs
>
> > The following is a valid execution trace consists of 5 events:
> > T1
> From: Christopher Schultz [mailto:ch...@christopherschultz.net]
> Subject: Re: svn commit: r1702821 - in /tomcat/tc8.0.x/trunk:
> java/org/apache/tomcat/util/http/HttpMessages.java webapps/docs/changelog.xml
> What's the reason for caching references to the return value of
> sm.getString()? Is
Hi all,
with change r1701668 JreVendor is used in catalina.Globals. But it seems
to be missing in tomcat-utils.jar since .../util/compat/** is not on the
included files list.
I have tried the patch
diff --git a/build.xml b/build.xml
index 3462373..03c4270 100644
--- a/build.xml
+++ b/build.x
> From: Yilong Li [mailto:yilong...@runtimeverification.com]
> Subject: Re: RV-Predict bugs
> Well, it is the problem (at least part of it) because JLS says "Informally,
> a read *r* is allowed to see the result of a write *w* if there is no
> *happens-before* ordering to prevent that read." In t
https://bz.apache.org/bugzilla/show_bug.cgi?id=58411
Bug ID: 58411
Summary: CoyoteWriter throws StringIndexOutOfBoundsException
when concurrently printing lines
Product: Tomcat 8
Version: 8.0.26
Hardware: All
On Tue, Sep 15, 2015 at 11:32 AM, Caldarale, Charles R <
chuck.caldar...@unisys.com> wrote:
> > From: Yilong Li [mailto:yilong...@runtimeverification.com]
> > Subject: Re: RV-Predict bugs
>
> > Well, it is the problem (at least part of it) because JLS says
> "Informally,
> > a read *r* is allowed
https://bz.apache.org/bugzilla/show_bug.cgi?id=58412
Bug ID: 58412
Summary: AsyncFileHandler logs package and method name as
null.null
Product: Tomcat 8
Version: trunk
Hardware: All
OS: All
Statu
https://bz.apache.org/bugzilla/show_bug.cgi?id=58411
Remy Maucherat changed:
What|Removed |Added
Resolution|--- |INVALID
Status|NEW
Chuck,
On 9/15/15 2:21 PM, Caldarale, Charles R wrote:
>> From: Christopher Schultz [mailto:ch...@christopherschultz.net]
>> Subject: Re: svn commit: r1702821 - in /tomcat/tc8.0.x/trunk:
>> java/org/apache/tomcat/util/http/HttpMessages.java webapps/docs/changelog.xml
>
>> What's the reason for
https://bz.apache.org/bugzilla/show_bug.cgi?id=58284
--- Comment #9 from Andrew Shore ---
Hey sorry the the delay in response. I was out of the office last week and
haven't had a chance to start this. How soon is soon? I probably won't be able
to get to this until later in the week.
--
You are
https://bz.apache.org/bugzilla/show_bug.cgi?id=58411
--- Comment #2 from sdav...@gmail.com ---
Yes, that's what I did end up doing but it seems odd that Tomcat would
specifically remove the appropriate synchronization provided by the
PrintWriter, so my code that was working on Jetty doesn't work i
> From: Yilong Li [mailto:yilong...@runtimeverification.com]
> Subject: Re: RV-Predict bugs
> > True, but as Mark previously pointed out, no one cares. All that happens
> > in that case is the object is redundantly created and then garbage
> > collected later; no damage.
> No, it's not right. I
Yilong,
On 9/15/15 12:59 PM, Yilong Li wrote:
> On Tue, Sep 15, 2015 at 7:19 AM, Mark Thomas wrote:
>
>> On 13/09/2015 21:59, Yilong Li wrote:
>>> Sorry about the vague explanation. But the actual reasons are not the
>> point
>>> here.
>>
>> No, that is exactly the point. When you claim that som
On 15/09/2015 19:51, Christopher Schultz wrote:
> Chuck,
>
> On 9/15/15 2:21 PM, Caldarale, Charles R wrote:
>>> From: Christopher Schultz [mailto:ch...@christopherschultz.net]
>>> Subject: Re: svn commit: r1702821 - in /tomcat/tc8.0.x/trunk:
>>> java/org/apache/tomcat/util/http/HttpMessages.jav
On 15/09/2015 18:28, Felix Schumacher wrote:
> Hi Mark,
>
> Am 15.09.2015 um 14:45 schrieb ma...@apache.org:
>> Author: markt
>> Date: Tue Sep 15 12:45:48 2015
>> New Revision: 1703177
>>
>> URL: http://svn.apache.org/r1703177
>> Log:
>> Use single object (membersLock) for all locking
>> Make memb
Chuck,
On 9/15/15 3:06 PM, Caldarale, Charles R wrote:
>> From: Yilong Li [mailto:yilong...@runtimeverification.com]
>> Subject: Re: RV-Predict bugs
>
>>> True, but as Mark previously pointed out, no one cares. All that happens
>>> in that case is the object is redundantly created and then garb
All,
On 9/15/15 3:07 PM, Christopher Schultz wrote:
> In the above case, the reference "s" may for a short time be a reference
> to an uninitialized object of type String. This can be problematic.
> Imagine the psusdo-bytecode below generated by the compiler:
>
> 1: push s
> 3: ifnull goto 8
> From: Christopher Schultz [mailto:ch...@christopherschultz.net]
> Subject: Re: svn commit: r1702821 - in /tomcat/tc8.0.x/trunk:
> java/org/apache/tomcat/util/http/HttpMessages.java webapps/docs/changelog.xml
> > There's a whole lot of stuff going on inside that method, including
> > string for
https://bz.apache.org/bugzilla/show_bug.cgi?id=58411
--- Comment #3 from Christopher Schultz ---
It's worth pointing-out that nowhere in java.io.PrintWriter does it say
anything about being thread-safe, nor does its superclass, java.io.Writer.
Also, none of the methods are synchronized.
Internal
On 15/09/2015 17:59, Yilong Li wrote:
> On Tue, Sep 15, 2015 at 7:19 AM, Mark Thomas wrote:
>> Long experience has lead us to be sceptical of bugs reported by
>> automated tools. When looking at such bugs and we can't see what the
>> problem is and the person raising the bug can't provide a clear
https://bz.apache.org/bugzilla/show_bug.cgi?id=58284
--- Comment #10 from Mark Thomas ---
You probably have a day or two. I'll update the bug when I reach the point
where I need the patch. If you can update it as well when you start work we
should be able to avoid duplicating effort.
--
You are
https://bz.apache.org/bugzilla/show_bug.cgi?id=58284
--- Comment #11 from Andrew Shore ---
Will do. Thanks Mark.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr.
On 15/09/2015 20:15, Mark Thomas wrote:
> On 15/09/2015 18:28, Felix Schumacher wrote:
>> Hi Mark,
>>
>> Am 15.09.2015 um 14:45 schrieb ma...@apache.org:
>>> Author: markt
>>> Date: Tue Sep 15 12:45:48 2015
>>> New Revision: 1703177
>>>
>>> URL: http://svn.apache.org/r1703177
>>> Log:
>>> Use singl
Mark,
On 9/15/15 3:09 PM, Mark Thomas wrote:
> On 15/09/2015 19:51, Christopher Schultz wrote:
>> Chuck,
>>
>> On 9/15/15 2:21 PM, Caldarale, Charles R wrote:
From: Christopher Schultz [mailto:ch...@christopherschultz.net]
Subject: Re: svn commit: r1702821 - in /tomcat/tc8.0.x/trunk:
>
> From: Mark Thomas [mailto:ma...@apache.org]
> Subject: Re: RV-Predict bugs
> Putting it into my own words to check my understanding:
> - The two reads in T2 may be re-ordered because, in T2, there is nothing
> that requires a happens-before relationship between the two reads
Depends on what
Mark,
On 9/15/15 3:29 PM, Mark Thomas wrote:
> On 15/09/2015 17:59, Yilong Li wrote:
>> On Tue, Sep 15, 2015 at 7:19 AM, Mark Thomas wrote:
>
>>> Long experience has lead us to be sceptical of bugs reported by
>>> automated tools. When looking at such bugs and we can't see what the
>>> problem i
On 15/09/2015 18:35, Caldarale, Charles R wrote:
>> From: Mark Thomas [mailto:ma...@apache.org]
>> Subject: Re: svn commit: r1703194 -
>> /tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java
>
>> The odds of a data race here are slim (to non-existent)
>
> That's definitely t
On 15/09/2015 18:41, Felix Schumacher wrote:
> Hi Mark,
>
> why didn't you remove the synchronization when you converted the code to
> ConcurrentLinkedDeque?
No idea. Focusing on one thing and missing the obvious I suspect.
> The old code had a concurrency problem, since events.size() was checke
On 15/09/2015 20:37, Christopher Schultz wrote:
> On 9/15/15 3:09 PM, Mark Thomas wrote:
>> The cached String values are returned approximately 2 orders of
>> magnitude faster. OK we are talking about 10s of nano-seconds vs.
>> fractions of nanoseconds so it is almost certainly in the noise but
> From: Christopher Schultz [mailto:ch...@christopherschultz.net]
> Subject: Re: RV-Predict bugs
> I don't see why a thread would read one value from memory and then have
> that value change locally without going back to main memory.
The point that was trying to be made was that independent read
> From: Christopher Schultz [mailto:ch...@christopherschultz.net]
> Subject: Re: RV-Predict bugs
> I discovered that within a synchronized block, the JIT is allowed to re-order
> statements if it determines it is safe to do so -- and that statements that
> occur before the memory barrier must no
On Tue, Sep 15, 2015 at 12:06 PM, Caldarale, Charles R <
chuck.caldar...@unisys.com> wrote:
> > From: Yilong Li [mailto:yilong...@runtimeverification.com]
> > Subject: Re: RV-Predict bugs
>
> > > True, but as Mark previously pointed out, no one cares. All that
> happens
> > > in that case is the
On 15/09/2015 20:42, Caldarale, Charles R wrote:
>> From: Mark Thomas [mailto:ma...@apache.org]
>> Subject: Re: RV-Predict bugs
>
>> Putting it into my own words to check my understanding:
>
>> - The two reads in T2 may be re-ordered because, in T2, there is nothing
>> that requires a happens-
Am 15. September 2015 21:47:57 MESZ, schrieb Mark Thomas :
>On 15/09/2015 18:41, Felix Schumacher wrote:
>> Hi Mark,
>>
>> why didn't you remove the synchronization when you converted the code
>to
>> ConcurrentLinkedDeque?
>
>No idea. Focusing on one thing and missing the obvious I suspect.
>
>>
Author: markt
Date: Tue Sep 15 20:24:49 2015
New Revision: 1703287
URL: http://svn.apache.org/r1703287
Log:
Follow-up to r1703151
More clean-up and remove an unnecessary clear() that could cause problems.
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/transport/nio/NioReceiver.java
M
> From: Mark Thomas [mailto:ma...@apache.org]
> Subject: Re: svn commit: r1703194 -
> /tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java
> What prevents the concurrency is that there is only ever one background
> thread. The only was I see this happening is:
> - T1 runs and
Author: markt
Date: Tue Sep 15 20:25:52 2015
New Revision: 1703288
URL: http://svn.apache.org/r1703288
Log:
Follow-up to r1703153
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/transport/nio/NioReceiver.java
Propchange: tomcat/tc8.
On 15/09/2015 21:18, Felix Schumacher wrote:
>
>
> Am 15. September 2015 21:47:57 MESZ, schrieb Mark Thomas :
>> On 15/09/2015 18:41, Felix Schumacher wrote:
>>> Hi Mark,
>>>
>>> why didn't you remove the synchronization when you converted the code
>> to
>>> ConcurrentLinkedDeque?
>>
>> No idea.
On Tue, Sep 15, 2015 at 12:29 PM, Mark Thomas wrote:
> On 15/09/2015 17:59, Yilong Li wrote:
> > On Tue, Sep 15, 2015 at 7:19 AM, Mark Thomas wrote:
>
> >> Long experience has lead us to be sceptical of bugs reported by
> >> automated tools. When looking at such bugs and we can't see what the
>
On 15/09/2015 21:24, Caldarale, Charles R wrote:
>> From: Mark Thomas [mailto:ma...@apache.org]
>> Subject: Re: svn commit: r1703194 -
>> /tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java
>
>> What prevents the concurrency is that there is only ever one background
>> threa
https://bz.apache.org/bugzilla/show_bug.cgi?id=58404
--- Comment #2 from Sebb ---
(In reply to Christopher Schultz from comment #1)
> This may not be a bug: ant scripts often provide sane defaults in case the
> properties files do not specify a value:
See Bug 58083 - the same issue was fixed in
https://bz.apache.org/bugzilla/show_bug.cgi?id=58081
--- Comment #3 from Sebb ---
(In reply to Christopher Schultz from comment #2)
> I think the Java source in there is now primarily there for historical
> reasons. Does anyone actually build the Java code from the tcnative project?
In case anyo
2015-09-15 22:28 GMT+02:00 Mark Thomas :
> > Sounds like a false positive to me. There are numerous implicit
> synchronizations in the above sequence, so the volatile is not particularly
> useful (but it's not terribly expensive either).
>
> Thanks. I'll revert that fix and resolve it as invalid.
1 - 100 of 139 matches
Mail list logo
