On 15/09/2015 18:41, Felix Schumacher wrote: > Hi Mark, > > why didn't you remove the synchronization when you converted the code to > ConcurrentLinkedDeque?
No idea. Focusing on one thing and missing the obvious I suspect. > The old code had a concurrency problem, since events.size() was checked > outside of the synchronize block. I think this is not a problem anymore, > but I don't understand the call to events.clear() afterwards the > while-loop in events(). We think we have guarded the queue and removed > all entries by calling pollFirst repeatedly, so why clear it afterwards? Don't know. I'll take another look and clean it up some more. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
