[GUMP@vmgump]: Project tomcat-tc8.0.x-test-apr (in module tomcat-8.0.x) failed

2014-12-10 Thread Bill Barker
it/target/junit-4.13-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-APR -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20141210-native-src.tar.gz -Dexampl

Re: Websocket client message processing

2014-12-10 Thread Mark Thomas
On 09/12/2014 23:42, Rémy Maucherat wrote: > 2014-12-09 20:47 GMT+01:00 Mark Thomas : > >> How would a message get into the socket buffer? The client needs a >> session to write a message and it won't get one until connectToServer >> returns. >> > You misunderstood it, the client opens the connect

svn commit: r1644358 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java

2014-12-10 Thread markt
Author: markt Date: Wed Dec 10 09:49:28 2014 New Revision: 1644358 URL: http://svn.apache.org/r1644358 Log: Add a comment to explain handling of messages sent by the server immediately after the WebSocket connection is established. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsWe

svn commit: r1644360 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java

2014-12-10 Thread markt
Author: markt Date: Wed Dec 10 09:50:14 2014 New Revision: 1644360 URL: http://svn.apache.org/r1644360 Log: Improve comment wording. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer

svn commit: r1644373 - /tomcat/trunk/test/org/apache/tomcat/websocket/TestWsRemoteEndpoint.java

2014-12-10 Thread markt
Author: markt Date: Wed Dec 10 11:08:06 2014 New Revision: 1644373 URL: http://svn.apache.org/r1644373 Log: Parameterise the message used in the test (so we can more easily test different sized messages). Modified: tomcat/trunk/test/org/apache/tomcat/websocket/TestWsRemoteEndpoint.java Modi

Re: svn commit: r1642773 - in /tomcat/trunk/java/org/apache/tomcat/websocket: WsFrameBase.java WsRemoteEndpointImplBase.java

2014-12-10 Thread Mark Thomas
On 08/12/2014 22:43, Rémy Maucherat wrote: > 2014-12-08 21:59 GMT+01:00 Mark Thomas : > >> What triggers the exception. That is the bit I don't understand. >> > The test is throwing an exception, it goes to onError which writes a > message, but the writer empty message gets sent first. From what I

Re: svn commit: r1642773 - in /tomcat/trunk/java/org/apache/tomcat/websocket: WsFrameBase.java WsRemoteEndpointImplBase.java

2014-12-10 Thread Mark Thomas
On 10/12/2014 12:08, Mark Thomas wrote: > On 08/12/2014 22:43, Rémy Maucherat wrote: >> 2014-12-08 21:59 GMT+01:00 Mark Thomas : >> >>> What triggers the exception. That is the bit I don't understand. >>> >> The test is throwing an exception, it goes to onError which writes a >> message, but the wr

[Bug 57324] Change in Expect100Continue behaviour in Tomcat is breaking existing clients with "keepalive" connections

2014-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57324 --- Comment #7 from Michael Osipov <1983-01...@gmx.net> --- As far as I can see, this behavior is fully RFC-compliant: A server that responds with a final status code before reading the entire message body SHOULD indicate in that response w

Re: svn commit: r1643194 - in /tomcat/trunk/java/org/apache/tomcat/websocket: Constants.java LocalStrings.properties TransformationFactory.java Util.java WsWebSocketContainer.java

2014-12-10 Thread Mark Thomas
On 08/12/2014 23:02, Rémy Maucherat wrote: > 2014-12-08 21:56 GMT+01:00 Mark Thomas : > >> The more I think about this, the more I think it made no sense to >> include extensions on the server side without an API to add extension >> implementations. But that boat has sailed. >> > > Ok, but these

svn commit: r1644384 - /tomcat/trunk/java/org/apache/tomcat/websocket/Constants.java

2014-12-10 Thread markt
Author: markt Date: Wed Dec 10 12:41:08 2014 New Revision: 1644384 URL: http://svn.apache.org/r1644384 Log: Add a comment to the effect that these options are likely to go away in the future. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/Constants.java Modified: tomcat/trunk/java/

svn commit: r1644412 - in /tomcat/trunk/java/org/apache/tomcat/websocket: Constants.java WsRemoteEndpointImplBase.java

2014-12-10 Thread remm
Author: remm Date: Wed Dec 10 14:00:00 2014 New Revision: 1644412 URL: http://svn.apache.org/r1644412 Log: Add some configuration, and default to sending those useful empty messages. Also remove explicit mention of the tests used. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/Const

Re: svn commit: r1642773 - in /tomcat/trunk/java/org/apache/tomcat/websocket: WsFrameBase.java WsRemoteEndpointImplBase.java

2014-12-10 Thread Rémy Maucherat
2014-12-10 13:08 GMT+01:00 Mark Thomas : > I'd prefer to see this commit reverted but, given your requirement for > an implementation that can pass the TCK - even if the TCK is wrong, > then I'd accept this behaviour being disabled by default and enabled by > yet another system property. > > I don

[Bug 57324] Change in Expect100Continue behaviour in Tomcat is breaking existing clients with "keepalive" connections

2014-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57324 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

svn commit: r1644443 - in /tomcat/trunk/test/org/apache/tomcat/websocket: TestWsRemoteEndpoint.java TesterEchoServer.java

2014-12-10 Thread markt
Author: markt Date: Wed Dec 10 14:59:38 2014 New Revision: 163 URL: http://svn.apache.org/r163 Log: Tests cases for https://java.net/jira/browse/WEBSOCKET_SPEC-232 Modified: tomcat/trunk/test/org/apache/tomcat/websocket/TestWsRemoteEndpoint.java tomcat/trunk/test/org/apache/tomcat

svn propchange: r1644443 - svn:log

2014-12-10 Thread markt
Author: markt Revision: 163 Modified property: svn:log Modified: svn:log at Wed Dec 10 15:01:20 2014 -- --- svn:log (original) +++ svn:log Wed Dec 10 15:01:20 2014 @@ -1 +1 @@ -Tests cases for https://java.net/jira/bro

[Bug 57324] Change in Expect100Continue behaviour in Tomcat is breaking existing clients with "keepalive" connections

2014-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57324 --- Comment #9 from Vamsi Krishna --- Created attachment 32280 --> https://issues.apache.org/bugzilla/attachment.cgi?id=32280&action=edit Tomcat HTTP traffic -- You are receiving this mail because: You are the assignee for the bug. ---

[Bug 57142] JSP 2.3 & EL 3.0 - %page import directive & EL ImportHandler

2014-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57142 Mark Thomas changed: What|Removed |Added Severity|enhancement |normal --- Comment #12 from Mark Tho

[Bug 57324] Change in Expect100Continue behaviour in Tomcat is breaking existing clients with "keepalive" connections

2014-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57324 Vamsi Krishna changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALI

Re: svn commit: r1643766 - /tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java

2014-12-10 Thread Christopher Schultz
Violetta, On 12/8/14 4:04 AM, violet...@apache.org wrote: > Author: violetagg > Date: Mon Dec 8 09:04:56 2014 > New Revision: 1643766 > > URL: http://svn.apache.org/r1643766 > Log: > Extract several "protected" methods in order to make StandardRoot easier for > extending. > > Modified: > t

[Bug 57338] New: SingleSignOnEntry cache of ClusterSingleSignOn valve is not synchronized on Tomcat startup

2014-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57338 Bug ID: 57338 Summary: SingleSignOnEntry cache of ClusterSingleSignOn valve is not synchronized on Tomcat startup Product: Tomcat 7 Version: 7.0.57 Hardware: PC

Re: svn commit: r1643912 - in /tomcat/trunk: build.properties.default build.xml res/patches/ res/patches/commons-logging-log4j2.patch

2014-12-10 Thread Rainer Jung
ACK, will revert for now. Am 09.12.2014 um 12:38 schrieb Mark Thomas: On 08/12/2014 21:58, Rainer Jung wrote: 3. Generally, I do not like as a long-term solution, as that tool is not available under Windows, unless you specifically configure it (needs update to BUILDING.txt)/ Any better i

svn commit: r1644504 - in /tomcat/trunk: build.properties.default build.xml res/patches/

2014-12-10 Thread rjung
Author: rjung Date: Wed Dec 10 18:46:22 2014 New Revision: 1644504 URL: http://svn.apache.org/r1644504 Log: Revert r1643912 (Log4J Version 2 support for JULI). Use of ant patch task is problematic on Windows. Need for JULI integration needs more justification. Check with upstream commonas logging

svn commit: r1644511 - /tomcat/trunk/java/org/apache/jasper/compiler/PageInfo.java

2014-12-10 Thread markt
Author: markt Date: Wed Dec 10 19:22:52 2014 New Revision: 1644511 URL: http://svn.apache.org/r1644511 Log: Min default buffer size must be at least 8k so this is fine. Modified: tomcat/trunk/java/org/apache/jasper/compiler/PageInfo.java Modified: tomcat/trunk/java/org/apache/jasper/compiler

svn commit: r1644516 - in /tomcat/trunk/java/org/apache/jasper: compiler/Generator.java compiler/PageInfo.java compiler/Validator.java runtime/JspSourceImports.java runtime/PageContextImpl.java

2014-12-10 Thread markt
Author: markt Date: Wed Dec 10 20:20:08 2014 New Revision: 1644516 URL: http://svn.apache.org/r1644516 Log: Revert original fix for BZ 57142 that attempted to: - determine if the page might use EL - if it did, create the ELContext (that would be required anyway) and set the necessary imports on

[Bug 57142] JSP 2.3 & EL 3.0 - %page import directive & EL ImportHandler

2014-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57142 --- Comment #13 from Mark Thomas --- a) and c) are addressed in r1644516 for trunk. Looking at b) next. -- You are receiving this mail because: You are the assignee for the bug. --

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-apr (in module tomcat-8.0.x) failed

2014-12-10 Thread Bill Barker
it/target/junit-4.13-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-APR -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20141210-native-src.tar.gz -Dexampl

svn commit: r1644523 - in /tomcat/trunk: java/javax/el/ImportHandler.java test/javax/el/TestImportHandler.java

2014-12-10 Thread markt
Author: markt Date: Wed Dec 10 21:08:54 2014 New Revision: 1644523 URL: http://svn.apache.org/r1644523 Log: Fix ImportHandler issues identified in review of fix for BZ 57142 - delay resolution of class name to Class until it is used - Use the TCCL to load classes by name Modified: tomcat/trun

[Bug 57142] JSP 2.3 & EL 3.0 - %page import directive & EL ImportHandler

2014-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57142 --- Comment #14 from Mark Thomas --- b) address in r1644523 for trunk. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail

svn commit: r1644524 - in /tomcat/tc8.0.x/trunk: ./ java/javax/el/ java/org/apache/jasper/compiler/ java/org/apache/jasper/runtime/ test/javax/el/ test/org/apache/el/ test/webapp/bug5nnnn/ webapps/doc

2014-12-10 Thread markt
Author: markt Date: Wed Dec 10 21:15:36 2014 New Revision: 1644524 URL: http://svn.apache.org/r1644524 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57142 JSP page imports must be exposed to EL via ImportHandler Added: tomcat/tc8.0.x/trunk/java/org/apache/jasper/runtime/JspSourc

[Bug 57142] JSP 2.3 & EL 3.0 - %page import directive & EL ImportHandler

2014-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57142 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1644525 - in /tomcat/tc8.0.x/trunk: ./ test/org/apache/catalina/valves/TestRequestFilterValve.java

2014-12-10 Thread markt
Author: markt Date: Wed Dec 10 21:19:50 2014 New Revision: 1644525 URL: http://svn.apache.org/r1644525 Log: Refactor test to stop IDE complaining about possible NPEs. Also requires slightly less code. Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/test/org/apache/

svn commit: r1644529 - in /tomcat/trunk/java/org/apache/catalina/connector: LocalStrings.properties Request.java

2014-12-10 Thread markt
Author: markt Date: Wed Dec 10 21:30:43 2014 New Revision: 1644529 URL: http://svn.apache.org/r1644529 Log: kkolinko review of fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=57215 Don't return the uri if things go wrong. Given that the error states in question should never happen, th

[Bug 57215] Regression in Tomcat 7.0.54 after Bug 56501 with urls starting with //

2014-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57215 --- Comment #9 from Mark Thomas --- In theory issue 3 should never happen. Therefore, I have changed the code to throw an ISE rather than return the uri. -- You are receiving this mail because: You are the assignee for the bug. -

buildbot failure in ASF Buildbot on tomcat-trunk

2014-12-10 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/764 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1644535 - /tomcat/trunk/java/org/apache/catalina/connector/Request.java

2014-12-10 Thread markt
Author: markt Date: Wed Dec 10 23:24:22 2014 New Revision: 1644535 URL: http://svn.apache.org/r1644535 Log: Follow-up to 1644529. Better fix that actually passes the unit tests. Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java Modified: tomcat/trunk/java/org/apache/cata