ACK, will revert for now.
Am 09.12.2014 um 12:38 schrieb Mark Thomas:
On 08/12/2014 21:58, Rainer Jung wrote:
<snip/>
3. Generally, I do not like <patch> as a long-term solution, as that
tool is not available under Windows, unless you specifically configure
it (needs update to BUILDING.txt)/
Any better idea? I can try to get the stuff in upstream jcl, but I think
it's not very likely they'll do a release.
Commons is about to switch to a "any committer can commit" model so you
will certainly be able to get the changes in. We could then get trunk
building from a snapshot.
We'd need a Commons logging release with your changes for the first
9.0.x release but that is a log way off. We haver several options there.
You could RM a Commons Logging release, we could take a packaged renamed
svn copy, etc.
Should I instead check in the resulting build2.xml and the 2 classes
into a res sub directory and copy the files out from there? The files
would hevae to be updated if we move to a newer jcl version, which might
well happen never. I could keep the patch file for reference and to make
merging after upgrading jcl easier.
Patch currently crashes for me on Windows trying to apply this patch in
place and that is starting to cause me problems. I don't know if it is a
general issue with the version of patch I am using or something specific
about this patch but either way it is causing problems.
I think backing this change out, applying the changes to Commons Logging
and then patching trunk to build from a C-L snapshot is clean way to do
this.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
