svn commit: r1601839 - /tomcat/tc6.0.x/trunk/STATUS.txt

2014-06-11 Thread kkolinko
Author: kkolinko Date: Wed Jun 11 09:28:23 2014 New Revision: 1601839 URL: http://svn.apache.org/r1601839 Log: votes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1601839&r1=1601838&r

[Bug 56518] NIO async servlet limit latch leak

2014-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56518 --- Comment #14 from Mark Thomas --- I've done some testing and it looks like the call to Thread.currentThread().isInterrupted() is nice and quick. I'm going to go ahead and make some changes here. I've been thinking about this some more a

Re: svn commit: r1601796 - in /tomcat/trunk: java/org/apache/catalina/connector/Request.java webapps/docs/changelog.xml

2014-06-11 Thread Mark Thomas
On 11/06/2014 02:49, violet...@apache.org wrote: > Author: violetagg > Date: Wed Jun 11 01:49:21 2014 > New Revision: 1601796 > > URL: http://svn.apache.org/r1601796 > Log: > Provide a better error message when asynchronous operations are not supported > by a filter or servlet. Patch provided by

[Bug 56606] Tomcat Installer: old attribute generated in tomcat-users.xml instead of the new one

2014-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56606 --- Comment #2 from Konstantin Kolinko --- For a record: There are several components that read tomcat-users.xml. org.apache.catalina.users.MemoryUserDatabase (-> .open() -> o.a.c.users.MemoryUserCreationFactory) prefers "username". org.a

[Bug 56518] NIO async servlet limit latch leak

2014-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56518 --- Comment #15 from Konstantin Kolinko --- (In reply to Mark Thomas from comment #14) > > I am leaning towards closing the > connection if Tomcat detects an interrupt since that is what would happen if > the thread was allowed to continue

svn commit: r1601850 - in /tomcat/trunk/java/org/apache/catalina/connector: LocalStrings.properties Request.java

2014-06-11 Thread violetagg
Author: violetagg Date: Wed Jun 11 11:09:38 2014 New Revision: 1601850 URL: http://svn.apache.org/r1601850 Log: Use StringManager for the async not supported message. Modified: tomcat/trunk/java/org/apache/catalina/connector/LocalStrings.properties tomcat/trunk/java/org/apache/catalina/co

svn commit: r1601852 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/connector/LocalStrings.properties java/org/apache/catalina/connector/Request.java

2014-06-11 Thread violetagg
Author: violetagg Date: Wed Jun 11 11:13:35 2014 New Revision: 1601852 URL: http://svn.apache.org/r1601852 Log: Merged revision 1601850 from tomcat/trunk: Use StringManager for the async not supported message. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/or

Re: svn commit: r1601796 - in /tomcat/trunk: java/org/apache/catalina/connector/Request.java webapps/docs/changelog.xml

2014-06-11 Thread Violeta Georgieva
2014-06-11 13:27 GMT+03:00 Mark Thomas : > > On 11/06/2014 02:49, violet...@apache.org wrote: > > Author: violetagg > > Date: Wed Jun 11 01:49:21 2014 > > New Revision: 1601796 > > > > URL: http://svn.apache.org/r1601796 > > Log: > > Provide a better error message when asynchronous operations are n

svn commit: r1601855 - /tomcat/trunk/java/org/apache/catalina/realm/package.html

2014-06-11 Thread kkolinko
Author: kkolinko Date: Wed Jun 11 11:19:45 2014 New Revision: 1601855 URL: http://svn.apache.org/r1601855 Log: Remove obsolete documentation from realm package javadoc. The text is something very old that talks about "debug" attribute and that there are two standard realms, JDBCRealm and MemoryRe

svn commit: r1601856 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/realm/package.html

2014-06-11 Thread kkolinko
Author: kkolinko Date: Wed Jun 11 11:22:38 2014 New Revision: 1601856 URL: http://svn.apache.org/r1601856 Log: Remove obsolete documentation from realm package javadoc. The text is something very old that talks about "debug" attribute and that there are two standard realms, JDBCRealm and MemoryRe

svn commit: r1601857 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/realm/package.html

2014-06-11 Thread kkolinko
Author: kkolinko Date: Wed Jun 11 11:24:41 2014 New Revision: 1601857 URL: http://svn.apache.org/r1601857 Log: CTR: docs Remove obsolete documentation from realm package javadoc. The text is something very old that talks about "debug" attribute and that there are two standard realms, JDBCRealm an

svn commit: r1601886 - in /tomcat/trunk: java/org/apache/catalina/realm/MemoryRuleSet.java webapps/docs/changelog.xml webapps/docs/config/realm.xml

2014-06-11 Thread kkolinko
Author: kkolinko Date: Wed Jun 11 13:23:18 2014 New Revision: 1601886 URL: http://svn.apache.org/r1601886 Log: Further fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=56606 Update documentation for MemoryRealm. Align MemoryUserRule class (in MemoryRuleSet.java) with MemoryUserCreationF

svn commit: r1601887 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/realm/MemoryRuleSet.java webapps/docs/changelog.xml webapps/docs/config/realm.xml

2014-06-11 Thread kkolinko
Author: kkolinko Date: Wed Jun 11 13:26:32 2014 New Revision: 1601887 URL: http://svn.apache.org/r1601887 Log: Further fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=56606 Update documentation for MemoryRealm. Align MemoryUserRule class (in MemoryRuleSet.java) with MemoryUserCreationF

svn commit: r1601892 - /tomcat/tc6.0.x/trunk/webapps/docs/config/realm.xml

2014-06-11 Thread kkolinko
Author: kkolinko Date: Wed Jun 11 13:35:31 2014 New Revision: 1601892 URL: http://svn.apache.org/r1601892 Log: CTR: docs. https://issues.apache.org/bugzilla/show_bug.cgi?id=56606 Update documentation for MemoryRealm to recommend the "username" attribute. It is partial backport of r1601886 from tom

[Bug 56606] Tomcat Installer: old attribute generated in tomcat-users.xml instead of the new one

2014-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56606 --- Comment #3 from Konstantin Kolinko --- (In reply to Konstantin Kolinko from comment #2) > > I agree that "username" is the preferred name, as MemoryUserDatabase.save() > (-> MemoryUser.toXml()) uses it when saving the file. The other >

svn propchange: r1601785 - svn:log

2014-06-11 Thread kkolinko
Author: kkolinko Revision: 1601785 Modified property: svn:log Modified: svn:log at Wed Jun 11 13:54:15 2014 -- --- svn:log (original) +++ svn:log Wed Jun 11 13:54:15 2014 @@ -1,3 +1,4 @@ +Fix https://issues.apache.org/bugz

buildbot failure in ASF Buildbot on tomcat-7-trunk

2014-06-11 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/108 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1601909 - /tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/Parser.java

2014-06-11 Thread kkolinko
Author: kkolinko Date: Wed Jun 11 14:24:10 2014 New Revision: 1601909 URL: http://svn.apache.org/r1601909 Log: Code cleanup: use if/elseif for alternative branches. Discussed in "Re:r1601787" thread. It is partial backport of r1543356. Modified: tomcat/tc7.0.x/trunk/java/org/apache/jasper/co

buildbot success in ASF Buildbot on tomcat-7-trunk

2014-06-11 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/109 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Sou

svn commit: r1601924 - in /tomcat/trunk: java/org/apache/jasper/compiler/JspReader.java java/org/apache/jasper/compiler/Parser.java webapps/docs/changelog.xml

2014-06-11 Thread kkolinko
Author: kkolinko Date: Wed Jun 11 15:23:25 2014 New Revision: 1601924 URL: http://svn.apache.org/r1601924 Log: Move code that parses EL expressions within JSP template text from Parser to JspReader class. This is done to get access to JspReader.nextChar(mark) to avoid calling reader.mark() in a

svn commit: r1601934 - in /tomcat/tc7.0.x/trunk: java/org/apache/jasper/compiler/JspReader.java java/org/apache/jasper/compiler/Parser.java webapps/docs/changelog.xml

2014-06-11 Thread kkolinko
Author: kkolinko Date: Wed Jun 11 15:48:17 2014 New Revision: 1601934 URL: http://svn.apache.org/r1601934 Log: Move code that parses EL expressions within JSP template text from Parser to JspReader class. This is done to get access to JspReader.nextChar(mark) to avoid calling reader.mark() in a

buildbot failure in ASF Buildbot on tomcat-trunk

2014-06-11 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/164 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Sta

buildbot failure in ASF Buildbot on tomcat-7-trunk

2014-06-11 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/110 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1601951 - /tomcat/tc6.0.x/trunk/STATUS.txt

2014-06-11 Thread kkolinko
Author: kkolinko Date: Wed Jun 11 16:53:03 2014 New Revision: 1601951 URL: http://svn.apache.org/r1601951 Log: Propose additional patch. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=

svn commit: r1601968 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/servlets/WebdavServlet.java webapps/docs/changelog.xml

2014-06-11 Thread kkolinko
Author: kkolinko Date: Wed Jun 11 17:35:36 2014 New Revision: 1601968 URL: http://svn.apache.org/r1601968 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56600 Fix missing "return;" statements after sendError(): do not waste time generating response for PROPFIND requests that contain b

[Bug 56600] Missing "return" statements in WebdavServlet.doPropfind()

2014-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56600 --- Comment #2 from Konstantin Kolinko --- Fixed in Tomcat 6 (r1601968), will be in 6.0.42 onwards. -- You are receiving this mail because: You are the assignee for the bug. ---

svn commit: r1601977 - /tomcat/trunk/java/org/apache/coyote/Adapter.java

2014-06-11 Thread markt
Author: markt Date: Wed Jun 11 18:18:08 2014 New Revision: 1601977 URL: http://svn.apache.org/r1601977 Log: Fix comment typo and other clean-up Modified: tomcat/trunk/java/org/apache/coyote/Adapter.java Modified: tomcat/trunk/java/org/apache/coyote/Adapter.java URL: http://svn.apache.org/vi

svn commit: r1602018 - in /tomcat/tc6.0.x/trunk: STATUS.txt bin/catalina-tasks.xml webapps/docs/changelog.xml

2014-06-11 Thread kkolinko
Author: kkolinko Date: Wed Jun 11 21:22:06 2014 New Revision: 1602018 URL: http://svn.apache.org/r1602018 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56560 Fix NoClassDefFoundError when using Jasper Ant task. Patch provided by M.Gemmell. Modified: tomcat/tc6.0.x/trunk/STATUS.t

[Bug 56560] Jasper ant task fails with java.lang.NoClassDefFoundError: org.apache.tomcat.util.descriptor.LocalResolver

2014-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56560 Konstantin Kolinko changed: What|Removed |Added Status|NEW |RESOLVED Resolution|-

svn commit: r1602027 - in /tomcat/trunk/test/org/apache/jasper: TestJspCompilationContext.java TestJspCpompilationContext.java

2014-06-11 Thread kkolinko
Author: kkolinko Date: Wed Jun 11 21:47:03 2014 New Revision: 1602027 URL: http://svn.apache.org/r1602027 Log: Correct typo in the name of a test class Added: tomcat/trunk/test/org/apache/jasper/TestJspCompilationContext.java - copied, changed from r1601960, tomcat/trunk/test/org/apach

buildbot success in ASF Buildbot on tomcat-trunk

2014-06-11 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/166 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1602046 - in /tomcat/trunk/test: org/apache/jasper/compiler/TestGenerator.java webapp/bug5nnnn/bug56581.jsp

2014-06-11 Thread kkolinko
Author: kkolinko Date: Wed Jun 11 22:55:01 2014 New Revision: 1602046 URL: http://svn.apache.org/r1602046 Log: https://issues.apache.org/bugzilla/show_bug.cgi?id=56581 Add test case for bug 56581. It tests exception handling for committed responses. Added: tomcat/trunk/test/webapp/bug5/bu

[Bug 56613] New: JSP COMPILATION ERROR ON TOMCAT 6 & 7 with JDK VERSION 1.8.0_20-ea

2014-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56613 Bug ID: 56613 Summary: JSP COMPILATION ERROR ON TOMCAT 6 & 7 with JDK VERSION 1.8.0_20-ea Product: Tomcat 7 Version: unspecified Hardware: PC Status: NEW