[Bug 55553] New: Proposal: Allow org.apache.catalina.valves.RemoteIpValve to set requests as secure with a transparent SSL termination proxy

2013-09-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=3 Bug ID: 3 Summary: Proposal: Allow org.apache.catalina.valves.RemoteIpValve to set requests as secure with a transparent SSL termination proxy

Tomcat 7 build is broken on a local PC

2013-09-12 Thread Violeta Georgieva
Hi, Although I can see that the central build is OK, I cannot build tomcat 7 trunk. The new class org.apache.tomcat.util.buf.Utf8Encoder uses java.nio.charset.StandardCharsets which is available only in java 7. Do you have such problems? Thanks Violeta

Re: Tomcat 7 build is broken on a local PC

2013-09-12 Thread Mark Thomas
On 12/09/2013 08:55, Violeta Georgieva wrote: > Hi, > > Although I can see that the central build is OK, I cannot build tomcat 7 > trunk. > > The new class org.apache.tomcat.util.buf.Utf8Encoder > uses java.nio.charset.StandardCharsets which is available only in java 7. > > Do you have such prob

Re: Tomcat 7 build is broken on a local PC

2013-09-12 Thread Mark Thomas
On 12/09/2013 09:00, Mark Thomas wrote: > On 12/09/2013 08:55, Violeta Georgieva wrote: >> Hi, >> >> Although I can see that the central build is OK, I cannot build tomcat 7 >> trunk. >> >> The new class org.apache.tomcat.util.buf.Utf8Encoder >> uses java.nio.charset.StandardCharsets which is avail

svn commit: r1522491 - /tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/buf/Utf8Encoder.java

2013-09-12 Thread markt
Author: markt Date: Thu Sep 12 08:55:00 2013 New Revision: 1522491 URL: http://svn.apache.org/r1522491 Log: Remove Java 7 dependency that was missed in back-port Modified: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/buf/Utf8Encoder.java Modified: tomcat/tc7.0.x/trunk/java/org/apache/tom

svn commit: r1522492 - /tomcat/tc7.0.x/trunk/build.xml

2013-09-12 Thread markt
Author: markt Date: Thu Sep 12 08:56:49 2013 New Revision: 1522492 URL: http://svn.apache.org/r1522492 Log: Ensure that only the web socket implementation classes are compiled with Java 7. This is done by making sure everything else is compiled first with Java 6. Modified: tomcat/tc7.0.x/tru

[Bug 55553] Proposal: Allow org.apache.catalina.valves.RemoteIpValve to set requests as secure with a transparent SSL termination proxy

2013-09-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=3 Mark Thomas changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1 from Mark Th

svn commit: r1522501 - /tomcat/trunk/java/org/apache/catalina/session/mbeans-descriptors.xml

2013-09-12 Thread kfujino
Author: kfujino Date: Thu Sep 12 09:28:53 2013 New Revision: 1522501 URL: http://svn.apache.org/r1522501 Log: The loaded attribute never exists in PersistentManager. isLoaded is defined as operation in mbeans-descriptors. Modified: tomcat/trunk/java/org/apache/catalina/session/mbeans-descri

svn commit: r1522502 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/session/mbeans-descriptors.xml webapps/docs/changelog.xml

2013-09-12 Thread kfujino
Author: kfujino Date: Thu Sep 12 09:34:02 2013 New Revision: 1522502 URL: http://svn.apache.org/r1522502 Log: The loaded attribute never exists in PersistentManager. isLoaded is defined as operation in mbeans-descriptors. Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/session/mbean

svn commit: r1522504 - /tomcat/trunk/java/org/apache/jasper/compiler/JspUtil.java

2013-09-12 Thread markt
Author: markt Date: Thu Sep 12 09:38:10 2013 New Revision: 1522504 URL: http://svn.apache.org/r1522504 Log: Fix some Javadoc Modified: tomcat/trunk/java/org/apache/jasper/compiler/JspUtil.java Modified: tomcat/trunk/java/org/apache/jasper/compiler/JspUtil.java URL: http://svn.apache.org/vie

svn commit: r1522505 - /tomcat/trunk/java/org/apache/jasper/runtime/JspRuntimeLibrary.java

2013-09-12 Thread markt
Author: markt Date: Thu Sep 12 09:39:15 2013 New Revision: 1522505 URL: http://svn.apache.org/r1522505 Log: Remove unused code. Modified: tomcat/trunk/java/org/apache/jasper/runtime/JspRuntimeLibrary.java Modified: tomcat/trunk/java/org/apache/jasper/runtime/JspRuntimeLibrary.java URL: http

svn commit: r1522512 - /tomcat/trunk/java/org/apache/jasper/compiler/JspUtil.java

2013-09-12 Thread markt
Author: markt Date: Thu Sep 12 10:06:16 2013 New Revision: 1522512 URL: http://svn.apache.org/r1522512 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=2 Separate the return type (which must be an object) from the expected type which may be a primitive. This is necessary for EL 3.0

[Bug 55553] Proposal: Allow org.apache.catalina.valves.RemoteIpValve to set requests as secure with a transparent SSL termination proxy

2013-09-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=3 --- Comment #2 from Knut Ytterhaug --- We need our tomcats to be able to serve the same content both on http and https and would like our applications to be able to use request.isSecure() to handle redirects etc accordingly. -- You are re

[Bug 55552] Potential NullPointerException in compiled JSPs if expected EL result is of primitive type

2013-09-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=2 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 55553] Proposal: Allow org.apache.catalina.valves.RemoteIpValve to set requests as secure with a transparent SSL termination proxy

2013-09-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=3 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|---

[Bug 55553] Proposal: Allow org.apache.catalina.valves.RemoteIpValve to set requests as secure with a transparent SSL termination proxy

2013-09-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=3 --- Comment #4 from Knut Ytterhaug --- Thanks for the quick answers. Unfortunately (for us) we're unable to configure using different connectors depending on if it's been processed or not. Would a patch adding a boolean property making the

[Bug 55553] Proposal: Allow org.apache.catalina.valves.RemoteIpValve to set requests as secure with a transparent SSL termination proxy

2013-09-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=3 --- Comment #5 from Mark Thomas --- (In reply to Knut Ytterhaug from comment #4) > Thanks for the quick answers. Unfortunately (for us) we're unable to > configure using different connectors depending on if it's been processed or > not. > >

svn commit: r1522526 - in /tomcat/trunk: java/org/apache/catalina/valves/CometConnectionManagerValve.java webapps/docs/changelog.xml

2013-09-12 Thread markt
Author: markt Date: Thu Sep 12 11:16:15 2013 New Revision: 1522526 URL: http://svn.apache.org/r1522526 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52558 Refactor CometConnectionManagerValve so that it does not prevent the session from being serialized in when running in a cluster.

[Bug 52558] CometConnectionManagerValve is adding non-serializable Request[] to Session

2013-09-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52558 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Component|Catalina

svn commit: r1522563 - /tomcat/trunk/java/org/apache/catalina/connector/Request.java

2013-09-12 Thread markt
Author: markt Date: Thu Sep 12 13:15:38 2013 New Revision: 1522563 URL: http://svn.apache.org/r1522563 Log: Apply clarification from the Servlet EG. Attempting to parse parts when no multi-part configuration has been provided will trigger an ISE. Modified: tomcat/trunk/java/org/apache/catali

svn commit: r1522576 - in /tomcat/trunk/java: javax/servlet/http/HttpServletRequest.java org/apache/catalina/connector/LocalStrings.properties

2013-09-12 Thread markt
Author: markt Date: Thu Sep 12 13:40:46 2013 New Revision: 1522576 URL: http://svn.apache.org/r1522576 Log: Apply clarification from the Servlet EG. Attempting to parse parts when no multi-part configuration has been provided will trigger an ISE. Modified: tomcat/trunk/java/javax/servlet/htt

buildbot failure in ASF Buildbot on tomcat-trunk

2013-09-12 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4956 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source St

svn commit: r1522587 - /tomcat/trunk/java/org/apache/catalina/connector/Request.java

2013-09-12 Thread markt
Author: markt Date: Thu Sep 12 14:14:15 2013 New Revision: 1522587 URL: http://svn.apache.org/r1522587 Log: Be consistent about how secure is accessed Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java

[Bug 53602] Support for HTTP status code 451

2013-09-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53602 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1522594 - /tomcat/trunk/test/org/apache/catalina/core/TestStandardContext.java

2013-09-12 Thread markt
Author: markt Date: Thu Sep 12 14:25:31 2013 New Revision: 1522594 URL: http://svn.apache.org/r1522594 Log: Update unit tests to align with changes in part parsing without configuration (now throws ISE) Modified: tomcat/trunk/test/org/apache/catalina/core/TestStandardContext.java Modified:

[Bug 55383] Improve markup and design of Tomcat's HTML pages

2013-09-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55383 --- Comment #42 from Konstantin Preißer --- Created attachment 30824 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30824&action=edit Updated Tomcat Site XMLs Hi, this patch improves the markup in the Tomcat Site XMLs. After a

buildbot success in ASF Buildbot on tomcat-trunk

2013-09-12 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4958 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1522615 - /tomcat/trunk/webapps/docs/changelog.xml

2013-09-12 Thread markt
Author: markt Date: Thu Sep 12 15:26:00 2013 New Revision: 1522615 URL: http://svn.apache.org/r1522615 Log: Fix trailing whitespace Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs

Where to put a helper class for test?

2013-09-12 Thread Nick Williams
Mark, I'm working on revisions to my patch for BZ 55317 based on your feedback. In this feedback you said: > 5. I'm not a fan of the org.apache.tomcat.unittest package unless the classes > concerned are going to be used by multiple tests across multiple packages. I put org.apache.tomcat.unitte

[Bug 55554] New: NoSuchMethodError on ConcurrentHashMap$KeySetView

2013-09-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=4 Bug ID: 4 Summary: NoSuchMethodError on ConcurrentHashMap$KeySetView Product: Tomcat 8 Version: trunk Hardware: PC OS: Linux Status: NEW Severit

[Bug 55554] NoSuchMethodError on ConcurrentHashMap$KeySetView

2013-09-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=4 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: Where to put a helper class for test?

2013-09-12 Thread Mark Thomas
On 12/09/2013 18:31, Nick Williams wrote: > Mark, > > I'm working on revisions to my patch for BZ 55317 based on your > feedback. In this feedback you said: > >> 5. I'm not a fan of the org.apache.tomcat.unittest package unless >> the classes concerned are going to be used by multiple tests acros

Re: Where to put a helper class for test?

2013-09-12 Thread Nick Williams
On Sep 12, 2013, at 1:03 PM, Mark Thomas wrote: > On 12/09/2013 18:31, Nick Williams wrote: >> Mark, >> >> I'm working on revisions to my patch for BZ 55317 based on your >> feedback. In this feedback you said: >> >>> 5. I'm not a fan of the org.apache.tomcat.unittest package unless >>> the cla

svn commit: r1522696 - /tomcat/trunk/java/org/apache/catalina/webresources/JarResource.java

2013-09-12 Thread markt
Author: markt Date: Thu Sep 12 19:01:27 2013 New Revision: 1522696 URL: http://svn.apache.org/r1522696 Log: Fix indent Modified: tomcat/trunk/java/org/apache/catalina/webresources/JarResource.java Modified: tomcat/trunk/java/org/apache/catalina/webresources/JarResource.java URL: http://svn.

[Bug 55554] NoSuchMethodError on ConcurrentHashMap$KeySetView

2013-09-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=4 rstoyanc...@yahoo.com changed: What|Removed |Added Resolution|INVALID |FIXED --- Comment #2 from r

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-09-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 Nick Williams changed: What|Removed |Added Attachment #30749|0 |1 is obsolete|

Re: Where to put a helper class for test?

2013-09-12 Thread Christopher Schultz
Nick, On 9/12/13 2:12 PM, Nick Williams wrote: > > On Sep 12, 2013, at 1:03 PM, Mark Thomas wrote: > >> On 12/09/2013 18:31, Nick Williams wrote: >>> Mark, >>> >>> I'm working on revisions to my patch for BZ 55317 based on your >>> feedback. In this feedback you said: >>> 5. I'm not a fan o

[Bug 55554] NoSuchMethodError on ConcurrentHashMap$KeySetView

2013-09-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=4 Christopher Schultz changed: What|Removed |Added Resolution|FIXED |INVALID --- Comment #3 from

svn commit: r1522704 - in /tomcat/trunk/java/org/apache/catalina/loader: WebappClassLoader.java WebappLoader.java

2013-09-12 Thread markt
Author: markt Date: Thu Sep 12 19:48:57 2013 New Revision: 1522704 URL: http://svn.apache.org/r1522704 Log: More resources refactoring. Remove the need to extract the classes into the work dir. Modified: tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java tomcat/trunk/jav

Re: [Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-09-12 Thread Nick Williams
On Aug 29, 2013, at 4:28 AM, bugzi...@apache.org wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 > > --- Comment #16 from Mark Thomas --- > (In reply to Nick Williams from comment #15) >> Created attachment 30749 [details] >> Proposed implementation of this feature > > 1. Why