HI Mark,
nice fix :-) Thanks!
Why the testcase at NBReadServlet must called the "listener.onDataAvailable();"?
I read the 3.1 spec and think the container must call onDataAvailable and
we do that at CoyoteAdapter.
§3.7 P 3.28
■ onDataAvailable(). The onDataAvailable method is invoked on the
Re
On 15/08/2013 08:53, Peter Rossbach wrote:
> HI Mark,
>
> nice fix :-) Thanks!
>
> Why the testcase at NBReadServlet must called the
> "listener.onDataAvailable();"?
https://issues.apache.org/bugzilla/show_bug.cgi?id=55381
> I read the 3.1 spec and think the container must call onDataAvailable
On 15/08/2013 00:02, David Blevins wrote:
>
> On Aug 14, 2013, at 2:25 AM, Arjan Tijms wrote:
>
>> markt wrote
>>> No-one said it would be difficult. TomEE has already done it. We'd just
>>> need to lift the code. Difficulty really doesn't come into it. If there
>>> is a demand for it, it will g
https://issues.apache.org/bugzilla/show_bug.cgi?id=55282
--- Comment #6 from Oleksii ---
I have encountered the same problem when used a workoaround solution for a SEAM
project (https://issues.jboss.org/browse/JBSEAM-4401). I need the
ConfigureListener to be invoked before the SeamListener.
Duri
Hi,
On Thursday, August 15, 2013, markt [via Tomcat] wrote:
> On 15/08/2013 00:02, David Blevins wrote:
>
> > If you wanted to roll up your sleeves, we'd be more than happy to see it
> ported or reimplemented in TomEE.
>
> or Tomcat :)
Definitely!
I'll also try to contact the guys who said to
Author: markt
Date: Thu Aug 15 10:32:15 2013
New Revision: 1514228
URL: http://svn.apache.org/r1514228
Log:
The container is responsible for the first call to each of onWritePossible()
and onDataAvailable() once a listener has been set.
Main component is the addition to the SocketWrapper of a lis
On 15/08/2013 11:32, ma...@apache.org wrote:
> Author: markt
> Date: Thu Aug 15 10:32:15 2013
> New Revision: 1514228
>
> URL: http://svn.apache.org/r1514228
> Log:
> The container is responsible for the first call to each of onWritePossible()
> and onDataAvailable() once a listener has been set.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55282
Oleksii changed:
What|Removed |Added
CC||o...@ciklum.com
--
You are receiving th
https://issues.apache.org/bugzilla/show_bug.cgi?id=55282
--- Comment #7 from Oleksii ---
For now I applied the following workaround. I have added the jsf-impl.jar to
the property "tomcat.util.scan.DefaultJarScanner.jarsToSkip" of the
TOMCAT\conf\catalina.properties. As a result my application sta
https://issues.apache.org/bugzilla/show_bug.cgi?id=55282
Oleksii changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|INVALID
https://issues.apache.org/bugzilla/show_bug.cgi?id=55282
Mark Thomas changed:
What|Removed |Added
Status|REOPENED|RESOLVED
Resolution|---
Author: markt
Date: Thu Aug 15 11:31:03 2013
New Revision: 1514237
URL: http://svn.apache.org/r1514237
Log:
Partial fix for BZ 55381 and OSX
Modified:
tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java
Modified:
tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11P
Author: markt
Date: Thu Aug 15 11:45:36 2013
New Revision: 1514239
URL: http://svn.apache.org/r1514239
Log:
Fix non-blocking test failures on OSX when using APR.
Modified:
tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java
tomcat/trunk/java/org/apache/coyote/http11/In
https://issues.apache.org/bugzilla/show_bug.cgi?id=55381
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://issues.apache.org/bugzilla/show_bug.cgi?id=55398
Mark Thomas changed:
What|Removed |Added
Status|NEEDINFO|RESOLVED
Resolution|---
The Buildbot has detected a new failure on builder tomcat-trunk while building
ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/4831
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build Source St
The Buildbot has detected a restored build on builder tomcat-trunk while
building ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/4832
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build Source
https://issues.apache.org/bugzilla/show_bug.cgi?id=55399
Mark Thomas changed:
What|Removed |Added
Status|NEEDINFO|NEW
--- Comment #5 from Mark Thomas
Author: violetagg
Date: Thu Aug 15 14:06:20 2013
New Revision: 1514281
URL: http://svn.apache.org/r1514281
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55357
Set the web app classloader as a context classloader before reading the object
data.
Modified:
tomcat/trunk/java/org/ap
Author: markt
Date: Thu Aug 15 14:25:30 2013
New Revision: 1514291
URL: http://svn.apache.org/r1514291
Log:
Refactor to reduce code duplication
Modified:
tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java
tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java
Author: markt
Date: Thu Aug 15 14:47:20 2013
New Revision: 1514305
URL: http://svn.apache.org/r1514305
Log:
Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=55399
Base i18n of error reports on request locale rather than default server local.
Modified:
tomcat/trunk/java/org/a
Hi Mark,
I test the current fix with my simple example at OSX (NIO) and now it works.
Many thanks,
Peter
Am 15.08.2013 um 12:40 schrieb Mark Thomas :
> On 15/08/2013 11:32, ma...@apache.org wrote:
>> Author: markt
>> Date: Thu Aug 15 10:32:15 2013
>> New Revision: 1514228
>>
>> URL: http://svn
The Buildbot has detected a new failure on builder tomcat-trunk while building
ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/4833
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build Source St
The Buildbot has detected a restored build on builder tomcat-trunk while
building ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/4834
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build Source
Author: markt
Date: Thu Aug 15 16:56:01 2013
New Revision: 1514368
URL: http://svn.apache.org/r1514368
Log:
Fix issue reported on users list.
Because the default bundle reports as the ROOT locale rather than as ENGLISH,
the request locale to resource bundle mapping failed.
Modified:
tomcat/t
Author: markt
Date: Thu Aug 15 17:02:48 2013
New Revision: 1514376
URL: http://svn.apache.org/r1514376
Log:
Fix issue reported on users list.
Because the default bundle reports as the ROOT locale rather than as ENGLISH,
the request locale to resource bundle mapping failed.
Modified:
tomcat/t
Author: markt
Date: Thu Aug 15 17:05:57 2013
New Revision: 1514380
URL: http://svn.apache.org/r1514380
Log:
Proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1514380&r1=1514379&r
Author: markt
Date: Thu Aug 15 17:06:21 2013
New Revision: 1514381
URL: http://svn.apache.org/r1514381
Log:
Fix copy/paste
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1514381&r1=151
On Aug 15, 2013, at 1:07 AM, Mark Thomas wrote:
>> If you wanted to roll up your sleeves, we'd be more than happy to see it
>> ported or reimplemented in TomEE.
>
> or Tomcat :)
Even better!
-David
-
To unsubscribe, e-mail
Author: markt
Date: Thu Aug 15 19:19:59 2013
New Revision: 1514447
URL: http://svn.apache.org/r1514447
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55314
Provide a container specific extension to the WsServerContainer to allow
frameworks to more easily diaptch requests to WebSocket
https://issues.apache.org/bugzilla/show_bug.cgi?id=55314
Mark Thomas changed:
What|Removed |Added
Status|REOPENED|RESOLVED
Resolution|---
https://issues.apache.org/bugzilla/show_bug.cgi?id=55399
--- Comment #6 from Mark Thomas ---
The error pages were simple to fix but fixing the HTTP response status line is
going to be more invasive. That part may end up being Tomcat 8 only because of
the internal changes required.
--
You are re
On 14.08.2013 12:41, Mark Thomas wrote:
> Summarising the response to this thread so far:
>
> There is a preference for not strictly enforcing whatever limit is
> selected. Rules need exceptions and committers can exercise judgement.
> It does create a grey area but the majority is OK with that.
>
Author: markt
Date: Thu Aug 15 19:32:09 2013
New Revision: 1514454
URL: http://svn.apache.org/r1514454
Log:
Follow-up to r1514447. Need to invert the test after the refactoring.
Modified:
tomcat/trunk/java/org/apache/tomcat/websocket/server/WsFilter.java
Modified: tomcat/trunk/java/org/apach
Author: violetagg
Date: Thu Aug 15 19:37:45 2013
New Revision: 1514455
URL: http://svn.apache.org/r1514455
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55357
Merged revision 1514281 from tomcat/trunk:
Set the web app classloader as a context classloader before reading the object
da
https://issues.apache.org/bugzilla/show_bug.cgi?id=55357
Violeta Georgieva changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|--
The Buildbot has detected a new failure on builder tomcat-trunk while building
ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/4836
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build Source St
Author: violetagg
Date: Thu Aug 15 20:31:48 2013
New Revision: 1514470
URL: http://svn.apache.org/r1514470
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55354
Restore the context environment parameters after associating the Principle with
the given user. Based on patch provided by R
Author: markt
Date: Thu Aug 15 20:51:38 2013
New Revision: 1514485
URL: http://svn.apache.org/r1514485
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55399
Have the message in the response line use the locale set for the response.
Modified:
tomcat/trunk/java/org/apache/coyote/ajp
Author: markt
Date: Thu Aug 15 20:52:13 2013
New Revision: 1514486
URL: http://svn.apache.org/r1514486
Log:
Have error page status message language consistent with content.
Modified:
tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java
Modified: tomcat/trunk/java/org/apache/cat
Author: markt
Date: Thu Aug 15 21:11:58 2013
New Revision: 1514496
URL: http://svn.apache.org/r1514496
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55399
Have the message in the response line use the locale set for the response.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
https://issues.apache.org/bugzilla/show_bug.cgi?id=55399
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Author: markt
Date: Thu Aug 15 21:31:50 2013
New Revision: 1514505
URL: http://svn.apache.org/r1514505
Log:
Start to back-port JSR-356 implementation to 7.0.x
Added:
tomcat/tc7.0.x/trunk/java/javax/websocket/
- copied from r1412268, tomcat/trunk/java/javax/websocket/
Modified:
tomca
Hi
how will it be backported?
i ask because in tomee we can't provide it out of the box since we need to
be certified against JavaEE 6 Web Profile which doesn't contain it (that's
why we have several distribution and not only the "plus" one).
If it is backported in tomcat without a spi or anothe
Author: markt
Date: Thu Aug 15 21:46:11 2013
New Revision: 1514510
URL: http://svn.apache.org/r1514510
Log:
Revert 1514505. On reflection, an svn copy is a better way to do this as it
makes the history easier to read.
Removed:
tomcat/tc7.0.x/trunk/java/javax/websocket/
Modified:
tomcat/t
On 15/08/2013 22:34, Romain Manni-Bucau wrote:
> Hi
>
> how will it be backported?
It will be a straight copy from trunk with the minimal modifications
necessary to get it to work including:
- No Java 7 notation
- No Servlet 3.1 APIs
- Any updates to Tomcat's internals to make HTTP upgrade compat
Author: markt
Date: Thu Aug 15 21:58:39 2013
New Revision: 1514511
URL: http://svn.apache.org/r1514511
Log:
Fix ordering. Remove deleted package.
Modified:
tomcat/trunk/res/checkstyle/javax-import-control.xml
Modified: tomcat/trunk/res/checkstyle/javax-import-control.xml
URL:
http://svn.apa
The Buildbot has detected a restored build on builder tomcat-trunk while
building ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/4838
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build Source
This isn't going to be quite as simple as I first thought.
The WebSocket client API requires Java SE 7 or later.
The WebSocket server API requires Java EE 6 or later.
Java EE 6 requires Java 6 or later.
The WebSocket server API depends on the WebSocket client API.
The WebSocket client implementat
Author: markt
Date: Thu Aug 15 22:49:12 2013
New Revision: 1514522
URL: http://svn.apache.org/r1514522
Log:
Add structure to receive WebSocket backport from trunk
Added:
tomcat/tc7.0.x/trunk/modules/websocket/
tomcat/tc7.0.x/trunk/modules/websocket/java/
tomcat/tc7.0.x/trunk/modules/w
Author: markt
Date: Thu Aug 15 22:53:11 2013
New Revision: 1514525
URL: http://svn.apache.org/r1514525
Log:
Copy JSR-356 WebSocket API and implementation from trunk into new Tomcat 7
module
Added:
tomcat/tc7.0.x/trunk/modules/websocket/java/javax/websocket/
- copied from r1514523, tomc
Author: markt
Date: Thu Aug 15 23:06:10 2013
New Revision: 1514533
URL: http://svn.apache.org/r1514533
Log:
Make method public so WebSocket module can use it
Modified:
tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/net/TesterSupport.java
Modified:
tomcat/tc7.0.x/trunk/test/org/apache/tomc
Author: markt
Date: Thu Aug 15 23:07:50 2013
New Revision: 1514534
URL: http://svn.apache.org/r1514534
Log:
Ignore some Eclipse files
Modified:
tomcat/tc7.0.x/trunk/modules/websocket/ (props changed)
Propchange: tomcat/tc7.0.x/trunk/modules/websocket/
--
https://issues.apache.org/bugzilla/show_bug.cgi?id=55383
--- Comment #5 from Konstantin Preißer ---
Created attachment 30735
--> https://issues.apache.org/bugzilla/attachment.cgi?id=30735&action=edit
Draft for improved HTML markup of Tomcat Docs
Hi,
as I did not receive negative comments, I t
Author: markt
Date: Thu Aug 15 23:09:06 2013
New Revision: 1514535
URL: http://svn.apache.org/r1514535
Log:
Start with the easy compilation fixes. Tomcat 7 hasn't refactored web.xml
parsing so change ApplicationListener import to pre-refactoring location.
Modified:
tomcat/tc7.0.x/trunk/modu
The Buildbot has detected a new failure on builder tomcat-trunk while building
ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/4839
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build Source St
Mark,
On 8/14/13 6:41 AM, Mark Thomas wrote:
> Summarising the response to this thread so far:
>
> There is a preference for not strictly enforcing whatever limit is
> selected. Rules need exceptions and committers can exercise judgement.
> It does create a grey area but the majority is OK with t
On Aug 15, 2013, at 5:47 PM, Mark Thomas wrote:
> This isn't going to be quite as simple as I first thought.
>
> The WebSocket client API requires Java SE 7 or later.
> The WebSocket server API requires Java EE 6 or later.
> Java EE 6 requires Java 6 or later.
> The WebSocket server API depends
Mark,
On 8/15/13 6:47 PM, Mark Thomas wrote:
> This isn't going to be quite as simple as I first thought.
>
> The WebSocket client API requires Java SE 7 or later.
> The WebSocket server API requires Java EE 6 or later.
> Java EE 6 requires Java 6 or later.
Clarification: are you saying that Jav
2013/8/14 Mark Thomas wrote:
>
> Summarising the response to this thread so far:
>
> There is a preference for not strictly enforcing whatever limit is
> selected. Rules need exceptions and committers can exercise judgement.
> It does create a grey area but the majority is OK with that.
>
> There i
Great, thanks Mark.
Le 15 août 2013 23:56, "Mark Thomas" a écrit :
> On 15/08/2013 22:34, Romain Manni-Bucau wrote:
> > Hi
> >
> > how will it be backported?
>
> It will be a straight copy from trunk with the minimal modifications
> necessary to get it to work including:
> - No Java 7 notation
>
On Fri, Aug 16, 2013 at 4:34 AM, Christopher Schultz <
ch...@christopherschultz.net> wrote:
> Mark,
>
> On 8/15/13 6:47 PM, Mark Thomas wrote:
> > This isn't going to be quite as simple as I first thought.
> >
> > The WebSocket client API requires Java SE 7 or later.
> > The WebSocket server API r
Author: jboynes
Date: Fri Aug 16 05:55:40 2013
New Revision: 1514588
URL: http://svn.apache.org/r1514588
Log:
Finish converting TLD parsing to using Digester.
TldParser now handles all TLD content required by Jasper rather than the
minimum needed for listener scanning.
Added test TLD files outsi
Author: violetagg
Date: Fri Aug 16 05:58:50 2013
New Revision: 1514589
URL: http://svn.apache.org/r1514589
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55354
Merged revision 1514470 from tomcat/trunk:
Restore the context environment parameters after associating the Principle with
t
https://issues.apache.org/bugzilla/show_bug.cgi?id=55354
Violeta Georgieva changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|--
Christopher Schultz wrote:
>Mark,
>
>On 8/15/13 6:47 PM, Mark Thomas wrote:
>> This isn't going to be quite as simple as I first thought.
>>
>> The WebSocket client API requires Java SE 7 or later.
>> The WebSocket server API requires Java EE 6 or later.
>> Java EE 6 requires Java 6 or later.
>
>
66 matches
Mail list logo
