Mark, On 8/14/13 6:41 AM, Mark Thomas wrote: > Summarising the response to this thread so far: > > There is a preference for not strictly enforcing whatever limit is > selected. Rules need exceptions and committers can exercise judgement. > It does create a grey area but the majority is OK with that. > > There is a mix of views on line length but there appears to be support > for increasing the max line length for code and marginally less support > for increasing the max line length for comments. > > Therefore, I'd like to propose the following: > > 1. Introduce a checkstyle enforced hard limit of 200 characters per line > and fix any lines that exceed it. There are currently 24 lines that > exceed this limit. > > 2. Increase acceptable line length for new / modified code and comments > to 100. No mass reformatting would take place. > > 3. Consider further reducing the hard limit to 100 + suitable margin > over time, possibly in stages. For example, reducing it to 120 > identifies 737 lines (quite a few files have multiple long lines so the > number of files affected it a lot less than 737). > > Thoughts? > > I'm inclined to fix the lines identified by 1 regardless. 200+ > characters per line is far too wide.
+1 -chris
signature.asc
Description: OpenPGP digital signature
