svn commit: r1485972 - /tomcat/trunk/java/org/apache/catalina/connector/Connector.java

2013-05-24 Thread markt
Author: markt Date: Fri May 24 08:33:44 2013 New Revision: 1485972 URL: http://svn.apache.org/r1485972 Log: Trivial formatting Modified: tomcat/trunk/java/org/apache/catalina/connector/Connector.java Modified: tomcat/trunk/java/org/apache/catalina/connector/Connector.java URL: http://svn.ap

svn commit: r1486056 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractInputBuffer.java InternalAprInputBuffer.java InternalNioInputBuffer.java

2013-05-24 Thread markt
Author: markt Date: Fri May 24 14:00:29 2013 New Revision: 1486056 URL: http://svn.apache.org/r1486056 Log: Improve Javadoc Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractInputBuffer.java tomcat/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java tomcat/trunk

svn commit: r1486059 - /tomcat/trunk/java/org/apache/coyote/http11/filters/SavedRequestInputFilter.java

2013-05-24 Thread markt
Author: markt Date: Fri May 24 14:06:40 2013 New Revision: 1486059 URL: http://svn.apache.org/r1486059 Log: Marginally more efficient Modified: tomcat/trunk/java/org/apache/coyote/http11/filters/SavedRequestInputFilter.java Modified: tomcat/trunk/java/org/apache/coyote/http11/filters/Saved

svn commit: r1486060 - in /tomcat/trunk/java/org/apache: catalina/connector/ coyote/ coyote/http11/ coyote/http11/filters/

2013-05-24 Thread markt
Author: markt Date: Fri May 24 14:08:25 2013 New Revision: 1486060 URL: http://svn.apache.org/r1486060 Log: Implement new isFinished() method that identifies when a request body has been fully read. Required since available()==0 != isFinished() Modified: tomcat/trunk/java/org/apache/catalina

svn commit: r1486061 - /tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

2013-05-24 Thread markt
Author: markt Date: Fri May 24 14:09:27 2013 New Revision: 1486061 URL: http://svn.apache.org/r1486061 Log: Use new isFinished() method rather than available==0 Check if body has been read in non-blocking mode when exiting service method Modified: tomcat/trunk/java/org/apache/catalina/connect

svn commit: r1486062 - /tomcat/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java

2013-05-24 Thread markt
Author: markt Date: Fri May 24 14:09:55 2013 New Revision: 1486062 URL: http://svn.apache.org/r1486062 Log: Add a test case for bug 54928 Modified: tomcat/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java Modified: tomcat/trunk/test/org/apache/catalina/connector/TestCoyoteAdapt

svn commit: r1486064 - /tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java

2013-05-24 Thread markt
Author: markt Date: Fri May 24 14:10:28 2013 New Revision: 1486064 URL: http://svn.apache.org/r1486064 Log: Modify test to check onAllDataRead() is called correctly Modified: tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java Modified: tomcat/trunk/test/org/apache/cat

[jira] [Created] (MTOMCAT-224) Tomcat Maven Plugin is not marked @threadSafe

2013-05-24 Thread Diego Lemos (JIRA)
Diego Lemos created MTOMCAT-224: --- Summary: Tomcat Maven Plugin is not marked @threadSafe Key: MTOMCAT-224 URL: https://issues.apache.org/jira/browse/MTOMCAT-224 Project: Apache Tomcat Maven Plugin

[Bug 55017] New: Ability to configure RMI bind address

2013-05-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55017 Bug ID: 55017 Summary: Ability to configure RMI bind address Product: Tomcat 7 Version: trunk Hardware: PC OS: Linux Status: NEW Severity: enhanceme

[Bug 55017] Ability to configure RMI bind address

2013-05-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55017 Alexey Noskov changed: What|Removed |Added CC||alexey.nos...@gmail.com -- You ar

svn commit: r1486085 - /tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java

2013-05-24 Thread markt
Author: markt Date: Fri May 24 14:59:45 2013 New Revision: 1486085 URL: http://svn.apache.org/r1486085 Log: Non-blocking ends when async ends so ensure listeners are cleared Modified: tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java Modified: tomcat/trunk/java/org/apache/coyote/Asy

mod_jk AM_MAINTAINER_MODE nightmares

2013-05-24 Thread William A. Rowe Jr.
Folks, it is abusive to force all builds of mod_jk to invoke the whole automake toolchain; it isn't practical to expect automake to work on all platforms which mod_jk is happy to compile under. Even the root of automake, m4 itself, is often flakey under some of these OS distributions. Automake o

svn commit: r1486134 - in /tomcat/trunk: java/org/apache/catalina/connector/Request.java test/org/apache/catalina/connector/TestRequest.java

2013-05-24 Thread violetagg
Author: violetagg Date: Fri May 24 17:46:27 2013 New Revision: 1486134 URL: http://svn.apache.org/r1486134 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54984 Ensure that the correct encoding will be used when processing the multipart data. Modified: tomcat/trunk/java/org/apach

buildbot failure in ASF Buildbot on tomcat-trunk

2013-05-24 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4373 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source St

[Bug 55017] Ability to configure RMI bind address

2013-05-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55017 --- Comment #1 from Christopher Schultz --- I think the code starting at line 217 should probably be an "else" of this if clause: if (rmiSSL) { csf = new SslRMIClientSocketFactory(); ssf = new Ss

[Bug 55017] Ability to configure RMI bind address

2013-05-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55017 Alexey Noskov changed: What|Removed |Added Attachment #30319|0 |1 is obsolete|

[Bug 55017] Ability to configure RMI bind address

2013-05-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55017 --- Comment #2 from Alexey Noskov --- Created attachment 30320 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30320&action=edit Patch to provider bind rmi bind address setup ability (updated) Just adjusted patch: added else cla

[PATCH] jdbc-pool | FairBlockingQueue

2013-05-24 Thread Björn Raupach
Hello, out of pure curiosity I was browsing the source of jdbc-pool and ended up looking through FairBlockingQueue. FairBlockingQueue utilises a global ReentrantLock for mutual exclusion. Common practice is to always follow a call to lock with a try-finally block. The methods poll(long, TimeUni

[Bug 55017] Ability to configure RMI bind address

2013-05-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55017 --- Comment #3 from Christopher Schultz --- I think conflicting settings should actually fail to configure the connector, rather than playing favorites. -- You are receiving this mail because: You are the assignee for the bug. --

[Bug 55017] Ability to configure RMI bind address

2013-05-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55017 --- Comment #4 from Alexey Noskov --- Well. But then which exception should be thrown here? Or there is other preferred way to fail configuring the connector? -- You are receiving this mail because: You are the assignee for the bug.

[Bug 52231] Ant Tasks need to reflect changes in manager commands

2013-05-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52231 Christopher Schultz changed: What|Removed |Added Status|NEW |RESOLVED Component|

[Bug 52627] Segmentation fault in org.apache.tomcat.jni.File.infoGet() native method

2013-05-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52627 Christopher Schultz changed: What|Removed |Added Attachment #28291|application/octet-stream|text/plain mime typ

svn commit: r1486216 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2013-05-24 Thread markt
Author: markt Date: Fri May 24 20:56:28 2013 New Revision: 1486216 URL: http://svn.apache.org/r1486216 Log: Trigger non-blocking error handling if the client hangs up while an APR socket is in the Poller. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Modified: tomc

[Bug 52627] Segmentation fault in org.apache.tomcat.jni.File.infoGet() native method

2013-05-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52627 --- Comment #4 from Christopher Schultz --- Can you give some more information about the crash? For example, build tcnative with debugging symbols and then post the JVM crash dump? I don't see why zeroing-out a apr_finfo_t structure before

svn commit: r1486217 - /tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java

2013-05-24 Thread violetagg
Author: violetagg Date: Fri May 24 20:58:10 2013 New Revision: 1486217 URL: http://svn.apache.org/r1486217 Log: Temporary disable the test check. Modified: tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java Modified: tomcat/trunk/test/org/apache/catalina/connector/TestRequest.j

Re: svn commit: r1486217 - /tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java

2013-05-24 Thread Mark Thomas
On 24/05/2013 21:58, violet...@apache.org wrote: > Author: violetagg > Date: Fri May 24 20:58:10 2013 > New Revision: 1486217 > > URL: http://svn.apache.org/r1486217 > Log: > Temporary disable the test check. Why? And why does this need to be in svn rather than a local change? Mark > > Modifie

svn commit: r1486219 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2013-05-24 Thread markt
Author: markt Date: Fri May 24 21:04:51 2013 New Revision: 1486219 URL: http://svn.apache.org/r1486219 Log: Remove some debug hacks accidently included in previous commit Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/uti

Re: [PATCH] jdbc-pool | FairBlockingQueue

2013-05-24 Thread Christopher Schultz
Björn, On 5/24/13 4:08 PM, Björn Raupach wrote: > out of pure curiosity I was browsing the source of jdbc-pool and > ended up looking through FairBlockingQueue. FairBlockingQueue > utilises a global ReentrantLock for mutual exclusion. Common practice > is to always follow a call to lock with a try

[Bug 55017] Ability to configure RMI bind address

2013-05-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55017 --- Comment #5 from Christopher Schultz --- Hmm... I thought sure that LifecycleListeners could throw checked exceptions, but it seems they can't. I'm still not happy with this not failing-fast. What happens if you throw an IllegalStateExc

[Bug 55017] Ability to configure RMI bind address

2013-05-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55017 Alexey Noskov changed: What|Removed |Added Attachment #30320|0 |1 is obsolete|

[Bug 55017] Ability to configure RMI bind address

2013-05-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55017 --- Comment #6 from Alexey Noskov --- Created attachment 30321 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30321&action=edit Patch to provider bind rmi bind address setup ability (updated, 2) Yes, with IllegalStateException

buildbot success in ASF Buildbot on tomcat-trunk

2013-05-24 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4374 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

[Bug 52627] Segmentation fault in org.apache.tomcat.jni.File.infoGet() native method

2013-05-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52627 --- Comment #5 from Ilya Maykov --- It's been a while since I reported this bug and I've had my work machine upgraded since then, so I probably don't have the necessary environment to reproduce this quickly. But from what I remember, yes th

svn commit: r1486294 - /tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java

2013-05-24 Thread violetagg
Author: violetagg Date: Sat May 25 06:59:25 2013 New Revision: 1486294 URL: http://svn.apache.org/r1486294 Log: Enable the test check again. Now it is also passing on OS different than Windows. Modified: tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java Modified: tomcat/trunk