Hello, out of pure curiosity I was browsing the source of jdbc-pool and ended up looking through FairBlockingQueue. FairBlockingQueue utilises a global ReentrantLock for mutual exclusion. Common practice is to always follow a call to lock with a try-finally block. The methods poll(long, TimeUnit), pollAsync() don't use that practice. I was wondering why. Attached is modified version of FairBlockingQueue. I know FairBlockingQueue is a sensitive part of jdbc-pool and I am certainly not trying to smart ass. Its just interest and probably only a minor issue.
Thanks! bj
--------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
