[Tomcat Wiki] Trivial Update of "Reva6518" by Reva6518

2013-03-20 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "Reva6518" page has been changed by Reva6518: http://wiki.apache.org/tomcat/Reva6518 New page: Dorene is the title I like to be named with and I experience cozy when folks use the

Typo

2013-03-20 Thread Ognjen Blagojevic
Hi, http://tomcat.apache.org/tomcat-7.0-doc/config/http.html "restrictedUserAgents" -> "The value is a regular expression (using java.util.regex) *matching matching* ..." -Ognjen - To unsubscribe, e-mail: dev-unsubscr...@tom

svn commit: r1458694 - /tomcat/trunk/webapps/docs/config/http.xml

2013-03-20 Thread violetagg
Author: violetagg Date: Wed Mar 20 09:10:49 2013 New Revision: 1458694 URL: http://svn.apache.org/r1458694 Log: Correct typo reported via mailing list Modified: tomcat/trunk/webapps/docs/config/http.xml Modified: tomcat/trunk/webapps/docs/config/http.xml URL: http://svn.apache.org/viewvc/to

svn commit: r1458699 - in /tomcat/tc7.0.x/trunk: ./ webapps/docs/config/http.xml

2013-03-20 Thread violetagg
Author: violetagg Date: Wed Mar 20 09:22:41 2013 New Revision: 1458699 URL: http://svn.apache.org/r1458699 Log: Merged revision 1458694 from tomcat/trunk: Correct typo reported via mailing list Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/webapps/docs/config/http

Re: Typo

2013-03-20 Thread Violeta Georgieva
2013/3/20 Ognjen Blagojevic wrote: > Hi, > > http://tomcat.apache.org/tomcat-7.0-doc/config/http.html > > "restrictedUserAgents" -> "The value is a regular expression (using > java.util.regex) *matching matching* ..." Thank you for the report. The fixed documentation will be available with the nex

svn commit: r1458708 - /tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocket.java

2013-03-20 Thread markt
Author: markt Date: Wed Mar 20 09:55:56 2013 New Revision: 1458708 URL: http://svn.apache.org/r1458708 Log: Drop the tests for the non-JSR356 WebSocket implementation Removed: tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocket.java --

svn commit: r1458709 - /tomcat/trunk/java/org/apache/catalina/websocket/

2013-03-20 Thread markt
Author: markt Date: Wed Mar 20 09:56:29 2013 New Revision: 1458709 URL: http://svn.apache.org/r1458709 Log: Drop the non-JSR356 WebSocket implementation Removed: tomcat/trunk/java/org/apache/catalina/websocket/ - To unsubsc

svn commit: r1458710 - in /tomcat/trunk: java/javax/servlet/http/ java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/tomcat/websocket/server/ test/org/apache/coyote/http11/upg

2013-03-20 Thread markt
Author: markt Date: Wed Mar 20 09:58:07 2013 New Revision: 1458710 URL: http://svn.apache.org/r1458710 Log: Align implementation with new name in spec WsProtocolHandler -> WsHttpUpgradeHanlder Align implementation with new HttpServletRequest.upgrade() method Added: tomcat/trunk/java/org/apa

[Bug 54728] HttpServletRequest#upgrade() and other interfaces don't match spec; change may be impossible to implement

2013-03-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54728 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 54729] new HttpParser.parseAuthorizationBasic method

2013-03-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54729 --- Comment #1 from Mark Thomas --- Regarding your points: 1. Clarity vs efficiency is always a trade off. It depends how much efficiency has been lost. Do you have any performance numbers? 2. I don't see a test case either. I'd rather ge

svn commit: r1458726 - in /tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/util/mime: Base64Decoder.java MimeUtility.java

2013-03-20 Thread markt
Author: markt Date: Wed Mar 20 10:30:46 2013 New Revision: 1458726 URL: http://svn.apache.org/r1458726 Log: The JRE (since Java 6) ships with a perfectly good Base64 Encoder/Decoder. Use it. Removed: tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/util/mime/Base64Decoder.java Modif

svn commit: r1458738 - in /tomcat/trunk: java/org/apache/catalina/ant/ java/org/apache/catalina/authenticator/ java/org/apache/catalina/realm/ java/org/apache/catalina/util/ test/org/apache/catalina/a

2013-03-20 Thread markt
Author: markt Date: Wed Mar 20 10:38:43 2013 New Revision: 1458738 URL: http://svn.apache.org/r1458738 Log: Replace Tomcat's own base64 encoder with the one from the JRE. Modified: tomcat/trunk/java/org/apache/catalina/ant/AbstractCatalinaTask.java tomcat/trunk/java/org/apache/catalina/au

svn commit: r1458739 - /tomcat/trunk/java/org/apache/catalina/util/Base64.java

2013-03-20 Thread markt
Author: markt Date: Wed Mar 20 10:39:12 2013 New Revision: 1458739 URL: http://svn.apache.org/r1458739 Log: Add note on removal Modified: tomcat/trunk/java/org/apache/catalina/util/Base64.java Modified: tomcat/trunk/java/org/apache/catalina/util/Base64.java URL: http://svn.apache.org/viewvc

svn commit: r1458740 - /tomcat/trunk/java/org/apache/catalina/util/Base64.java

2013-03-20 Thread markt
Author: markt Date: Wed Mar 20 10:39:41 2013 New Revision: 1458740 URL: http://svn.apache.org/r1458740 Log: Remove deprecated code Modified: tomcat/trunk/java/org/apache/catalina/util/Base64.java Modified: tomcat/trunk/java/org/apache/catalina/util/Base64.java URL: http://svn.apache.org/vie

svn commit: r1458742 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/http/fileupload/ java/org/apache/tomcat/util/http/fileupload/util/mime/Base64Decoder.java java/org/apache/tomcat/util/ht

2013-03-20 Thread markt
Author: markt Date: Wed Mar 20 10:40:37 2013 New Revision: 1458742 URL: http://svn.apache.org/r1458742 Log: The JRE (since Java 6) ships with a perfectly good Base64 Encoder/Decoder. Use it. Removed: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/http/fileupload/util/mime/Base64Decoder.ja

svn commit: r1458748 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ant/ java/org/apache/catalina/authenticator/ java/org/apache/catalina/realm/ java/org/apache/catalina/util/ test/org/apache

2013-03-20 Thread markt
Author: markt Date: Wed Mar 20 10:43:46 2013 New Revision: 1458748 URL: http://svn.apache.org/r1458748 Log: Replace Tomcat's own base64 encoder with the one from the JRE. Deprecate Tomcat's encoder which will be removed in Tomcat 8. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat

[Tomcat Wiki] Trivial Update of "HelaineVJ" by HelaineVJ

2013-03-20 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "HelaineVJ" page has been changed by HelaineVJ: http://wiki.apache.org/tomcat/HelaineVJ New page: Hilaria Altizer is the name individuals use to call me and as well I feel comforta

[Bug 45661] NioBlockingSelector uses all CPU after a socket connection is killed

2013-03-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45661 --- Comment #5 from Sergio Garcia --- Hi, I still reproduce this error with these conditions : - Tomcat 7.0.14 - Linux 2.6 - java version "1.6.0_37" I don't think this issue must be closed with the status RESOLVED WORKSFORME Greetings,

[Tomcat Wiki] Update of "AdminGroup" by KonstantinKolinko

2013-03-20 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "AdminGroup" page has been changed by KonstantinKolinko: http://wiki.apache.org/tomcat/AdminGroup?action=diff&rev1=4&rev2=5 Comment: Remove anonymous read access to this page - #ac

[Tomcat Wiki] Update of "LocalBadContent" by KonstantinKolinko

2013-03-20 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "LocalBadContent" page has been changed by KonstantinKolinko: http://wiki.apache.org/tomcat/LocalBadContent?action=diff&rev1=91&rev2=92 #acl LeoSimons:read,write,admin,delete,reve

[Bug 45661] NioBlockingSelector uses all CPU after a socket connection is killed

2013-03-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45661 --- Comment #6 from Konstantin Kolinko --- No, 1. you are reproducing a different error on a different OS. 2. your report is irrelevant, there have been many fixes since 7.0.14. The current version of Tomcat 7 is 7.0.37. -- You are receiv

[Tomcat Wiki] Trivial Update of "Alfonzo37" by Alfonzo37

2013-03-20 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "Alfonzo37" page has been changed by Alfonzo37: http://wiki.apache.org/tomcat/Alfonzo37 New page: Long is what his wife likes to call him but he doesn't like when people use his fu

[Tomcat Wiki] Update of "LocalBadContent" by KonstantinKolinko

2013-03-20 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "LocalBadContent" page has been changed by KonstantinKolinko: http://wiki.apache.org/tomcat/LocalBadContent?action=diff&rev1=92&rev2=93 freecities\.com freewebpages\.org freew

Wiki (was: Update of "LocalBadContent")

2013-03-20 Thread Konstantin Kolinko
2013/3/19 Mark Thomas : > On 18/03/2013 21:46, Apache Wiki wrote: >> Dear Wiki user, >> >> You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for >> change notification. >> >> The "LocalBadContent" page has been changed by ChuckCaldarale: > > I've raised it before and folks weren

RE: Wiki (was: Update of "LocalBadContent")

2013-03-20 Thread Caldarale, Charles R
> From: Konstantin Kolinko [mailto:knst.koli...@gmail.com] > Subject: Wiki (was: Update of "LocalBadContent") > I'd say that if we go this tight security way, then I think we should > remove most of "Powered by" page (maybe all besides articles) and do > not bother maintaining it. I'd like to ke

Re: Wiki (was: Update of "LocalBadContent")

2013-03-20 Thread Tim Funk
+1 for the lock down. [with sadness] If someone would like to add content it can be done via bug report. [Component = Wiki? ] Then if a few are filed by the same person escalate their access as trusted. I can try to keep an eye on these types of bugs flowing through. +1 To removing the powered b

Re: Wiki (was: Update of "LocalBadContent")

2013-03-20 Thread Konstantin Kolinko
2013/3/20 Caldarale, Charles R : >> From: Konstantin Kolinko [mailto:knst.koli...@gmail.com] >> Subject: Wiki (was: Update of "LocalBadContent") > >> I'd say that if we go this tight security way, then I think we should >> remove most of "Powered by" page (maybe all besides articles) and do >> not

Question for the loader used in o.a.t.util.scan.StandardJarScanner

2013-03-20 Thread Violeta Georgieva
Hi, I have a question for the loader that is used in o.a.t.util.scan.StandardJarScanner.scan(ServletContext, ClassLoader, JarScannerCallback, Set) (7.0.x trunk). Why don't we use the loader that is provided as a method parameter, but instead of this we are using the thread context class loader?

[Tomcat Wiki] Trivial Update of "WillieSla" by WillieSla

2013-03-20 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "WillieSla" page has been changed by WillieSla: http://wiki.apache.org/tomcat/WillieSla New page: Not much to write about me really.<> Feels good to be a member of this community.<>

[Tomcat Wiki] Update of "LocalBadContent" by ChuckCaldarale

2013-03-20 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "LocalBadContent" page has been changed by ChuckCaldarale: http://wiki.apache.org/tomcat/LocalBadContent?action=diff&rev1=93&rev2=94 bodybuilding bravepages\.com breathefreshe

[Bug 54728] HttpServletRequest#upgrade() and other interfaces don't match spec; change may be impossible to implement

2013-03-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54728 --- Comment #3 from Nick Williams --- Okay, I see where my mistake was. Wow. *rubs eyes* I think I need to go back to bed. Lol. Thanks. -- You are receiving this mail because: You are the assignee for the bug. -

[Bug 54732] New: StatementCache interceptor does not forward calls to Statement.close() which causes memory leaks

2013-03-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54732 Bug ID: 54732 Summary: StatementCache interceptor does not forward calls to Statement.close() which causes memory leaks Product: Tomcat 7 Version: 7.0.34 Hardware: PC

[Bug 54732] StatementCache interceptor does not forward calls to Statement.close() which causes memory leaks

2013-03-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54732 ber...@step.polymtl.ca changed: What|Removed |Added CC||ber...@step.polymtl.ca

[Bug 54729] new HttpParser.parseAuthorizationBasic method

2013-03-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54729 --- Comment #2 from Mark Thomas --- I've done some additional testing. On a warmed up system the JRE and Tomcat Base64 decoding implementations are comparable. Tomcat does warm up faster. Without warm up on 100 iterations (different in

[Bug 54732] StatementCache interceptor does not forward calls to Statement.close() which causes memory leaks

2013-03-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54732 Mark Thomas changed: What|Removed |Added Component|Catalina|jdbc-pool Version|7.0.34

[Bug 54734] New: Tomcat Servlet 3.1 API needs to be synchronized with Proposed Final Draft

2013-03-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54734 Bug ID: 54734 Summary: Tomcat Servlet 3.1 API needs to be synchronized with Proposed Final Draft Product: Tomcat 8 Version: trunk Hardware: All OS: Al

[Bug 54734] Tomcat Servlet 3.1 API needs to be synchronized with Proposed Final Draft

2013-03-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54734 --- Comment #1 from Nick Williams --- Created attachment 30085 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30085&action=edit Patch to fix NoBodyResponse#setContentLength() -- You are receiving this mail because: You are the

[Bug 54734] Tomcat Servlet 3.1 API needs to be synchronized with Proposed Final Draft

2013-03-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54734 Nick Williams changed: What|Removed |Added Attachment #30084|0 |1 is patch|

[Bug 54734] Tomcat Servlet 3.1 API needs to be synchronized with Proposed Final Draft

2013-03-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54734 --- Comment #2 from Nick Williams --- I recommend that the patch to fix NoBodyResponse#setContentLength() get back-ported to Tomcat 7.0, since it should have behaved this way in Servlet 3.0. -- You are receiving this mail because: You are

[Bug 54734] Tomcat Servlet 3.1 API needs to be synchronized with Proposed Final Draft

2013-03-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54734 --- Comment #3 from Nick Williams --- For reference, here is the Servlet Spec bug I filed about missing methods in NoBodyResponse: http://java.net/jira/browse/SERVLET_SPEC-69 -- You are receiving this mail because: You are the assignee f

Re: Question for the loader used in o.a.t.util.scan.StandardJarScanner

2013-03-20 Thread Mark Thomas
On 20/03/2013 13:55, Violeta Georgieva wrote: > Hi, > > I have a question for the loader that is used in > o.a.t.util.scan.StandardJarScanner.scan(ServletContext, ClassLoader, > JarScannerCallback, Set) (7.0.x trunk). > > Why don't we use the loader that is provided as a method parameter, > but i

svn commit: r1459010 - /tomcat/trunk/test/org/apache/catalina/util/TesterBase64Performance.java

2013-03-20 Thread markt
Author: markt Date: Wed Mar 20 19:27:44 2013 New Revision: 1459010 URL: http://svn.apache.org/r1459010 Log: Add test case used to investigate Base64 decoder performance Added: tomcat/trunk/test/org/apache/catalina/util/TesterBase64Performance.java (with props) Added: tomcat/trunk/test/org

[Bug 54693] Add a validationQueryTimeout property

2013-03-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54693 --- Comment #3 from Daniel Mikusa --- Comments inline below... >Only one comment: since a value of "0" disabled query timeout (it will wait >forever), why not make the default 0 instead of -1? I implemented it the same way as DBCP to try

[Bug 54693] Add a validationQueryTimeout property

2013-03-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54693 --- Comment #4 from Daniel Mikusa --- Created attachment 30086 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30086&action=edit Second patch Added patch with additional testcase. -- You are receiving this mail because: You ar

svn commit: r1459028 - in /tomcat/trunk/java/org/apache: catalina/Context.java catalina/connector/Request.java catalina/core/ApplicationContext.java catalina/core/DefaultInstanceManager.java catalina/

2013-03-20 Thread remm
Author: remm Date: Wed Mar 20 20:10:41 2013 New Revision: 1459028 URL: http://svn.apache.org/r1459028 Log: - I am pretty sure the point of the upgrade(Class) method is to be able to inject, so the instance manager has to be used. - Add InstanceManager on Context, and also add newInstance(Class) -

svn commit: r1459031 - in /tomcat/trunk/java/org/apache/catalina: authenticator/BasicAuthenticator.java authenticator/SpnegoAuthenticator.java realm/JNDIRealm.java util/Base64.java

2013-03-20 Thread markt
Author: markt Date: Wed Mar 20 20:22:42 2013 New Revision: 1459031 URL: http://svn.apache.org/r1459031 Log: Deprecate Base64 and switch to DatatypeConverter Modified: tomcat/trunk/java/org/apache/catalina/authenticator/BasicAuthenticator.java tomcat/trunk/java/org/apache/catalina/authenti

svn commit: r1459032 - in /tomcat/trunk: java/org/apache/catalina/util/Base64.java test/org/apache/catalina/util/TesterBase64Performance.java

2013-03-20 Thread markt
Author: markt Date: Wed Mar 20 20:23:34 2013 New Revision: 1459032 URL: http://svn.apache.org/r1459032 Log: Remove Base64 and the associated test case Removed: tomcat/trunk/java/org/apache/catalina/util/Base64.java tomcat/trunk/test/org/apache/catalina/util/TesterBase64Performance.java

buildbot success in ASF Buildbot on tomcat-trunk

2013-03-20 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4138 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1459036 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/authenticator/ java/org/apache/catalina/realm/ java/org/apache/catalina/util/ test/org/apache/catalina/util/ webapps/docs/

2013-03-20 Thread markt
Author: markt Date: Wed Mar 20 20:37:59 2013 New Revision: 1459036 URL: http://svn.apache.org/r1459036 Log: (empty) Added: tomcat/tc7.0.x/trunk/test/org/apache/catalina/util/TesterBase64Performance.java - copied, changed from r1459010, tomcat/trunk/test/org/apache/catalina/util/Tester

buildbot failure in ASF Buildbot on tomcat-trunk

2013-03-20 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4139 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source St

svn commit: r1459043 - /tomcat/trunk/test/org/apache/catalina/core/TesterContext.java

2013-03-20 Thread markt
Author: markt Date: Wed Mar 20 20:46:04 2013 New Revision: 1459043 URL: http://svn.apache.org/r1459043 Log: Add new methods Modified: tomcat/trunk/test/org/apache/catalina/core/TesterContext.java Modified: tomcat/trunk/test/org/apache/catalina/core/TesterContext.java URL: http://svn.apache.

Re: svn commit: r1459036 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/authenticator/ java/org/apache/catalina/realm/ java/org/apache/catalina/util/ test/org/apache/catalina/util/ webapps/do

2013-03-20 Thread Konstantin Kolinko
2013/3/21 : > Author: markt > Date: Wed Mar 20 20:37:59 2013 > New Revision: 1459036 > > URL: http://svn.apache.org/r1459036 > Log: (empty) Log message? > > Added: > > tomcat/tc7.0.x/trunk/test/org/apache/catalina/util/TesterBase64Performance.java > - copied, changed from r1459010, >

[Tomcat Wiki] Trivial Update of "GarlandWi" by GarlandWi

2013-03-20 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "GarlandWi" page has been changed by GarlandWi: http://wiki.apache.org/tomcat/GarlandWi New page: buy a car with bad creditare available in secured as well as different prices.<> I

svn commit: r1459045 - in /tomcat/trunk/java/org/apache/catalina: connector/Request.java core/StandardContext.java

2013-03-20 Thread markt
Author: markt Date: Wed Mar 20 20:46:47 2013 New Revision: 1459045 URL: http://svn.apache.org/r1459045 Log: Fix some Eclipse nags Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Modified: tomcat/trunk/

Re: svn commit: r1459036 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/authenticator/ java/org/apache/catalina/realm/ java/org/apache/catalina/util/ test/org/apache/catalina/util/ webapps/do

2013-03-20 Thread Mark Thomas
On 20/03/2013 20:46, Konstantin Kolinko wrote: > 2013/3/21 : >> Author: markt >> Date: Wed Mar 20 20:37:59 2013 >> New Revision: 1459036 >> >> URL: http://svn.apache.org/r1459036 >> Log: (empty) > > Log message? Sorry. Fixed. Mark ---

svn propchange: r1459036 - svn:log

2013-03-20 Thread markt
Author: markt Revision: 1459036 Modified property: svn:log Modified: svn:log at Wed Mar 20 20:48:57 2013 -- --- svn:log (original) +++ svn:log Wed Mar 20 20:48:57 2013 @@ -0,0 +1 @@ +Deprecate Tomcat's internal Base 64 enc

Re: svn commit: r1459043 - /tomcat/trunk/test/org/apache/catalina/core/TesterContext.java

2013-03-20 Thread Remy Maucherat
On Wed, 2013-03-20 at 20:46 +, ma...@apache.org wrote: > Author: markt > Date: Wed Mar 20 20:46:04 2013 > New Revision: 1459043 > > URL: http://svn.apache.org/r1459043 > Log: > Add new methods > > Modified: > tomcat/trunk/test/org/apache/catalina/core/TesterContext.java Sorry about that

Re: svn commit: r1459043 - /tomcat/trunk/test/org/apache/catalina/core/TesterContext.java

2013-03-20 Thread Mark Thomas
On 20/03/2013 20:50, Remy Maucherat wrote: > On Wed, 2013-03-20 at 20:46 +, ma...@apache.org wrote: >> Author: markt >> Date: Wed Mar 20 20:46:04 2013 >> New Revision: 1459043 >> >> URL: http://svn.apache.org/r1459043 >> Log: >> Add new methods >> >> Modified: >> tomcat/trunk/test/org/apach

Time for 7.0.39

2013-03-20 Thread Mark Thomas
I plan to get the most recent FileUpload changes (if any), run the unit tests, run the TCKs and then tag 7.0.39 so that should happen some time early tomorrow if all goes well. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomca

[Bug 54693] Add a validationQueryTimeout property

2013-03-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54693 --- Comment #5 from Daniel Mikusa --- Sorry, found an issue with my second patch. Getting an NPE with testOnConnect set to true. Need to revisit and see what is happening. -- You are receiving this mail because: You are the assignee for

[Tomcat Wiki] Update of "LocalBadContent" by ChuckCaldarale

2013-03-20 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "LocalBadContent" page has been changed by ChuckCaldarale: http://wiki.apache.org/tomcat/LocalBadContent?action=diff&rev1=94&rev2=95 xn--lnakuten-9za\.se yehuo\.cn yesbo\.de +

Re: Time for 7.0.39

2013-03-20 Thread Nick Williams
On Mar 20, 2013, at 3:55 PM, Mark Thomas wrote: > I plan to get the most recent FileUpload changes (if any), run the unit > tests, run the TCKs and then tag 7.0.39 so that should happen some time > early tomorrow if all goes well. > > Mark In 54734 I propose a patch that needs to also be back-p

Re: svn commit: r1459031 - in /tomcat/trunk/java/org/apache/catalina: authenticator/BasicAuthenticator.java authenticator/SpnegoAuthenticator.java realm/JNDIRealm.java util/Base64.java

2013-03-20 Thread Konstantin Kolinko
1. I do not like that you need to convert chunks to Strings to call that API. Though in this particular case the strings should be short enough for it to do not matter. 2. I think we should not blindly cache authentication strings, even if it costs some performance. I think such things should not

svn commit: r1459061 - in /tomcat/trunk: java/org/apache/catalina/authenticator/BasicAuthenticator.java java/org/apache/catalina/authenticator/SpnegoAuthenticator.java test/org/apache/catalina/authent

2013-03-20 Thread markt
Author: markt Date: Wed Mar 20 21:17:48 2013 New Revision: 1459061 URL: http://svn.apache.org/r1459061 Log: Switching to the new Decoder has fixed a couple of TODOs. Update the comments and tests accordingly. Modified: tomcat/trunk/java/org/apache/catalina/authenticator/BasicAuthenticator.ja

svn commit: r1459062 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/authenticator/ test/org/apache/catalina/authenticator/

2013-03-20 Thread markt
Author: markt Date: Wed Mar 20 21:18:27 2013 New Revision: 1459062 URL: http://svn.apache.org/r1459062 Log: Switching to the new Decoder has fixed a couple of TODOs. Update the comments and tests accordingly. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/or

Re: Time for 7.0.39

2013-03-20 Thread Konstantin Kolinko
2013/3/21 Mark Thomas : > I plan to get the most recent FileUpload changes (if any), run the unit > tests, run the TCKs and then tag 7.0.39 so that should happen some time > early tomorrow if all goes well. 1. There are some jdbc-pool bugs that are worth looking at https://issues.apache.org/bugzil

Re: svn commit: r1459043 - /tomcat/trunk/test/org/apache/catalina/core/TesterContext.java

2013-03-20 Thread Nick Williams
On Mar 20, 2013, at 3:53 PM, Mark Thomas wrote: > On 20/03/2013 20:50, Remy Maucherat wrote: >> On Wed, 2013-03-20 at 20:46 +, ma...@apache.org wrote: >>> Author: markt >>> Date: Wed Mar 20 20:46:04 2013 >>> New Revision: 1459043 >>> >>> URL: http://svn.apache.org/r1459043 >>> Log: >>> Add n

svn commit: r1459074 - /tomcat/trunk/java/org/apache/catalina/authenticator/BasicAuthenticator.java

2013-03-20 Thread markt
Author: markt Date: Wed Mar 20 22:00:43 2013 New Revision: 1459074 URL: http://svn.apache.org/r1459074 Log: Keep auth headers out of the StringCache Modified: tomcat/trunk/java/org/apache/catalina/authenticator/BasicAuthenticator.java Modified: tomcat/trunk/java/org/apache/catalina/authenti

svn commit: r1459075 - /tomcat/trunk/test/org/apache/catalina/mapper/TestMapper.java

2013-03-20 Thread markt
Author: markt Date: Wed Mar 20 22:04:18 2013 New Revision: 1459075 URL: http://svn.apache.org/r1459075 Log: Buidlbot needs a little longer Modified: tomcat/trunk/test/org/apache/catalina/mapper/TestMapper.java Modified: tomcat/trunk/test/org/apache/catalina/mapper/TestMapper.java URL: http:

Re: Time for 7.0.39

2013-03-20 Thread Mark Thomas
On 20/03/2013 21:31, Konstantin Kolinko wrote: > 2013/3/21 Mark Thomas : >> I plan to get the most recent FileUpload changes (if any), run the unit >> tests, run the TCKs and then tag 7.0.39 so that should happen some time >> early tomorrow if all goes well. > > 1. There are some jdbc-pool bugs th

svn commit: r1459076 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/authenticator/BasicAuthenticator.java

2013-03-20 Thread markt
Author: markt Date: Wed Mar 20 22:05:46 2013 New Revision: 1459076 URL: http://svn.apache.org/r1459076 Log: Keep auth headers out of the StringCache Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/authenticator/BasicAuthenticator.java Prop

svn commit: r1459077 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/tomcat/util/http/mapper/TestMapper.java

2013-03-20 Thread markt
Author: markt Date: Wed Mar 20 22:08:08 2013 New Revision: 1459077 URL: http://svn.apache.org/r1459077 Log: Buidlbot needs a little longer Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/http/mapper/TestMapper.java Propchange: tomcat/tc7

WebServlets and HttpSessions (again) ... How to update last accessed time?

2013-03-20 Thread Nick Williams
Reading through the expert mailing list for the WebSocket spec, I gather that the experts did not feel it appropriate to update the last access time for HttpSession objects when messages are received. I DO agree with this; there's no way to know what the user really wants here, and it could be a

Re: Time for 7.0.39

2013-03-20 Thread Mark Thomas
On 20/03/2013 20:58, Nick Williams wrote: > > On Mar 20, 2013, at 3:55 PM, Mark Thomas wrote: > >> I plan to get the most recent FileUpload changes (if any), run the unit >> tests, run the TCKs and then tag 7.0.39 so that should happen some time >> early tomorrow if all goes well. >> >> Mark > >

svn commit: r1459085 - /tomcat/trunk/java/javax/servlet/http/HttpServlet.java

2013-03-20 Thread markt
Author: markt Date: Wed Mar 20 22:35:31 2013 New Revision: 1459085 URL: http://svn.apache.org/r1459085 Log: Ensure HEAD requests return the correct content length when the requested resource uses a Writer. Patch by Nick Williams. Modified: tomcat/trunk/java/javax/servlet/http/HttpServlet.jav

svn commit: r1459087 - in /tomcat/tc7.0.x/trunk: ./ java/javax/servlet/http/HttpServlet.java webapps/docs/changelog.xml

2013-03-20 Thread markt
Author: markt Date: Wed Mar 20 22:37:38 2013 New Revision: 1459087 URL: http://svn.apache.org/r1459087 Log: Ensure HEAD requests return the correct content length when the requested resource uses a Writer. Patch by Nick Williams. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/t

[Bug 54734] Tomcat Servlet 3.1 API needs to be synchronized with Proposed Final Draft

2013-03-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54734 --- Comment #4 from Mark Thomas --- (In reply to comment #2) > I recommend that the patch to fix NoBodyResponse#setContentLength() get > back-ported to Tomcat 7.0, since it should have behaved this way in Servlet > 3.0. Applied to trunk an

[Tomcat Wiki] Trivial Update of "PercyCurl" by PercyCurl

2013-03-20 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "PercyCurl" page has been changed by PercyCurl: http://wiki.apache.org/tomcat/PercyCurl New page: enterprise restaurant revenue software application, business enterprise restaurant

Re: svn commit: r1459043 - /tomcat/trunk/test/org/apache/catalina/core/TesterContext.java

2013-03-20 Thread Mark Thomas
On 20/03/2013 21:35, Nick Williams wrote: > > On Mar 20, 2013, at 3:53 PM, Mark Thomas wrote: > >> On 20/03/2013 20:50, Remy Maucherat wrote: >>> On Wed, 2013-03-20 at 20:46 +, ma...@apache.org wrote: Author: markt Date: Wed Mar 20 20:46:04 2013 New Revision: 1459043

Re: svn commit: r1459043 - /tomcat/trunk/test/org/apache/catalina/core/TesterContext.java

2013-03-20 Thread Nick Williams
On Mar 20, 2013, at 5:48 PM, Mark Thomas wrote: > On 20/03/2013 21:35, Nick Williams wrote: >> >> On Mar 20, 2013, at 3:53 PM, Mark Thomas wrote: >> >>> On 20/03/2013 20:50, Remy Maucherat wrote: On Wed, 2013-03-20 at 20:46 +, ma...@apache.org wrote: > Author: markt > Date: Wed

[Tomcat Wiki] Update of "LocalBadContent" by ChuckCaldarale

2013-03-20 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "LocalBadContent" page has been changed by ChuckCaldarale: http://wiki.apache.org/tomcat/LocalBadContent?action=diff&rev1=95&rev2=96 angosso\.net aprendedanzaoriental\.info as

buildbot success in ASF Buildbot on tomcat-7-trunk

2013-03-20 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1138 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build So

Re: svn commit: r1459043 - /tomcat/trunk/test/org/apache/catalina/core/TesterContext.java

2013-03-20 Thread Mark Thomas
On 20/03/2013 22:50, Nick Williams wrote: > > On Mar 20, 2013, at 5:48 PM, Mark Thomas wrote: > >> On 20/03/2013 21:35, Nick Williams wrote: >>> Also agreed. However, r1459028 introduces some unnecessary casting. This is >>> easily solved: >> >> Indeed, but Eclipse flags a couple of errors wh

Re: svn commit: r1459043 - /tomcat/trunk/test/org/apache/catalina/core/TesterContext.java

2013-03-20 Thread Nick Williams
On Mar 20, 2013, at 6:45 PM, Mark Thomas wrote: > On 20/03/2013 22:50, Nick Williams wrote: >> >> On Mar 20, 2013, at 5:48 PM, Mark Thomas wrote: >> >>> On 20/03/2013 21:35, Nick Williams wrote: > > > Also agreed. However, r1459028 introduces some unnecessary casting. This is easi

[Bug 54665] Provide JNDI support for java.net.URL resources

2013-03-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54665 --- Comment #3 from Christopher Schultz --- I'm not sure why String -> URL wouldn't be cross-platform. WRT licenses, LGPL is incompatible with AL2, so you'd have to get the author to grant the code to the ASF under a different license. --

Re: BIO performance issues

2013-03-20 Thread igaz
Is this thread/issue still *active*? I have a few ideas (and I worked on a similar issue awhile back). But this thread was last active 2 years ago and there was even discussion of deprecating BIO in tomcat 8, so I don't want to waste time on something that is dormant or has been superceded -- V

[Bug 54690] HTTPS BIO/NIO connector does not enable TLS 1.1 and TLS 1.2 by default

2013-03-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54690 --- Comment #8 from Tim Whittington --- For posterity, the actual situation with JSSE is a bit more complicated than client vs server. (The fix and workaround for this issue are correct - this is just to clarify the landscape in case it's e

[Bug 54690] HTTPS BIO/NIO connector does not enable TLS 1.1 and TLS 1.2 by default

2013-03-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54690 --- Comment #9 from Tim Whittington --- Created attachment 30088 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30088&action=edit JSSE options on Oracle Java 7 -- You are receiving this mail because: You are the assignee for t

[Bug 54690] HTTPS BIO/NIO connector does not enable TLS 1.1 and TLS 1.2 by default

2013-03-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54690 --- Comment #10 from Tim Whittington --- Created attachment 30089 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30089&action=edit JSSE options on Oracle Java 6 -- You are receiving this mail because: You are the assignee for

[Bug 54690] HTTPS BIO/NIO connector does not enable TLS 1.1 and TLS 1.2 by default

2013-03-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54690 --- Comment #11 from Tim Whittington --- Created attachment 30090 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30090&action=edit JSSE options on AIX Java 7 -- You are receiving this mail because: You are the assignee for the

[Tomcat Wiki] Trivial Update of "LuannPres" by LuannPres

2013-03-20 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "LuannPres" page has been changed by LuannPres: http://wiki.apache.org/tomcat/LuannPres New page: There is nothing to say about me at all.<> Yes! Im a part of this site.<> I really

[Tomcat Wiki] Trivial Update of "LAJLyndon" by LAJLyndon

2013-03-20 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "LAJLyndon" page has been changed by LAJLyndon: http://wiki.apache.org/tomcat/LAJLyndon New page: Nothing to write about myself really.<> Finally a part of this community.<> I reall

Use of JAXB api to process Base64 in Tomcat 7 and 8

2013-03-20 Thread Konstantin Kolinko
Hi! Recent Mark's commits in Tomcat 7, 8 replaced custom implementations(*) of base64 with use of the following class from JAXB: javax.xml.bind.DatatypeConverter This affects base64 processing in our own classes and in our copy of Commons FileUpload. The original fileupload library in commons wa

Re: Use of JAXB api to process Base64 in Tomcat 7 and 8

2013-03-20 Thread Nick Williams
On Mar 21, 2013, at 12:35 AM, Konstantin Kolinko wrote: > Hi! > > Recent Mark's commits in Tomcat 7, 8 replaced custom > implementations(*) of base64 > with use of the following class from JAXB: > > javax.xml.bind.DatatypeConverter > > This affects base64 processing in our own classes and in o