On 20/03/2013 21:35, Nick Williams wrote: > > On Mar 20, 2013, at 3:53 PM, Mark Thomas wrote: > >> On 20/03/2013 20:50, Remy Maucherat wrote: >>> On Wed, 2013-03-20 at 20:46 +0000, ma...@apache.org wrote: >>>> Author: markt >>>> Date: Wed Mar 20 20:46:04 2013 >>>> New Revision: 1459043 >>>> >>>> URL: http://svn.apache.org/r1459043 >>>> Log: >>>> Add new methods >>>> >>>> Modified: >>>> tomcat/trunk/test/org/apache/catalina/core/TesterContext.java >>> >>> Sorry about that ... >> >> No problem. >> >>> I'm not sure this is a very good idea, but OTOH I'm quite sure this is >>> meant to be injected, so I added the get/set. >> >> I agree injection is required and I don't see an alternative way to do >> it. Thanks for catching this. >> >> Mark > > Also agreed. However, r1459028 introduces some unnecessary casting. This is > easily solved:
Indeed, but Eclipse flags a couple of errors when you do this. The errors are incorrect but rather a nuisance. Something to look at after the next update. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
