Bug report for Tomcat 6 [2012/09/09]

2012-09-09 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Connectors [2012/09/09]

2012-09-09 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Taglibs [2012/09/09]

2012-09-09 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 5 [2012/09/09]

2012-09-09 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 7 [2012/09/09]

2012-09-09 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Native [2012/09/09]

2012-09-09 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Modules [2012/09/09]

2012-09-09 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Re: svn commit: r1382367 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/catalina/startup/ webapps/docs/ webapps/docs/config/

2012-09-09 Thread Konstantin Kolinko
2012/9/9 : > Author: markt > Date: Sat Sep 8 21:11:46 2012 > New Revision: 1382367 > > URL: http://svn.apache.org/viewvc?rev=1382367&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52777 > Implement optional automatic removal of old applications where parallel > deployme

svn commit: r1382515 - /tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java

2012-09-09 Thread markt
Author: markt Date: Sun Sep 9 15:23:09 2012 New Revision: 1382515 URL: http://svn.apache.org/viewvc?rev=1382515&view=rev Log: Review comments from kkolinko Modified: tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java Modified: tomcat/trunk/java/org/apache/catalina/startup/HostCon

Re: svn commit: r1382367 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/catalina/startup/ webapps/docs/ webapps/docs/config/

2012-09-09 Thread Mark Thomas
On 09/09/2012 15:24, Konstantin Kolinko wrote: > 2012/9/9 : >> Author: markt >> Date: Sat Sep 8 21:11:46 2012 >> New Revision: 1382367 >> >> URL: http://svn.apache.org/viewvc?rev=1382367&view=rev >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52777 >> Implement optional automat

svn commit: r1382516 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/HostConfig.java

2012-09-09 Thread markt
Author: markt Date: Sun Sep 9 15:25:05 2012 New Revision: 1382516 URL: http://svn.apache.org/viewvc?rev=1382516&view=rev Log: Review comments from kkolinko Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/HostConfig.java Propchange:

svn commit: r1382521 - /tomcat/trunk/java/org/apache/juli/logging/LogConfigurationException.java

2012-09-09 Thread markt
Author: markt Date: Sun Sep 9 15:58:04 2012 New Revision: 1382521 URL: http://svn.apache.org/viewvc?rev=1382521&view=rev Log: Simplify Modified: tomcat/trunk/java/org/apache/juli/logging/LogConfigurationException.java Modified: tomcat/trunk/java/org/apache/juli/logging/LogConfigurationExce

svn commit: r1382526 - /tomcat/trunk/java/org/apache/naming/NamingContext.java

2012-09-09 Thread markt
Author: markt Date: Sun Sep 9 16:07:16 2012 New Revision: 1382526 URL: http://svn.apache.org/viewvc?rev=1382526&view=rev Log: Clean-up - final markers from UCDetector - refactor constructors to permit use of final Modified: tomcat/trunk/java/org/apache/naming/NamingContext.java Modified:

Resources - overview

2012-09-09 Thread Mark Thomas
I now have my proposed alternative resources implementation complete to the point where it is worth comitting somewhere for others to comment on. I therefore, propose the following way forward: 1. Create a trunk-resources branch under the sandbox (copied from trunk) and commit the new implementati

svn commit: r1382548 - in /tomcat/sandbox/trunk-resources: ./ java/org/apache/juli/logging/LogConfigurationException.java java/org/apache/naming/NamingContext.java

2012-09-09 Thread markt
Author: markt Date: Sun Sep 9 18:07:05 2012 New Revision: 1382548 URL: http://svn.apache.org/viewvc?rev=1382548&view=rev Log: Create sandbox for new resources implementation Added: tomcat/sandbox/trunk-resources/ - copied from r1382516, tomcat/trunk/ tomcat/sandbox/trunk-resources

svn commit: r1382551 - in /tomcat/sandbox/trunk-resources/java/org/apache/catalina: WebResource.java WebResourceRoot.java WebResourceSet.java

2012-09-09 Thread markt
Author: markt Date: Sun Sep 9 18:14:22 2012 New Revision: 1382551 URL: http://svn.apache.org/viewvc?rev=1382551&view=rev Log: Initial definition of new resources API Added: tomcat/sandbox/trunk-resources/java/org/apache/catalina/WebResource.java (with props) tomcat/sandbox/trunk-reso

svn commit: r1382552 - in /tomcat/sandbox/trunk-resources/java/org/apache/catalina/webresources: ./ DirResourceSet.java EmptyResource.java FileResource.java JarResource.java JarResourceSet.java Standa

2012-09-09 Thread markt
Author: markt Date: Sun Sep 9 18:15:01 2012 New Revision: 1382552 URL: http://svn.apache.org/viewvc?rev=1382552&view=rev Log: Initial implementation of new resources API Added: tomcat/sandbox/trunk-resources/java/org/apache/catalina/webresources/ (with props) tomcat/sandbox/trunk-res

Resources - Remaining TODOs

2012-09-09 Thread Mark Thomas
This thread is for tracking the remaining TODO items. An initial brain dump of to do items: 1. Run Tomcat 7 TCKs a) To check they pass (minus the API tests which will fail) b) to compare the performance 2. Add the ability to configure the new resources via context.xml / server.xml and d

Resources - The need for refactoring

2012-09-09 Thread Mark Thomas
This is issue a) in Konstantin's comments in TOMCAT-NEXT.txt My expectation is that the need for refactoring in some form or another is clear. Currently Tomcat has the following features: - aliases - resource JARs - VirtualDirContext / VirtualLoader and in Servlet 3.1 there will be overlays. [1]

Resources - Performance (caching)

2012-09-09 Thread Mark Thomas
This is part of issue b) in Konstantin's comments in TOMCAT-NEXT.txt The current DirContext implementation supports caching in most but not all circumstances. It would be possible to insert a cache into the StandardRoot implementation but I am not convinced it is necessary. The read-cache built in

Resources - Is DirContext the right basis for the API?

2012-09-09 Thread Mark Thomas
This is part of issue b) in Konstantin's comments in TOMCAT-NEXT.txt Konstantin has accurately summed up the issues with basing the API on DirContext as: - Unnecessary objects, e.g. NamingException instead of null. - Too many methods. Name vs. String. list() vs. listBindings(). -

Re: Resources - Performance (caching)

2012-09-09 Thread Mark Thomas
On 09/09/2012 19:44, Mark Thomas wrote: > This is part of issue b) in Konstantin's comments in TOMCAT-NEXT.txt > > The current DirContext implementation supports caching in most but not > all circumstances. It would be possible to insert a cache into the > StandardRoot implementation but I am not

Resources - WebappClassLoader and resource access

2012-09-09 Thread Mark Thomas
This is issue c) in Konstantin's comments in TOMCAT-NEXT.txt The WebappClassLoader currently makes copies of various resources to work-around various issues. Providing that these copies are internal to the WebappClassLoader then I do not see this issue as directly affecting the refactoring of the

Resources - JarScanner / WebappClassLoader

2012-09-09 Thread Mark Thomas
This is issue d) in Konstantin's comments in TOMCAT-NEXT.txt Konstantin is right to point out the inefficiencies in JarScanner. There is no need to scan WEB-INF/lib and WEB-INF/classes as the class path from the WebappClassLoader already includes them. However, I think this can be considered sepa

svn commit: r1382561 - /tomcat/sandbox/trunk-resources/java/org/apache/catalina/loader/VirtualWebappLoader.java

2012-09-09 Thread markt
Author: markt Date: Sun Sep 9 19:04:52 2012 New Revision: 1382561 URL: http://svn.apache.org/viewvc?rev=1382561&view=rev Log: Remove file that no longer compiles Removed: tomcat/sandbox/trunk-resources/java/org/apache/catalina/loader/VirtualWebappLoader.java --

Resources - Custom URL scheme for unified access

2012-09-09 Thread Mark Thomas
This is issue e) in Konstantin's comments in TOMCAT-NEXT.txt Copying Konstantin's notes: Goodies: - Uniform URL space. Both files and directories can be represented, hiding details of aliases, resource jars, etc. - It hides implementation details. - Permissions can be e

Resources - Custom URL connections

2012-09-09 Thread Mark Thomas
This is issue f) in Konstantin's comments in TOMCAT-NEXT.txt This issue only applies if a custom URL scheme is required. I think we should park this issue until that question is answered. Mark - To unsubscribe, e-mail: dev-unsub

svn commit: r1382563 - /tomcat/sandbox/trunk-resources/test/org/apache/catalina/core/TestStandardContextAliases.java

2012-09-09 Thread markt
Author: markt Date: Sun Sep 9 19:35:15 2012 New Revision: 1382563 URL: http://svn.apache.org/viewvc?rev=1382563&view=rev Log: Get test working with new Resources implementation Modified: tomcat/sandbox/trunk-resources/test/org/apache/catalina/core/TestStandardContextAliases.java Modified:

svn commit: r1382579 - in /tomcat/sandbox/trunk-resources/java/org/apache/catalina: WebResourceRoot.java loader/WebappClassLoader.java webresources/StandardRoot.java

2012-09-09 Thread markt
Author: markt Date: Sun Sep 9 21:00:38 2012 New Revision: 1382579 URL: http://svn.apache.org/viewvc?rev=1382579&view=rev Log: I'm not convinced this is desirable or even necessary but the current unit tests expect to be able to list all matching resources even though only one of them will ever

svn commit: r1382580 - /tomcat/sandbox/trunk-resources/test/org/apache/naming/resources/TestProxyDirContext.java

2012-09-09 Thread markt
Author: markt Date: Sun Sep 9 21:12:27 2012 New Revision: 1382580 URL: http://svn.apache.org/viewvc?rev=1382580&view=rev Log: Remove test that is no longer required Removed: tomcat/sandbox/trunk-resources/test/org/apache/naming/resources/TestProxyDirContext.java --

svn commit: r1382582 - in /tomcat/sandbox/trunk-resources/java/org/apache/catalina: WebResource.java webresources/FileResource.java webresources/StandardRoot.java

2012-09-09 Thread markt
Author: markt Date: Sun Sep 9 21:25:05 2012 New Revision: 1382582 URL: http://svn.apache.org/viewvc?rev=1382582&view=rev Log: Clarify behaviour of WebResource#getURL() if the resource does not exist and implement the correct behaviour consistently. Modified: tomcat/sandbox/trunk-resources/j

svn commit: r1382587 - in /tomcat/sandbox/trunk-resources/java/org/apache/catalina/webresources: DirResourceSet.java FileResource.java

2012-09-09 Thread markt
Author: markt Date: Sun Sep 9 21:54:15 2012 New Revision: 1382587 URL: http://svn.apache.org/viewvc?rev=1382587&view=rev Log: Special case to handle Resource JARs that have been unpacked under /WEB-INF/classes Eclipse requires this Modified: tomcat/sandbox/trunk-resources/java/org/apache/c

svn commit: r1382591 - /tomcat/sandbox/trunk-resources/java/org/apache/catalina/webresources/DirResourceSet.java

2012-09-09 Thread markt
Author: markt Date: Sun Sep 9 22:03:04 2012 New Revision: 1382591 URL: http://svn.apache.org/viewvc?rev=1382591&view=rev Log: // -> / Modified: tomcat/sandbox/trunk-resources/java/org/apache/catalina/webresources/DirResourceSet.java Modified: tomcat/sandbox/trunk-resources/java/org/apache

svn commit: r1382602 - /tomcat/sandbox/trunk-resources/test/org/apache/catalina/loader/TestVirtualContext.java

2012-09-09 Thread markt
Author: markt Date: Sun Sep 9 22:36:52 2012 New Revision: 1382602 URL: http://svn.apache.org/viewvc?rev=1382602&view=rev Log: Tweak unit test to work with new resources - still fails. There is work to do in the JarScanner. Modified: tomcat/sandbox/trunk-resources/test/org/apache/catalina/l

Re: svn commit: r1382367 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/catalina/startup/ webapps/docs/ webapps/docs/config/

2012-09-09 Thread Keiichi Fujino
> > /** > + * Check for old versions of applications using parallel deployment that > are > + * now unused (have no active sessions) and undeploy any that are found. > + */ > +public void checkUndeploy() { > +// Need ordered set of names > +SortedSet sortedAppN

[GUMP@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed

2012-09-09 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-taglibs-standard has an issue affecting its community integration.