Re: Unit tests and trunk

2012-07-12 Thread Mark Thomas
On 12/07/2012 02:05, Filip Hanik wrote: > I can reproduce the bug in both our unit tests and the original bug report. > further more I can turn non blocking into blocking by opening an closing a > selector that is never used. > > definitely a bug, since a jvm/network flag resolves it. > > whi

Re: Missing classes in stock 5.5.35 JARs?

2012-07-12 Thread Mark Thomas
On 12/07/2012 01:25, Christopher Schultz wrote: > All, > > http://stackoverflow.com/questions/11427522/ssl-configuration-getting-classpuretlsimplementation-jsse15factory-not-foun > > The SO poster is using 5.5.30 but the problem appears to still > exist in 5.5.35 (latest). > > I downloaded the "

Re: access to build environment

2012-07-12 Thread Mark Thomas
On 12/07/2012 02:06, Filip Hanik wrote: > I'd guess those two, do we use anything else for tomcat ci? Not on ASF infrastructure. The first step is to get trunk building with 1.7. It doesn't at the moment because of some jdbc-pool tests that implement some of the SQL interfaces. Fix those and we c

svn commit: r1360606 - in /tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/driver: Connection.java Driver.java ResultSet.java Statement.java

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 09:56:17 2012 New Revision: 1360606 URL: http://svn.apache.org/viewvc?rev=1360606&view=rev Log: Get jdbc-pool tests compiling with Java 7 Modified: tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/driver/Connection.java tomcat/trunk

svn commit: r1360608 - /tomcat/trunk/test/org/apache/catalina/connector/TestSendFile.java

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 09:57:32 2012 New Revision: 1360608 URL: http://svn.apache.org/viewvc?rev=1360608&view=rev Log: Fix import order Modified: tomcat/trunk/test/org/apache/catalina/connector/TestSendFile.java Modified: tomcat/trunk/test/org/apache/catalina/connector/TestSendFile.j

svn commit: r1360609 - in /tomcat/trunk/java/org/apache/coyote: http11/NpnHandler.java spdy/SpdyAprNpnHandler.java

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 10:02:15 2012 New Revision: 1360609 URL: http://svn.apache.org/viewvc?rev=1360609&view=rev Log: Fix some generics warnings Modified: tomcat/trunk/java/org/apache/coyote/http11/NpnHandler.java tomcat/trunk/java/org/apache/coyote/spdy/SpdyAprNpnHandler.java M

svn commit: r1360611 - /tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 10:07:48 2012 New Revision: 1360611 URL: http://svn.apache.org/viewvc?rev=1360611&view=rev Log: Fix a handful of Eclipse warnings Modified: tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java Modified: tomcat/trunk/test/org/apache/catalin

svn commit: r1360615 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractHttp11JsseProtocol.java AbstractHttp11Protocol.java Http11AprProtocol.java Http11NioProtocol.java Http11Protocol.java Npn

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 10:18:20 2012 New Revision: 1360615 URL: http://svn.apache.org/viewvc?rev=1360615&view=rev Log: Fix more warnings - More generics for npn - Use final where appropriate Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11JsseProtocol.java tom

svn commit: r1360616 - /tomcat/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 10:19:57 2012 New Revision: 1360616 URL: http://svn.apache.org/viewvc?rev=1360616&view=rev Log: Remove unused code Modified: tomcat/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java Modified: tomcat/trunk/java/org/apache/coyote/http11/InternalNi

svn commit: r1360618 - in /tomcat/trunk/java/org/apache/tomcat/jni/socket: AprSocket.java AprSocketContext.java

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 10:30:44 2012 New Revision: 1360618 URL: http://svn.apache.org/viewvc?rev=1360618&view=rev Log: Clean up debug logging Modified: tomcat/trunk/java/org/apache/tomcat/jni/socket/AprSocket.java tomcat/trunk/java/org/apache/tomcat/jni/socket/AprSocketContext.jav

Re: svn commit: r1360618 - in /tomcat/trunk/java/org/apache/tomcat/jni/socket: AprSocket.java AprSocketContext.java

2012-07-12 Thread Rainer Jung
On 12.07.2012 12:30, ma...@apache.org wrote: Author: markt Date: Thu Jul 12 10:30:44 2012 New Revision: 1360618 URL: http://svn.apache.org/viewvc?rev=1360618&view=rev Log: Clean up debug logging Modified: tomcat/trunk/java/org/apache/tomcat/jni/socket/AprSocket.java tomcat/trunk/java/

Current unit test behaviour for trunk using Java 7 on Solaris

2012-07-12 Thread Rainer Jung
Versions TC trunk r1360616 tested with Java 1.7.0_05 on Solaris 10 Sparc. Compiled everything with the same JVM version using compile.source=1.7 compile.target=1.7 except for DBCP which was compiled with Java 6. Unit test failures == One test failure, namely org.apac

Re: Missing classes in stock 5.5.35 JARs?

2012-07-12 Thread Jim Jagielski
On Jul 11, 2012, at 8:25 PM, Christopher Schultz wrote: > All, > > http://stackoverflow.com/questions/11427522/ssl-configuration-getting-classpuretlsimplementation-jsse15factory-not-foun > > The SO poster is using 5.5.30 but the problem appears to still exist in > 5.5.35 (latest). > > I downlo

RE: access to build environment

2012-07-12 Thread Filip Hanik (mailing lists)
> -Original Message- > From: Mark Thomas [mailto:ma...@apache.org] > Sent: Thursday, July 12, 2012 1:33 AM > To: Tomcat Developers List > Subject: Re: access to build environment > > On 12/07/2012 02:06, Filip Hanik wrote: > > I'd guess those two, do we use anything else for tomcat ci? >

svn commit: r1360704 - in /tomcat/tc7.0.x/trunk/modules: ./ jdbc-pool/

2012-07-12 Thread fhanik
Author: fhanik Date: Thu Jul 12 14:34:50 2012 New Revision: 1360704 URL: http://svn.apache.org/viewvc?rev=1360704&view=rev Log: jdbc-pool is branched off into Tomcat 7 so that refactoring can take place in trunk Added: tomcat/tc7.0.x/trunk/modules/jdbc-pool/ - copied from r1360703, to

svn commit: r1360729 - in /tomcat/trunk: ./ modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/driver/ res/dbcp/

2012-07-12 Thread fhanik
Author: fhanik Date: Thu Jul 12 15:38:28 2012 New Revision: 1360729 URL: http://svn.apache.org/viewvc?rev=1360729&view=rev Log: Configure Tomcat trunk to build with Java 7. This includes adding a patch to the Commons-DBCP code from res/dbcp Added: tomcat/trunk/res/dbcp/ tomcat/trunk/res/

svn commit: r1360730 - /tomcat/trunk/build.xml

2012-07-12 Thread fhanik
Author: fhanik Date: Thu Jul 12 15:41:01 2012 New Revision: 1360730 URL: http://svn.apache.org/viewvc?rev=1360730&view=rev Log: removed debug statement Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1360730&r1=1

Re: svn commit: r1360618 - in /tomcat/trunk/java/org/apache/tomcat/jni/socket: AprSocket.java AprSocketContext.java

2012-07-12 Thread Mark Thomas
On 12/07/2012 11:48, Rainer Jung wrote: > On 12.07.2012 12:30, ma...@apache.org wrote: >> Author: markt >> Date: Thu Jul 12 10:30:44 2012 >> New Revision: 1360618 >> >> URL: http://svn.apache.org/viewvc?rev=1360618&view=rev >> Log: >> Clean up debug logging >> >> Modified: >> tomcat/trunk/java

svn commit: r1360746 - /tomcat/trunk/java/org/apache/tomcat/jni/socket/AprSocket.java

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 16:19:45 2012 New Revision: 1360746 URL: http://svn.apache.org/viewvc?rev=1360746&view=rev Log: Remove level check Modified: tomcat/trunk/java/org/apache/tomcat/jni/socket/AprSocket.java Modified: tomcat/trunk/java/org/apache/tomcat/jni/socket/AprSocket.java UR

Re: access to build environment

2012-07-12 Thread Mark Thomas
On 12/07/2012 15:28, Filip Hanik (mailing lists) wrote: >> -Original Message- >> From: Mark Thomas [mailto:ma...@apache.org] >> Sent: Thursday, July 12, 2012 1:33 AM >> To: Tomcat Developers List >> Subject: Re: access to build environment >> >> On 12/07/2012 02:06, Filip Hanik wrote: >>> I

svn commit: r1360748 - /tomcat/trunk/build.xml

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 16:21:42 2012 New Revision: 1360748 URL: http://svn.apache.org/viewvc?rev=1360748&view=rev Log: Whitespace police Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1360748&r1=1360747&

svn commit: r1360806 - in /tomcat/trunk/java/javax/el: BeanELResolver.java ELContext.java ExpressionFactory.java ListELResolver.java MapELResolver.java ResourceBundleELResolver.java

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 16:40:55 2012 New Revision: 1360806 URL: http://svn.apache.org/viewvc?rev=1360806&view=rev Log: Code clean-up for javax.el - Add final prompted by UCDetector - Java 7 use of <> Modified: tomcat/trunk/java/javax/el/BeanELResolver.java tomcat/trunk/java/java

svn commit: r1360811 - /tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/driver/Driver.java

2012-07-12 Thread fhanik
Author: fhanik Date: Thu Jul 12 16:50:58 2012 New Revision: 1360811 URL: http://svn.apache.org/viewvc?rev=1360811&view=rev Log: fix override annotation Modified: tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/driver/Driver.java Modified: tomcat/tc7.0.x/tru

svn commit: r1360814 - in /tomcat/trunk/java/javax/servlet: ./ http/ jsp/el/ jsp/tagext/

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 17:04:02 2012 New Revision: 1360814 URL: http://svn.apache.org/viewvc?rev=1360814&view=rev Log: Code clean-up for javax.servlet - Add final prompted by UCDetector - Java 7 use of <> Modified: tomcat/trunk/java/javax/servlet/ServletSecurityElement.java tomc

svn commit: r1360821 - /tomcat/trunk/TOMCAT-NEXT.txt

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 17:13:13 2012 New Revision: 1360821 URL: http://svn.apache.org/viewvc?rev=1360821&view=rev Log: Update Modified: tomcat/trunk/TOMCAT-NEXT.txt Modified: tomcat/trunk/TOMCAT-NEXT.txt URL: http://svn.apache.org/viewvc/tomcat/trunk/TOMCAT-NEXT.txt?rev=1360821&r1=1

svn commit: r1360822 - /tomcat/trunk/TOMCAT-NEXT.txt

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 17:15:14 2012 New Revision: 1360822 URL: http://svn.apache.org/viewvc?rev=1360822&view=rev Log: More work Modified: tomcat/trunk/TOMCAT-NEXT.txt Modified: tomcat/trunk/TOMCAT-NEXT.txt URL: http://svn.apache.org/viewvc/tomcat/trunk/TOMCAT-NEXT.txt?rev=1360822&r

svn commit: r1360838 - in /tomcat/trunk/java/org/apache/catalina/ant/jmx: Arg.java JMXAccessorCreateTask.java JMXAccessorInvokeTask.java

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 18:07:12 2012 New Revision: 1360838 URL: http://svn.apache.org/viewvc?rev=1360838&view=rev Log: Deprecate so they can be made private Modified: tomcat/trunk/java/org/apache/catalina/ant/jmx/Arg.java tomcat/trunk/java/org/apache/catalina/ant/jmx/JMXAccessorCr

svn commit: r1360839 - in /tomcat/trunk/java/org/apache/catalina/ant/jmx: Arg.java JMXAccessorCreateTask.java JMXAccessorInvokeTask.java JMXAccessorTask.java

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 18:10:32 2012 New Revision: 1360839 URL: http://svn.apache.org/viewvc?rev=1360839&view=rev Log: Code clean-up for o.a.catalina.ant.jmx - Add final prompted by UCDetector - Java 7 use of <> Modified: tomcat/trunk/java/org/apache/catalina/ant/jmx/Arg.java to

svn commit: r1360840 - in /tomcat/trunk/java/org/apache/catalina/ant: AbstractCatalinaTask.java BaseRedirectorHelperTask.java

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 18:12:36 2012 New Revision: 1360840 URL: http://svn.apache.org/viewvc?rev=1360840&view=rev Log: Code clean-up for o.a.catalina.ant - Add final prompted by UCDetector - Java 7 use of <> Modified: tomcat/trunk/java/org/apache/catalina/ant/AbstractCatalinaTask.ja

svn commit: r1360841 - in /tomcat/trunk/java/org/apache/catalina/authenticator: SavedRequest.java SingleSignOn.java

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 18:14:58 2012 New Revision: 1360841 URL: http://svn.apache.org/viewvc?rev=1360841&view=rev Log: Code clean-up for o.a.catalina.authenticator - Add final prompted by UCDetector - Java 7 use of <> Modified: tomcat/trunk/java/org/apache/catalina/authenticator/Sav

[Bug 53541] New: Bug in virtual webapp feature. Custom tags badly supported.

2012-07-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53541 Priority: P2 Bug ID: 53541 Assignee: dev@tomcat.apache.org Summary: Bug in virtual webapp feature. Custom tags badly supported. Severity: major Classification: Uncl

[Bug 53541] Bug in virtual webapp feature. Custom tags badly supported.

2012-07-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53541 Philip changed: What|Removed |Added CC||philipz...@gmail.com OS|

[Bug 53541] Bug in virtual webapp feature. Custom tags badly supported.

2012-07-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53541 --- Comment #1 from Philip --- All configs, sources, logs mentioned in the defect report, can be downloaded here - https://docs.google.com/open?id=0B1YRF9AZ53VhSlJaRkY5dS1aZW8 P.S. Bugzilla limited me to 1kb per attachement, it's very unus

svn commit: r1360847 - /tomcat/trunk/java/org/apache/catalina/connector/Response.java

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 18:30:32 2012 New Revision: 1360847 URL: http://svn.apache.org/viewvc?rev=1360847&view=rev Log: Deprecate unused protected field Modified: tomcat/trunk/java/org/apache/catalina/connector/Response.java Modified: tomcat/trunk/java/org/apache/catalina/connector/Re

[Bug 53541] Bug in virtual webapp feature. Custom tags badly supported. Error is "org.apache.jasper.JasperException: The absolute uri: http://java.sun.com/jsp/jstl/core cannot be resolved in either we

2012-07-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53541 Philip changed: What|Removed |Added Summary|Bug in virtual webapp |Bug in virtual webapp |

[Bug 53541] Bug in virtual webapp feature. Custom tags badly supported. Error is "org.apache.jasper.JasperException: The absolute uri: http://java.sun.com/jsp/jstl/core cannot be resolved in either we

2012-07-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53541 Philip changed: What|Removed |Added URL||https://docs.google.com/ope

svn commit: r1360850 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ant/jmx/Arg.java java/org/apache/catalina/ant/jmx/JMXAccessorCreateTask.java java/org/apache/catalina/ant/jmx/JMXAccessorIn

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 18:35:57 2012 New Revision: 1360850 URL: http://svn.apache.org/viewvc?rev=1360850&view=rev Log: Deprecate so they can be made private in 8.0.x Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/ant/jmx/Arg.java

svn commit: r1360851 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/connector/Response.java

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 18:37:11 2012 New Revision: 1360851 URL: http://svn.apache.org/viewvc?rev=1360851&view=rev Log: Deprecate unused code Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/Response.java Propchange: tomcat/

svn commit: r1360853 - /tomcat/trunk/java/org/apache/catalina/connector/Response.java

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 18:37:43 2012 New Revision: 1360853 URL: http://svn.apache.org/viewvc?rev=1360853&view=rev Log: Remove unused code Modified: tomcat/trunk/java/org/apache/catalina/connector/Response.java Modified: tomcat/trunk/java/org/apache/catalina/connector/Response.java UR

svn commit: r1360855 - in /tomcat/trunk/java/org/apache/catalina/connector: Connector.java CoyoteAdapter.java CoyotePrincipal.java InputBuffer.java MapperListener.java OutputBuffer.java Request.java R

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 18:42:57 2012 New Revision: 1360855 URL: http://svn.apache.org/viewvc?rev=1360855&view=rev Log: Code clean-up for o.a.catalina.connector - Add final prompted by UCDetector - Java 7 use of <> Modified: tomcat/trunk/java/org/apache/catalina/connector/Connector.j

svn commit: r1360892 - /tomcat/trunk/java/org/apache/catalina/core/ApplicationJspPropertyGroupDescriptor.java

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 19:50:56 2012 New Revision: 1360892 URL: http://svn.apache.org/viewvc?rev=1360892&view=rev Log: Deprecate Modified: tomcat/trunk/java/org/apache/catalina/core/ApplicationJspPropertyGroupDescriptor.java Modified: tomcat/trunk/java/org/apache/catalina/core/Appl

svn commit: r1360894 - /tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 19:58:38 2012 New Revision: 1360894 URL: http://svn.apache.org/viewvc?rev=1360894&view=rev Log: Fix Java 7 warnings Modified: tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java Modified: tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.

svn commit: r1360905 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioSelectorPool.java

2012-07-12 Thread fhanik
Author: fhanik Date: Thu Jul 12 20:11:31 2012 New Revision: 1360905 URL: http://svn.apache.org/viewvc?rev=1360905&view=rev Log: Correct handling of timeout - negative or zero means no timeout but an instant Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioSelectorPool.java Modified

Re: svn commit: r1360905 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioSelectorPool.java

2012-07-12 Thread Mark Thomas
On 12/07/2012 21:11, fha...@apache.org wrote: > Author: fhanik > Date: Thu Jul 12 20:11:31 2012 > New Revision: 1360905 > > URL: http://svn.apache.org/viewvc?rev=1360905&view=rev > Log: > Correct handling of timeout - negative or zero means no timeout but an instant Nope. The expected and documen

svn commit: r1360910 - /tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 20:26:48 2012 New Revision: 1360910 URL: http://svn.apache.org/viewvc?rev=1360910&view=rev Log: Code clean-up - Add final prompted by UCDetector - Java 7 use of <> Modified: tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java Modified: tomcat/trunk/

svn commit: r1360917 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioSelectorPool.java

2012-07-12 Thread fhanik
Author: fhanik Date: Thu Jul 12 20:40:02 2012 New Revision: 1360917 URL: http://svn.apache.org/viewvc?rev=1360917&view=rev Log: Fix timeout according to Javadoc Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioSelectorPool.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/

RE: svn commit: r1360905 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioSelectorPool.java

2012-07-12 Thread Filip Hanik (mailing lists)
You are correct, I was chasing down the following: Testsuite: org.apache.catalina.websocket.TestWebSocket Tests run: 6, Failures: 1, Errors: 0, Time elapsed: 2.048 sec INFO: Starting ProtocolHandler ["http-nio-127.0.0.1-auto-2-9027"] Jul 12, 2012 11:56:27 AM org.apache.coyote.AbstractProtoco

RE: Current unit test behaviour for trunk using Java 7 on Solaris

2012-07-12 Thread Filip Hanik (mailing lists)
Fixed in http://svn.apache.org/viewvc?view=revision&revision=1360917 DBCP should compile as well as JDBC-POOL with 1.7 now too > -Original Message- > From: Rainer Jung [mailto:rainer.j...@kippdata.de] > Sent: Thursday, July 12, 2012 6:33 AM > To: Tomcat Developers List > Subject: Current

Re: svn commit: r1360905 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioSelectorPool.java

2012-07-12 Thread Mark Thomas
On 12/07/2012 21:42, Filip Hanik (mailing lists) wrote: > You are correct, I was chasing down the following: > > Testsuite: org.apache.catalina.websocket.TestWebSocket > Tests run: 6, Failures: 1, Errors: 0, Time elapsed: 2.048 sec > > INFO: Starting ProtocolHandler ["http-nio-127.0.0.1-auto-

svn commit: r1360929 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioSelectorPool.java

2012-07-12 Thread fhanik
Author: fhanik Date: Thu Jul 12 20:48:31 2012 New Revision: 1360929 URL: http://svn.apache.org/viewvc?rev=1360929&view=rev Log: brain farts today. Must get the value of the keycount key Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioSelectorPool.java Modified: tomcat/trunk/java/or

svn commit: r1360933 - /tomcat/trunk/java/org/apache/catalina/core/

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 20:51:27 2012 New Revision: 1360933 URL: http://svn.apache.org/viewvc?rev=1360933&view=rev Log: Code clean-up for o.a.catalina.core - Add final prompted by UCDetector - Java 7 use of <> Modified: tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.ja

Re: Current unit test behaviour for trunk using Java 7 on Solaris

2012-07-12 Thread Filip Hanik Mailing Lists
and properly fixed in http://svn.apache.org/viewvc?view=revision&revision=1360929 - Original Message - > From: "Filip Hanik (mailing lists)" > To: "Tomcat Developers List" > Sent: Thursday, July 12, 2012 2:43:55 PM > Subject: RE: Current unit test behaviour for trunk using Java 7 on Sol

svn commit: r1360942 - in /tomcat/trunk/java/org/apache/catalina/core: StandardWrapper.java StandardWrapperValve.java

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 21:06:42 2012 New Revision: 1360942 URL: http://svn.apache.org/viewvc?rev=1360942&view=rev Log: Deprecate unused setters Modified: tomcat/trunk/java/org/apache/catalina/core/StandardWrapper.java tomcat/trunk/java/org/apache/catalina/core/StandardWrapperValve

svn commit: r1360943 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ApplicationJspPropertyGroupDescriptor.java java/org/apache/catalina/core/StandardWrapper.java java/org/apache/catalina

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 21:07:48 2012 New Revision: 1360943 URL: http://svn.apache.org/viewvc?rev=1360943&view=rev Log: Deprecation prior to removal in 8.0.x Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/ApplicationJspProperty

svn commit: r1360946 - /tomcat/trunk/java/org/apache/catalina/core/StandardWrapperValve.java

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 21:10:13 2012 New Revision: 1360946 URL: http://svn.apache.org/viewvc?rev=1360946&view=rev Log: Fix a FindBugs warning (increment of volatile not atomic) Modified: tomcat/trunk/java/org/apache/catalina/core/StandardWrapperValve.java Modified: tomcat/trunk/java/

svn commit: r1360949 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 21:14:03 2012 New Revision: 1360949 URL: http://svn.apache.org/viewvc?rev=1360949&view=rev Log: Filter out a false positive Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml URL: http:

svn commit: r1360957 - in /tomcat/trunk/java/org/apache/catalina/core: StandardServer.java StandardService.java

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 21:27:13 2012 New Revision: 1360957 URL: http://svn.apache.org/viewvc?rev=1360957&view=rev Log: Fix FindBugs issues (sync on mutated object) Modified: tomcat/trunk/java/org/apache/catalina/core/StandardServer.java tomcat/trunk/java/org/apache/catalina/core/S

svn commit: r1360966 - /tomcat/trunk/java/org/apache/catalina/deploy/

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 21:40:27 2012 New Revision: 1360966 URL: http://svn.apache.org/viewvc?rev=1360966&view=rev Log: Code clean-up for o.a.catalina.deploy - Add final prompted by UCDetector - Java 7 use of <> Modified: tomcat/trunk/java/org/apache/catalina/deploy/ContextHandler.ja

svn commit: r1360969 - in /tomcat/trunk/java/org/apache/catalina/deploy: InjectionTarget.java SecurityRoleRef.java

2012-07-12 Thread markt
Author: markt Date: Thu Jul 12 21:45:37 2012 New Revision: 1360969 URL: http://svn.apache.org/viewvc?rev=1360969&view=rev Log: Fix FindBugs warnings (Serializable classes with non-serializabe fields) Modified: tomcat/trunk/java/org/apache/catalina/deploy/InjectionTarget.java tomcat/trunk/

[Bug 53542] New: Spelling mistake on 503 service unavailable page

2012-07-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53542 Priority: P2 Bug ID: 53542 Assignee: dev@tomcat.apache.org Summary: Spelling mistake on 503 service unavailable page Severity: minor Classification: Unclassified OS: Wi