Author: markt
Date: Sat Oct 29 16:11:02 2011
New Revision: 1194915
URL: http://svn.apache.org/viewvc?rev=1194915&view=rev
Log:
Review comments from kkolinko for parameter parsing improvements
Modified:
tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java
tomcat/trunk/java/org/ap
Author: markt
Date: Sat Oct 29 16:16:18 2011
New Revision: 1194917
URL: http://svn.apache.org/viewvc?rev=1194917&view=rev
Log:
Review comments from kkolinko for parameter parsing improvements
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/uti
Author: markt
Date: Sat Oct 29 16:16:53 2011
New Revision: 1194919
URL: http://svn.apache.org/viewvc?rev=1194919&view=rev
Log:
Update proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.tx
On 29/10/2011 01:55, kkoli...@apache.org wrote:
> Author: kkolinko
> Date: Sat Oct 29 00:55:28 2011
> New Revision: 1190720
>
> URL: http://svn.apache.org/viewvc?rev=1190720&view=rev
> Log:
> Add one more patch to Mark's proposal.
> Veto and add review comments.
Thanks for the comments. Fixes app
Author: markt
Date: Sat Oct 29 16:18:01 2011
New Revision: 1194920
URL: http://svn.apache.org/viewvc?rev=1194920&view=rev
Log:
Update proposal
Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.tx
Hi,
As part of Commons daemon that we ship with tomcat
there is example daemon launch script which users
have started to use for running tomcat under jsvc.
I propose we move that script from daemon to tomcat
since it belongs here.
The script can be found inside each tomcat distribution as
bin/com
2011/10/29 Mark Thomas :
>> + - Maybe "if (paramHashValues.containsKey(key))" can be replaced
>> + with testing whether result of (paramHashValues.containsKey(key))
>> is null.
> Hashtable does not permit null keys or values.
>> + - Maybe "if (paramHashValues.containsKey(key))" c
On 29/10/2011 19:08, Konstantin Kolinko wrote:
> I mean that there are two hashtable lookup operations in a row:
>
> a) containsKey(key)
> b) get(key) if a) returned true
>
> It can be replaced by calling b) once and testing whether its result is null.
Doh. Got it this time. I'll look at that to
