svn commit: r1137541 - in /tomcat/trunk: conf/catalina.properties webapps/docs/changelog.xml

Author: rjung Date: Mon Jun 20 08:06:56 2011 New Revision: 1137541 URL: http://svn.apache.org/viewvc?rev=1137541&view=rev Log: Add the Tomcat extras JARs to the list of JARs to skip when scanning for TLDs and web fragments. Modified: tomcat/trunk/conf/catalina.properties tomcat/trunk/weba

svn commit: r1137559 - /tomcat/trunk/bin/digest.bat

Author: rjung Date: Mon Jun 20 09:27:30 2011 New Revision: 1137559 URL: http://svn.apache.org/viewvc?rev=1137559&view=rev Log: Make Windows shell scripts for individual commands consistent. Modified: tomcat/trunk/bin/digest.bat Modified: tomcat/trunk/bin/digest.bat URL: http://svn.apache.or

svn commit: r1137560 - /tomcat/trunk/bin/configtest.bat

Author: rjung Date: Mon Jun 20 09:27:44 2011 New Revision: 1137560 URL: http://svn.apache.org/viewvc?rev=1137560&view=rev Log: Add missing Windows configtest script. Added: tomcat/trunk/bin/configtest.bat (with props) Added: tomcat/trunk/bin/configtest.bat URL: http://svn.apache.org/viewv

svn commit: r1137558 - in /tomcat/trunk/bin: configtest.sh digest.sh shutdown.sh startup.sh version.sh

Author: rjung Date: Mon Jun 20 09:26:36 2011 New Revision: 1137558 URL: http://svn.apache.org/viewvc?rev=1137558&view=rev Log: Make Unix shell scripts for individual commands consistent. Modified: tomcat/trunk/bin/configtest.sh (contents, props changed) tomcat/trunk/bin/digest.sh to

svn commit: r1137565 - /tomcat/trunk/bin/setclasspath.bat

Author: rjung Date: Mon Jun 20 09:50:17 2011 New Revision: 1137565 URL: http://svn.apache.org/viewvc?rev=1137565&view=rev Log: Make JRE / JDK detection on Windows work the same way as on Unix: - if "debug" is demanded, only use JAVA_HOME and check for a JDK there - without "debug", either use JR

svn commit: r1137567 - /tomcat/trunk/bin/catalina.sh

Author: rjung Date: Mon Jun 20 09:52:16 2011 New Revision: 1137567 URL: http://svn.apache.org/viewvc?rev=1137567&view=rev Log: - Clarify JRE_HOME in catalina.sh - sort OS detection by OS name Modified: tomcat/trunk/bin/catalina.sh Modified: tomcat/trunk/bin/catalina.sh URL: http://svn.apach

svn commit: r1137568 - /tomcat/trunk/bin/tool-wrapper.sh

Author: rjung Date: Mon Jun 20 09:52:45 2011 New Revision: 1137568 URL: http://svn.apache.org/viewvc?rev=1137568&view=rev Log: Make tool-wrapper.sh consistent with catalina.sh. Modified: tomcat/trunk/bin/tool-wrapper.sh Modified: tomcat/trunk/bin/tool-wrapper.sh URL: http://svn.apache.org/v

svn commit: r1137569 - in /tomcat/trunk/bin: catalina.bat tool-wrapper.bat

Author: rjung Date: Mon Jun 20 09:53:37 2011 New Revision: 1137569 URL: http://svn.apache.org/viewvc?rev=1137569&view=rev Log: Make variable explanations for catalina.bat and tool-wrapper.bat consistent with their Unix counterparts. Modified: tomcat/trunk/bin/catalina.bat tomcat/trunk/bin

DO NOT REPLY [Bug 51384] Adding http codebase to catalina.policy file causes ClassLoaderLogManager access denied exception

https://issues.apache.org/bugzilla/show_bug.cgi?id=51384 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

Using eval vs. exec in shell scripts

Since Mladens change r918873 in March 2010 we use eval instead of exec in the shell scripts. The svn log says: "Use eval instead direct call or exec command so that arguments with spaces are properly handled" Eval leaves a copy of the shell process hanging around until Tomcat shutdown. I want to

svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

Author: rjung Date: Mon Jun 20 12:37:01 2011 New Revision: 1137607 URL: http://svn.apache.org/viewvc?rev=1137607&view=rev Log: Slight improvement of configtest handling in Unix shell script: - add to usage - don't use CATALINA_OPTS (think memory size etc.) - log a message if status != 0 Modified

svn commit: r1137609 - /tomcat/trunk/bin/catalina.bat

Author: rjung Date: Mon Jun 20 12:37:57 2011 New Revision: 1137609 URL: http://svn.apache.org/viewvc?rev=1137609&view=rev Log: Add configtest to Windows catalina.bat. Not yet complete: - No error code escalation - No log message Modified: tomcat/trunk/bin/catalina.bat Modified: tomcat/trun

Re: Using eval vs. exec in shell scripts

Which script ? Could you send us the svn link ? 2011/6/20 Rainer Jung : > Since Mladens change r918873 in March 2010 we use eval instead of exec > in the shell scripts. The svn log says: > > "Use eval instead direct call or exec command so that arguments with > spaces are properly handled" > > Ev

Overhauling setclasspath.(bat|sh)?

1) Renaming Since quite some time now the setclasspath script doesn't have anything to do with setting a class path. It only searches for JRE / JDK and sets up the path to the Java or JDB binary plus JAVA_ENDORSED_DIRS. So it would be more correct to call it checkjava.sh or setupjava.sh or whatev

Re: Using eval vs. exec in shell scripts

On 06/20/2011 01:39 PM, Rainer Jung wrote: Since Mladens change r918873 in March 2010 we use eval instead of exec in the shell scripts. The svn log says: "Use eval instead direct call or exec command so that arguments with spaces are properly handled" Mladen or whoever else understood this: can

Re: Overhauling setclasspath.(bat|sh)?

On Mon, Jun 20, 2011 at 2:50 PM, Rainer Jung wrote: > 1) Renaming > > Since quite some time now the setclasspath script doesn't have anything > to do with setting a class path. It only searches for JRE / JDK and sets > up the path to the Java or JDB binary plus JAVA_ENDORSED_DIRS. > > So it would

Re: svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

On 06/20/2011 02:37 PM, rj...@apache.org wrote: Author: rjung Date: Mon Jun 20 12:37:01 2011 New Revision: 1137607 URL: http://svn.apache.org/viewvc?rev=1137607&view=rev Log: Slight improvement of configtest handling in Unix shell script: - add to usage - don't use CATALINA_OPTS (think memory s

Re: Using eval vs. exec in shell scripts

On 20.06.2011 14:52, Mladen Turk wrote: > On 06/20/2011 01:39 PM, Rainer Jung wrote: >> Since Mladens change r918873 in March 2010 we use eval instead of exec >> in the shell scripts. The svn log says: >> >> "Use eval instead direct call or exec command so that arguments with >> spaces are properly

Re: Overhauling setclasspath.(bat|sh)?

On 20.06.2011 14:54, Leon Rosenberg wrote: > On Mon, Jun 20, 2011 at 2:50 PM, Rainer Jung wrote: >> 1) Renaming >> >> Since quite some time now the setclasspath script doesn't have anything >> to do with setting a class path. It only searches for JRE / JDK and sets >> up the path to the Java or JD

Re: svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

On 20.06.2011 14:56, Mladen Turk wrote: > On 06/20/2011 02:37 PM, rj...@apache.org wrote: >> Author: rjung >> Date: Mon Jun 20 12:37:01 2011 >> New Revision: 1137607 >> >> URL: http://svn.apache.org/viewvc?rev=1137607&view=rev >> Log: >> Slight improvement of configtest handling in >> Unix shell sc

DO NOT REPLY [Bug 51328] StringManager/ResourceBundle parsing error causes webapp deployment to fail on ppc64 gcj

https://issues.apache.org/bugzilla/show_bug.cgi?id=51328 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|

Re: svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

On 06/20/2011 03:16 PM, Rainer Jung wrote: On 20.06.2011 14:56, Mladen Turk wrote: On 06/20/2011 02:37 PM, rj...@apache.org wrote: Author: rjung Date: Mon Jun 20 12:37:01 2011 New Revision: 1137607 URL: http://svn.apache.org/viewvc?rev=1137607&view=rev Log: Slight improvement of configtest han

DO NOT REPLY [Bug 51124] ArrayIndexOutOfBoundsException after setting org.apache.jasper.runtime.BodyContentImpl.LIMIT_BUFFER=true

https://issues.apache.org/bugzilla/show_bug.cgi?id=51124 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|

svn commit: r1137627 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/jasper/runtime/BodyContentImpl.java webapps/docs/changelog.xml

Author: markt Date: Mon Jun 20 13:26:12 2011 New Revision: 1137627 URL: http://svn.apache.org/viewvc?rev=1137627&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51124 Make Tomcat more robust if an OOME occurs. Usually after an OOME all bets are off but this change appears to

Re: svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

On 20/06/2011 14:21, Mladen Turk wrote: > Just don't see what was the problem with that option that > would require it to go away. This wasn't discussed on the dev list > so if I weren't tracking the svn commits it would be a big surprise on > the next tomcat release. Look at the patch again. It o

Re: Overhauling setclasspath.(bat|sh)?

now when you say it, it does really make sense ;-) thanx leon On Mon, Jun 20, 2011 at 3:15 PM, Rainer Jung wrote: > On 20.06.2011 14:54, Leon Rosenberg wrote: >> On Mon, Jun 20, 2011 at 2:50 PM, Rainer Jung wrote: >>> 1) Renaming >>> >>> Since quite some time now the setclasspath script doesn't

Re: svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

On 20.06.2011 14:56, Mladen Turk wrote: > On 06/20/2011 02:37 PM, rj...@apache.org wrote: >> Author: rjung >> Date: Mon Jun 20 12:37:01 2011 >> New Revision: 1137607 >> >> URL: http://svn.apache.org/viewvc?rev=1137607&view=rev >> Log: >> Slight improvement of configtest handling in >> Unix shell sc

svn commit: r1137629 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/Context.java java/org/apache/catalina/session/ManagerBase.java webapps/docs/changelog.xml

Author: markt Date: Mon Jun 20 13:38:23 2011 New Revision: 1137629 URL: http://svn.apache.org/viewvc?rev=1137629&view=rev Log: Expose a container event for changing the session ID Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/ja

svn commit: r1137630 - /tomcat/tc6.0.x/trunk/STATUS.txt

Author: markt Date: Mon Jun 20 13:42:58 2011 New Revision: 1137630 URL: http://svn.apache.org/viewvc?rev=1137630&view=rev Log: Vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=11376

Re: svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

2011/6/20 Mladen Turk : >> >> Look at the patch again. It only removes the option for configtest >> > > It depends what you have in CATALINA_OPTS. > If you have -d32/-d64 this won't get picked. > However still don't get it why it was removed? > > Funny, but I was actually trying to add $CATALINA_OP

Re: svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

On 20.06.2011 15:41, Mladen Turk wrote: > On 06/20/2011 03:28 PM, Mark Thomas wrote: >> On 20/06/2011 14:21, Mladen Turk wrote: >>> Just don't see what was the problem with that option that >>> would require it to go away. This wasn't discussed on the dev list >>> so if I weren't tracking the svn c

Re: Using eval vs. exec in shell scripts

On 06/20/2011 03:12 PM, Rainer Jung wrote: ... and We eval for start/stop so we can get the pid. And this is broken now. We used $! with exec and we still use it with eval. But with eval $! returns the pid of a child shell and the java process id a child of that pid. Are you sure? cat

Re: svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

On 06/20/2011 03:53 PM, Rainer Jung wrote: On 20.06.2011 15:41, Mladen Turk wrote: In general all commands except those that start a Tomcat (and thus deploy webapps etc.) should not use that type of params. They should go into CATALINA_OPTS. Everything that you can use multiple times in parallel

Re: svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

On 06/20/2011 03:28 PM, Mark Thomas wrote: On 20/06/2011 14:21, Mladen Turk wrote: Just don't see what was the problem with that option that would require it to go away. This wasn't discussed on the dev list so if I weren't tracking the svn commits it would be a big surprise on the next tomcat r

Re: Using eval vs. exec in shell scripts

On 20.06.2011 15:59, Mladen Turk wrote: > On 06/20/2011 03:12 PM, Rainer Jung wrote: >> >>> ... and >>> We eval for start/stop so we can get the pid. >> >> And this is broken now. We used $! with exec and we still use it with >> eval. But with eval $! returns the pid of a child shell and the java >

Re: svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

On 6/20/2011 8:06 AM, Mladen Turk wrote: On 06/20/2011 03:53 PM, Rainer Jung wrote: On 20.06.2011 15:41, Mladen Turk wrote: In general all commands except those that start a Tomcat (and thus deploy webapps etc.) should not use that type of params. They should go into CATALINA_OPTS. Everything t

Re: svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

On 20.06.2011 16:06, Mladen Turk wrote: > On 06/20/2011 03:53 PM, Rainer Jung wrote: >> On 20.06.2011 15:41, Mladen Turk wrote: >> >> In general all commands except those that start a Tomcat (and thus >> deploy webapps etc.) should not use that type of params. They should go >> into CATALINA_OPTS.

svn commit: r1137638 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11AprProtocol.java

Author: markt Date: Mon Jun 20 14:24:19 2011 New Revision: 1137638 URL: http://svn.apache.org/viewvc?rev=1137638&view=rev Log: Remove unnecessary code. Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol

OneLineFormatter by default?

Should we use the new OneLineFormatter as the default juli formatter? I never found anyone who liked the default java.util.logging log format, which spreads all messages out via two lines. One line contains the timestamp, the other line the message. So if your grep for a message, you want find ou

Re: OneLineFormatter by default?

On 20/06/2011 15:51, Rainer Jung wrote: > Should we use the new OneLineFormatter as the default juli formatter? > > I never found anyone who liked the default java.util.logging log format, > which spreads all messages out via two lines. One line contains the > timestamp, the other line the message

svn commit: r1137646 - /tomcat/trunk/java/org/apache/jasper/JspCompilationContext.java

Author: markt Date: Mon Jun 20 14:57:37 2011 New Revision: 1137646 URL: http://svn.apache.org/viewvc?rev=1137646&view=rev Log: Packages tag files have jndi URLs not file URLs Modified: tomcat/trunk/java/org/apache/jasper/JspCompilationContext.java Modified: tomcat/trunk/java/org/apache/jaspe

DO NOT REPLY [Bug 51395] New: First application that loads SAXParserFactory causes Class loader memory leak

https://issues.apache.org/bugzilla/show_bug.cgi?id=51395 Bug #: 51395 Summary: First application that loads SAXParserFactory causes Class loader memory leak Product: Tomcat 7 Version: 7.0.14 Platform: PC OS/Version

DO NOT REPLY [Bug 51395] First application that loads SAXParserFactory causes Class loader memory leak

https://issues.apache.org/bugzilla/show_bug.cgi?id=51395 --- Comment #1 from Arjen Knibbe 2011-06-20 15:07:59 UTC --- Created attachment 27179 --> https://issues.apache.org/bugzilla/attachment.cgi?id=27179 Minimal web application with xercesImpl in lib -- Configure bugmail: https://issues.ap

DO NOT REPLY [Bug 51395] First application that loads SAXParserFactory causes Class loader memory leak

https://issues.apache.org/bugzilla/show_bug.cgi?id=51395 --- Comment #2 from Arjen Knibbe 2011-06-20 15:08:46 UTC --- Created attachment 27180 --> https://issues.apache.org/bugzilla/attachment.cgi?id=27180 Minimal web application with xercesImpl in lib - second part -- Configure bugmail: htt

svn commit: r1137652 - /tomcat/trunk/webapps/docs/changelog.xml

Author: rjung Date: Mon Jun 20 15:11:59 2011 New Revision: 1137652 URL: http://svn.apache.org/viewvc?rev=1137652&view=rev Log: Add note about script changes. Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc

Re: Wiki spam prevention measure

On 19 June 2011 15:20, Konstantin Kolinko wrote: > 2011/6/19 sebb : >> Gavin recently updated the details of how the ASF Wiki works, and >> added details of how SpamAssassin have completely stopped spam >> happening: >> >> http://wiki.apache.org/general/OurWikiFarm#per_wiki_access_control_-_tighte

svn commit: r1137693 - in /tomcat/trunk: java/org/apache/catalina/startup/ContextConfig.java webapps/docs/changelog.xml

Author: markt Date: Mon Jun 20 16:38:40 2011 New Revision: 1137693 URL: http://svn.apache.org/viewvc?rev=1137693&view=rev Log: The fix for bug 51310 caused a regression that re-introduced bug 49957 and deleted the contents of the work directory when Tomcat was shutdown. This fix ensures that tha

Re: OneLineFormatter by default?

2011/6/20 Rainer Jung : > Should we use the new OneLineFormatter as the default juli formatter? > > I never found anyone who liked the default java.util.logging log format, > which spreads all messages out via two lines. One line contains the > timestamp, the other line the message. > > So if your

DO NOT REPLY [Bug 51396] New: Embedding class cannot launch a webapp with a jsp servlet

https://issues.apache.org/bugzilla/show_bug.cgi?id=51396 Bug #: 51396 Summary: Embedding class cannot launch a webapp with a jsp servlet Product: Tomcat 7 Version: 7.0.16 Platform: PC Status: NEW Seve

DO NOT REPLY [Bug 51396] Embedding class cannot launch a webapp with a jsp servlet

https://issues.apache.org/bugzilla/show_bug.cgi?id=51396 bmargulies changed: What|Removed |Added OS/Version||All Severity|normal

DO NOT REPLY [Bug 51396] Embedding class cannot launch a webapp with a jsp servlet

https://issues.apache.org/bugzilla/show_bug.cgi?id=51396 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 51396] Embedding class cannot launch a webapp with a jsp servlet

https://issues.apache.org/bugzilla/show_bug.cgi?id=51396 bmargulies changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID

Re: Fixing bug 33453

Getting back to this. Comments in-line. On 23/05/2011 22:01, Konstantin Kolinko wrote: > 2011/5/20 Mark Thomas : >> All, >> >> I've been looking at [1]. Ignoring the flames, there do appear to be >> several use cases where the current time-stamp checks are insufficient >> (although there are simpl

svn commit: r1137725 - in /tomcat/trunk: java/org/apache/catalina/loader/ java/org/apache/jasper/ java/org/apache/jasper/compiler/ java/org/apache/jasper/runtime/ java/org/apache/jasper/servlet/ webap

Author: markt Date: Mon Jun 20 18:02:25 2011 New Revision: 1137725 URL: http://svn.apache.org/viewvc?rev=1137725&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=33453 Recompile JSPs if last modified time of the source or any of its dependencies changes either forwards or back

DO NOT REPLY [Bug 33453] Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

https://issues.apache.org/bugzilla/show_bug.cgi?id=33453 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|

Re: OneLineFormatter by default?

Thanks Konstantin. I'll take a look at cleaning up 1) to 3), likely using the DateFormatCache from the AccessLogValve as a utility class. Regards, Rainer On 20.06.2011 18:52, Konstantin Kolinko wrote: > 2011/6/20 Rainer Jung : >> Should we use the new OneLineFormatter as the default juli formatt

Re: OneLineFormatter by default?

On 20/06/2011 19:07, Rainer Jung wrote: > Thanks Konstantin. I'll take a look at cleaning up 1) to 3), likely > using the DateFormatCache from the AccessLogValve as a utility class. Already on it. Note DateFormatCache can't be used because a) JULI can't depend on Catalina and b) the AccessLog time

svn commit: r1137731 - in /tomcat/trunk: java/org/apache/juli/OneLineFormatter.java webapps/docs/changelog.xml

Author: markt Date: Mon Jun 20 18:19:08 2011 New Revision: 1137731 URL: http://svn.apache.org/viewvc?rev=1137731&view=rev Log: Address kkolinko's review comments Modified: tomcat/trunk/java/org/apache/juli/OneLineFormatter.java tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/tru

Re: OneLineFormatter by default?

On 20.06.2011 20:10, Mark Thomas wrote: > On 20/06/2011 19:07, Rainer Jung wrote: >> Thanks Konstantin. I'll take a look at cleaning up 1) to 3), likely >> using the DateFormatCache from the AccessLogValve as a utility class. > > Already on it. Note DateFormatCache can't be used because a) JULI ca

svn commit: r1137746 - /tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java

Author: rjung Date: Mon Jun 20 19:01:14 2011 New Revision: 1137746 URL: http://svn.apache.org/viewvc?rev=1137746&view=rev Log: Remove unused code. Modified: tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java Modified: tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.

Re: OneLineFormatter by default?

Mark, On 6/20/2011 10:54 AM, Mark Thomas wrote: > On 20/06/2011 15:51, Rainer Jung wrote: >> Should we use the new OneLineFormatter as the default juli formatter? >> >> I never found anyone who liked the default java.util.logging log format, >> which spreads all messages out via two lines. One lin

Re: OneLineFormatter by default?

On 20/06/2011 19:55, Rainer Jung wrote: > On 20.06.2011 20:10, Mark Thomas wrote: >> On 20/06/2011 19:07, Rainer Jung wrote: >>> Thanks Konstantin. I'll take a look at cleaning up 1) to 3), likely >>> using the DateFormatCache from the AccessLogValve as a utility class. >> >> Already on it. Note Da

Re: svn commit: r1137731 - in /tomcat/trunk: java/org/apache/juli/OneLineFormatter.java webapps/docs/changelog.xml

A version using the DateFormatCache is available at: http://people.apache.org/~rjung/patches/OneLineFormatter-DateFormatCache.patch Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional comm

Re: svn commit: r1137731 - in /tomcat/trunk: java/org/apache/juli/OneLineFormatter.java webapps/docs/changelog.xml

On 20/06/2011 20:15, Rainer Jung wrote: > A version using the DateFormatCache is available at: > > http://people.apache.org/~rjung/patches/OneLineFormatter-DateFormatCache.patch If it works, why not commit it ;) Mark - To uns

REMINDER: Participation Requested: Survey about Open-Source Software Development

Hi, Apologies for any inconvenience and thank you to those who have already completed the survey. We will keep the survey open for another couple of weeks. But, we do hope you will consider responding to the email request below (sent 2 weeks ago). Thanks, Dr. Jeffrey Carver Assistant Professor U

DO NOT REPLY [Bug 51395] First application that loads SAXParserFactory causes Class loader memory leak

https://issues.apache.org/bugzilla/show_bug.cgi?id=51395 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1137753 - in /tomcat/trunk: java/org/apache/catalina/startup/ContextConfig.java webapps/docs/changelog.xml

Author: markt Date: Mon Jun 20 19:26:45 2011 New Revision: 1137753 URL: http://svn.apache.org/viewvc?rev=1137753&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51395 Fix memory leak triggered when an application that includes a SAXParserFactory is the first web application t

DO NOT REPLY [Bug 51396] Embedding class cannot launch a webapp with a jsp servlet

https://issues.apache.org/bugzilla/show_bug.cgi?id=51396 --- Comment #3 from bmargulies 2011-06-20 19:36:14 UTC --- Since bz won't let me edit, I will improve on my description down here. 1) I've written a class that uses the embedded API: org.apache.catalina.startup.Tomcat 2) My class call

svn commit: r1137754 - in /tomcat/trunk: conf/catalina.properties test/org/apache/catalina/startup/TomcatBaseTest.java webapps/docs/changelog.xml

Author: rjung Date: Mon Jun 20 19:44:04 2011 New Revision: 1137754 URL: http://svn.apache.org/viewvc?rev=1137754&view=rev Log: More Jars to skip: ant-junit and Java Help. Modified: tomcat/trunk/conf/catalina.properties tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java

svn commit: r1137758 - in /tomcat/trunk: java/org/apache/juli/DateFormatCache.java java/org/apache/juli/OneLineFormatter.java webapps/docs/changelog.xml

Author: rjung Date: Mon Jun 20 19:47:57 2011 New Revision: 1137758 URL: http://svn.apache.org/viewvc?rev=1137758&view=rev Log: Let OneLineFormatter use DateFormatCache. Added: tomcat/trunk/java/org/apache/juli/DateFormatCache.java (with props) Modified: tomcat/trunk/java/org/apache/juli

DO NOT REPLY [Bug 51396] Embedding class cannot launch a webapp with a jsp servlet

https://issues.apache.org/bugzilla/show_bug.cgi?id=51396 --- Comment #4 from bmargulies 2011-06-20 19:51:00 UTC --- In short, if there is a defect here, it is that: org.apache.catalina.startup.Tomcat.initWebappDefaults(Context) does not set up the servlet named 'jsp' which is set up in the def

svn commit: r1137762 - /tomcat/trunk/java/org/apache/juli/DateFormatCache.java

Author: rjung Date: Mon Jun 20 20:12:26 2011 New Revision: 1137762 URL: http://svn.apache.org/viewvc?rev=1137762&view=rev Log: Make sure we never use the DateFormatCache with millisecond patterns. Tidy the format pattern like we do in the AccessLogValve. Modified: tomcat/trunk/java/org/apach

svn commit: r1137764 - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

Author: markt Date: Mon Jun 20 20:20:27 2011 New Revision: 1137764 URL: http://svn.apache.org/viewvc?rev=1137764&view=rev Log: Fix odd looking code Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig

DO NOT REPLY [Bug 51396] Embedding class cannot launch a webapp with a jsp servlet

https://issues.apache.org/bugzilla/show_bug.cgi?id=51396 --- Comment #5 from bmargulies 2011-06-20 22:09:07 UTC --- Created attachment 27182 --> https://issues.apache.org/bugzilla/attachment.cgi?id=27182 test case in a patch Here is a minimal test case as a patch. Proposed fix to follow. --

DO NOT REPLY [Bug 51396] Embedding class cannot launch a webapp with a jsp servlet

https://issues.apache.org/bugzilla/show_bug.cgi?id=51396 --- Comment #6 from Mark Thomas 2011-06-20 22:11:25 UTC --- Bugs opened shortly after almost identical reports on the users list and containing statements that are clearly wrong (the jsp servlet is defined) do tend to get closed as invalid

svn commit: r1137803 - /tomcat/trunk/webapps/docs/changelog.xml

Author: markt Date: Mon Jun 20 22:28:57 2011 New Revision: 1137803 URL: http://svn.apache.org/viewvc?rev=1137803&view=rev Log: Ordering Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/

svn commit: r1137806 - in /tomcat/trunk: java/org/apache/catalina/startup/ test/org/apache/catalina/startup/ test/webapp-3.0-fragments/ test/webapp-3.0-fragments/WEB-INF/ webapps/docs/

Author: markt Date: Mon Jun 20 22:34:16 2011 New Revision: 1137806 URL: http://svn.apache.org/viewvc?rev=1137806&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51396 Correctly handle jsp-file entries in web.xml when the JSP servlet has been configured via code when embedding

DO NOT REPLY [Bug 51396] Embedding class cannot launch a webapp with a jsp servlet

https://issues.apache.org/bugzilla/show_bug.cgi?id=51396 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|

DO NOT REPLY [Bug 51396] Embedding class cannot launch a webapp with a jsp servlet

https://issues.apache.org/bugzilla/show_bug.cgi?id=51396 bmargulies changed: What|Removed |Added Attachment #27182|0 |1 is obsolete|

DO NOT REPLY [Bug 51396] Embedding class cannot launch a webapp with a jsp servlet

https://issues.apache.org/bugzilla/show_bug.cgi?id=51396 --- Comment #9 from bmargulies 2011-06-20 22:42:30 UTC --- Well, now we've completed the whole story in parallel. Debugging the functions in ContextConfig, I think it is semi-fair to say that the jsp servlet is not, in fact, defined -- i

DO NOT REPLY [Bug 51396] Embedding class cannot launch a webapp with a jsp servlet

https://issues.apache.org/bugzilla/show_bug.cgi?id=51396 Mark Thomas changed: What|Removed |Added Attachment #27183|0 |1 is obsolete|

DO NOT REPLY [Bug 51396] Embedding class cannot launch a webapp with a jsp servlet

https://issues.apache.org/bugzilla/show_bug.cgi?id=51396 --- Comment #11 from bmargulies 2011-06-20 22:51:14 UTC --- Just for the record, it's not that I didn't see the importance of fishing the init params out of where they were, it's that I couldn't work out for myself where to find them. That

DO NOT REPLY [Bug 43790] concurrent access issue on TagHandlerPool

https://issues.apache.org/bugzilla/show_bug.cgi?id=43790 Mark Thomas changed: What|Removed |Added Status|ASSIGNED|NEW --- Comment #4 from Mark Thomas

svn commit: r1137815 - /tomcat/trunk/java/org/apache/jasper/runtime/PerThreadTagHandlerPool.java

Author: markt Date: Mon Jun 20 23:02:10 2011 New Revision: 1137815 URL: http://svn.apache.org/viewvc?rev=1137815&view=rev Log: Deprecated TagPool that may trigger memory leaks. Modified: tomcat/trunk/java/org/apache/jasper/runtime/PerThreadTagHandlerPool.java Modified: tomcat/trunk/java/org

svn commit: r1137819 - /tomcat/trunk/java/org/apache/jasper/runtime/TagHandlerPool.java

Author: markt Date: Mon Jun 20 23:09:49 2011 New Revision: 1137819 URL: http://svn.apache.org/viewvc?rev=1137819&view=rev Log: Auto format Modified: tomcat/trunk/java/org/apache/jasper/runtime/TagHandlerPool.java Modified: tomcat/trunk/java/org/apache/jasper/runtime/TagHandlerPool.java URL:

DO NOT REPLY [Bug 43790] concurrent access issue on TagHandlerPool

https://issues.apache.org/bugzilla/show_bug.cgi?id=43790 --- Comment #5 from Mark Thomas 2011-06-21 00:28:33 UTC --- Created attachment 27184 --> https://issues.apache.org/bugzilla/attachment.cgi?id=27184 Patche based on LinkedBlockingQueue While switching to LinkedBlockingQueue allows concurr

DO NOT REPLY [Bug 43790] concurrent access issue on TagHandlerPool

https://issues.apache.org/bugzilla/show_bug.cgi?id=43790 Mark Thomas changed: What|Removed |Added Attachment #21404|0 |1 is obsolete|

DO NOT REPLY [Bug 43790] concurrent access issue on TagHandlerPool

https://issues.apache.org/bugzilla/show_bug.cgi?id=43790 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 51400] New: Use of "new String(byte[] b, String enc)" hits Sun JVM bottleneck

https://issues.apache.org/bugzilla/show_bug.cgi?id=51400 Bug #: 51400 Summary: Use of "new String(byte[] b, String enc)" hits Sun JVM bottleneck Product: Tomcat 6 Version: 6.0.32 Platform: All OS/Version: All

DO NOT REPLY [Bug 51401] New: java.lang.IllegalArgumentException: element is limited to 1 occurrence

https://issues.apache.org/bugzilla/show_bug.cgi?id=51401 Bug #: 51401 Summary: java.lang.IllegalArgumentException: element is limited to 1 occurrence Product: Tomcat 7 Version: trunk Platform: All OS/Version: All

DO NOT REPLY [Bug 51401] java.lang.IllegalArgumentException: element is limited to 1 occurrence

https://issues.apache.org/bugzilla/show_bug.cgi?id=51401 --- Comment #1 from Eiji Takahashi 2011-06-21 01:59:01 UTC --- (In reply to comment #0) > When I reverted the code back to the revision 1137764, I got no exception. > Regards. Oops, sorry. Revision 1137764 is not correct. "1137693" is cor

DO NOT REPLY [Bug 51253] use_server_errors for status 401 does not forward WWW-Authenticate

https://issues.apache.org/bugzilla/show_bug.cgi?id=51253 Charles Parker changed: What|Removed |Added CC||chuck.t.par...@gmail.com -- Conf

Re: svn commit: r1137803 - /tomcat/trunk/webapps/docs/changelog.xml

On 21.06.2011 00:28, ma...@apache.org wrote: > Author: markt > Date: Mon Jun 20 22:28:57 2011 > New Revision: 1137803 > > URL: http://svn.apache.org/viewvc?rev=1137803&view=rev > Log: > Ordering > > Modified: > tomcat/trunk/webapps/docs/changelog.xml I always forget whether there's a standar

svn commit: r1137862 - in /tomcat/trunk/bin: catalina.bat catalina.sh

Author: rjung Date: Tue Jun 21 05:30:55 2011 New Revision: 1137862 URL: http://svn.apache.org/viewvc?rev=1137862&view=rev Log: Define CATALINA_BASE fallback earlier, so one can use CATALINA_BASE and CATALINA_HOME variables in setenv without knowing, whether the two have been split (i.e. CATALINA_B

svn commit: r1137866 - in /tomcat/trunk/bin: catalina.bat catalina.sh

Author: rjung Date: Tue Jun 21 06:13:44 2011 New Revision: 1137866 URL: http://svn.apache.org/viewvc?rev=1137866&view=rev Log: Clarify difference between CATALINA_OPTS and JAVA_OPTS in the scripts. Feel free to improve wording and examples. Modified: tomcat/trunk/bin/catalina.bat tomcat/

svn commit: r1137868 - in /tomcat/trunk/bin: catalina.bat catalina.sh

Author: rjung Date: Tue Jun 21 06:17:38 2011 New Revision: 1137868 URL: http://svn.apache.org/viewvc?rev=1137868&view=rev Log: Add an info about setenv.sh before listing the customizable variables. Modified: tomcat/trunk/bin/catalina.bat tomcat/trunk/bin/catalina.sh Modified: tomcat/trun

Re: svn commit: r1137803 - /tomcat/trunk/webapps/docs/changelog.xml

2011/6/21 Rainer Jung : > On 21.06.2011 00:28, ma...@apache.org wrote: >> Author: markt >> Date: Mon Jun 20 22:28:57 2011 >> New Revision: 1137803 >> >> URL: http://svn.apache.org/viewvc?rev=1137803&view=rev >> Log: >> Ordering >> >> Modified: >>     tomcat/trunk/webapps/docs/changelog.xml > > I al