Re: Response.getWriter(), getOutputStream(), setContentLength() spec issues

2011-02-27 Thread Rainer Jung
On 25.02.2011 13:01, Mark Thomas wrote: So, the questions we need to decide: 1. Is the fix for bug 50748 correct? I think it is. +0 2. Should Tomcat try and handle this situation (e.g. if any bytes have been written by a filter, commit the response). This could be tricky to get right when fo

svn commit: r1075019 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

2011-02-27 Thread markt
Author: markt Date: Sun Feb 27 10:31:49 2011 New Revision: 1075019 URL: http://svn.apache.org/viewvc?rev=1075019&view=rev Log: Another false positive Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml URL: http://svn

DO NOT REPLY [Bug 50836] LifecycleState#isAvailable() to be more restrictive

2011-02-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50836 --- Comment #6 from Mark Thomas 2011-02-27 05:49:00 EST --- (In reply to comment #5) > I do not have one. I was thinking about AccessLog in context of bug 50835 > (AccessLog#log() being called on uninitialized valve in unclear circumstances

svn commit: r1075022 - in /tomcat/trunk: java/org/apache/catalina/Lifecycle.java java/org/apache/catalina/LifecycleListener.java java/org/apache/catalina/LifecycleState.java java/org/apache/catalina/u

2011-02-27 Thread markt
Author: markt Date: Sun Feb 27 11:00:12 2011 New Revision: 1075022 URL: http://svn.apache.org/viewvc?rev=1075022&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50836 Better documentation of the meaning of Lifecycle.isAvailable() and correct a couple of cases where this could

DO NOT REPLY [Bug 50836] LifecycleState#isAvailable() to be more restrictive

2011-02-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50836 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1075030 - /tomcat/trunk/java/org/apache/tomcat/util/net/SecureNioChannel.java

2011-02-27 Thread markt
Author: markt Date: Sun Feb 27 11:28:01 2011 New Revision: 1075030 URL: http://svn.apache.org/viewvc?rev=1075030&view=rev Log: Block whilst waiting for data from client in NIO SSL-rehandshake rather than spinning the CPU Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SecureNioChannel

Re: svn commit: r1074675 - in /tomcat/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/

2011-02-27 Thread Mark Thomas
> On 25/02/2011 20:16, Filip Hanik - Dev Lists wrote: >> The simplest solution is, would be to use an individual selector. >> Register the socket and issue a select() on the thread you are running on. >> If you want to use a shared selector (like NIO does for reads and >> writes) it requires a bit

Bug report for Taglibs [2011/02/27]

2011-02-27 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 5 [2011/02/27]

2011-02-27 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 6 [2011/02/27]

2011-02-27 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 7 [2011/02/27]

2011-02-27 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Modules [2011/02/27]

2011-02-27 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Connectors [2011/02/27]

2011-02-27 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Native [2011/02/27]

2011-02-27 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

svn commit: r1075050 - in /tomcat/trunk: java/org/apache/catalina/startup/CatalinaProperties.java webapps/docs/changelog.xml

2011-02-27 Thread markt
Author: markt Date: Sun Feb 27 13:19:22 2011 New Revision: 1075050 URL: http://svn.apache.org/viewvc?rev=1075050&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=31027 Trim whitespace from names and values obtained from $CATALINA_BASE/conf/catalina.properties to avoid hard to

svn commit: r1075052 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2011-02-27 Thread markt
Author: markt Date: Sun Feb 27 13:22:56 2011 New Revision: 1075052 URL: http://svn.apache.org/viewvc?rev=1075052&view=rev Log: Proposal Modified: tomcat/tc5.5.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/t

DO NOT REPLY [Bug 31027] major error from minor whitespace error in properties file

2011-02-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=31027 Mark Thomas changed: What|Removed |Added Component|Catalina|Catalina Version|4.1.30

DO NOT REPLY [Bug 28853] Make Ant tasks declaration easier

2011-02-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=28853 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

Re: svn commit: r1075050 - in /tomcat/trunk: java/org/apache/catalina/startup/CatalinaProperties.java webapps/docs/changelog.xml

2011-02-27 Thread Konstantin Kolinko
2011/2/27 : > Author: markt > Date: Sun Feb 27 13:19:22 2011 > New Revision: 1075050 > > --- tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java > (original) > +++ tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java Sun > Feb 27 13:19:22 2011 > @@ -140,7 +140

Re: svn commit: r1075050 - in /tomcat/trunk: java/org/apache/catalina/startup/CatalinaProperties.java webapps/docs/changelog.xml

2011-02-27 Thread Mark Thomas
On 27/02/2011 14:00, Konstantin Kolinko wrote: > 3) I think I am -1 on this change. If there ever would be some > property that I would need to set to the value of \u0020, I would not > be able to do so. I think that we should care about our own properties > only and not enforce our rules on someth

svn commit: r1075056 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2011-02-27 Thread markt
Author: markt Date: Sun Feb 27 14:06:56 2011 New Revision: 1075056 URL: http://svn.apache.org/viewvc?rev=1075056&view=rev Log: Withdraw proposal Modified: tomcat/tc5.5.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org

DO NOT REPLY [Bug 31027] major error from minor whitespace error in properties file

2011-02-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=31027 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1075058 - in /tomcat/trunk: java/org/apache/catalina/startup/CatalinaProperties.java webapps/docs/changelog.xml

2011-02-27 Thread markt
Author: markt Date: Sun Feb 27 14:12:39 2011 New Revision: 1075058 URL: http://svn.apache.org/viewvc?rev=1075058&view=rev Log: Revert r1075050 Modified: tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/ja

svn commit: r1075060 - /tomcat/trunk/java/org/apache/catalina/ant/jmx/JMXAccessorQueryTask.java

2011-02-27 Thread markt
Author: markt Date: Sun Feb 27 14:26:55 2011 New Revision: 1075060 URL: http://svn.apache.org/viewvc?rev=1075060&view=rev Log: Remove unused code Modified: tomcat/trunk/java/org/apache/catalina/ant/jmx/JMXAccessorQueryTask.java Modified: tomcat/trunk/java/org/apache/catalina/ant/jmx/JMXAcce

svn commit: r1075061 - /tomcat/trunk/java/org/apache/catalina/ant/jmx/JMXAccessorTask.java

2011-02-27 Thread markt
Author: markt Date: Sun Feb 27 14:29:07 2011 New Revision: 1075061 URL: http://svn.apache.org/viewvc?rev=1075061&view=rev Log: Misc clean-up - Suppress Eclipse warnings - Remove unused code - Correct Javadoc Modified: tomcat/trunk/java/org/apache/catalina/ant/jmx/JMXAccessorTask.java Modi

svn commit: r1075062 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

2011-02-27 Thread markt
Author: markt Date: Sun Feb 27 14:31:27 2011 New Revision: 1075062 URL: http://svn.apache.org/viewvc?rev=1075062&view=rev Log: Couple more false positives Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml URL: http:

svn commit: r1075063 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

2011-02-27 Thread markt
Author: markt Date: Sun Feb 27 14:34:19 2011 New Revision: 1075063 URL: http://svn.apache.org/viewvc?rev=1075063&view=rev Log: Another false positive Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml URL: http://svn

DO NOT REPLY [Bug 50836] LifecycleState#isAvailable() to be more restrictive

2011-02-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50836 --- Comment #8 from Konstantin Kolinko 2011-02-27 09:36:52 EST --- OK. I like it. Let's stop at this. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- Y

DO NOT REPLY [Bug 50838] New: Enhance Supported TLD Scanning Locations with WEB-INF/classes Support

2011-02-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50838 Summary: Enhance Supported TLD Scanning Locations with WEB-INF/classes Support Product: Tomcat 7 Version: 7.0.8 Platform: All OS/Version: All Status: NEW

DO NOT REPLY [Bug 50838] Enhance Supported TLD Scanning Locations with WEB-INF/classes Support

2011-02-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50838 Scott Hamilton changed: What|Removed |Added CC||scott.hamil...@plateau.com -- Co

svn commit: r1075083 - in /tomcat/trunk: java/org/apache/catalina/authenticator/AuthenticatorBase.java res/findbugs/filter-false-positives.xml

2011-02-27 Thread markt
Author: markt Date: Sun Feb 27 15:53:45 2011 New Revision: 1075083 URL: http://svn.apache.org/viewvc?rev=1075083&view=rev Log: Misc clean-up - remove unused code - suppress FindBugs false positives - add javadoc Modified: tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.j

[Tomcat Wiki] Update of "FAQ/Developing" by KonstantinKolinko

2011-02-27 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "FAQ/Developing" page has been changed by KonstantinKolinko. The comment on this change is: Reformat. Split into subsections.. http://wiki.apache.org/tomcat/FAQ/Developing?action=dif

DO NOT REPLY [Bug 50839] New: Closing connection on the client side (browser) during unfinished transmission result in 100% CPU slike for 30 sec during socket shutdownd in jk_connect.c

2011-02-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50839 Summary: Closing connection on the client side (browser) during unfinished transmission result in 100% CPU slike for 30 sec during socket shutdownd in jk_connect.c Product: Tomcat

[Tomcat Wiki] Update of "HowTo" by KonstantinKolinko

2011-02-27 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "HowTo" page has been changed by KonstantinKolinko. The comment on this change is: Correct wrong example. Add a link.. http://wiki.apache.org/tomcat/HowTo?action=diff&rev1=98&rev2=99

DO NOT REPLY [Bug 48863] Log directory misconfiguration for class loaders

2011-02-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48863 --- Comment #7 from Konstantin Kolinko 2011-02-27 13:46:41 EST --- Regarding the patch that is applied to tc7 at r1073047 and is currently proposed for 6.0.x: 1) The calls to ClassLoaderFactory#validateFile(file, type) pass canonical path

DO NOT REPLY [Bug 43497] Add ability to escape rendered output of JSP expressions

2011-02-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43497 --- Comment #4 from Chin Huang 2011-02-27 13:49:50 EST --- If you don't want to patch Tomcat, here is a custom ELResolver that XML-escapes EL values. You just have to add a servlet context listener to web.xml to configure it in your web ap

svn commit: r1075129 - /tomcat/tc5.5.x/trunk/STATUS.txt

2011-02-27 Thread kkolinko
Author: kkolinko Date: Sun Feb 27 20:11:50 2011 New Revision: 1075129 URL: http://svn.apache.org/viewvc?rev=1075129&view=rev Log: vote Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=10

svn commit: r1075175 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

2011-02-27 Thread markt
Author: markt Date: Sun Feb 27 22:59:10 2011 New Revision: 1075175 URL: http://svn.apache.org/viewvc?rev=1075175&view=rev Log: Clear remaining FindBugs issues from javax.* Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/trunk/res/findbugs/filter-false-positive

svn commit: r1075176 - in /tomcat/trunk/java/org/apache/catalina/connector: CometEventImpl.java Connector.java Constants.java CoyoteInputStream.java CoyotePrincipal.java InputBuffer.java OutputBuffer.

2011-02-27 Thread markt
Author: markt Date: Sun Feb 27 23:08:45 2011 New Revision: 1075176 URL: http://svn.apache.org/viewvc?rev=1075176&view=rev Log: Fix Eclipse warnings Remove unused code Modified: tomcat/trunk/java/org/apache/catalina/connector/CometEventImpl.java tomcat/trunk/java/org/apache/catalina/connec

DO NOT REPLY [Bug 50793] Invalid DispatchType in ServletRequestListener on async dispatch

2011-02-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50793 Konstantin Kolinko changed: What|Removed |Added Status|VERIFIED|CLOSED -- Configure bugmail:

Re: svn commit: r1075175 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

2011-02-27 Thread sebb
On 27 February 2011 22:59, wrote: > Author: markt > Date: Sun Feb 27 22:59:10 2011 > New Revision: 1075175 > > URL: http://svn.apache.org/viewvc?rev=1075175&view=rev > Log: > Clear remaining FindBugs issues from javax.* > > Modified: >    tomcat/trunk/res/findbugs/filter-false-positives.xml > > M