Author: markt
Date: Sun Feb 27 15:53:45 2011
New Revision: 1075083
URL: http://svn.apache.org/viewvc?rev=1075083&view=rev
Log:
Misc clean-up
- remove unused code
- suppress FindBugs false positives
- add javadoc
Modified:
tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java
tomcat/trunk/res/findbugs/filter-false-positives.xml
Modified:
tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java?rev=1075083&r1=1075082&r2=1075083&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java
Sun Feb 27 15:53:45 2011
@@ -92,12 +92,6 @@ public abstract class AuthenticatorBase
/**
- * The number of random bytes to include when generating a
- * session identifier.
- */
- protected static final int SESSION_ID_BYTES = 16;
-
- /**
* Authentication header
*/
protected static final String AUTH_HEADER_NAME = "WWW-Authenticate";
@@ -789,6 +783,15 @@ public abstract class AuthenticatorBase
protected abstract String getAuthMethod();
+ /**
+ * Process the login request.
+ *
+ * @param request Associated request
+ * @param username The user
+ * @param password The password
+ * @return The authenticated Principal
+ * @throws ServletException
+ */
protected Principal doLogin(Request request, String username,
String password) throws ServletException {
Principal p = context.getRealm().authenticate(username, password);
Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1075083&r1=1075082&r2=1075083&view=diff
==============================================================================
--- tomcat/trunk/res/findbugs/filter-false-positives.xml (original)
+++ tomcat/trunk/res/findbugs/filter-false-positives.xml Sun Feb 27 15:53:45
2011
@@ -37,6 +37,11 @@
<Bug code="REC"/>
</Match>
<Match>
+ <Class name="org.apache.catalina.authenticator.AuthenticatorBase"/>
+ <Field name="sessionIdGenerator"/>
+ <Bug code="IS"/>
+ </Match>
+ <Match>
<!-- JNI library can only be loaded once so statics are appropriate -->
<Class name="org.apache.catalina.core.AprLifecycleListener" />
<Bug code="ST" />
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
