https://issues.apache.org/bugzilla/show_bug.cgi?id=50835
Summary: NPE on AccessLogValve.getTimeZone
Product: Tomcat 6
Version: 6.0.32
Platform: Macintosh
Status: NEW
Severity: normal
Priority: P2
Component: Catalin
Author: kkolinko
Date: Sat Feb 26 15:04:05 2011
New Revision: 1074864
URL: http://svn.apache.org/viewvc?rev=1074864&view=rev
Log:
Reduce level of log message for invalid URL parameters from WARNING to INFO.
Modified:
tomcat/tc6.0.x/trunk/ (props changed)
tomcat/tc6.0.x/trunk/STATUS.txt
https://issues.apache.org/bugzilla/show_bug.cgi?id=50835
Konstantin Kolinko changed:
What|Removed |Added
OS/Version||All
--- Comment #1 from Konst
https://issues.apache.org/bugzilla/show_bug.cgi?id=29494
Mark Thomas changed:
What|Removed |Added
Status|NEEDINFO|RESOLVED
Resolution|
https://issues.apache.org/bugzilla/show_bug.cgi?id=50726
--- Comment #7 from Konstantin Kolinko 2011-02-26
11:28:24 EST ---
Answering my own questions
(In reply to comment #3)
> I wonder also whether initializing the array as = {'s', 't', 'r', 'i', 'n',
> 'g'} performs worse or better than the
Author: kkolinko
Date: Sat Feb 26 16:32:53 2011
New Revision: 1074872
URL: http://svn.apache.org/viewvc?rev=1074872&view=rev
Log:
vote
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=10
https://issues.apache.org/bugzilla/show_bug.cgi?id=50835
--- Comment #2 from based 2011-02-26 11:41:40 EST ---
I cannot reproduce it.
In what circumstances this was observed? Are there other errors and warnings or
interesting messages in the logs? Did tomcat start successfully?
> I tried to dep
https://issues.apache.org/bugzilla/show_bug.cgi?id=50835
Chuck Caldarale changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
https://issues.apache.org/bugzilla/show_bug.cgi?id=33405
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
https://issues.apache.org/bugzilla/show_bug.cgi?id=50836
Summary: LifecycleState#isAvailable() to be more restrictive
Product: Tomcat 7
Version: 7.0.8
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: normal
Hi!
I was reviewing Mark's comment in
https://issues.apache.org/bugzilla/show_bug.cgi?id=33405#c1
1)
> A mal-formed web.xml is ignored
It is ignored in TC7, but it causes the app startup to fail in TC5.5 and TC6.
I think in TC7 the app startup should fail as well,
because there might be securit
https://issues.apache.org/bugzilla/show_bug.cgi?id=50836
--- Comment #1 from Mark Thomas 2011-02-26 14:22:21 EST ---
Agree with MUST_DESTROY.
Need to review the others.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because:
https://issues.apache.org/bugzilla/show_bug.cgi?id=50836
--- Comment #2 from Mark Thomas 2011-02-26 14:31:37 EST ---
isAvailable() is aligned with when the public methods are available for use by
other components. On that basis isAvailable() should return true for states
STOPPING_PREP and STARTIN
Author: markt
Date: Sat Feb 26 19:37:13 2011
New Revision: 1074911
URL: http://svn.apache.org/viewvc?rev=1074911&view=rev
Log:
Fix FindBugs warning
Modified:
tomcat/trunk/java/org/apache/catalina/deploy/FilterDef.java
Modified: tomcat/trunk/java/org/apache/catalina/deploy/FilterDef.java
URL:
On 26/02/2011 19:16, Konstantin Kolinko wrote:
> Hi!
>
> I was reviewing Mark's comment in
> https://issues.apache.org/bugzilla/show_bug.cgi?id=33405#c1
>
> 1)
>> A mal-formed web.xml is ignored
>
> It is ignored in TC7, but it causes the app startup to fail in TC5.5 and TC6.
>
> I think in TC7
https://issues.apache.org/bugzilla/show_bug.cgi?id=50836
--- Comment #3 from Konstantin Kolinko 2011-02-26
14:54:47 EST ---
(In reply to comment #2)
> are available for use by other components.
The "public" methods: I think those are methods that perform some work, like
AccessLog#log(), not jus
2011/2/26 Mark Thomas :
> On 26/02/2011 19:16, Konstantin Kolinko wrote:
>
> Drat. I was looking at this solely in terms of bug 33405. Of course, you
> are right. The webapp should not start in this case. I'll fix that. It
> might well make bug 33405 a WONTFIX.
The bug 33405 is fixed. (web.xml is
Author: markt
Date: Sat Feb 26 20:01:10 2011
New Revision: 1074914
URL: http://svn.apache.org/viewvc?rev=1074914&view=rev
Log:
Ensure a web application is taken out of service if the web.xml file is not
valid.
Modified:
tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
tom
https://issues.apache.org/bugzilla/show_bug.cgi?id=33405
--- Comment #2 from Mark Thomas 2011-02-26 15:03:22 EST ---
My last comment was not correct (due to a bug in Tomcat 7 I overlooked).
Once a deployed web-app is working, web.xml is monitored. It it is mal-formed,
the web-app is taken out of
Author: markt
Date: Sat Feb 26 20:07:00 2011
New Revision: 1074915
URL: http://svn.apache.org/viewvc?rev=1074915&view=rev
Log:
No need to call stop if the app didn't start
Modified:
tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java
Modified: tomcat/trunk/java/org/apache/catalina/
https://issues.apache.org/bugzilla/show_bug.cgi?id=50836
--- Comment #4 from Mark Thomas 2011-02-26 15:34:28 EST ---
(In reply to comment #3)
> The "public" methods: I think those are methods that perform some work, like
> AccessLog#log(), not just any public methods. Or you are talking about JM
Author: markt
Date: Sat Feb 26 20:40:25 2011
New Revision: 1074918
URL: http://svn.apache.org/viewvc?rev=1074918&view=rev
Log:
Fix what looks like a copy/paste error
Modified:
tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties
tomcat/trunk/java/org/apache/catalina/core/Loc
Author: markt
Date: Sat Feb 26 20:44:34 2011
New Revision: 1074919
URL: http://svn.apache.org/viewvc?rev=1074919&view=rev
Log:
Fix FindBugs identified error in Servlet 2.2 jspFile handling
Modified:
tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
tomcat/trunk/webapps/docs
https://issues.apache.org/bugzilla/show_bug.cgi?id=50836
--- Comment #5 from Konstantin Kolinko 2011-02-26
19:15:00 EST ---
(In reply to comment #4)
> > Regarding STARTING:
> >
> > I think that in STARTING it is too early to call those methods: the
> > component
> > has not completed its star
24 matches
Mail list logo
