https://issues.apache.org/bugzilla/show_bug.cgi?id=50726

--- Comment #7 from Konstantin Kolinko <knst.koli...@gmail.com> 2011-02-26 
11:28:24 EST ---
Answering my own questions

(In reply to comment #3)
> I wonder also whether initializing the array as = {'s', 't', 'r', 'i', 'n',
> 'g'} performs worse or better than the existing code.

It works, but generates a lot of code, like the following (for an array of 11
chars):
   0:    bipush    11
   2:    newarray char
   4:    dup
   5:    iconst_0
   6:    bipush    72
   8:    castore
   9:    dup
   10:    iconst_1
   11:    bipush    101
   13:    castore
   14:    dup
(...)
   59:    bipush    10
   61:    bipush    100
   63:    castore
   64:    putstatic
   67:    return

I have not measured whether it works considerably slow or not.

> BTW, using mappedFile=false will probably hit the same limit.
> (That is when the "breakAtLF" variable is false in that
> visit(Node.TemplateText) method).

The mappedFile=false will not experience this issue under usual circumstances.

There is a constant JspUtil.CHUNKSIZE and thus strings longer than 1024 will be
split at LF regardless of breakAtLF flag. If the JSP has lines of 64K bytes
without any LF in them, this issue will be observed regardless of mappedFile
setting. But such JSPs are very unlikely.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to