DO NOT REPLY [Bug 48253] Tomcat Native patch - adding dynamic locking callbacks for openssl engines

2011-01-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48253 --- Comment #4 from jfclere 2011-01-07 03:01:23 EST --- Fixed by svn commit: r1055907 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assign

DO NOT REPLY [Bug 50557] Tomcat , Comet - Writes are getting blocked some time

2011-01-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50557 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1056216 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/ha/session/DeltaManager.java webapps/docs/changelog.xml

2011-01-07 Thread kfujino
Author: kfujino Date: Fri Jan 7 08:08:01 2011 New Revision: 1056216 URL: http://svn.apache.org/viewvc?rev=1056216&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50547. Add time stamp for CHANGE_SESSION_ID and SESSION_EXPIRED message. Modified: tomcat/tc6.0.x/trunk/STATU

DO NOT REPLY [Bug 50547] The CHANGE_SESSION_ID message that received during cluster session synchronization is dropped.

2011-01-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50547 Keiichi Fujino changed: What|Removed |Added Component|Cluster |Catalina:Cluster Versi

DO NOT REPLY [Bug 49557] index erro in the loop to get the env info in the proc.create function

2011-01-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49557 --- Comment #5 from jfclere 2011-01-07 03:22:10 EST --- the free() are needed as the tcn_get_string makes malloc(). -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail becau

svn commit: r1056218 - in /tomcat/native/branches/1.1.x: native/src/proc.c xdocs/miscellaneous/changelog.xml

2011-01-07 Thread jfclere
Author: jfclere Date: Fri Jan 7 08:28:05 2011 New Revision: 1056218 URL: http://svn.apache.org/viewvc?rev=1056218&view=rev Log: Fix for 49557. Modified: tomcat/native/branches/1.1.x/native/src/proc.c tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml Modified: tomcat/native/

DO NOT REPLY [Bug 49557] index erro in the loop to get the env info in the proc.create function

2011-01-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49557 jfclere changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 46179] apr ssl client authentication

2011-01-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46179 --- Comment #4 from jfclere 2011-01-07 03:34:14 EST --- Could you please try with SSLVerifyDepth="1". Note that the certificates attached to the case are too old new :-( -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.c

DO NOT REPLY [Bug 50552] Ant Tasks give a null pointer exception when an error occurs, masking true error

2011-01-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50552 --- Comment #5 from chris.rim...@nominet.org.uk 2011-01-07 04:40:28 EST --- Btw I would have written a test or tests to show that my patch fixes the problem, but there don't seem to be any tests for these ant tasks. Unless I'm looking in the

svn commit: r1056234 - /tomcat/trunk/java/org/apache/naming/factory/DataSourceLinkFactory.java

2011-01-07 Thread markt
Author: markt Date: Fri Jan 7 10:05:07 2011 New Revision: 1056234 URL: http://svn.apache.org/viewvc?rev=1056234&view=rev Log: Fix various warnings Modified: tomcat/trunk/java/org/apache/naming/factory/DataSourceLinkFactory.java Modified: tomcat/trunk/java/org/apache/naming/factory/DataSourc

svn commit: r1056237 - /tomcat/trunk/webapps/docs/changelog.xml

2011-01-07 Thread markt
Author: markt Date: Fri Jan 7 10:16:59 2011 New Revision: 1056237 URL: http://svn.apache.org/viewvc?rev=1056237&view=rev Log: Numerical order, fix indenting Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc

svn commit: r1056244 - in /tomcat/trunk: java/org/apache/naming/java/javaURLContextFactory.java res/findbugs/filter-false-positives.xml webapps/docs/changelog.xml

2011-01-07 Thread markt
Author: markt Date: Fri Jan 7 10:31:59 2011 New Revision: 1056244 URL: http://svn.apache.org/viewvc?rev=1056244&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50554 Various FindBugs / Eclipse warnings Silence the false positives Modified: tomcat/trunk/java/org/apache/na

DO NOT REPLY [Bug 50554] Bad use of getClass() could potentially lead to concurrency bugs in future

2011-01-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50554 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[PROPOSAL] Remove o.a.catlina.InstanceListener

2011-01-07 Thread Mark Thomas
All, I just stumbled across o.a.catlina.InstanceListener and the associated classes when I was reviewing the results of the unused code detector. It isn't used at all in 7.0.x, nor can I find any sign of it being used in 6.0.x and 5.5.x. A search of the mail archives doesn't turn up any uses eith

svn commit: r1056256 - in /tomcat/trunk/java/javax/servlet: ServletRequestEvent.java jsp/tagext/BodyTagSupport.java jsp/tagext/TagSupport.java

2011-01-07 Thread markt
Author: markt Date: Fri Jan 7 11:02:25 2011 New Revision: 1056256 URL: http://svn.apache.org/viewvc?rev=1056256&view=rev Log: Fix some simple FindBugs issues Modified: tomcat/trunk/java/javax/servlet/ServletRequestEvent.java tomcat/trunk/java/javax/servlet/jsp/tagext/BodyTagSupport.java

DO NOT REPLY [Bug 50410] Poll.create with THREADSAFE will silently switch the flag off

2011-01-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50410 Mladen Turk changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1056264 - in /tomcat/trunk: java/org/apache/catalina/ant/BaseRedirectorHelperTask.java webapps/docs/changelog.xml

2011-01-07 Thread markt
Author: markt Date: Fri Jan 7 11:24:36 2011 New Revision: 1056264 URL: http://svn.apache.org/viewvc?rev=1056264&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50552 Avoid NPE that hides error when using Ant tasks (schultz) Modified: tomcat/trunk/java/org/apache/catalina

svn commit: r1056266 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-01-07 Thread markt
Author: markt Date: Fri Jan 7 11:26:58 2011 New Revision: 1056266 URL: http://svn.apache.org/viewvc?rev=1056266&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1

DO NOT REPLY [Bug 50552] Ant Tasks give a null pointer exception when an error occurs, masking true error

2011-01-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50552 Mark Thomas changed: What|Removed |Added Component|Integration |Catalina Product|Tomcat 7

Re: [PROPOSAL] Remove o.a.catlina.InstanceListener

2011-01-07 Thread Konstantin Kolinko
2011/1/7 Mark Thomas : > All, > > I just stumbled across o.a.catlina.InstanceListener and the associated > classes when I was reviewing the results of the unused code detector. > > It isn't used at all in 7.0.x, nor can I find any sign of it being used > in 6.0.x and 5.5.x. A search of the mail arc

Re: [PROPOSAL] Remove o.a.catlina.InstanceListener

2011-01-07 Thread Mark Thomas
On 07/01/2011 12:18, Konstantin Kolinko wrote: > 2011/1/7 Mark Thomas : >> All, >> >> I just stumbled across o.a.catlina.InstanceListener and the associated >> classes when I was reviewing the results of the unused code detector. >> >> It isn't used at all in 7.0.x, nor can I find any sign of it be

Re: [PROPOSAL] Remove o.a.catlina.InstanceListener

2011-01-07 Thread Remy Maucherat
On Fri, 2011-01-07 at 15:18 +0300, Konstantin Kolinko wrote: > We indeed do not have our own classes that implement InstanceListener, > but if you search for o.a.c.InstanceEvent, it is used in a plenty of places > (to implement this feature actually). > > So it is not just throwing away classes, i

svn commit: r1056298 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/catalina/valves/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/or

2011-01-07 Thread markt
Author: markt Date: Fri Jan 7 13:01:00 2011 New Revision: 1056298 URL: http://svn.apache.org/viewvc?rev=1056298&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50496 Differentiate between content written (what the app writes to the output stream) and bytes written (what Tomc

DO NOT REPLY [Bug 50496] AccessLogValve not logging size correctly for %B with enabled compression

2011-01-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50496 --- Comment #2 from Mark Thomas 2011-01-07 08:01:31 EST --- This is fixed in 7.0.x and will be included in 7.0.6 onwards. The changes required were simple but extensive. I am leaning towards WONTFIX for 6.0.x and earlier. -- Configure bu

svn commit: r1056310 - /tomcat/trunk/test/org/apache/catalina/connector/TestMaxConnections.java

2011-01-07 Thread markt
Author: markt Date: Fri Jan 7 13:26:33 2011 New Revision: 1056310 URL: http://svn.apache.org/viewvc?rev=1056310&view=rev Log: Put sleep in right place for test to pass. With acceptCount of 1 need a short delay else connections get rejected as Tomcat doesn't process incoming connections fast enou

Re: svn commit: r1050249 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11NioProtocol.java webapps/docs/changelog.xml

2011-01-07 Thread Konstantin Kolinko
Is it worth being ported to 6.0? It looks so, though have not reviewed it in detail yet. 2010/12/17 : > Author: markt > Date: Fri Dec 17 00:17:18 2010 > New Revision: 1050249 > > URL: http://svn.apache.org/viewvc?rev=1050249&view=rev > Log: > Fix massive memory leak in NIO connector. Http11NioPro

svn commit: r1056340 - in /tomcat/trunk/test/org/apache/catalina: filters/TestRemoteIpFilter.java valves/TestRemoteIpValve.java

2011-01-07 Thread markt
Author: markt Date: Fri Jan 7 14:56:50 2011 New Revision: 1056340 URL: http://svn.apache.org/viewvc?rev=1056340&view=rev Log: Fix tests after regex changes Modified: tomcat/trunk/test/org/apache/catalina/filters/TestRemoteIpFilter.java tomcat/trunk/test/org/apache/catalina/valves/TestRem

svn commit: r1056344 - /tomcat/trunk/test/org/apache/tomcat/util/http/TestCookies.java

2011-01-07 Thread markt
Author: markt Date: Fri Jan 7 15:16:44 2011 New Revision: 1056344 URL: http://svn.apache.org/viewvc?rev=1056344&view=rev Log: Update tests now name only cookies are not accepted by default Modified: tomcat/trunk/test/org/apache/tomcat/util/http/TestCookies.java Modified: tomcat/trunk/test/o

DO NOT REPLY [Bug 50552] Ant Tasks give a null pointer exception when an error occurs, masking true error

2011-01-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50552 --- Comment #7 from Christopher Schultz 2011-01-07 10:35:59 EST --- (In reply to comment #6) > Fixed in 7.0.x for 7.0.6 using Chris S's first proposal. I hadn't taken enough time to determine if that fix (adding the null check, right?) wo

svn commit: r1056386 - /tomcat/trunk/build.properties.default

2011-01-07 Thread mturk
Author: mturk Date: Fri Jan 7 16:45:31 2011 New Revision: 1056386 URL: http://svn.apache.org/viewvc?rev=1056386&view=rev Log: Update daemon to 1.0.5 Modified: tomcat/trunk/build.properties.default Modified: tomcat/trunk/build.properties.default URL: http://svn.apache.org/viewvc/tomcat/trun

svn commit: r1056387 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-01-07 Thread mturk
Author: mturk Date: Fri Jan 7 16:47:53 2011 New Revision: 1056387 URL: http://svn.apache.org/viewvc?rev=1056387&view=rev Log: Propose Commons Daemon update to 1.0.5 Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/

svn commit: r1056389 - /tomcat/tc5.5.x/trunk/STATUS.txt

2011-01-07 Thread mturk
Author: mturk Date: Fri Jan 7 16:49:49 2011 New Revision: 1056389 URL: http://svn.apache.org/viewvc?rev=1056389&view=rev Log: Propose Commons Daemon update to 1.0.5 Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/

buildbot failure in ASF Buildbot on tomcat-trunk

2011-01-07 Thread buildbot
The Buildbot has detected a new failure of tomcat-trunk on ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/1074 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: Build Source Stamp: [branch tomcat/trunk] 105

tagging TC 6.0.30 on Monday

2011-01-07 Thread jean-frederic clere
Hi, I plan to tag 6.0.30 on Monday, please complain if you disagree. Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1056403 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-01-07 Thread jfclere
Author: jfclere Date: Fri Jan 7 17:25:48 2011 New Revision: 1056403 URL: http://svn.apache.org/viewvc?rev=1056403&view=rev Log: my votes. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?re

svn commit: r1056411 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/jasper/compiler/ELFunctionMapper.java webapps/docs/changelog.xml

2011-01-07 Thread markt
Author: markt Date: Fri Jan 7 17:46:32 2011 New Revision: 1056411 URL: http://svn.apache.org/viewvc?rev=1056411&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49555 Correctly handle tag libraries that use functions defined in static inner classes Modified: tomcat/tc6.0

DO NOT REPLY [Bug 49555] Custom Taglibs should support all parameters

2011-01-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49555 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1056414 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/coyote/http11/Http11AprProcessor.java webapps/docs/changelog.xml

2011-01-07 Thread markt
Author: markt Date: Fri Jan 7 17:49:20 2011 New Revision: 1056414 URL: http://svn.apache.org/viewvc?rev=1056414&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47319 Return IP address rather than null for getRemoteHost() and the APR connector Modified: tomcat/tc6.0.x/tru

DO NOT REPLY [Bug 47319] With APR, getRemoteHost() returns NULL for unknown clients

2011-01-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47319 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1056426 - in /tomcat/tc6.0.x/trunk: STATUS.txt res/config.ini res/jvm.ini res/main.ico res/tomcat.nsi res/uninst.ico webapps/docs/changelog.xml

2011-01-07 Thread markt
Author: markt Date: Fri Jan 7 18:00:28 2011 New Revision: 1056426 URL: http://svn.apache.org/viewvc?rev=1056426&view=rev Log: * Backport Windows installer improvements from Tomcat 7.0.5. - Use *modern* types of nsis install/uninstall icons (r76, mturk) - Create service-install.log file du

DO NOT REPLY [Bug 50140] Silent installation into wrong target directory

2011-01-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50140 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|

Re: svn commit: r1056244 - in /tomcat/trunk: java/org/apache/naming/java/javaURLContextFactory.java res/findbugs/filter-false-positives.xml webapps/docs/changelog.xml

2011-01-07 Thread sebb
On 7 January 2011 10:32, wrote: > Author: markt > Date: Fri Jan  7 10:31:59 2011 > New Revision: 1056244 > > URL: http://svn.apache.org/viewvc?rev=1056244&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50554 > Various FindBugs / Eclipse warnings > Silence the false posit

svn commit: r1056434 - /tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java

2011-01-07 Thread markt
Author: markt Date: Fri Jan 7 18:13:38 2011 New Revision: 1056434 URL: http://svn.apache.org/viewvc?rev=1056434&view=rev Log: Fix security exception when running Servlet TCK Modified: tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java Modified: tomcat/trunk/java/org/apach

svn commit: r1056442 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/core/StandardEngine.java webapps/docs/changelog.xml

2011-01-07 Thread markt
Author: markt Date: Fri Jan 7 18:26:09 2011 New Revision: 1056442 URL: http://svn.apache.org/viewvc?rev=1056442&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50201 Handle ROOT webapp redeployment, host start/stop etc for default access log Modified: tomcat/tc6.0.x/trun

DO NOT REPLY [Bug 50201] StandardEngine.defaultAccessLog may become stale when ROOT webapp is redeployed

2011-01-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50201 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1056445 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/valves/RemoteIpValve.java webapps/docs/changelog.xml

2011-01-07 Thread markt
Author: markt Date: Fri Jan 7 18:28:40 2011 New Revision: 1056445 URL: http://svn.apache.org/viewvc?rev=1056445&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50453 Correctly handle multiple X-Forwarded-For headers in RemoteIpValve Patch provided by Jim Riggs Modified:

DO NOT REPLY [Bug 50453] Multiple X-Forwarded-For headers not handled by RemoteIP valve

2011-01-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50453 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 50467] Occasional NIO connector lockups on high load

2011-01-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50467 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1056451 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/el/lang/ELArithmetic.java java/org/apache/tomcat/util/net/NioEndpoint.java test/org/apache/el/lang/TestELArithmetic.java

2011-01-07 Thread markt
Author: markt Date: Fri Jan 7 18:43:39 2011 New Revision: 1056451 URL: http://svn.apache.org/viewvc?rev=1056451&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50500 Use correct coercions for EL arithmetic operations. Based on a patch by Brian Weisleder Added: tomcat/tc

DO NOT REPLY [Bug 50500] EL evaluation of floating-point String value vs BigInteger loses precision

2011-01-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50500 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

Re: svn commit: r1056445 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/valves/RemoteIpValve.java webapps/docs/changelog.xml

2011-01-07 Thread sebb
On 7 January 2011 18:28, wrote: > Author: markt > Date: Fri Jan  7 18:28:40 2011 > New Revision: 1056445 > > URL: http://svn.apache.org/viewvc?rev=1056445&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50453 > Correctly handle multiple X-Forwarded-For headers in RemoteIp

[Tomcat Wiki] Update of "FAQ/Performance_and_Monitori ng" by MichaelCzeiszperger

2011-01-07 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "FAQ/Performance_and_Monitoring" page has been changed by MichaelCzeiszperger. http://wiki.apache.org/tomcat/FAQ/Performance_and_Monitoring?action=diff&rev1=7&rev2=8 --

Re: ThreadLocal Clear References Problem

2011-01-07 Thread Gurkan Erdogdu
>>>So, you are stopping a second application from the code shown in the >>>bug? Yes. >>>Can you post a working example? I will try to attach a simple JSF application. Thanks; --Gurkan - Original Message From: Christopher Schultz To: Tomcat Developers List Sent: Thu, January 6, 201

svn commit: r1056492 - /tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

2011-01-07 Thread kkolinko
Author: kkolinko Date: Fri Jan 7 20:26:17 2011 New Revision: 1056492 URL: http://svn.apache.org/viewvc?rev=1056492&view=rev Log: Correct a typo Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/vie

Re: Tomcat JDBC Pool in Tomcat 6.0.x / 7.0.x

2011-01-07 Thread Henri Gomez
> I can run a vote for a release, people just need to check it out, and then > we can release it. +1 > Personally I like to see it as default for Tomcat 7, as it offers much > enhancements, and little disadvantages over dbcp > the code base is so small, that the interest in working on it, makes i

svn commit: r1056500 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2011-01-07 Thread kkolinko
Author: kkolinko Date: Fri Jan 7 20:45:24 2011 New Revision: 1056500 URL: http://svn.apache.org/viewvc?rev=1056500&view=rev Log: Withdraw proposals. Manager & HostManager using httpOnly=true is fine with me (r1041251). Let's not force this option by default. Modified: tomcat/tc5.5.x/trunk/S

svn propchange: r1056451 - svn:log

2011-01-07 Thread kkolinko
Author: kkolinko Revision: 1056451 Modified property: svn:log Modified: svn:log at Fri Jan 7 21:08:19 2011 -- --- svn:log (original) +++ svn:log Fri Jan 7 21:08:19 2011 @@ -1,2 +1,4 @@ -Fix https://issues.apache.org/bugz

svn commit: r1056511 - /tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

2011-01-07 Thread kkolinko
Author: kkolinko Date: Fri Jan 7 21:12:18 2011 New Revision: 1056511 URL: http://svn.apache.org/viewvc?rev=1056511&view=rev Log: Additional changelog entry for r1056451, where two issues were fixed in one commit. Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc6

DO NOT REPLY [Bug 50560] New: StringBuffer => StringBuilder for internal buffer construction

2011-01-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50560 Summary: StringBuffer => StringBuilder for internal buffer construction Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW

svn commit: r1056546 - /tomcat/tc5.5.x/trunk/STATUS.txt

2011-01-07 Thread kkolinko
Author: kkolinko Date: Fri Jan 7 22:31:16 2011 New Revision: 1056546 URL: http://svn.apache.org/viewvc?rev=1056546&view=rev Log: Propose backport of 47319 fix to TC 5.5 Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tom

DO NOT REPLY [Bug 47319] With APR, getRemoteHost() returns NULL for unknown clients

2011-01-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47319 --- Comment #4 from Konstantin Kolinko 2011-01-07 17:33:10 EST --- Proposed for 5.5.x as well. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are

svn commit: r1056553 - in /tomcat/trunk: java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java java/org/apache/catalina/core/LocalStrings.properties webapps/docs/changelog.xml webapps/doc

2011-01-07 Thread slaurent
Author: slaurent Date: Fri Jan 7 22:56:30 2011 New Revision: 1056553 URL: http://svn.apache.org/viewvc?rev=1056553&view=rev Log: bug 50556: improve JreMemoryLeakPreventionListener against leak caused by LdapPoolManager https://issues.apache.org/bugzilla/show_bug.cgi?id=50556 Modified: tom

DO NOT REPLY [Bug 50556] improve JreMemoryLeakPreventionListener against leak caused by LdapPoolManager

2011-01-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50556 --- Comment #4 from Sylvain Laurent 2011-01-07 18:01:14 EST --- >I guess you'd only have to do it if com.sun.jndi.ldap.connect.pool.timeout > >0, though system properties can be changed at runtime, so it might be a good >idea to temporar

svn commit: r1056557 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-01-07 Thread slaurent
Author: slaurent Date: Fri Jan 7 23:17:36 2011 New Revision: 1056557 URL: http://svn.apache.org/viewvc?rev=1056557&view=rev Log: proposed bacport on tc 6 for bug 50556: improve JreMemoryLeakPreventionListener against leak caused by LdapPoolManager https://issues.apache.org/bugzilla/show_bug.cgi

DO NOT REPLY [Bug 50556] improve JreMemoryLeakPreventionListener against leak caused by LdapPoolManager

2011-01-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50556 Sylvain Laurent changed: What|Removed |Added Component|Catalina|Catalina Version|7.0.

DO NOT REPLY [Bug 50518] jps.exe and jvisualvm.exe cannot detect tomcat using jdk1.6.0_23

2011-01-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50518 --- Comment #9 from Konstantin Kolinko 2011-01-07 18:35:22 EST --- (In reply to comment #8) > I've added a known issues section to the FAQ. For reference: The known issues FAQ page is [1]. The Sun/Oracle bug page for this issue is [2]. [

svn commit: r1056562 - in /tomcat/trunk: build.properties.default build.xml webapps/docs/changelog.xml

2011-01-07 Thread kkolinko
Author: kkolinko Date: Fri Jan 7 23:54:54 2011 New Revision: 1056562 URL: http://svn.apache.org/viewvc?rev=1056562&view=rev Log: Provide two alternative locations for the libraries downloaded from the ASF web site at build time. Use the main distribution site as default and the archive one as f

svn commit: r1056569 - /tomcat/trunk/java/org/apache/naming/factory/DataSourceLinkFactory.java

2011-01-07 Thread kkolinko
Author: kkolinko Date: Sat Jan 8 00:22:56 2011 New Revision: 1056569 URL: http://svn.apache.org/viewvc?rev=1056569&view=rev Log: Folloup to r1055989 Add qualifiers to the fields of DataSourceLinkFactory.DataSourceHandler class. Modified: tomcat/trunk/java/org/apache/naming/factory/DataSource

buildbot success in ASF Buildbot on tomcat-trunk

2011-01-07 Thread buildbot
The Buildbot has detected a restored build of tomcat-trunk on ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/1078 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: Build Source Stamp: [branch tomcat/trunk]

svn commit: r1056576 - /tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java

2011-01-07 Thread kkolinko
Author: kkolinko Date: Sat Jan 8 00:50:02 2011 New Revision: 1056576 URL: http://svn.apache.org/viewvc?rev=1056576&view=rev Log: Followup to r1056553 There should not be "import com.sun.jndi.ldap.LdapPoolManager;" as we must not depend on that class at build time. Actually the import was used by

svn commit: r1056577 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-01-07 Thread kkolinko
Author: kkolinko Date: Sat Jan 8 00:52:03 2011 New Revision: 1056577 URL: http://svn.apache.org/viewvc?rev=1056577&view=rev Log: votes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1

svn commit: r1056583 - /tomcat/trunk/test/org/apache/catalina/valves/TestRemoteIpValve.java

2011-01-07 Thread kkolinko
Author: kkolinko Date: Sat Jan 8 01:09:54 2011 New Revision: 1056583 URL: http://svn.apache.org/viewvc?rev=1056583&view=rev Log: Correct typo in the method names in a test case, so that they match to what method is actually being tested. Modified: tomcat/trunk/test/org/apache/catalina/valve