DO NOT REPLY [Bug 49960] New: HttpServletRequest.getCharacterEncoding does not break up the Content-Disposition header well.

2010-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49960 Summary: HttpServletRequest.getCharacterEncoding does not break up the Content-Disposition header well. Product: Tomcat 5 Version: 5.5.23 Platform: All OS/Version: All

DO NOT REPLY [Bug 49929] AJP APR connector to mod_jk can result in SEND_BODY_CHUNK message after END_RESPONSE message

2010-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49929 --- Comment #4 from brett.dellegra...@intact-is.com 2010-09-20 09:07:58 EDT --- Created an attachment (id=26055) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26055) testcase: Servlet for writing directly to output stream This

DO NOT REPLY [Bug 49964] New: Allow parsing of application/x-www-form-urlencoded request body into getParameter methods for PUT requests

2010-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49964 Summary: Allow parsing of application/x-www-form-urlencoded request body into getParameter methods for PUT requests Product: Tomcat 6 Version: unspecified Pla

DO NOT REPLY [Bug 49964] Allow parsing of application/x-www-form-urlencoded request body into getParameter methods for PUT requests

2010-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49964 Christopher Schultz changed: What|Removed |Added OS/Version||All --- Comment #1 from Chri

Tomcat service VS start as batch file

2010-09-20 Thread liorpf
Hi, I upgrade our application from tomcat 5.5 & java 1.5 to Tomcat 6 and 1.6 When I run the tomcat 6 using batch file (using catlina.bat) it works perfectly fine, However when the tomcat is installed as service our main java script file (it is a huge Dojo resource) seems to be cut somehow and the

Writing unit tests

2010-09-20 Thread Christopher Schultz
All, I'm attempting a patch for https://issues.apache.org/bugzilla/show_bug.cgi?id=49964 and I'd like to write a few unit tests for it. In the Tomcat 6.0.x trunk, I can only find what appear to be 30-40 test files. Is there a test suite elsewhere that I can download and augment in order to properl

DO NOT REPLY [Bug 49935] recursive tag calls don't work

2010-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49935 --- Comment #2 from Peter Giles 2010-09-20 14:41:59 EDT --- I verified that this issue still exists in Tomcat 5.5.31 as well. Not sure how to flag the issue for that since the version isn't known to Bugzilla yet. -- Configure bugmail: h

RE: Tomcat service VS start as batch file

2010-09-20 Thread Caldarale, Charles R
> From: liorpf [mailto:lior.pe...@amdocs.com] > Subject: Tomcat service VS start as batch file > I upgrade our application from tomcat 5.5 & java 1.5 to > Tomcat 6 and 1.6 Exact Tomcat versions? Using APR or not? Exact JDK version? Exact platform you're running on? (Windows something, appa

RE: Tomcat service VS start as batch file

2010-09-20 Thread liorpf
We are not using APR Everything is teh same except that the service is using the JRE DLL while batch file is using java under the JDK installation n828cl wrote: > >> From: liorpf [mailto:lior.pe...@amdocs.com] >> Subject: Tomcat service VS start as batch file > >> I upgrade our application fro

Re: Tomcat service VS start as batch file

2010-09-20 Thread Pid
On 20/09/2010 20:53, liorpf wrote: > > We are not using APR > Everything is teh same except that the service is using the JRE DLL while > batch file is using java under the JDK installation Probably a discussion for the Users List, rather than the developers list, for now at least. p 0x625908

DO NOT REPLY [Bug 49935] recursive tag calls don't work

2010-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49935 Mark Thomas changed: What|Removed |Added Version|5.5.30 |5.5.31 --- Comment #3 from Mark Thom

DO NOT REPLY [Bug 49964] Allow parsing of application/x-www-form-urlencoded request body into getParameter methods for PUT requests

2010-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49964 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 48692] Provide option to parse application/x-www-form-urlencoded PUT requests

2010-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48692 Mark Thomas changed: What|Removed |Added CC||ch...@christopherschultz.ne

Re: Writing unit tests

2010-09-20 Thread Mark Thomas
On 20/09/2010 11:29, Christopher Schultz wrote: > All, > > I'm attempting a patch for > https://issues.apache.org/bugzilla/show_bug.cgi?id=49964 and I'd like to > write a few unit tests for it. In the Tomcat 6.0.x trunk, I can only > find what appear to be 30-40 test files. Is there a test suite e

DO NOT REPLY [Bug 48692] Provide option to parse application/x-www-form-urlencoded PUT requests

2010-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48692 --- Comment #2 from Christopher Schultz 2010-09-20 16:40:52 EDT --- I'll copy my comments from the duplicate bug #49964 just so they're more likely to be read: My proposal is this (and I'm prepared to write the patches myself): 1. A new

DO NOT REPLY [Bug 48692] Provide option to parse application/x-www-form-urlencoded PUT requests

2010-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48692 --- Comment #3 from Mark Thomas 2010-09-20 16:45:51 EDT --- How about parsePutBodyParams (since POST will always be parsed) with values false (default) or true? The logic for STRICT_SERVLET_COMPLIANCE in 7.0.x has been made more consistent

Re: Writing unit tests

2010-09-20 Thread Christopher Schultz
Mark, On 9/20/2010 4:33 PM, Mark Thomas wrote: > On 20/09/2010 11:29, Christopher Schultz wrote: >> All, >> >> I'm attempting a patch for >> https://issues.apache.org/bugzilla/show_bug.cgi?id=49964 and I'd like to >> write a few unit tests for it. In the Tomcat 6.0.x trunk, I can only >> find what

DO NOT REPLY [Bug 48692] Provide option to parse application/x-www-form-urlencoded PUT requests

2010-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48692 --- Comment #4 from Christopher Schultz 2010-09-20 16:50:00 EDT --- In one of the discussions on the tomcat-user list, the OP had complained that he couldn't pass "parameters" using methods such as DELETE, etc. I figured I'd let the config

Re: Writing unit tests

2010-09-20 Thread Mark Thomas
On 20/09/2010 13:46, Christopher Schultz wrote: > 1. There's a method in catalina.connector.Connector called init(). When > does that get called? I had expected that it would be called after all > the setXXX attributes had be set on it from the digester upon start-up, > but it appears that Connect

DO NOT REPLY [Bug 48692] Provide option to parse application/x-www-form-urlencoded PUT requests

2010-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48692 --- Comment #5 from Mark Thomas 2010-09-20 16:54:15 EDT --- OK. A comma separated list of method names would make sense in that case. Although methods that are not allowed to have bodies should not be permitted. -- Configure bugmail: http

Re: Writing unit tests

2010-09-20 Thread Christopher Schultz
Mark, On 9/20/2010 4:52 PM, Mark Thomas wrote: > That'll probably be better in 7.0.x. I do wonder what init code you > might need. I was expecting a simple boolean attribute. Once that is > sorted, we can figure out how to port it to 6.0.x Since I was thinking of allowing any set of HTTP methods,

DO NOT REPLY [Bug 48692] Provide option to parse application/x-www-form-urlencoded PUT requests

2010-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48692 --- Comment #6 from Christopher Schultz 2010-09-20 17:02:15 EDT --- Hmm. I was trying to avoid an exhaustive or partial list of HTTP methods specifically in the code: I wanted to let this code grow to work with any crazy non-standard metho

RE: Writing unit tests

2010-09-20 Thread Caldarale, Charles R
> From: Christopher Schultz [mailto:ch...@christopherschultz.net] > Subject: Re: Writing unit tests > > Yep. Go with the current style of the file. > Gotcha. Just remember: no bloody tabs (even if the source file still has some). - Chuck THIS COMMUNICATION MAY CONTAIN CONFIDENTIAL AND/OR OT

Code Style.

2010-09-20 Thread Wesley Acheson
>> 2. Coding conventions seem to be applied ... inconsistently. Is there a >> code style guide that I can actually follow so my code "looks right", or >> should I just look at what's already there in the files I'm modifying >> and take my best guess at what's appropriate? > > Yep. Go with the curre

DO NOT REPLY [Bug 48692] Provide option to parse application/x-www-form-urlencoded PUT requests

2010-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48692 --- Comment #7 from Christopher Schultz 2010-09-20 18:15:54 EDT --- Okay, I've got my patch working in TC 7, and I've renamed the configuration setting to the less unwieldy "parseBodyMethods". -- Configure bugmail: https://issues.apache.

Re: Code Style.

2010-09-20 Thread Mark Thomas
On 20/09/2010 15:04, Wesley Acheson wrote: >>> 2. Coding conventions seem to be applied ... inconsistently. Is there a >>> code style guide that I can actually follow so my code "looks right", or >>> should I just look at what's already there in the files I'm modifying >>> and take my best guess at

Re: Code Style.

2010-09-20 Thread Wesley Acheson
Sorry missed that. Somehow though I think I may have seen it just not when I was last looking for it. The fact that I named it such seems like I had it in my subconsious. Sorry Wes [OT] Is it actually any use the extent I've tried to be involved? On Tue, Sep 21, 2010 at 12:58 AM, Mark Thomas wr

Re: Bug 49914 - "Filter on url-pattern of "/" is not invoked"

2010-09-20 Thread Wesley Acheson
On Tue, Sep 14, 2010 at 3:16 PM, Wesley Acheson wrote: > On Tue, Sep 14, 2010 at 3:01 PM, Remy Maucherat wrote: >> On Tue, 2010-09-14 at 12:26 +0100, Mark Thomas wrote: >>> You need to be able to quote the section of the spec that demonstrates >>> it is wrong. Having quickly scanned the 2.5 and 3

Re: Code Style.

2010-09-20 Thread Mark Thomas
On 20/09/2010 16:09, Wesley Acheson wrote: > Sorry missed that. Somehow though I think I may have seen it just not > when I was last looking for it. The fact that I named it such seems > like I had it in my subconsious. Sorry np. There is plenty of scope to improve that along the lines you suggest

Re: Bug 49914 - "Filter on url-pattern of "/" is not invoked"

2010-09-20 Thread Mark Thomas
On 20/09/2010 16:19, Wesley Acheson wrote: > Just a friendly nudge I'm not looking into this any further because I > don't know what the correct behaviour is. The servlet documentation > isn't clear as stated. I feel I lean the other way than Mark in that I > think the bug is valid. However unless

DO NOT REPLY [Bug 49965] New: JAASRealm uses wrong string constants

2010-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49965 Summary: JAASRealm uses wrong string constants Product: Tomcat 6 Version: 6.0.29 Platform: PC OS/Version: Linux Status: NEW Severity: minor Priority: P2

DO NOT REPLY [Bug 49942] Possible data-race on NioEndpoint$PollerEvent.interestOps

2010-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49942 konstantin.s.serebry...@gmail.com changed: What|Removed |Added CC||konstantin.s.ser