svn commit: r981441 - in /tomcat/trunk: java/org/apache/tomcat/util/http/fileupload/ test/webapp-3.0/WEB-INF/tags/ test/webapp-3.0/bug45nnn/

2010-08-02 Thread rjung
Author: rjung Date: Mon Aug 2 10:00:40 2010 New Revision: 981441 URL: http://svn.apache.org/viewvc?rev=981441&view=rev Log: Fix svn properties: - java/org/apache/tomcat/util/http/fileupload/InvalidFileNameException.java Removed mime-type and added eol-style and keywords. Already pinged upstre

Re: [VOTE] Release Apache Tomcat 7.0.1

2010-08-02 Thread Mark Thomas
On 01/08/2010 21:35, Mark Thomas wrote: > The proposed Apache Tomcat 7.0.1 release is now available for voting. > > It can be obtained from: > http://people.apache.org/~markt/dev/tomcat-7/v7.0.1/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_1/ > > I have incl

svn commit: r981448 - in /tomcat/trunk: java/org/apache/catalina/security/SecurityClassLoad.java webapps/docs/changelog.xml

2010-08-02 Thread markt
Author: markt Date: Mon Aug 2 10:49:06 2010 New Revision: 981448 URL: http://svn.apache.org/viewvc?rev=981448&view=rev Log: Fix running with a security manager Modified: tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java tomcat/trunk/webapps/docs/changelog.xml Modifie

svn commit: r981451 - /tomcat/trunk/java/org/apache/catalina/util/LifecycleMBeanBase.java

2010-08-02 Thread markt
Author: markt Date: Mon Aug 2 10:58:23 2010 New Revision: 981451 URL: http://svn.apache.org/viewvc?rev=981451&view=rev Log: Javadoc fixes Modified: tomcat/trunk/java/org/apache/catalina/util/LifecycleMBeanBase.java Modified: tomcat/trunk/java/org/apache/catalina/util/LifecycleMBeanBase.java

Re: [VOTE] Release Apache Tomcat 7.0.1

2010-08-02 Thread Mladen Turk
On 08/02/2010 12:44 PM, Mark Thomas wrote: On 01/08/2010 21:35, Mark Thomas wrote: The proposed Apache Tomcat 7.0.1 release is now available for voting. It can be obtained from: http://people.apache.org/~markt/dev/tomcat-7/v7.0.1/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/t

svn commit: r981453 - /tomcat/trunk/conf/catalina.policy

2010-08-02 Thread markt
Author: markt Date: Mon Aug 2 11:00:51 2010 New Revision: 981453 URL: http://svn.apache.org/viewvc?rev=981453&view=rev Log: nit Modified: tomcat/trunk/conf/catalina.policy Modified: tomcat/trunk/conf/catalina.policy URL: http://svn.apache.org/viewvc/tomcat/trunk/conf/catalina.policy?rev=98

Re: [VOTE] Release Apache Tomcat 7.0.1

2010-08-02 Thread Mark Thomas
On 02/08/2010 12:00, Mladen Turk wrote: > On 08/02/2010 12:44 PM, Mark Thomas wrote: >> On 01/08/2010 21:35, Mark Thomas wrote: >>> The proposed Apache Tomcat 7.0.1 release is now available for voting. >>> >>> It can be obtained from: >>> http://people.apache.org/~markt/dev/tomcat-7/v7.0.1/ >>> The

svn commit: r981466 - /tomcat/trunk/checkstyle.xml

2010-08-02 Thread markt
Author: markt Date: Mon Aug 2 11:53:26 2010 New Revision: 981466 URL: http://svn.apache.org/viewvc?rev=981466&view=rev Log: Not ready for this check yet Modified: tomcat/trunk/checkstyle.xml Modified: tomcat/trunk/checkstyle.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/checkstyle.xml

svn commit: r981468 - /tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_es.properties

2010-08-02 Thread markt
Author: markt Date: Mon Aug 2 12:01:13 2010 New Revision: 981468 URL: http://svn.apache.org/viewvc?rev=981468&view=rev Log: Tab police Modified: tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_es.properties Modified: tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_es.

svn commit: r981487 - in /tomcat/trunk/java/org/apache/catalina: startup/ContextConfig.java util/LifecycleMBeanBase.java

2010-08-02 Thread rjung
Author: rjung Date: Mon Aug 2 12:44:45 2010 New Revision: 981487 URL: http://svn.apache.org/viewvc?rev=981487&view=rev Log: Javadocs fix: @Link -> @link Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java tomcat/trunk/java/org/apache/catalina/util/LifecycleMBeanBas

svn commit: r981490 - in /tomcat/trunk/java: javax/servlet/FilterConfig.java org/apache/catalina/core/ApplicationContext.java org/apache/catalina/mbeans/JmxRemoteLifecycleListener.java org/apache/jasp

2010-08-02 Thread rjung
Author: rjung Date: Mon Aug 2 12:52:11 2010 New Revision: 981490 URL: http://svn.apache.org/viewvc?rev=981490&view=rev Log: Javadocs fix: @returns -> @return. Modified: tomcat/trunk/java/javax/servlet/FilterConfig.java tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java

svn commit: r981500 - /tomcat/trunk/build.xml

2010-08-02 Thread rjung
Author: rjung Date: Mon Aug 2 13:07:03 2010 New Revision: 981500 URL: http://svn.apache.org/viewvc?rev=981500&view=rev Log: Use source encoding ISO-8859-1 for javadoc just like we do for javac. Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL: http://svn.apache.org/vie

svn commit: r981501 - in /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile: StackMap.java StackMapEntry.java StackMapTable.java StackMapTableEntry.java

2010-08-02 Thread rjung
Author: rjung Date: Mon Aug 2 13:08:37 2010 New Revision: 981501 URL: http://svn.apache.org/viewvc?rev=981501&view=rev Log: Replace UTF section sign in Javadoc by HTML entity. Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/StackMap.java tomcat/trunk/java/org/apache/tom

svn commit: r981565 [5/5] - /tomcat/trunk/java/javax/servlet/resources/

2010-08-02 Thread markt
Modified: tomcat/trunk/java/javax/servlet/resources/web-app_2_4.xsd URL: http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/resources/web-app_2_4.xsd?rev=981565&r1=981564&r2=981565&view=diff == --- tomcat/trunk/j

svn commit: r981565 [2/5] - /tomcat/trunk/java/javax/servlet/resources/

2010-08-02 Thread markt
Modified: tomcat/trunk/java/javax/servlet/resources/j2ee_web_services_1_1.xsd URL: http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/resources/j2ee_web_services_1_1.xsd?rev=981565&r1=981564&r2=981565&view=diff =

svn commit: r981566 - in /tomcat/trunk/java/org/apache: catalina/ant/jmx/package.html catalina/connector/mbeans-descriptors.xml jasper/tagplugins/jstl/tagPlugins.xml tomcat/util/bcel/classfile/Attribu

2010-08-02 Thread markt
Author: markt Date: Mon Aug 2 15:41:50 2010 New Revision: 981566 URL: http://svn.apache.org/viewvc?rev=981566&view=rev Log: Tab police Modified: tomcat/trunk/java/org/apache/catalina/ant/jmx/package.html tomcat/trunk/java/org/apache/catalina/connector/mbeans-descriptors.xml tomcat/tr

svn commit: r981567 - /tomcat/trunk/conf/context.xml

2010-08-02 Thread markt
Author: markt Date: Mon Aug 2 15:42:07 2010 New Revision: 981567 URL: http://svn.apache.org/viewvc?rev=981567&view=rev Log: Tab police Modified: tomcat/trunk/conf/context.xml Modified: tomcat/trunk/conf/context.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/conf/context.xml?rev=981567&

svn commit: r981569 - in /tomcat/trunk/res: deployer/build.xml maven/mvn-pub.xml

2010-08-02 Thread markt
Author: markt Date: Mon Aug 2 15:43:58 2010 New Revision: 981569 URL: http://svn.apache.org/viewvc?rev=981569&view=rev Log: Tab police Modified: tomcat/trunk/res/deployer/build.xml tomcat/trunk/res/maven/mvn-pub.xml Modified: tomcat/trunk/res/deployer/build.xml URL: http://svn.apache.o

svn commit: r981574 - in /tomcat/trunk/webapps/docs: ./ appdev/ appdev/sample/web/WEB-INF/ architecture/startup/ images/

2010-08-02 Thread markt
Author: markt Date: Mon Aug 2 15:58:37 2010 New Revision: 981574 URL: http://svn.apache.org/viewvc?rev=981574&view=rev Log: Tab police Modified: tomcat/trunk/webapps/docs/appdev/processes.xml tomcat/trunk/webapps/docs/appdev/sample/web/WEB-INF/web.xml tomcat/trunk/webapps/docs/apr.xm

svn commit: r981578 - in /tomcat/trunk/webapps/examples: WEB-INF/jsp/ WEB-INF/jsp2/ jsp/cal/ jsp/checkbox/ jsp/colors/ jsp/dates/ jsp/error/ jsp/jsp2/el/ jsp/jsp2/jspattribute/ jsp/jsp2/jspx/ jsp/jsp2

2010-08-02 Thread markt
Author: markt Date: Mon Aug 2 16:10:21 2010 New Revision: 981578 URL: http://svn.apache.org/viewvc?rev=981578&view=rev Log: Tab police Modified: tomcat/trunk/webapps/examples/WEB-INF/jsp/debug-taglib.tld tomcat/trunk/webapps/examples/WEB-INF/jsp/example-taglib.tld tomcat/trunk/webapp

svn commit: r981579 - in /tomcat/trunk/webapps: ROOT/tomcat.svg host-manager/WEB-INF/web.xml manager/WEB-INF/jsp/sessionDetail.jsp manager/WEB-INF/jsp/sessionsList.jsp manager/status.xsd manager/xform

2010-08-02 Thread markt
Author: markt Date: Mon Aug 2 16:13:22 2010 New Revision: 981579 URL: http://svn.apache.org/viewvc?rev=981579&view=rev Log: Tab police Modified: tomcat/trunk/webapps/ROOT/tomcat.svg tomcat/trunk/webapps/host-manager/WEB-INF/web.xml tomcat/trunk/webapps/manager/WEB-INF/jsp/sessionDeta

svn commit: r981580 - in /tomcat/trunk: build.xml eclipse.classpath eclipse.project webapps/docs/changelog.xml

2010-08-02 Thread markt
Author: markt Date: Mon Aug 2 16:16:18 2010 New Revision: 981580 URL: http://svn.apache.org/viewvc?rev=981580&view=rev Log: Extend Checkstyle to most text files Fix tabs in remaining files Modified: tomcat/trunk/build.xml tomcat/trunk/eclipse.classpath tomcat/trunk/eclipse.project

svn commit: r981589 - /tomcat/trunk/java/org/apache/catalina/connector/Connector.java

2010-08-02 Thread markt
Author: markt Date: Mon Aug 2 16:30:51 2010 New Revision: 981589 URL: http://svn.apache.org/viewvc?rev=981589&view=rev Log: Correct Javadoc copy and paste error Modified: tomcat/trunk/java/org/apache/catalina/connector/Connector.java Modified: tomcat/trunk/java/org/apache/catalina/connector

svn commit: r981602 - in /tomcat/trunk/java/org/apache/catalina: core/ filters/ ha/ ha/session/ ha/tcp/

2010-08-02 Thread markt
Author: markt Date: Mon Aug 2 17:05:03 2010 New Revision: 981602 URL: http://svn.apache.org/viewvc?rev=981602&view=rev Log: Handful of Javadoc fixes Modified: tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java tomcat/trunk/java/org/apache/catalina/core/StandardServer.java

getCurrentTimeMillis definition in JDBCAccessValve

2010-08-02 Thread Channing Benson
Hi, What am I missing here? In JDBCAccessValve, the method getCurrentTimeMillis is defined as public long getCurrentTimeMillis() { long systime = System.currentTimeMillis(); if ((systime - currentTimeMillis) > 1000) { currentTimeMillis = new java.util.Date(sys

Re: getCurrentTimeMillis definition in JDBCAccessValve

2010-08-02 Thread Mark Thomas
On 02/08/2010 23:12, Channing Benson wrote: > Hi, > > What am I missing here? > > In JDBCAccessValve, the method getCurrentTimeMillis is defined as > > public long getCurrentTimeMillis() { > long systime = System.currentTimeMillis(); > if ((systime - currentTimeMillis) > 10

RE: getCurrentTimeMillis definition in JDBCAccessValve

2010-08-02 Thread Caldarale, Charles R
> From: Mark Thomas [mailto:ma...@apache.org] > Subject: Re: getCurrentTimeMillis definition in JDBCAccessValve > > Speed. This way we only generate a new date string every 1s. But why generate the Date instance at all? Since System.currentTimeMillis() is being called every time, why not return

Re: getCurrentTimeMillis definition in JDBCAccessValve

2010-08-02 Thread Mark Thomas
On 02/08/2010 23:33, Caldarale, Charles R wrote: >> From: Mark Thomas [mailto:ma...@apache.org] >> Subject: Re: getCurrentTimeMillis definition in JDBCAccessValve >> >> Speed. This way we only generate a new date string every 1s. > > But why generate the Date instance at all? Since System.current

RE: getCurrentTimeMillis definition in JDBCAccessValve

2010-08-02 Thread Caldarale, Charles R
> From: Mark Thomas [mailto:ma...@apache.org] > Subject: Re: getCurrentTimeMillis definition in JDBCAccessValve > > Note that there are some tests in the test tree you can use to see what > impact your changes have on performance. I would expect almost nil performance benefit from changing this c