Re: svn commit: r960104 - /tomcat/trunk/test/org/apache/catalina/mbeans/TestRegistration.java

2010-07-08 Thread Mark Thomas
On 08/07/2010 06:37, Marc Guillemot wrote: > Hi Mark, > > Mark Thomas wrote: >> ... >> There is nothing stopping you running FindBugs, Checkstyle or any other >> tool locally. I use FindBugs on the Tomact 7 code-base all the time. > > what about sharing the config and including it into the build?

Re: svn commit: r960104 - /tomcat/trunk/test/org/apache/catalina/mbeans/TestRegistration.java

2010-07-08 Thread Marc Guillemot
Mark Thomas wrote: ... JavadocType (versionFormat) -> currently 539 failures Not sure what exactly you are proposing here. Could you clarify? I mean the format of the @Version JavaDoc tag what Konstantin Kolinko has started to fix: http://tomcat.markmail.org/thread/bfry4x5gwbhezo6x ...

[Tomcat Wiki] Update of "TomcatVersions" by markt

2010-07-08 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "TomcatVersions" page has been changed by markt. The comment on this change is: Re-order to list latest first. Update 7.0.x info. Update list of unsupported versions.. http://wiki.a

svn commit: r961647 - /tomcat/trunk/TOMCAT-7-RELEASE-PLAN.txt

2010-07-08 Thread markt
Author: markt Date: Thu Jul 8 09:00:47 2010 New Revision: 961647 URL: http://svn.apache.org/viewvc?rev=961647&view=rev Log: Update post release of 7.0.0 beta Modified: tomcat/trunk/TOMCAT-7-RELEASE-PLAN.txt Modified: tomcat/trunk/TOMCAT-7-RELEASE-PLAN.txt URL: http://svn.apache.org/viewvc/

Re: [VOTE] Release build 6.0.28

2010-07-08 Thread Rainer Jung
On 08.07.2010 01:14, sebb wrote: On 7 July 2010 21:19, Rainer Jung wrote: On 07.07.2010 21:00, sebb wrote: On 7 July 2010 10:47, Rainer Jungwrote: On 29.06.2010 17:17, jean-frederic clere wrote: - build.properties: it would be nice, if you did the release changes to the file before

Re: svn commit: r960104 - /tomcat/trunk/test/org/apache/catalina/mbeans/TestRegistration.java

2010-07-08 Thread Rainer Jung
On 08.07.2010 10:30, Marc Guillemot wrote: Mark Thomas wrote: ... JavadocType (versionFormat) -> currently 539 failures Not sure what exactly you are proposing here. Could you clarify? I mean the format of the @Version JavaDoc tag what Konstantin Kolinko has started to fix: http://tomcat.ma

DO NOT REPLY [Bug 49234] JMX Descriptor Modifications

2010-07-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49234 --- Comment #58 from chamith buddhika 2010-07-08 07:05:50 EDT --- Created an attachment (id=25733) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25733) o.a.Catalina.users Patch Removes non existent class descriptors. -- Con

DO NOT REPLY [Bug 49234] JMX Descriptor Modifications

2010-07-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49234 --- Comment #59 from chamith buddhika 2010-07-08 07:09:03 EDT --- Created an attachment (id=25734) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25734) o.a.Catalina.valves Patch Removes non existent class descriptors and adds

svn commit: r961720 - /tomcat/tc6.0.x/trunk/KEYS

2010-07-08 Thread jfclere
Author: jfclere Date: Thu Jul 8 11:37:08 2010 New Revision: 961720 URL: http://svn.apache.org/viewvc?rev=961720&view=rev Log: Add my long key. Modified: tomcat/tc6.0.x/trunk/KEYS Modified: tomcat/tc6.0.x/trunk/KEYS URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/KEYS?rev=961720&r1=9

svn commit: r961726 - /tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

2010-07-08 Thread jfclere
Author: jfclere Date: Thu Jul 8 12:11:29 2010 New Revision: 961726 URL: http://svn.apache.org/viewvc?rev=961726&view=rev Log: 6.0.27 wasn't released. Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.o

[RESULT] [VOTE] Release Tomcat 5.5.30 Build

2010-07-08 Thread Jim Jagielski
On Jul 1, 2010, at 12:11 PM, Jim Jagielski wrote: > The builds for Tomcat 5.5.30 are ready for testing and approval. > The candidates binaries are available here: > > http://people.apache.org/~jim/tomcat-5.5/ > > According to the release process, the 5.5.30 build corresponding to the > tag TO

Re: [VOTE] Release build 6.0.28

2010-07-08 Thread Henri Yandell
On Thu, Jul 8, 2010 at 3:59 AM, Rainer Jung wrote: > On 08.07.2010 01:14, sebb wrote: >> >> On 7 July 2010 21:19, Rainer Jung  wrote: >>> >>> On 07.07.2010 21:00, sebb wrote: On 7 July 2010 10:47, Rainer Jung    wrote: > > On 29.06.2010 17:17, jean-frederic clere wrote: >>> >

svn commit: r961819 - in /tomcat/trunk: java/org/apache/catalina/connector/Connector.java webapps/docs/changelog.xml

2010-07-08 Thread markt
Author: markt Date: Thu Jul 8 15:48:48 2010 New Revision: 961819 URL: http://svn.apache.org/viewvc?rev=961819&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49503 Revert the protocol handler component of r940656. Subsequent lifecycle fixes have resolved the issues that requ

DO NOT REPLY [Bug 49503] Connectors do not bind to their ports in Catalina.load(), but only later in start()

2010-07-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49503 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 49555] Custom Taglibs should support all parameters

2010-07-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49555 Mark Thomas changed: What|Removed |Added Severity|blocker |normal --- Comment #3 from Mark Thom

Vote: Add Checkstyle roleset and make code cleanups!

2010-07-08 Thread Peter Roßbach
Hi, after the discussion about code style (http://tomcat.markmail.org/thread/2c7lkzmpcuxqpgjj ), I think that we must vote for this fix: https://issues.apache.org/bugzilla/show_bug.cgi?id=49268 It includes a starting point for a very limited checkstyle ruleset. +1: progressively introduce che

svn commit: r961827 - in /tomcat/site/trunk/xdocs: download-60.xml index.xml oldnews.xml security-6.xml stylesheets/tomcat-site.xsl

2010-07-08 Thread jfclere
Author: jfclere Date: Thu Jul 8 16:09:11 2010 New Revision: 961827 URL: http://svn.apache.org/viewvc?rev=961827&view=rev Log: change for the 6.0.28 release and put back the standard logo. Modified: tomcat/site/trunk/xdocs/download-60.xml tomcat/site/trunk/xdocs/index.xml tomcat/site/

svn commit: r961828 [3/3] - /tomcat/site/trunk/docs/

2010-07-08 Thread jfclere
Modified: tomcat/site/trunk/docs/security-impact.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/security-impact.html?rev=961828&r1=961827&r2=961828&view=diff == --- tomcat/site/trunk/docs/security-impact.htm

Re: Vote: Add Checkstyle roleset and make code cleanups!

2010-07-08 Thread Remy Maucherat
On Thu, 2010-07-08 at 18:02 +0200, Peter Roßbach wrote: > Hi, > > after the discussion about code style > (http://tomcat.markmail.org/thread/2c7lkzmpcuxqpgjj > ), I think that we must vote for this fix: > > https://issues.apache.org/bugzilla/show_bug.cgi?id=49268 > It includes a starting point

Re: [VOTE] Release build 6.0.28

2010-07-08 Thread sebb
On 8 July 2010 16:22, Henri Yandell wrote: > On Thu, Jul 8, 2010 at 3:59 AM, Rainer Jung wrote: >> On 08.07.2010 01:14, sebb wrote: >>> >>> On 7 July 2010 21:19, Rainer Jung  wrote: On 07.07.2010 21:00, sebb wrote: > > On 7 July 2010 10:47, Rainer Jung    wrote: >> >> On

[g...@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed

2010-07-08 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-taglibs-standard has an issue affecting its community integration.

Re: [VOTE] Release build 6.0.28

2010-07-08 Thread Henri Yandell
On Thu, Jul 8, 2010 at 9:36 AM, sebb wrote: > On 8 July 2010 16:22, Henri Yandell wrote: >> >> IIUC, it means the tag would not refer to any trunk revision. > > Strictly speaking, yes, there is no exact match in trunk, because the > version fixes are deliberately not applied to trunk. > >> It get

svn commit: r961868 - in /tomcat/site/trunk: docs/download-55.html xdocs/download-55.xml

2010-07-08 Thread jim
Author: jim Date: Thu Jul 8 18:28:01 2010 New Revision: 961868 URL: http://svn.apache.org/viewvc?rev=961868&view=rev Log: 5.5.30 Modified: tomcat/site/trunk/docs/download-55.html tomcat/site/trunk/xdocs/download-55.xml Modified: tomcat/site/trunk/docs/download-55.html URL: http://svn.a

Re: [VOTE] Release build 6.0.28

2010-07-08 Thread Konstantin Kolinko
2010/7/7 sebb : > > Or: > > Create clean workspace from SVN. > > Make any necessary updates that apply to the tag only. > > Create the tag from the workspace using svn copy dir https://.../ > > Trunk is then untainted by unnecessary changes, and the tag commit > e-mail shows the changes made. > His

Re: [VOTE] Release build 6.0.28

2010-07-08 Thread sebb
On 8 July 2010 17:57, Henri Yandell wrote: > On Thu, Jul 8, 2010 at 9:36 AM, sebb wrote: >> On 8 July 2010 16:22, Henri Yandell wrote: >>> >>> IIUC, it means the tag would not refer to any trunk revision. >> >> Strictly speaking, yes, there is no exact match in trunk, because the >> version fixe

svn commit: r961942 - /tomcat/trunk/java/javax/servlet/jsp/tagext/FunctionInfo.java

2010-07-08 Thread markt
Author: markt Date: Thu Jul 8 21:19:39 2010 New Revision: 961942 URL: http://svn.apache.org/viewvc?rev=961942&view=rev Log: Tab police Modified: tomcat/trunk/java/javax/servlet/jsp/tagext/FunctionInfo.java Modified: tomcat/trunk/java/javax/servlet/jsp/tagext/FunctionInfo.java URL: http://s

svn commit: r961947 - in /tomcat/trunk/test: org/apache/el/TestELInJsp.java org/apache/el/TesterFunctions.java webapp-3.0/WEB-INF/bugs.tld webapp-3.0/bug49555.jsp

2010-07-08 Thread markt
Author: markt Date: Thu Jul 8 21:28:21 2010 New Revision: 961947 URL: http://svn.apache.org/viewvc?rev=961947&view=rev Log: Test case for https://issues.apache.org/bugzilla/show_bug.cgi?id=49555 Fix to follow shortly Added: tomcat/trunk/test/webapp-3.0/bug49555.jsp (with props) Modified:

svn commit: r961948 - in /tomcat/trunk: java/org/apache/jasper/compiler/ELFunctionMapper.java webapps/docs/changelog.xml

2010-07-08 Thread markt
Author: markt Date: Thu Jul 8 21:29:12 2010 New Revision: 961948 URL: http://svn.apache.org/viewvc?rev=961948&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49555 Correctly handle tag libraries that use functions defined in static inner classes Modified: tomcat/trunk/j

svn commit: r961949 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-07-08 Thread markt
Author: markt Date: Thu Jul 8 21:30:16 2010 New Revision: 961949 URL: http://svn.apache.org/viewvc?rev=961949&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=961

DO NOT REPLY [Bug 49555] Custom Taglibs should support all parameters

2010-07-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49555 Mark Thomas changed: What|Removed |Added Component|Jasper |Jasper Product|Tomcat 7

DO NOT REPLY [Bug 49574] New: ConcurrentModificationException when updating a WAR file

2010-07-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49574 Summary: ConcurrentModificationException when updating a WAR file Product: Tomcat 6 Version: 6.0.20 Platform: PC OS/Version: Linux Status: NEW Sever

svn commit: r961955 - /tomcat/tc5.5.x/trunk/STATUS.txt

2010-07-08 Thread kkolinko
Author: kkolinko Date: Thu Jul 8 21:41:08 2010 New Revision: 961955 URL: http://svn.apache.org/viewvc?rev=961955&view=rev Log: vote Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=9619

DO NOT REPLY [Bug 49574] ConcurrentModificationException when updating a WAR file

2010-07-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49574 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 49234] JMX Descriptor Modifications

2010-07-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49234 --- Comment #60 from Mark Thomas 2010-07-08 17:56:28 EDT --- All patches applied. Many thanks. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are t

svn commit: r961963 - in /tomcat/trunk: java/org/apache/naming/factory/webservices/ServiceRefFactory.java webapps/docs/changelog.xml

2010-07-08 Thread markt
Author: markt Date: Thu Jul 8 22:22:34 2010 New Revision: 961963 URL: http://svn.apache.org/viewvc?rev=961963&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48297 Use the HandlerInfo to initialise the HandlerChain, rather than adding to it which clearly isn't correct. >From

DO NOT REPLY [Bug 48297] webservices.ServiceRefFactory.initHandlerChain adds wrong items to list?

2010-07-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48297 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 49576] New: 飞过海

2010-07-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49576 Summary: 飞过海 Product: Tomcat 3 Version: Unknown Platform: PC OS/Version: Windows XP Status: NEW Severity: minor Priority: P2 Component: Servlet

DO NOT REPLY [Bug 49576] 飞过海

2010-07-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49576 Bill Barker changed: What|Removed |Added Status|NEW |RESOLVED Resolution|