On 08/07/2010 06:37, Marc Guillemot wrote: > Hi Mark, > > Mark Thomas wrote: >> ... >> There is nothing stopping you running FindBugs, Checkstyle or any other >> tool locally. I use FindBugs on the Tomact 7 code-base all the time. > > what about sharing the config and including it into the build?
It is just the default configuration for the Eclipse plug-in, not part of the build script or anything. > According to the negative comments on commits, everybody should agree on > following checks > FileTabCharacter -> currently 146 failures +1 > JavadocType (versionFormat) -> currently 539 failures Not sure what exactly you are proposing here. Could you clarify? > Following simple steps could be: Seems reasonable, providing there is agreement amongst the committers for each additional check that is added. > Additionally it seems that you pay attention at some warnings emitted by > your IDE. It would be interesting to express these rules as checkstyle > (or whatever) rule that can be checked automatically. Can you list the > Eclipse style warnings you try to fix? Just the standard Java compiler warnings. > I agree that coherent code style is only cosmetic in a first time as it > doesn't change the resulting byte code. Nevertheless it makes easier to > concentrate on the important things: the code content, without being > distracted by the form. Therefore it helps to find real problems and > make easier to compare files, apply patches, ... But it makes it harder to back-port changes. I'm not against cleaning up the code, we just need to be aware of the consequences of doing so. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
