Hi,
I am using Tomcat6.0.13, and could read from the tomcat document that the
,antiResourceLocking' has a side effect of truncating the size of some files
to 0 bytes.
Does the side effect still exist with Tomcat 6.0.13 version? I know that
Tomcat 5.0 has this side effect but I don't know w
Filip Hanik - Dev Lists wrote:
> Cleaned up and fixed.
>
> The release is located here:
> http://people.apache.org/~fhanik/jdbc-pool/v1.0.4/
>
>
> [ ] STABLE - I couldn't find any bugs
> [ ] BETA - I found some bugs but not critical
> [X] BROKEN - I found some show stoppers
>
As Sebb has bee
Filip Hanik - Dev Lists wrote:
> is no longer being picked up, at least not in my test.
> I think it's related to the deploy refactor that has been going on,
> possibly related to
> https://issues.apache.org/bugzilla/show_bug.cgi?id=47343
Possibly. I'll take a look.
Mark
--
Filip Hanik - Dev Lists wrote:
> I'm not sure what we are trying to do in this test, in my mind we are
> proving nothing with this test :)
The only purpose of the test is to provide a representative micro
benchmark of the current code vs your suggestion to use ThreadLocals
instead (in the 5.5.x pa
sebb wrote:
> Oops, forgot to mention - there are only 5 threads in the test; it
> might be useful to try tests with increasing numbers of threads to see
> if the relative numbers change.
I did (I used 50) and they get a little closer but not much.
I left it at 5 as that was my best WAG as to how
Author: markt
Date: Fri Jun 19 11:11:06 2009
New Revision: 786455
URL: http://svn.apache.org/viewvc?rev=786455&view=rev
Log:
Minor improvements
- as per Sebb's comment on the dev list - need to add a volatile
- correct the log message
Modified:
tomcat/trunk/test/org/apache/catalina/valves/Ben
sebb wrote:
> If it is intended to allow currentDate to be updated by another thread
> before the return, then the field needs to be volatile. Otherwise the
> return value needs to be established in the synch. block.
It needs to be volatile. I ran some comparisons and the performance
difference ap
Mark Thomas wrote:
> The (updated) candidates source tarball and derived binaries are
> available here:
> http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.40/
>
> According to the release process, the release based on the 4.0.40 tag is:
> [ ] Broken
> [ ] Alpha
> [ ] Beta
> [X] Stable
Here is
Author: markt
Date: Fri Jun 19 12:04:52 2009
New Revision: 786468
URL: http://svn.apache.org/viewvc?rev=786468&view=rev
Log:
As per review comments:
- use StringBuilder
- add comment to explain one possible cause
- better logging using original data
Modified:
tomcat/trunk/java/org/apache/tomc
Author: markt
Date: Fri Jun 19 12:07:39 2009
New Revision: 786469
URL: http://svn.apache.org/viewvc?rev=786469&view=rev
Log:
Add patch to address Filip and Konstantin's review comments
I have assumed Filip is still +1 for this
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.
Author: markt
Date: Fri Jun 19 12:10:05 2009
New Revision: 786471
URL: http://svn.apache.org/viewvc?rev=786471&view=rev
Log:
The servletapi gives us a perfectly good constant for
'javax.servlet.context.tempdir'. Use it.
Modified:
tomcat/trunk/java/org/apache/catalina/Globals.java
tomcat/
Author: markt
Date: Fri Jun 19 12:16:25 2009
New Revision: 786473
URL: http://svn.apache.org/viewvc?rev=786473&view=rev
Log:
Undo accidental commit of files that should not have been included in r786471.
These will follow separately with the correct comments. Sorry for the noise.
Modified:
t
Where these meant to be included?
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java?rev=786471&r1=786470&r2=786471&view=diff
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/JspRuntimeContext.java?rev=786471&r1=786470&r2=786471&v
Tim Funk wrote:
> Where these meant to be included?
No. Finger trouble on my part. Different tools with different default
behaviour for the enter key. Should already be fixed.
Mark
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java?rev=786471&r1=78647
Author: kkolinko
Date: Fri Jun 19 12:27:08 2009
New Revision: 786477
URL: http://svn.apache.org/viewvc?rev=786477&view=rev
Log:
Rewrote the benchmarks, to allow more than 2 different implementations to be
compared.
Modified:
tomcat/trunk/test/org/apache/catalina/valves/Benchmarks.java
Modif
Mark,
I rewrote the benchmark to allow more than two implementations to be compared.
A test now implements Runnable and its toString() prints the variable
part of the message.
It was fun running these tests. I will detail my observations later.
My thought is that the main difference in time com
Author: markt
Date: Fri Jun 19 12:40:56 2009
New Revision: 786483
URL: http://svn.apache.org/viewvc?rev=786483&view=rev
Log:
Add an additional volatile from a review of the associated benchmark tests.
Add a sync
Modified:
tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java
Modif
Author: markt
Revision: 786483
Modified property: svn:log
Modified: svn:log at Fri Jun 19 12:49:51 2009
--
--- svn:log (original)
+++ svn:log Fri Jun 19 12:49:51 2009
@@ -1,2 +1,2 @@
Add an additional volatile from a revi
Author: kkolinko
Date: Fri Jun 19 12:51:11 2009
New Revision: 786484
URL: http://svn.apache.org/viewvc?rev=786484&view=rev
Log:
Added toString() call to the StringBuffer. The tests will run a bit slower
because of that.
Added two other implementation variants for the first test.
Modified:
to
Author: markt
Date: Fri Jun 19 12:55:56 2009
New Revision: 786486
URL: http://svn.apache.org/viewvc?rev=786486&view=rev
Log:
Add a header case-sensitivity test for 37794 test case (as reported by Tim)
Modified:
tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java
Modified: tomcat
Author: markt
Date: Fri Jun 19 12:56:40 2009
New Revision: 786487
URL: http://svn.apache.org/viewvc?rev=786487&view=rev
Log:
Headers should be compared ignoring case. Reported by Tim F.
Modified:
tomcat/trunk/java/org/apache/catalina/connector/Request.java
Modified: tomcat/trunk/java/org/apa
Author: markt
Date: Fri Jun 19 13:00:29 2009
New Revision: 786489
URL: http://svn.apache.org/viewvc?rev=786489&view=rev
Log:
Add additional required patch
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/tru
Author: markt
Date: Fri Jun 19 13:03:42 2009
New Revision: 786490
URL: http://svn.apache.org/viewvc?rev=786490&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38352
The JSPLoader needs to have read/write permission to the context's temp
directory, as per the spec.
Modified:
Author: markt
Date: Fri Jun 19 13:05:52 2009
New Revision: 786491
URL: http://svn.apache.org/viewvc?rev=786491&view=rev
Log:
Propose fix
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=
https://issues.apache.org/bugzilla/show_bug.cgi?id=38352
--- Comment #7 from Mark Thomas 2009-06-19 06:06:24 PST ---
Not quite.
The javax.servlet.context.tempdir is a context attribute rather than a system
property. There is a complication that the name of the work directory varies
per cont
https://issues.apache.org/bugzilla/show_bug.cgi?id=38352
Mark Thomas changed:
What|Removed |Added
Status|NEEDINFO|NEW
--- Comment #8 from Mark Tho
Author: markt
Date: Fri Jun 19 13:07:28 2009
New Revision: 786494
URL: http://svn.apache.org/viewvc?rev=786494&view=rev
Log:
Propose patch
Modified:
tomcat/current/tc5.5.x/STATUS.txt
Modified: tomcat/current/tc5.5.x/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.
Author: markt
Date: Fri Jun 19 13:08:02 2009
New Revision: 786495
URL: http://svn.apache.org/viewvc?rev=786495&view=rev
Log:
Add extra patch required
Modified:
tomcat/current/tc5.5.x/STATUS.txt
Modified: tomcat/current/tc5.5.x/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/current/tc5.
Author: markt
Date: Fri Jun 19 13:11:00 2009
New Revision: 786496
URL: http://svn.apache.org/viewvc?rev=786496&view=rev
Log:
Update to pool 1.5.1 - fixes regression in 1.5
Modified:
tomcat/trunk/build.properties.default
Modified: tomcat/trunk/build.properties.default
URL:
http://svn.apache.
Author: markt
Date: Fri Jun 19 13:13:35 2009
New Revision: 786498
URL: http://svn.apache.org/viewvc?rev=786498&view=rev
Log:
Propose pool update
Modified:
tomcat/current/tc5.5.x/STATUS.txt
Modified: tomcat/current/tc5.5.x/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/S
Author: markt
Date: Fri Jun 19 13:13:53 2009
New Revision: 786499
URL: http://svn.apache.org/viewvc?rev=786499&view=rev
Log:
Propose pool update
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.
Just spotted this duplicate code in AccessLogValve:
661:if (!dateStamp.equals(tsDate)) {
662:if (!dateStamp.equals(tsDate)) {
Not sure this double-checked looking offers any benefit ;-)
--
> From: Mladen Turk
> I suppose the .sh files have LF line endings even in .zip,
> and those are the only one critical.
I believe they do (I'm not near my pc so can't check) and if they don't, I'd be
+1 for changing the build scipts so they do.
Mark
--
On 19/06/2009, sebb wrote:
> Just spotted this duplicate code in AccessLogValve:
>
> 661:if (!dateStamp.equals(tsDate)) {
> 662:if (!dateStamp.equals(tsDate)) {
>
> Not sure this double-checked looking offers any benefit ;-)
>
Line 767 is als
No, I think line767 is still needed. You could turn to the last part of this
article for reference: "
http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html";.
2009/6/19 sebb
> On 19/06/2009, sebb wrote:
> > Just spotted this duplicate code in AccessLogValve:
> >
> > 661:
Author: markt
Date: Fri Jun 19 14:55:07 2009
New Revision: 786527
URL: http://svn.apache.org/viewvc?rev=786527&view=rev
Log:
Votes and a comment
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.
Author: markt
Date: Fri Jun 19 15:00:18 2009
New Revision: 786530
URL: http://svn.apache.org/viewvc?rev=786530&view=rev
Log:
Votes
Modified:
tomcat/current/tc5.5.x/STATUS.txt
Modified: tomcat/current/tc5.5.x/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=
Author: fhanik
Date: Fri Jun 19 15:05:04 2009
New Revision: 786532
URL: http://svn.apache.org/viewvc?rev=786532&view=rev
Log:
Correct per sebb/markt
Modified:
tomcat/trunk/modules/jdbc-pool/NOTICE
Modified: tomcat/trunk/modules/jdbc-pool/NOTICE
URL:
http://svn.apache.org/viewvc/tomcat/trunk
Author: markt
Date: Fri Jun 19 15:12:02 2009
New Revision: 786540
URL: http://svn.apache.org/viewvc?rev=786540&view=rev
Log:
Remove duplicate code - my bad from r781779. Thanks to sebb for spotting it.
Modified:
tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java
Modified: tomca
On 19/06/2009, Xie Xiaodong wrote:
> No, I think line767 is still needed. You could turn to the last part of this
> article for reference: "
> http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html";.
Oops, my bad.
The code would still work, but it would sometimes create a new D
There is an incorrect NOTICE file, I missed the actual message trying to
be told to me in all the noise. my apologies
Filip
Filip Hanik - Dev Lists wrote:
Cleaned up and fixed.
The release is located here:
http://people.apache.org/~fhanik/jdbc-pool/v1.0.4/
[ ] STABLE - I couldn't find any b
On 19/06/2009, fha...@apache.org wrote:
> Author: fhanik
> Date: Fri Jun 19 15:05:04 2009
> New Revision: 786532
>
> URL: http://svn.apache.org/viewvc?rev=786532&view=rev
> Log:
> Correct per sebb/markt
Sorry, but this is still incorrect.
The NOTICE is now:
>>>
This product includes softwa
Mark Thomas wrote:
Filip Hanik - Dev Lists wrote:
I'm not sure what we are trying to do in this test, in my mind we are
proving nothing with this test :)
The only purpose of the test is to provide a representative micro
benchmark of the current code vs your suggestion to use ThreadLoca
sebb wrote:
On 19/06/2009, fha...@apache.org wrote:
Author: fhanik
Date: Fri Jun 19 15:05:04 2009
New Revision: 786532
URL: http://svn.apache.org/viewvc?rev=786532&view=rev
Log:
Correct per sebb/markt
Sorry, but this is still incorrect.
The NOTICE is now:
This product inclu
Author: fhanik
Date: Fri Jun 19 16:16:16 2009
New Revision: 786569
URL: http://svn.apache.org/viewvc?rev=786569&view=rev
Log:
correction
Modified:
tomcat/trunk/modules/jdbc-pool/NOTICE
Modified: tomcat/trunk/modules/jdbc-pool/NOTICE
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdb
On 19/06/2009, fha...@apache.org wrote:
> Author: fhanik
> Date: Fri Jun 19 16:16:16 2009
> New Revision: 786569
>
> URL: http://svn.apache.org/viewvc?rev=786569&view=rev
> Log:
> correction
>
> Modified:
> tomcat/trunk/modules/jdbc-pool/NOTICE
>
> Modified: tomcat/trunk/modules/jdbc-po
On 16/06/2009, Mark Thomas wrote:
> The (updated) candidates source tarball and derived binaries are
> available here:
> http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.40/
>
> According to the release process, the release based on the 4.0.40 tag is:
Did you mean 4.1.40?
Also, where can I
sebb wrote:
> On 16/06/2009, Mark Thomas wrote:
>> The (updated) candidates source tarball and derived binaries are
>> available here:
>> http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.40/
>>
>> According to the release process, the release based on the 4.0.40 tag is:
>
> Did you mean 4.1
Author: fhanik
Date: Fri Jun 19 17:07:36 2009
New Revision: 786584
URL: http://svn.apache.org/viewvc?rev=786584&view=rev
Log:
shortened
Modified:
tomcat/trunk/modules/jdbc-pool/NOTICE
Modified: tomcat/trunk/modules/jdbc-pool/NOTICE
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc
Author: markt
Date: Fri Jun 19 17:13:00 2009
New Revision: 786585
URL: http://svn.apache.org/viewvc?rev=786585&view=rev
Log:
As per Filip's suggestions:
- reduce object creation
- better use of ThreadLocals
Modified:
tomcat/trunk/test/org/apache/catalina/valves/Benchmarks.java
Modified: tomc
Filip Hanik - Dev Lists wrote:
> Mark Thomas wrote:
>> I was a little surprised that ThreadLocal seems to be slower. I still
>> wonder if I got the test wrong for that but I can't see anything.
>>
> If it was me doing the date, and making it all threadlocal, with no
> global variables at all
> And
> * Fix wrong download location of tcnative 1.1.16
> Patch for "build/build.properties.default":
>
> http://people.apache.org/~kkolinko/patches/2009-05-25_fix_tcnative_download.patch
> +1: kkolinko, fhanik
> - -1:
> + -1: markt - the updated location is still wrong
It points to
http://to
2009/6/19
> http://svn.apache.org/viewvc?rev=785768&view=rev
> http://svn.apache.org/viewvc?rev=785859&view=rev
> +1: kkolinko
> + +1: markt - I don't like commenting out code - if it isn't needed just
> delete it
> + - This is fine for 6.0.x, for trunk 1.6 is the minimum
> -1
Konstantin Kolinko wrote:
>> * Fix wrong download location of tcnative 1.1.16
>> Patch for "build/build.properties.default":
>>
>> http://people.apache.org/~kkolinko/patches/2009-05-25_fix_tcnative_download.patch
>> +1: kkolinko, fhanik
>> - -1:
>> + -1: markt - the updated location is st
Konstantin Kolinko wrote:
> 2009/6/19
>> http://svn.apache.org/viewvc?rev=785768&view=rev
>> http://svn.apache.org/viewvc?rev=785859&view=rev
>> +1: kkolinko
>> + +1: markt - I don't like commenting out code - if it isn't needed just
>> delete it
>> +- This is fine for 6.0.x, f
On 19/06/2009, Mark Thomas wrote:
> sebb wrote:
> > On 16/06/2009, Mark Thomas wrote:
> >> The (updated) candidates source tarball and derived binaries are
> >> available here:
> >> http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.40/
> >>
> >> According to the release process, the re
Author: kkolinko
Date: Fri Jun 19 18:57:59 2009
New Revision: 786631
URL: http://svn.apache.org/viewvc?rev=786631&view=rev
Log:
Add two more implementations for the second test.
a) using a single ThreadLocal instead of multiple ones
b) also using StringBuilder instead of StringBuffer
Also, replace
2009/6/19 Mark Thomas :
>
> I've made the changes you suggested and lo and behold the ThreadLocal is
> quicker.
>
>> testAccessLogGetDate: 16 threads and 1000 iterations using Syncs
>> took 7461ms
>> testAccessLogGetDate: 16 threads and 1000 iterations using
>> ThreadLocals took 6433ms
>
>
On 19/06/2009, kkoli...@apache.org wrote:
> Author: kkolinko
> Date: Fri Jun 19 18:57:59 2009
> New Revision: 786631
>
> URL: http://svn.apache.org/viewvc?rev=786631&view=rev
> Log:
> Add two more implementations for the second test.
> a) using a single ThreadLocal instead of multiple ones
>
sebb wrote:
> The source archives mostly agree with the tags, however there are code
> changes in the following files:
>
> connectors/http11/src/java/org/apache/coyote/http11/Http11Processor.java
> connectors/util/java/org/apache/tomcat/util/buf/CharChunk.java
> connectors/util/java/org/apache/tom
Author: markt
Date: Fri Jun 19 20:21:53 2009
New Revision: 786653
URL: http://svn.apache.org/viewvc?rev=786653&view=rev
Log:
Switch to ThreadLocal where possible. This removes all the syncs apart from
those related to accessing the log file.
Modified:
tomcat/trunk/java/org/apache/catalina/va
Author: markt
Date: Fri Jun 19 20:25:01 2009
New Revision: 786654
URL: http://svn.apache.org/viewvc?rev=786654&view=rev
Log:
As per http://www.apache.org/dev/crypto.html#inform add a crypto notice to each
of the releases
Modified:
tomcat/build/tc5.5.x/RELEASE-NOTES
tomcat/container/branc
ma...@apache.org wrote:
> Author: markt
> Date: Fri Jun 19 20:21:53 2009
> New Revision: 786653
>
> URL: http://svn.apache.org/viewvc?rev=786653&view=rev
> Log:
> Switch to ThreadLocal where possible. This removes all the syncs apart from
> those related to accessing the log file.
I'm planning t
Author: kkolinko
Date: Fri Jun 19 20:29:34 2009
New Revision: 786656
URL: http://svn.apache.org/viewvc?rev=786656&view=rev
Log:
votes
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=786
On 19/06/2009, Mark Thomas wrote:
> sebb wrote:
> > The source archives mostly agree with the tags, however there are code
> > changes in the following files:
> >
> > connectors/http11/src/java/org/apache/coyote/http11/Http11Processor.java
> > connectors/util/java/org/apache/tomcat/util/buf/C
On 19/06/2009, ma...@apache.org wrote:
> Author: markt
> Date: Fri Jun 19 20:21:53 2009
> New Revision: 786653
>
> URL: http://svn.apache.org/viewvc?rev=786653&view=rev
> Log:
> Switch to ThreadLocal where possible. This removes all the syncs apart from
> those related to accessing the log f
Author: markt
Date: Fri Jun 19 21:14:32 2009
New Revision: 786667
URL: http://svn.apache.org/viewvc?rev=786667&view=rev
Log:
Can't use queryMB as that isn't the only source.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/http/Parameters.java
Modified: tomcat/trunk/java/org/apache/tomcat/
Author: markt
Date: Fri Jun 19 21:27:32 2009
New Revision: 786670
URL: http://svn.apache.org/viewvc?rev=786670&view=rev
Log:
Address Konstantin's review comment.
The patch is now sufficiently different that I removed Filip's vote to give him
a chance to re-review
Modified:
tomcat/tc6.0.x/tru
https://issues.apache.org/bugzilla/show_bug.cgi?id=47395
Summary: Dispatcher.forward and getPathInfo() != null causes
stack overflow
Product: Tomcat 6
Version: 6.0.20
Platform: PC
OS/Version: Windows XP
Status: NEW
we're copying bytes to two new byte arrays on every call, just so that
we have info when it fails?
especially only logged with debugEnabled, shouldn't your logic check
that flag then
Filip
ma...@apache.org wrote:
Author: markt
Date: Fri Jun 19 21:14:32 2009
New Revision: 786667
URL: http://s
Filip Hanik - Dev Lists wrote:
> we're copying bytes to two new byte arrays on every call, just so that
> we have info when it fails?
For query string there is (and always has been) one copy and then this
patch copies again for the failure info.
For POST requests the only copy is for the failure
https://issues.apache.org/bugzilla/show_bug.cgi?id=47395
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
https://issues.apache.org/bugzilla/show_bug.cgi?id=47371
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
Mark Thomas wrote:
The (updated) candidates source tarball and derived binaries are
available here:
http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.40/
According to the release process, the release based on the 4.0.40 tag is:
[ ] Broken
[ ] Alpha
[ ] Beta
[X] Stable
[x] Stable
Tested on
74 matches
Mail list logo
