svn commit: r751217 - in /tomcat/connectors/trunk/jk/native/common: jk_ajp_common.c jk_lb_worker.c jk_shm.h

2009-03-07 Thread mturk
Author: mturk Date: Sat Mar 7 08:00:54 2009 New Revision: 751217 URL: http://svn.apache.org/viewvc?rev=751217&view=rev Log: If the number of the channels in error more then half of the busy channels mark the worker global status as error Modified: tomcat/connectors/trunk/jk/native/common/jk_

Re: mod_jk local error states vs. global error states

2009-03-07 Thread Mladen Turk
Rainer Jung wrote: On 06.03.2009 13:32, Mladen Turk wrote: For the rest it's simply too much to cope in a single email ;) I put the force recovery fix and the "else" suggestion in a patch at: http://people.apache.org/~rjung/mod_jk-dev/patches/local_states.patch I've added 'in_error' for aj

Re: svn commit: r751136 - /tomcat/tc6.0.x/tags/TOMCAT_6_0_19/

2009-03-07 Thread Mark Thomas
Remy Maucherat wrote: > On Fri, 2009-03-06 at 23:32 +, r...@apache.org wrote: >> Author: remm >> Date: Fri Mar 6 23:32:40 2009 >> New Revision: 751136 >> >> URL: http://svn.apache.org/viewvc?rev=751136&view=rev >> Log: >> - Apache Tomcat 6.0.19. >> >> Added: >> tomcat/tc6.0.x/tags/TOMCAT_6

svn commit: r751239 - /tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c

2009-03-07 Thread rjung
Author: rjung Date: Sat Mar 7 10:37:57 2009 New Revision: 751239 URL: http://svn.apache.org/viewvc?rev=751239&view=rev Log: No functional change, fix typos and reformat comments. Modified: tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c Modified: tomcat/connectors/trunk/jk/native/c

Re: svn commit: r751213 - in /tomcat/connectors/trunk/jk/native/common: jk_ajp13.h jk_ajp_common.c jk_lb_worker.c

2009-03-07 Thread Rainer Jung
On 07.03.2009 08:18, mt...@apache.org wrote: Author: mturk Date: Sat Mar 7 07:18:08 2009 New Revision: 751213 URL: http://svn.apache.org/viewvc?rev=751213&view=rev Log: Retun protocol error from ajp get message. This allows to make difference weather we got something from the server or the noth

Re: svn commit: r751217 - in /tomcat/connectors/trunk/jk/native/common: jk_ajp_common.c jk_lb_worker.c jk_shm.h

2009-03-07 Thread Rainer Jung
On 07.03.2009 09:00, mt...@apache.org wrote: Author: mturk Date: Sat Mar 7 08:00:54 2009 New Revision: 751217 URL: http://svn.apache.org/viewvc?rev=751217&view=rev Log: If the number of the channels in error more then half of the busy channels mark the worker global status as error Modified:

[g...@vmgump]: Project jakarta-tomcat-jk-native (in module jakarta-tomcat-connectors) failed

2009-03-07 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project jakarta-tomcat-jk-native has an issue affecting its community integration

DO NOT REPLY [Bug 46764] Tomcat 6 and xmlValidation="false" not working

2009-03-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46764 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r751275 - in /tomcat/connectors/trunk/jk/native/common: jk_ajp_common.c jk_lb_worker.c jk_shm.h

2009-03-07 Thread mturk
Author: mturk Date: Sat Mar 7 14:19:23 2009 New Revision: 751275 URL: http://svn.apache.org/viewvc?rev=751275&view=rev Log: Revert the in_error counter Modified: tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c tomcat/co

Re: svn commit: r751217 - in /tomcat/connectors/trunk/jk/native/common: jk_ajp_common.c jk_lb_worker.c jk_shm.h

2009-03-07 Thread Mladen Turk
Rainer Jung wrote: On 07.03.2009 09:00, mt...@apache.org wrote: Summary: I still like the idea of using the error_time. Each OK request will reset it, and that's fine. As long as there's something good coming back we have a global chance. But if there are no OK's for some time we should swit

DO NOT REPLY [Bug 46808] mod_jk 1.2.27 can't detect network error

2009-03-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46808 --- Comment #6 from Eiji Takahashi 2009-03-07 07:28:41 PST --- Hi. I'm sorry that the explanation is insufficient. I used the roughly following settings. - worker.list=wlb # not use socket_connect_timeout worker.ap00.socket_t

DO NOT REPLY [Bug 46803] Configuration fix for jsvc daemon

2009-03-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46803 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 46808] mod_jk 1.2.27 can't detect network error

2009-03-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46808 --- Comment #7 from Eiji Takahashi 2009-03-07 07:43:57 PST --- Created an attachment (id=23349) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23349) log file 1 of 4 -- Configure bugmail: https://issues.apache.org/bugzil

DO NOT REPLY [Bug 46808] mod_jk 1.2.27 can't detect network error

2009-03-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46808 --- Comment #8 from Eiji Takahashi 2009-03-07 07:44:52 PST --- Created an attachment (id=23350) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23350) log file 2 of 4 -- Configure bugmail: https://issues.apache.org/bugzil

DO NOT REPLY [Bug 46808] mod_jk 1.2.27 can't detect network error

2009-03-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46808 --- Comment #9 from Eiji Takahashi 2009-03-07 07:45:38 PST --- Created an attachment (id=23351) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23351) log file 3 of 4 -- Configure bugmail: https://issues.apache.org/bugzil

DO NOT REPLY [Bug 46808] mod_jk 1.2.27 can't detect network error

2009-03-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46808 --- Comment #10 from Eiji Takahashi 2009-03-07 07:47:10 PST --- Created an attachment (id=23352) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23352) log file 4 of 4 -- Configure bugmail: https://issues.apache.org/bugzi

DO NOT REPLY [Bug 46808] mod_jk 1.2.27 can't detect network error

2009-03-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46808 --- Comment #11 from Eiji Takahashi 2009-03-07 07:49:16 PST --- Oops! I'm sorry. The log file was too large. I divided the log file. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are re

svn commit: r751286 - /tomcat/trunk/webapps/docs/jasper-howto.xml

2009-03-07 Thread markt
Author: markt Date: Sat Mar 7 16:00:22 2009 New Revision: 751286 URL: http://svn.apache.org/viewvc?rev=751286&view=rev Log: Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=46807 Correctly document org.apache.japser.runtime.JspFactoryImpl.USE_POOL Modified: tomcat/trunk/web

svn commit: r751287 - in /tomcat/trunk: conf/web.xml webapps/docs/jasper-howto.xml

2009-03-07 Thread markt
Author: markt Date: Sat Mar 7 16:08:41 2009 New Revision: 751287 URL: http://svn.apache.org/viewvc?rev=751287&view=rev Log: Fix remainder of https://issues.apache.org/bugzilla/show_bug.cgi?id=46807 Make it clear that enablePooling is a compilation, not a runtime option. Modified: tomcat/trun

svn commit: r751288 - in /tomcat/tc6.0.x/trunk: ./ conf/web.xml webapps/docs/changelog.xml webapps/docs/jasper-howto.xml

2009-03-07 Thread markt
Author: markt Date: Sat Mar 7 16:15:26 2009 New Revision: 751288 URL: http://svn.apache.org/viewvc?rev=751288&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46807 Correct docs for configuration of tag pooling Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/

DO NOT REPLY [Bug 46807] Cannot disable jsp tag pooling

2009-03-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46807 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r751289 - in /tomcat/trunk/java/org/apache/catalina/users: LocalStrings.properties MemoryUserDatabase.java

2009-03-07 Thread markt
Author: markt Date: Sat Mar 7 16:28:46 2009 New Revision: 751289 URL: http://svn.apache.org/viewvc?rev=751289&view=rev Log: Make UserDatabase read only by default and log an error if someone tries to save changes. Modified: tomcat/trunk/java/org/apache/catalina/users/LocalStrings.properties

svn commit: r751291 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-03-07 Thread markt
Author: markt Date: Sat Mar 7 16:33:42 2009 New Revision: 751291 URL: http://svn.apache.org/viewvc?rev=751291&view=rev Log: Proposal for bz 46815 Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATU

DO NOT REPLY [Bug 46815] Tomcat user database file - permission problem on Unix systems

2009-03-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46815 --- Comment #3 from Mark Thomas 2009-03-07 08:33:47 PST --- I suspect that it is read write by default as a legacy of the 5.5.x admin app which could add and remove users (you can still do this in 6.0.x using jmx). I assume you are aw

svn commit: r751295 - /tomcat/trunk/java/org/apache/catalina/session/mbeans-descriptors.xml

2009-03-07 Thread markt
Author: markt Date: Sat Mar 7 16:54:46 2009 New Revision: 751295 URL: http://svn.apache.org/viewvc?rev=751295&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46816 Align mbean descriptor attributes with implementations Modified: tomcat/trunk/java/org/apache/catalina/sess

svn commit: r751296 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-03-07 Thread markt
Author: markt Date: Sat Mar 7 16:56:22 2009 New Revision: 751296 URL: http://svn.apache.org/viewvc?rev=751296&view=rev Log: Propose fix for 46816 Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATU

DO NOT REPLY [Bug 46816] /status/all fails if using PersistentManager

2009-03-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46816 --- Comment #1 from Mark Thomas 2009-03-07 08:56:44 PST --- The getter was missing in the mbean descriptor. I have added it in trunk and proposed the change for 6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userpref

DO NOT REPLY [Bug 46808] mod_jk 1.2.27 can't detect network error

2009-03-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46808 Mladen Turk changed: What|Removed |Added Component|Common |mod_jk --- Comment #12 from Mlad

svn commit: r751303 - in /tomcat/trunk/java/org/apache/jk: apr/ common/ChannelJni.java common/ChannelShm.java common/ChannelUn.java common/JniHandler.java common/Shm.java common/Shm14.java

2009-03-07 Thread markt
Author: markt Date: Sat Mar 7 18:32:40 2009 New Revision: 751303 URL: http://svn.apache.org/viewvc?rev=751303&view=rev Log: Remove jk jni code from Tomcat 7. It is deprecated in mod_jk and will almost certainly have been rmeoved by the time 7.0.x has a stable release. Shout if I deleted somethin

svn commit: r751304 - in /tomcat/trunk: java/org/apache/catalina/valves/AddDefaultCharsetValve.java webapps/docs/config/valve.xml

2009-03-07 Thread markt
Author: markt Date: Sat Mar 7 18:45:53 2009 New Revision: 751304 URL: http://svn.apache.org/viewvc?rev=751304&view=rev Log: Add AddDefaultCharSetValve Added: tomcat/trunk/java/org/apache/catalina/valves/AddDefaultCharsetValve.java (with props) Modified: tomcat/trunk/webapps/docs/confi

svn commit: r751313 - /tomcat/trunk/java/org/apache/catalina/connector/Response.java

2009-03-07 Thread markt
Author: markt Date: Sat Mar 7 19:42:09 2009 New Revision: 751313 URL: http://svn.apache.org/viewvc?rev=751313&view=rev Log: Allow the AddDefaultCharsetValve to be effective when a writer is used Modified: tomcat/trunk/java/org/apache/catalina/connector/Response.java Modified: tomcat/trunk/j

svn commit: r751314 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-03-07 Thread markt
Author: markt Date: Sat Mar 7 19:43:57 2009 New Revision: 751314 URL: http://svn.apache.org/viewvc?rev=751314&view=rev Log: Propose new valve an option to make it more effective Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/v

svn commit: r751315 - in /tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/interceptor: AbstractQueryReport.java SlowQueryReport.java StatementFinalizer.java

2009-03-07 Thread markt
Author: markt Date: Sat Mar 7 19:50:34 2009 New Revision: 751315 URL: http://svn.apache.org/viewvc?rev=751315&view=rev Log: Some generics fixes Modified: tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/interceptor/AbstractQueryReport.java tomcat/trunk/modules/jdbc-pool/

svn commit: r751317 - /tomcat/trunk/java/org/apache/jasper/xmlparser/EncodingMap.java

2009-03-07 Thread markt
Author: markt Date: Sat Mar 7 19:55:10 2009 New Revision: 751317 URL: http://svn.apache.org/viewvc?rev=751317&view=rev Log: Clear a bunch of generics warnings in Eclipse Modified: tomcat/trunk/java/org/apache/jasper/xmlparser/EncodingMap.java Modified: tomcat/trunk/java/org/apache/jasper/xm

svn commit: r751326 - in /tomcat/trunk/java/org/apache/jasper/xmlparser: TreeNode.java UTF8Reader.java XMLEncodingDetector.java

2009-03-07 Thread markt
Author: markt Date: Sat Mar 7 20:39:58 2009 New Revision: 751326 URL: http://svn.apache.org/viewvc?rev=751326&view=rev Log: Fix Eclipse warnings in this package Modified: tomcat/trunk/java/org/apache/jasper/xmlparser/TreeNode.java tomcat/trunk/java/org/apache/jasper/xmlparser/UTF8Reader.

Re: svn commit: r751304 - in /tomcat/trunk: java/org/apache/catalina/valves/AddDefaultCharsetValve.java webapps/docs/config/valve.xml

2009-03-07 Thread Bill Barker
wrote in message news:20090307184553.971be2388...@eris.apache.org... > Author: markt > Date: Sat Mar 7 18:45:53 2009 > New Revision: 751304 > > URL: http://svn.apache.org/viewvc?rev=751304&view=rev > Log: > Add AddDefaultCharSetValve > > Added: > > tomcat/trunk/java/org/apache/catalina/valves/

Re: svn commit: r751304 - in /tomcat/trunk: java/org/apache/catalina/valves/AddDefaultCharsetValve.java webapps/docs/config/valve.xml

2009-03-07 Thread Filip Hanik - Dev Lists
Bill Barker wrote: wrote in message news:20090307184553.971be2388...@eris.apache.org... Author: markt Date: Sat Mar 7 18:45:53 2009 New Revision: 751304 URL: http://svn.apache.org/viewvc?rev=751304&view=rev Log: Add AddDefaultCharSetValve Added: tomcat/trunk/java/org/apache/catalina/valv

DO NOT REPLY [Bug 46819] New: Remove redundant object instantiations in JspRuntimeLibrary

2009-03-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46819 Summary: Remove redundant object instantiations in JspRuntimeLibrary Product: Tomcat 6 Version: 6.0.18 Platform: PC OS/Version: Windows Vista Status: NEW