Author: markt
Date: Sat Mar 7 16:28:46 2009
New Revision: 751289
URL: http://svn.apache.org/viewvc?rev=751289&view=rev
Log:
Make UserDatabase read only by default and log an error if someone tries to
save changes.
Modified:
tomcat/trunk/java/org/apache/catalina/users/LocalStrings.properties
tomcat/trunk/java/org/apache/catalina/users/MemoryUserDatabase.java
Modified: tomcat/trunk/java/org/apache/catalina/users/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/users/LocalStrings.properties?rev=751289&r1=751288&r2=751289&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/users/LocalStrings.properties
(original)
+++ tomcat/trunk/java/org/apache/catalina/users/LocalStrings.properties Sat Mar
7 16:28:46 2009
@@ -18,3 +18,4 @@
memoryUserDatabase.renameNew=Cannot rename new file to {0}
memoryUserDatabase.writeException=IOException writing to {0}
memoryUserDatabase.notPersistable=User database is not persistable - no write
permissions on directory
+memoryUserDatabase.readOnly=User database has been configured to be read only.
Changes cannot be saved
Modified: tomcat/trunk/java/org/apache/catalina/users/MemoryUserDatabase.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/users/MemoryUserDatabase.java?rev=751289&r1=751288&r2=751289&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/users/MemoryUserDatabase.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/users/MemoryUserDatabase.java Sat Mar
7 16:28:46 2009
@@ -120,7 +120,7 @@
/**
* A flag, indicating if the user database is read only.
*/
- protected boolean readonly = false;
+ protected boolean readonly = true;
/**
* The set of {...@link Role}s defined in this database, keyed by
@@ -500,6 +500,7 @@
public void save() throws Exception {
if (getReadonly()) {
+ log.error(sm.getString("memoryUserDatabase.readOnly"));
return;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
