Re: NIO Connector, please review

2006-06-22 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: Ok, I have a non SSL enabled Java NIO connector created and checked in. It works in the exact way as APR, meaning it blocks on read and write, So its no true NIO, but close enough to handle comet style traffic, and to increase the connection count without increasin

DO NOT REPLY [Bug 39821] - JK busy number is abnormal

2006-06-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r416314 - in /tomcat/tc6.0.x/trunk: build.properties.default build.xml

2006-06-22 Thread remm
Author: remm Date: Thu Jun 22 03:11:41 2006 New Revision: 416314 URL: http://svn.apache.org/viewvc?rev=416314&view=rev Log: - Add new files. Modified: tomcat/tc6.0.x/trunk/build.properties.default tomcat/tc6.0.x/trunk/build.xml Modified: tomcat/tc6.0.x/trunk/build.properties.default URL:

Re: svn commit: r416187 [1/3] - in /tomcat/tc6.0.x/trunk/java/org/apache: catalina/connector/ coyote/http11/ tomcat/util/net/

2006-06-22 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: -if ("HTTP/1.1".equals(protocol)) { +if ("HTTP/1.1/NIO".equals(protocol)) { + setProtocolHandlerClassName("org.apache.coyote.http11.Http11NioProtocol"); +} else if ("HTTP/1.1".equals(protocol)) { I think using the actu

DO NOT REPLY [Bug 39862] New: - provide support for protocol-independent GenericServlet

2006-06-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: NIO Connector, please review

2006-06-22 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: Ok, I have a non SSL enabled Java NIO connector created and checked in. It works in the exact way as APR, meaning it blocks on read and write, So its no true NIO, but close enough to handle comet style traffic, and to increase the connection

Re: svn commit: r416193 [2/2] - /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2006-06-22 Thread Filip Hanik - Dev Lists
so you mean, that SVN changed the line endings when I checked in the code the first time, and that was the mismatch? cause it was me checking in the file the first time and second. Filip William A. Rowe, Jr. wrote: Filip Hanik - Dev Lists wrote: wow, what just happened here, how could the enti

Re: svn commit: r416187 [1/3] - in /tomcat/tc6.0.x/trunk/java/org/apache: catalina/connector/ coyote/http11/ tomcat/util/net/

2006-06-22 Thread Filip Hanik - Dev Lists
I agree, would you mind if I redid the connector, so that the protocolHandlerClassName works? currently, it only checks the protocol, as it does so in the constructor of the Connector. so setting protocol or attributes later will have no effect public void begin(Attributes attributes) throws E

DO NOT REPLY [Bug 39865] New: - Not able to open Openoffice files

2006-06-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: NIO Connector, please review

2006-06-22 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: you gotta look at the glass as half full, not half empty :), it also doesn't crash the VM when the client aborts the connection on a comet request ;) I know of no crash problems. I think there's a very negative development atmosphere in the components you become

Re: svn commit: r416187 [1/3] - in /tomcat/tc6.0.x/trunk/java/org/apache: catalina/connector/ coyote/http11/ tomcat/util/net/

2006-06-22 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: I agree, would you mind if I redid the connector, so that the protocolHandlerClassName works? currently, it only checks the protocol, as it does so in the constructor of the Connector. so setting protocol or attributes later will have no effect public void begin

svn commit: r416390 - in /tomcat/container/tc5.5.x/modules/groupcom: ./ src/share/org/apache/catalina/tribes/group/ src/share/org/apache/catalina/tribes/group/interceptors/ src/share/org/apache/catali

2006-06-22 Thread fhanik
Author: fhanik Date: Thu Jun 22 08:08:58 2006 New Revision: 416390 URL: http://svn.apache.org/viewvc?rev=416390&view=rev Log: Support for JDK1.4 all the way Added: tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/io/BufferPool14Impl.java Modified: tomcat/con

Re: NIO Connector, please review

2006-06-22 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: you gotta look at the glass as half full, not half empty :), it also doesn't crash the VM when the client aborts the connection on a comet request ;) I know of no crash problems. I think there's a very negative development atmosphere in th

DO NOT REPLY [Bug 39866] New: - Context manager name isn't reset correctly after reload, in a cluster.

2006-06-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: NIO Connector, please review

2006-06-22 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: I did, just check http://marc.theaimsgroup.com/?l=tomcat-dev&m=115064982127403&w=2 In terms of negativity, not sure where your head is at, but there is none here. This was quite a subtle mention. The plan is that the socket will not get destroyed and deallocated

svn commit: r416408 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Connector.java

2006-06-22 Thread fhanik
Author: fhanik Date: Thu Jun 22 09:03:32 2006 New Revision: 416408 URL: http://svn.apache.org/viewvc?rev=416408&view=rev Log: Reverted checkin, we can use a fully qualified class name inside of the protocol Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Connector.java Modi

Re: NIO Connector, please review

2006-06-22 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: I did, just check http://marc.theaimsgroup.com/?l=tomcat-dev&m=115064982127403&w=2 In terms of negativity, not sure where your head is at, but there is none here. This was quite a subtle mention. The plan is that the socket will not get de

svn commit: r416409 [1/2] - /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2006-06-22 Thread fhanik
Author: fhanik Date: Thu Jun 22 09:10:17 2006 New Revision: 416409 URL: http://svn.apache.org/viewvc?rev=416409&view=rev Log: Reverted last nights checkin, until I fix the line ending story, and this also makes the connector work again Modified: tomcat/tc6.0.x/trunk/java/org/apache/tomcat/ut

Re: NIO Connector, please review

2006-06-22 Thread Filip Hanik - Dev Lists
Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: I did, just check http://marc.theaimsgroup.com/?l=tomcat-dev&m=115064982127403&w=2 In terms of negativity, not sure where your head is at, but there is none here. This was quite a subtle mention. The plan is

Re: NIO Connector, please review

2006-06-22 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: Alright, fixed, my last night checkin, the one I was unable to diff, caused the problem, I have reverted that one, and the Connector since we can use the fully qualified classname here. I am able to diff to see what got fixed, and it's trivial: all requests were

Re: NIO Connector, please review

2006-06-22 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: Alright, fixed, my last night checkin, the one I was unable to diff, caused the problem, I have reverted that one, and the Connector since we can use the fully qualified classname here. I am able to diff to see what got fixed, and it's triv

Re: NIO Connector, please review

2006-06-22 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: Alright, fixed, my last night checkin, the one I was unable to diff, caused the problem, I have reverted that one, and the Connector since we can use the fully qualified classname here. I am able to diff to s

Re: NIO Connector, please review

2006-06-22 Thread Costin Manolache
On 6/22/06, Remy Maucherat <[EMAIL PROTECTED]> wrote: Filip Hanik - Dev Lists wrote: > Ok, I have a non SSL enabled Java NIO connector created and checked in. > It works in the exact way as APR, meaning it blocks on read and write, > So its no true NIO, but close enough to handle comet style tra

Re: NIO Connector, please review

2006-06-22 Thread Jess Holle
Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: Alright, fixed, my last night checkin, the one I was unable to diff, caused the problem, I have reverted that one, and the Connector since we can use the fully qualified classname here.

svn commit: r416423 - /tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java

2006-06-22 Thread fhanik
Author: fhanik Date: Thu Jun 22 10:09:14 2006 New Revision: 416423 URL: http://svn.apache.org/viewvc?rev=416423&view=rev Log: must come up with a better sleep, this brings the nio connector up to the same speed as the io connector however, there is a risk for cpu contention on slow clients, fix

Re: NIO Connector, please review

2006-06-22 Thread Filip Hanik - Dev Lists
Jess Holle wrote: Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: Alright, fixed, my last night checkin, the one I was unable to diff, caused the problem, I have reverted that one, and the Connector since we can use the fully qualifie

Re: NIO Connector, please review

2006-06-22 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: That's unfortunate. So regular is better? What are they doing with Grizzly? no, its me :) I need to come up with a non cpu sucking wait algorithm for the wait. once that is fixed, the performance should be close to identical For some reason, the performance we

Re: NIO Connector, please review

2006-06-22 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: That's unfortunate. So regular is better? What are they doing with Grizzly? no, its me :) I need to come up with a non cpu sucking wait algorithm for the wait. once that is fixed, the performance should be close to identical For some rea

svn commit: r416444 [1/2] - in /tomcat/tc6.0.x/trunk/java/org/apache: coyote/http11/Http11NioProcessor.java coyote/http11/InternalNioInputBuffer.java tomcat/util/net/NioEndpoint.java

2006-06-22 Thread fhanik
Author: fhanik Date: Thu Jun 22 12:05:02 2006 New Revision: 416444 URL: http://svn.apache.org/viewvc?rev=416444&view=rev Log: Fix so that we don't do a busy read, instead we are properly doing a NIO poller wait This way, we can achieve blocking read, without wasting CPU cycles. Since we are using

Re: svn commit: r416444 [1/2] - in /tomcat/tc6.0.x/trunk/java/org/apache: coyote/http11/Http11NioProcessor.java coyote/http11/InternalNioInputBuffer.java tomcat/util/net/NioEndpoint.java

2006-06-22 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: Author: fhanik Date: Thu Jun 22 12:05:02 2006 New Revision: 416444 URL: http://svn.apache.org/viewvc?rev=416444&view=rev Log: Fix so that we don't do a busy read, instead we are properly doing a NIO poller wait This way, we can achieve blocking read, without wasting CPU

svn commit: r416456 - in /tomcat/tc6.0.x/trunk/java/org/apache: coyote/http11/InternalNioInputBuffer.java tomcat/util/net/NioEndpoint.java

2006-06-22 Thread fhanik
Author: fhanik Date: Thu Jun 22 12:59:39 2006 New Revision: 416456 URL: http://svn.apache.org/viewvc?rev=416456&view=rev Log: Catch the cancelled key exceptions and act appropriately Modified: tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java tomcat/tc6.0.x/t

Re: svn commit: r416444 [1/2] - in /tomcat/tc6.0.x/trunk/java/org/apache: coyote/http11/Http11NioProcessor.java coyote/http11/InternalNioInputBuffer.java tomcat/util/net/NioEndpoint.java

2006-06-22 Thread Filip Hanik - Dev Lists
Thanks for the help on this. I am now catching those exceptions, I have the correct speed, but after the test is done, the poller is going ape-sh#@ and takes 100% of cpu, making future tests really slow. I need to figure out why it isn't letting go of the connections Filip Remy Maucherat wrot

Re: svn commit: r416444 [1/2] - in /tomcat/tc6.0.x/trunk/java/org/apache: coyote/http11/Http11NioProcessor.java coyote/http11/InternalNioInputBuffer.java tomcat/util/net/NioEndpoint.java

2006-06-22 Thread Filip Hanik - Dev Lists
basically what is happening is that the connection is "keep-alive" so it goes back and register itself for more read, read return -1, which is end of stream, and it re-register itself. I will make it throw an exception to end the loop Filip Filip Hanik - Dev Lists wrote: Thanks for the help

svn commit: r416461 - in /tomcat/tc6.0.x/trunk/java/org/apache: coyote/http11/InternalNioInputBuffer.java tomcat/util/net/NioEndpoint.java

2006-06-22 Thread fhanik
Author: fhanik Date: Thu Jun 22 13:28:27 2006 New Revision: 416461 URL: http://svn.apache.org/viewvc?rev=416461&view=rev Log: Two fixes, process timeouts last, no need to check a timeout on a valid read. hence we do it after we process the actual operations Throw an IO exception if we reach end o

svn commit: r416481 - /tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioInputBuffer.java

2006-06-22 Thread fhanik
Author: fhanik Date: Thu Jun 22 15:02:23 2006 New Revision: 416481 URL: http://svn.apache.org/viewvc?rev=416481&view=rev Log: Dont do the not needed operations, if they are not needed. Performance is just a tad under java.io, which is expected as we need to poll, as opposed to constantly wait for

NIO vs BIO speed

2006-06-22 Thread Filip Hanik - Dev Lists
I've attached two test runs NIO vs BIO. The results are very similar, in a regular scenario, blocking IO should be a little bit faster, cause it doesn't have to poll, and then hand off to a separate thread before reading. Benefit of the NIO is of course that the number of open sockets are no lo

Re: NIO vs BIO speed

2006-06-22 Thread Filip Hanik - Dev Lists
Here is another test that I ran from a remote machine, setting maxThreads="25" and ab concurrency to 50 and keepalive on. In this case, NIO is a lot faster. Turn off keepalive on ab, and we get similar results to previous run, where BIO is a tad faster. [EMAIL PROTECTED] bin]$ ./ab -n 2 -k

Re: NIO vs BIO speed

2006-06-22 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: Remy, can you run your tests again, are you still seeing a huge difference? Obviously, you did not change anything. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-ma

Re: NIO vs BIO speed

2006-06-22 Thread Remy Maucherat
Filip Hanik - Dev Lists wrote: Here is another test that I ran from a remote machine, setting maxThreads="25" and ab concurrency to 50 and keepalive on. In this case, NIO is a lot faster. Turn off keepalive on ab, and we get similar results to previous run, where BIO is a tad faster. Scaling t

Re: NIO vs BIO speed

2006-06-22 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: Remy, can you run your tests again, are you still seeing a huge difference? Obviously, you did not change anything. yes, I changed from busy read to polling, I wasn't sure if you ran your tests after that. I've ran my test

Re: NIO vs BIO speed

2006-06-22 Thread Filip Hanik - Dev Lists
Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: Here is another test that I ran from a remote machine, setting maxThreads="25" and ab concurrency to 50 and keepalive on. In this case, NIO is a lot faster. Turn off keepalive on ab, and we get similar results to previous run, where

UNSUBSCRIBE PLEASE..............................

2006-06-22 Thread hamood rehman
From: Filip Hanik - Dev Lists <[EMAIL PROTECTED]> Reply-To: "Tomcat Developers List" To: Tomcat Developers List Subject: Re: NIO Connector, please review Date: Thu, 22 Jun 2006 11:25:59 -0500 Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: Alright, fixed, my last night checkin, the on

[EMAIL PROTECTED]: Project tomcat-tc6 (in module tomcat-tc6) failed

2006-06-22 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project tomcat-tc6 has an issue affecting its community integration. This issue affects 1

[EMAIL PROTECTED]: Project tomcat-tc6 (in module tomcat-tc6) failed

2006-06-22 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project tomcat-tc6 has an issue affecting its community integration. This issue affects 1

DO NOT REPLY [Bug 39873] New: - unable to access the jar files

2006-06-22 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

New Feature List

2006-06-22 Thread Riyaz Mansoor
i'll keep it brief. i'm looking to spend time on working on the new features coming to tomcat 5.5 or 6 on the website, i could find no info on this. i was hoping there would be a page listing the features being worked in 5.5 and the coming features in 6 riyaz

Re: svn commit: r415549 - /tomcat/connectors/trunk/jni/native/src/network.c

2006-06-22 Thread prakash shanmugam
hello mturk i want to know how to store a *.doc file ,or *.pdf file in MYSQL database using JSP or SERVLET as a front end if you know the asnwer please reply me soon its very important. bye On 6/20/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: Author: mturk Date: Tue Jun 20 00:56:

Re: NIO vs BIO speed

2006-06-22 Thread Dakota Jack
I am interested in this code.  Is there a way I can see the code?  Thanks. On 6/22/06, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote: Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: Here is another test that I ran from a remote machine, setting maxThreads="25" and ab concurre

Re: New Feature List

2006-06-22 Thread prakash shanmugam
hai if you can help me it will be a big relief for me now iam using tomcat 5.0 and linux as my server machine and the client machine are windows xp in my coding iam using JSP and SERVLETS. the problem is i want to store images and pdf files into mydatabase . the backend is mysql 4.0 can u able to