Re: org.apache.catalina.Core MBeans Descriptor Modifications

2010-06-02 Thread Mark Thomas
On 02/06/2010 14:23, buddhika chamith wrote: > Hi Mark, > > I prefer separate MBeans since it would help to keep base interfaces clean. OK. Works for me. Keep the MBeans in the separate package that already exists. Mark - To

Re: org.apache.catalina.Core MBeans Descriptor Modifications

2010-06-02 Thread buddhika chamith
Hi Mark, I prefer separate MBeans since it would help to keep base interfaces clean. Regards

Re: org.apache.catalina.Core MBeans Descriptor Modifications

2010-05-31 Thread Mark Thomas
On 28/05/2010 04:22, buddhika chamith wrote: > Hi Mark, > > As far as I feel additional methods in the base class may tend to bloat the > base interface unnecessarily. Some of the methods are not generic so that > they cannot be included in the base interface as well. On the other hand > using sep

Re: org.apache.catalina.Core MBeans Descriptor Modifications

2010-05-27 Thread buddhika chamith
Hi Mark, As far as I feel additional methods in the base class may tend to bloat the base interface unnecessarily. Some of the methods are not generic so that they cannot be included in the base interface as well. On the other hand using separate MBeans avoids these issues. Additional methods can

Re: org.apache.catalina.Core MBeans Descriptor Modifications

2010-05-26 Thread Mark Thomas
On 26/05/2010 11:40, buddhika chamith wrote: > Hi Mark, > > >> *Class: StandardWrapper* >>> >>> >>> Method : >>> add/removeLifeCycleListener(org.apache.catalina.LifecycleListener) >>> Suggestion : Remove the methods since the method can be provided in a >>> generic way with only

Re: org.apache.catalina.Core MBeans Descriptor Modifications

2010-05-26 Thread buddhika chamith
Hi Mark, > *Class: StandardWrapper* >> >> >> Method : >> add/removeLifeCycleListener(org.apache.catalina.LifecycleListener) >> Suggestion : Remove the methods since the method can be provided in a >> generic way with only involving primitives. >> > > Again, I don't get what you m

Re: org.apache.catalina.Core MBeans Descriptor Modifications

2010-05-25 Thread Mark Thomas
On 23/05/2010 04:57, buddhika chamith wrote: Hi All, It seems that o.a.Catalina.Core MBeans descriptor has got operations containing POJO objects instead of primitive types which make them inaccessible via JConsole. I suggest the following to avoid this situation. Any comments and suggestions ar

org.apache.catalina.Core MBeans Descriptor Modifications

2010-05-22 Thread buddhika chamith
Hi All, It seems that o.a.Catalina.Core MBeans descriptor has got operations containing POJO objects instead of primitive types which make them inaccessible via JConsole. I suggest the following to avoid this situation. Any comments and suggestions are appreciated. *Class: StandardContext * ' Me